Skip to contentSkip to conversation

mfd: at91-usart: Add platform dependency

PATCH Applied Jean Delvare 2 participants 2 messages Nov 12, 2018 – Nov 13, 2018 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: at91-usart: Add platform dependency

It doesn't make sense to present option MFD_AT91_USART by default if not building an AT91 kernel, as the drivers which depend on it are not available.

Fixes 7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
Cc Radu Pirea <[email protected]>
Cc Lee Jones <[email protected]>

---
As a side note, maybe it would make sense to have SPI_AT91_USART select MFD_AT91_USART instead of depend on it, so that MFD_AT91_USART could be hidden?

 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +1 -0
@@ -102,6 +102,7 @@ config MFD_AAT2870_CORE
 config MFD_AT91_USART
 	tristate "AT91 USART Driver"
 	select MFD_CORE
+	depends on ARCH_AT91 || COMPILE_TEST
 	help
 	  Select this to get support for AT91 USART IP. This is a wrapper
 	  over at91-usart-serial driver and usart-spi-driver. Only one function
Signature · 2 lines
Jean Delvare
SUSE L3 Support
Applied
#1 lore raw
Quoted 8 lines · Jean Delvare

It doesn't make sense to present option MFD_AT91_USART by default if not building an AT91 kernel, as the drivers which depend on it are not available.

Fixes 7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
Cc Radu Pirea <[email protected]>
Cc Lee Jones <[email protected]>
Quoted 7 lines

---
As a side note, maybe it would make sense to have SPI_AT91_USART select MFD_AT91_USART instead of depend on it, so that MFD_AT91_USART could be hidden?

 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog