crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS
PATCH 1/1 crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS
The values specified in the documentation don't match the actual defaults set in qcrypto_block_luks_create().
Signed-off-by Alberto Garcia <[email protected]>
--- qapi/crypto.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
qapi/crypto.json +3 -3
@@ -181,11 +181,11 @@ # The options that apply to LUKS encryption format initialization # # @cipher-alg: the cipher algorithm for data encryption -# Currently defaults to 'aes'. +# Currently defaults to 'aes-256'. # @cipher-mode: the cipher mode for data encryption -# Currently defaults to 'cbc' +# Currently defaults to 'xts' # @ivgen-alg: the initialization vector generator -# Currently defaults to 'essiv' +# Currently defaults to 'plain64' # @ivgen-hash-alg: the initialization vector generator hash # Currently defaults to 'sha256' # @hash-alg: the master key hash algorithm
Signature · 1 line
2.11.0
Quoted 7 lines · Alberto Garcia
The values specified in the documentation don't match the actual defaults set in
qcrypto_block_luks_create().Signed-off-by Alberto Garcia <[email protected]>--- qapi/crypto.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by Daniel P. Berrangé <[email protected]>
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
ping
Quoted 29 lines · Alberto Garcia
The values specified in the documentation don't match the actual defaults set in
qcrypto_block_luks_create().Signed-off-by Alberto Garcia <[email protected]>--- qapi/crypto.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)qapi/crypto.json +3
-3@@ -181,11 +181,11 @@ # The options that apply to LUKS encryption format initialization # # @cipher-alg: the cipher algorithm for data encryption -# Currently defaults to 'aes'. +# Currently defaults to 'aes-256'. # @cipher-mode: the cipher mode for data encryption -# Currently defaults to 'cbc' +# Currently defaults to 'xts' # @ivgen-alg: the initialization vector generator -# Currently defaults to 'essiv' +# Currently defaults to 'plain64' # @ivgen-hash-alg: the initialization vector generator hash # Currently defaults to 'sha256' # @hash-alg: the master key hash algorithmSignature · 1 line
2.11.0
Quoted 1 line · Alberto Garcia
ping
Sorry, I should have said I queued this patch when adding my previous R-b.
Quoted 22 lines · Alberto Garcia
Quoted 21 lines
The values specified in the documentation don't match the actual defaults set in
qcrypto_block_luks_create().Signed-off-by Alberto Garcia <[email protected]>--- qapi/crypto.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)qapi/crypto.json +2
-2@@ -181,11 +181,11 @@ # The options that apply to LUKS encryption format initialization # # @cipher-alg: the cipher algorithm for data encryption -# Currently defaults to 'aes'. +# Currently defaults to 'aes-256'. # @cipher-mode: the cipher mode for data encryption -# Currently defaults to 'cbc' +# Currently defaults to 'xts'
Quoted 8 lines
Quoted 8 lines
qapi/crypto.json +1
-1# @ivgen-alg: the initialization vector generator -# Currently defaults to 'essiv' +# Currently defaults to 'plain64' # @ivgen-hash-alg: the initialization vector generator hash # Currently defaults to 'sha256' # @hash-alg: the master key hash algorithmSignature · 1 line
2.11.0
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|