Skip to contentSkip to conversation

arm64: dts: sdm630 SoC and Sony Pioneer (Xperia XA2) support

PATCH In review Craig Tatlor 3 participants 4 messages Aug 12, 2018 – Nov 12, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: sdm630 SoC and Sony Pioneer (Xperia XA2) support

Initial device tree support for Qualcomm SDM630 SoC and Sony Pioneer (Xperia XA2).

SDM630 is based off of the SDM660 soc and all SDM660 specific drivers are compatible with it. SDM660 is also based off of MSM8998 so it uses some of its drivers aswell.

The device tree is based on the CAF 4.4 kernel tree.

The device can be booted into the initrd with a shell over UART.

---

Changes from v1:
Adds gpio-ranges node to allow gpio-hogs to function

 arch/arm64/boot/dts/qcom/Makefile            |   1 +
 arch/arm64/boot/dts/qcom/sdm630-pins.dtsi    |  17 +
 arch/arm64/boot/dts/qcom/sdm630-pioneer.dts  |  16 +
 arch/arm64/boot/dts/qcom/sdm630-pioneer.dtsi |  22 ++
 arch/arm64/boot/dts/qcom/sdm630.dtsi         | 384 +++++++++++++++++++
 5 files changed, 439 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sdm630-pins.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/sdm630-pioneer.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sdm630-pioneer.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/sdm630.dtsi
arch/arm64/boot/dts/qcom/Makefile +1 -0
index 9319e74b8906..80f98bb19998 100644
@@ -6,4 +6,5 @@ dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-bullhead-rev-101.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8994-angler-rev-101.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sdm630-pioneer.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm845-mtp.dtb
arch/arm64/boot/dts/qcom/sdm630-pins.dtsi new file +17 -0
new file mode 100644
index 000000000000..78b79c1076f1
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2018, Craig Tatlor. */
+
+&tlmm {
+	blsp1_uart1_default: blsp1_uart1_default {
+		pinmux {
+			pins = "gpio0", "gpio1", "gpio2", "gpio3";
+			function = "gpio";
+		};
+
+		pinconf {
+			pins = "gpio0", "gpio1", "gpio2", "gpio3";
+			drive-strength = <2>;
+			bias-disable;
+		};
+	};
+};
arch/arm64/boot/dts/qcom/sdm630-pioneer.dts new file +16 -0
new file mode 100644
index 000000000000..67c7e3b57739
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2018, Craig Tatlor. */
+
+/dts-v1/;
+
+#include "sdm630-pioneer.dtsi"
+
+/ {
+	model = "Sony Xperia XA2";
+	compatible = "sony,pioneer", "qcom,sdm630";
+
+	/* required for bootloader to select correct board */
+	qcom,board-id = <8 0>;
+	qcom,pmic-id = <0x0001001b 0x0101011a 0x0 0x0>,
+			<0x0001001b 0x0201011a 0x0 0x0>;
+};
arch/arm64/boot/dts/qcom/sdm630-pioneer.dtsi new file +22 -0
new file mode 100644
index 000000000000..512792c23369
@@ -0,0 +1,22 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2018, Craig Tatlor. */
+
+#include "sdm630.dtsi"
+
+/ {
+	aliases {
+		serial0 = &blsp1_uart1;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&soc {
+	serial at c170000 {
+		status = "okay";
+		pinctrl-names = "default";
+		pinctrl-0 = <&blsp1_uart1_default>;
+	};
+};
arch/arm64/boot/dts/qcom/sdm630.dtsi new file +384 -0

384 lines not on this page · raw message

Signature · 1 line
2.18.0
#1 lore raw
Thank you for the patch! Yet something to improve:

Hi Craig,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on agross/for-next]
[also build test ERROR on v4.18 next-20180817]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Craig-Tatlor/arm64-dts-sdm630-SoC-and-Sony-Pioneer-Xperia-XA2-support/20180813-040803
base:   https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git for-next
config: arm64-allnoconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm64

All errors (new ones prefixed by >>):

In file included from arch/arm64/boot/dts/qcom/sdm630-pioneer.dtsi:4:0,

                    from arch/arm64/boot/dts/qcom/sdm630-pioneer.dts:6:
>> arch/arm64/boot/dts/qcom/sdm630.dtsi:5:10: fatal error: dt-bindings/clock/qcom,gcc-sdm660.h: No such file or directory
    #include <dt-bindings/clock/qcom,gcc-sdm660.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

compilation terminated.

vim +5 arch/arm64/boot/dts/qcom/sdm630.dtsi

3
4 #include <dt-bindings/interrupt-controller/arm-gic.h>

   > 5	#include <dt-bindings/clock/qcom,gcc-sdm660.h>
     6	

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 6666 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180820/4fde0e3a/attachment.gz>

#2 lore raw
In reply to Craig Tatlor

Hi Craig,

Am Sonntag, 12. August 2018, 16:23:12 CET schrieb Craig Tatlor:

Quoted 7 lines

Initial device tree support for Qualcomm SDM630 SoC and Sony Pioneer (Xperia XA2).

SDM630 is based off of the SDM660 soc and all SDM660 specific drivers are compatible with it. SDM660 is also based off of MSM8998 so it uses some of its drivers aswell.

Quoted 5 lines

The device tree is based on the CAF 4.4 kernel tree.

The device can be booted into the initrd with a shell over UART.

With I think core drivers like clk, pinctrl merged in 4.20, do you plan on respinning the devicetree support or in general continue working on sdm630/sdm660?

Or do you have some git tree available somewhere, were I can follow along? I do have interest in supporting a sdm630 phone of my own but still don't want to duplicate work :-)

Thanks
Heiko

#3 lore raw
Quoted 12 lines · Heiko Stuebner

Hi Craig,

Am Sonntag, 12. August 2018, 16:23:12 CET schrieb Craig Tatlor:

Quoted 9 lines

Initial device tree support for Qualcomm SDM630 SoC and Sony Pioneer (Xperia XA2).

SDM630 is based off of the SDM660 soc and all SDM660 specific drivers are compatible with it. SDM660 is also based off of MSM8998 so it uses some of its drivers aswell.

The device tree is based on the CAF 4.4 kernel tree.

Quoted 8 lines
Quoted 3 lines

The device can be booted into the initrd with a shell over UART.

With I think core drivers like clk, pinctrl merged in 4.20, do you plan on respinning the devicetree support or in general continue working on sdm630/sdm660?

Yeah, i am just a little busy at the moment, i should probably be sending of v3 in a few weeks.

Quoted 3 lines

Or do you have some git tree available somewhere, were I can follow along? I do have interest in supporting a sdm630 phone of my own but still don't want to duplicate work :-)

My git tree is https://gitlab.com/opendata26/linux the mainline-submit-2 branch, i have sdhci, usb(via downstream backport just so i can debug without opening phone) and also working on modem but that isnt in that tree and isnt working quite yet.

Quoted 7 lines

Thanks
Heiko