Skip to contentSkip to conversation

qemu-arm: Enable VirtIO distro target

PATCH New Sumit Garg 2 participants 3 messages Nov 12, 2018 – Nov 13, 2018

lore
Share & tools
lore

Sumit Garg

author
#0 lore raw

PATCH 1/1 qemu-arm: Enable VirtIO distro target

With -device virtio-blk-device,drive=hd0, it could detect distro boot target.

Signed-off-by Sumit Garg <[email protected]>

---

Depends on https://patchwork.ozlabs.org/patch/995524/ which adds VirtIO distro boot command.

 include/configs/qemu-arm.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/configs/qemu-arm.h +2 -1
index fedc466..437c3ae 100644
@@ -25,7 +25,8 @@
 
 #define BOOT_TARGET_DEVICES(func) \
 	func(SCSI, scsi, 0) \
-	func(DHCP, dhcp, na)
+	func(DHCP, dhcp, na) \
+	func(VIRTIO, virtio, 0)
 
 #include <config_distro_bootcmd.h>
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 qemu-arm: Enable VirtIO distro target

Hi Sumit,

Quoted 5 lines · On Mon, 12 Nov 2018 15:29:08 +0530 Sumit Garg <[email protected]> wrote:

With -device virtio-blk-device,drive=hd0, it could detect distro boot target.

Signed-off-by Sumit Garg <[email protected]>

---

...

Quoted 5 lines
include/configs/qemu-arm.h +0 -0
index fedc466..437c3ae 100644

include/configs/qemu-arm.h line 32

Quoted 9 lines
include/configs/qemu-arm.h +2 -1
@@ -25,7 +25,8 @@
 
 #define BOOT_TARGET_DEVICES(func) \
 	func(SCSI, scsi, 0) \
-	func(DHCP, dhcp, na)
+	func(DHCP, dhcp, na) \
+	func(VIRTIO, virtio, 0)
 
 #include <config_distro_bootcmd.h>

I think typically DHCP is the very last boot option since it can take quite long to notice if there's no DHCP server on the network and fall back to the next option. So perhaps an order of

SCSI; VIRTIO; DHCP

would be better.

Other than that, looks fine to me.

- Tuomas

author
#2 lore raw

PATCH 1/1 qemu-arm: Enable VirtIO distro target

Hi Tuomas,

Quoted 24 lines · Tuomas Tynkkynen

Hi Sumit,

Quoted 5 lines · On Mon, 12 Nov 2018 15:29:08 +0530 Sumit Garg <[email protected]> wrote:

With -device virtio-blk-device,drive=hd0, it could detect distro boot target.

Signed-off-by Sumit Garg <[email protected]>

---

...

Quoted 12 lines
include/configs/qemu-arm.h +2 -1
index fedc466..437c3ae 100644
@@ -25,7 +25,8 @@
 
 #define BOOT_TARGET_DEVICES(func) \
      func(SCSI, scsi, 0) \
-     func(DHCP, dhcp, na)
+     func(DHCP, dhcp, na) \
+     func(VIRTIO, virtio, 0)
Quoted 9 lines

include/configs/qemu-arm.h line 32

Quoted 2 lines
include/configs/qemu-arm.h +0 -0
 #include <config_distro_bootcmd.h>

I think typically DHCP is the very last boot option since it can take quite long to notice if there's no DHCP server on the network and fall back to the next option. So perhaps an order of

SCSI; VIRTIO; DHCP

Yeah it does makes sense. Will change in v2.

-Sumit

Quoted 5 lines

would be better.

Other than that, looks fine to me.

- Tuomas