Skip to contentSkip to conversation

arm64: dts: stratix10: Support Ethernet Jumbo frame

PATCH Applied Dinh Nguyen 3 participants 5 messages Nov 13, 2018 – Nov 16, 2018

Subsystems (3)
Stable branch Device tree bindings Arm/socfpga architecture
lore
Share & tools
lore

Dinh Nguyen

author maintainer
#0 lore raw

PATCH 1/2 arm64: dts: stratix10: Support Ethernet Jumbo frame

From: Thor Thayer <[email protected]>

commit a27460c9768ee19949c5b91f3d959ccd88c2a64a upstream

Properly specify the RX and TX FIFO size which is important for Jumbo frames.
Update the max-frame-size to support Jumbo frames.

Signed-off-by Thor Thayer <[email protected]>
Signed-off-by David S. Miller <[email protected]>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi      | 6 ++++++
 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +6 -0
index d033da401c26..8a2641c742ae 100644
@@ -137,6 +137,8 @@
 			reset-names = "stmmaceth", "stmmaceth-ocp";
 			clocks = <&clkmgr STRATIX10_EMAC0_CLK>;
 			clock-names = "stmmaceth";
+			tx-fifo-depth = <16384>;
+			rx-fifo-depth = <16384>;
 			status = "disabled";
 		};
 

@@ -150,6 +152,8 @@
 			reset-names = "stmmaceth", "stmmaceth-ocp";
 			clocks = <&clkmgr STRATIX10_EMAC1_CLK>;
 			clock-names = "stmmaceth";
+			tx-fifo-depth = <16384>;
+			rx-fifo-depth = <16384>;
 			status = "disabled";
 		};
 

@@ -163,6 +167,8 @@
 			reset-names = "stmmaceth", "stmmaceth-ocp";
 			clocks = <&clkmgr STRATIX10_EMAC2_CLK>;
 			clock-names = "stmmaceth";
+			tx-fifo-depth = <16384>;
+			rx-fifo-depth = <16384>;
 			status = "disabled";
 		};
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts +1 -1
index 6edc4fa9fd42..7c661753bfaf 100644
@@ -76,7 +76,7 @@
 	phy-mode = "rgmii";
 	phy-handle = <&phy0>;
 
-	max-frame-size = <3800>;
+	max-frame-size = <9000>;
 
 	mdio0 {
 		#address-cells = <1>;
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH 2/2 arm64: dts: stratix10: fix multicast filtering

From: Aaro Koskinen <[email protected]>

commit fd5ba6ee3187617287fb9cb187e3d6b3631210a3 upstream

On Stratix 10, the EMAC has 256 hash buckets for multicast filtering. This needs to be specified in DTS, otherwise the stmmac driver defaults to 64 buckets and initializes the filter incorrectly. As a result, e.g. valid IPv6 multicast traffic ends up being dropped.

Fixes 78cd6a9d8e15 ("arm64: dts: Add base stratix 10 dtsi")
Cc [email protected]
Signed-off-by Aaro Koskinen <[email protected]>
Signed-off-by Dinh Nguyen <[email protected]>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +3 -0
index 8a2641c742ae..f89e6c86e4d7 100644
@@ -139,6 +139,7 @@
 			clock-names = "stmmaceth";
 			tx-fifo-depth = <16384>;
 			rx-fifo-depth = <16384>;
+			snps,multicast-filter-bins = <256>;
 			status = "disabled";
 		};
 

@@ -154,6 +155,7 @@
 			clock-names = "stmmaceth";
 			tx-fifo-depth = <16384>;
 			rx-fifo-depth = <16384>;
+			snps,multicast-filter-bins = <256>;
 			status = "disabled";
 		};
 

@@ -169,6 +171,7 @@
 			clock-names = "stmmaceth";
 			tx-fifo-depth = <16384>;
 			rx-fifo-depth = <16384>;
+			snps,multicast-filter-bins = <256>;
 			status = "disabled";
 		};
Signature · 1 line
2.17.1
maintainer
#2 lore raw
In reply to Dinh Nguyen
Quoted 8 lines · Dinh Nguyen

From: Thor Thayer <[email protected]>

commit a27460c9768ee19949c5b91f3d959ccd88c2a64a upstream

Properly specify the RX and TX FIFO size which is important for Jumbo frames.
Update the max-frame-size to support Jumbo frames.

Quoted 6 lines
Signed-off-by Thor Thayer <[email protected]>
Signed-off-by David S. Miller <[email protected]>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi      | 6 ++++++
 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

Any hint as to what stable tree(s) you want these applied to?

thanks,

greg k-h

author maintainer
#3 lore raw
Quoted 9 lines · Greg KH
Quoted 8 lines · Dinh Nguyen

From: Thor Thayer <[email protected]>

commit a27460c9768ee19949c5b91f3d959ccd88c2a64a upstream

Properly specify the RX and TX FIFO size which is important for Jumbo frames.
Update the max-frame-size to support Jumbo frames.

Quoted 9 lines
Quoted 6 lines
Signed-off-by Thor Thayer <[email protected]>
Signed-off-by David S. Miller <[email protected]>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi      | 6 ++++++
 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

Any hint as to what stable tree(s) you want these applied to?

Oh sorry about that! Please apply these to 4.18-stable and 4.19-stable.

Thanks,
Dinh

maintainer Applied
#4 lore raw
Quoted 19 lines · Dinh Nguyen
Quoted 16 lines · Greg KH
Quoted 14 lines · Dinh Nguyen

From: Thor Thayer <[email protected]>

commit a27460c9768ee19949c5b91f3d959ccd88c2a64a upstream

Properly specify the RX and TX FIFO size which is important for Jumbo frames.
Update the max-frame-size to support Jumbo frames.

Signed-off-by Thor Thayer <[email protected]>
Signed-off-by David S. Miller <[email protected]>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi      | 6 ++++++
 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)
Quoted 4 lines
Quoted 2 lines

Any hint as to what stable tree(s) you want these applied to?

Oh sorry about that! Please apply these to 4.18-stable and 4.19-stable.

Queued for 4.18 and 4.19, thank you.

--
Thanks,
Sasha