Skip to contentSkip to conversation

fsl-lsch3: soc: Enable AHB read support for Flexspi controller

PATCH Superseded Ashish Kumar 2 participants 4 messages Nov 13, 2018 – Nov 20, 2018 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 fsl-lsch3: soc: Enable AHB read support for Flexspi controller

Enable AHB support for Flexspi controller interface meaning memory can be accessed via md command using absolute addresses

---
v3:
Depends upon http://patchwork.ozlabs.org/patch/975009/
v2:
1. Rename FSPI to FlexSPI in description and comments
2. s/cmd/command
3. Add macro and comments to improve readablity of code in soc.c
4. Add declaration in soc.h for fspi_ahb_init()

 arch/arm/cpu/armv8/fsl-layerscape/Kconfig     | 10 +++++
 arch/arm/cpu/armv8/fsl-layerscape/soc.c       | 44 +++++++++++++++++++
 .../arm/include/asm/arch-fsl-layerscape/soc.h |  7 +++
 3 files changed, 61 insertions(+)
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +10 -0
index 5280d33ec8..70f26973e9 100644
@@ -327,6 +327,16 @@ config SYS_FSPI_AHB_INIT
 	  performed. Default LUT programmed in AHB mode is Fast Read command
 	  with 4-byte addressing enabled.
 
+config FSPI_AHB_EN_4BYTE
+	bool "Enable 4-byte Fast Read command for AHB mode"
+	depends on NXP_FSPI
+	default n
+	help
+	  The default setting for FlexSPI AHB bus just supports 3-byte addressing.
+	  But some FlexSPI flash sizes are up to 64MBytes.
+	  This flag enables fast read command for AHB mode and modifies required
+	  LUT to support full FlexSPI flash.
+
 config SYS_CCI400_OFFSET
 	hex "Offset for CCI400 base"
 	depends on SYS_FSL_HAS_CCI400
arch/arm/cpu/armv8/fsl-layerscape/soc.c +44 -0

56 lines not on this page · raw message

arch/arm/include/asm/arch-fsl-layerscape/soc.h +7 -0
index 61b6e4bf07..84450c76ed 100644
@@ -102,6 +102,13 @@ void init_pfe_scfg_dcfg_regs(void);
 int qspi_ahb_init(void);
 #endif
 
+#ifdef CONFIG_FSPI_AHB_EN_4BYTE
+#define SYS_NXP_FSPI_LUTCR_LOCK			0x00000001
+#define SYS_NXP_FSPI_LUTCR_UNLOCK		0x00000002
+#define SYS_NXP_FSPI_LUTKEY			0x5AF05AF0
+int fspi_ahb_init(void);
+#endif
+
 void cpu_name(char *name);
 #ifdef CONFIG_SYS_FSL_ERRATUM_A009635
 void erratum_a009635(void);
Signature · 1 line
2.17.1
#1 lore raw

PATCH v3 1/1 fsl-lsch3: soc: Enable AHB read support for Flexspi controller

Quoted 9 lines · Ashish Kumar

Enable AHB support for Flexspi controller interface meaning memory can be accessed via md command using absolute addresses

---
v3:
Depends upon http://patchwork.ozlabs.org/patch/975009/

Your v3 patch depends on its v2 version. This doesn't make sense.

York

#2 lore raw

PATCH v3 1/1 fsl-lsch3: soc: Enable AHB read support for Flexspi controller

Quoted 11 lines

-----Original Message-----
From: York Sun
Sent: Tuesday, November 20, 2018 2:13 AM
To: Ashish Kumar <[email protected]>; u-boot at lists.denx.de
Cc: Yogesh Narayan Gaur <[email protected]>; Rajat Srivastava <[email protected]>
Subject: Re: [PATCH v3] fsl-lsch3: soc: Enable AHB read support for Flexspi controller

Quoted 10 lines
Quoted 9 lines · Ashish Kumar

Enable AHB support for Flexspi controller interface meaning memory can be accessed via md command using absolute addresses

---
v3:
Depends upon http://patchwork.ozlabs.org/patch/975009/

Hi York,

Sorry that was typo, it was meant to be http://patchwork.ozlabs.org/patch/974301/.
But unfortunately after lot of delay in review on NXP-FlexSPI driver, it has been asked to re-write to a new frame-work. I think I should defer this http://patchwork.ozlabs.org/patch/975008/ and http://patchwork.ozlabs.org/patch/996846/ for the time being until 974301 is re-written. What do you suggest?

Regards
Ashish

Quoted 4 lines

Your v3 patch depends on its v2 version. This doesn't make sense.

York

#3 lore raw

PATCH v3 1/1 fsl-lsch3: soc: Enable AHB read support for Flexspi controller

Quoted 21 lines · Ashish Kumar
Quoted 11 lines

-----Original Message-----
From: York Sun
Sent: Tuesday, November 20, 2018 2:13 AM
To: Ashish Kumar <[email protected]>; u-boot at lists.denx.de
Cc: Yogesh Narayan Gaur <[email protected]>; Rajat Srivastava <[email protected]>
Subject: Re: [PATCH v3] fsl-lsch3: soc: Enable AHB read support for Flexspi controller

Quoted 10 lines
Quoted 9 lines · Ashish Kumar

Enable AHB support for Flexspi controller interface meaning memory can be accessed via md command using absolute addresses

---
v3:
Depends upon http://patchwork.ozlabs.org/patch/975009/

Quoted 5 lines

Hi York,

Sorry that was typo, it was meant to be http://patchwork.ozlabs.org/patch/974301/.
But unfortunately after lot of delay in review on NXP-FlexSPI driver, it has been asked to re-write to a new frame-work. I think I should defer this http://patchwork.ozlabs.org/patch/975008/ and http://patchwork.ozlabs.org/patch/996846/ for the time being until 974301 is re-written. What do you suggest?

You still need FlexSPI driver, don't you? Please work with Jagan on the driver.

York