Testing statx syscall Timestamp fields
PATCH v4 1/1 Testing statx syscall Timestamp fields
The time before and after the execution of the corresponding system call is noted.
It is checked whether the time returned by statx lies in this range.
open syscall with O_CREAT flag for birth time.
write syscall for modified time.
read syscall for access time.
chmod syscall for status change time.
--- include/tst_safe_clocks.h | 32 ++++++ runtest/syscalls | 1 + testcases/kernel/syscalls/statx/.gitignore | 2 + testcases/kernel/syscalls/statx/Makefile | 4 + testcases/kernel/syscalls/statx/statx06.c | 174 +++++++++++++++++++++++++++++ 5 files changed, 213 insertions(+) create mode 100644 include/tst_safe_clocks.h create mode 100644 testcases/kernel/syscalls/statx/statx06.c
include/tst_safe_clocks.h new file +32 -0
@@ -0,0 +1,32 @@ +#include <time.h> +#include "tst_test.h" + +static inline void safe_clock_getres (const char *file,const int lineno, +clockid_t clk_id,struct timespec *res) +{ +int rval; + + rval =clock_getres (clk_id, res); +if (rval ==-1 ) +tst_brk (TBROK |TERRNO , +"%s:%d:, clock_getres() failed" , file, lineno); + +} + +static inline void safe_clock_gettime (const char *file,const int lineno, +clockid_t clk_id,struct timespec *tp) +{ +int rval; + + rval =clock_gettime (clk_id, tp); +if (rval ==-1 ) +tst_brk (TBROK |TERRNO , +"%s:%d:, clock_gettime() failed" , file, lineno); +} + +#define SAFE_CLOCK_GETRES (clk_id, res)\ + safe_clock_getres(__FILE__, __LINE__, (clk_id), (res)) + +#define SAFE_CLOCK_GETTIME (clk_id, tp)\ + safe_clock_gettime(__FILE__, __LINE__, (clk_id), (tp)) +
runtest/syscalls +1 -0
@@ -1514,3 +1514,4 @@ statx02 statx02 statx03 statx03 statx04 statx04 statx05 statx05 +statx06 statx06
testcases/kernel/syscalls/statx/.gitignore +2 -0
@@ -3,3 +3,5 @@ /statx03 /statx04 /statx05 +/statx06 +
testcases/kernel/syscalls/statx/Makefile +4 -0
@@ -24,3 +24,7 @@ include $(top_srcdir)/include/mk/testcases.mk %_64: CPPFLAGS += -D_FILE_OFFSET_BITS=64 include $(top_srcdir)/include/mk/generic_leaf_target.mk + +statx06: LDLIBS += -lrt + +
testcases/kernel/syscalls/statx/statx06.c new file +174 -0
174 lines not on this page · raw message
Signature · 1 line
2.11.0
PATCH v4 1/1 Testing statx syscall Timestamp fields
Hi!
include/tst_safe_clocks.h
Quoted 6 lines
include/tst_safe_clocks.h new file +0
-0@@ -0,0 +1,32 @@
Here it misses SPDX license identifier, copyright and also C guards.
include/tst_safe_clocks.h line 10
Quoted 10 lines
include/tst_safe_clocks.h new file +10
-0+#include <time.h> +#include "tst_test.h" + +static inline void safe_clock_getres (const char *file,const int lineno, +clockid_t clk_id,struct timespec *res) +{ +int rval; + + rval =clock_getres (clk_id, res); +if (rval ==-1 )
^ rval != 0 is a bit more robust
include/tst_safe_clocks.h line 12
Quoted 2 lines
include/tst_safe_clocks.h new file +2
-0+tst_brk (TBROK |TERRNO , +"%s:%d:, clock_getres() failed" , file, lineno);
^ ^
| We should print the parameters here
No comma here please.
include/tst_safe_clocks.h line 23
Quoted 11 lines
include/tst_safe_clocks.h new file +11
-0+ +} + +static inline void safe_clock_gettime (const char *file,const int lineno, +clockid_t clk_id,struct timespec *tp) +{ +int rval; + + rval =clock_gettime (clk_id, tp); +if (rval ==-1 ) + tst_brk(TBROK | TERRNO,
^ Trailing whitespace.
include/tst_safe_clocks.h line 24
Quoted 1 line
include/tst_safe_clocks.h new file +1
-0+ "%s:%d:, clock_gettime() failed", file, lineno);
Here as well.
Quoted 109 lines
include/tst_safe_clocks.h new file +8
-0+} + +#define SAFE_CLOCK_GETRES (clk_id, res)\ + safe_clock_getres(__FILE__, __LINE__, (clk_id), (res)) + +#define SAFE_CLOCK_GETTIME (clk_id, tp)\ + safe_clock_gettime(__FILE__, __LINE__, (clk_id), (tp)) +runtest/syscalls +1
-0@@ -1514,3 +1514,4 @@ statx02 statx02 statx03 statx03 statx04 statx04 statx05 statx05 +statx06 statx06testcases/kernel/syscalls/statx/.gitignore +2
-0@@ -3,3 +3,5 @@ /statx03 /statx04 /statx05 +/statx06 +testcases/kernel/syscalls/statx/Makefile +4
-0@@ -24,3 +24,7 @@ include $(top_srcdir)/include/mk/testcases.mk %_64: CPPFLAGS += -D_FILE_OFFSET_BITS=64 include $(top_srcdir)/include/mk/generic_leaf_target.mk + +statx06: LDLIBS += -lrt + +testcases/kernel/syscalls/statx/statx06.c new file +64
-0@@ -0,0 +1,174 @@ +// SPDX-License-Identifier: GPL-2.0 or later +/* +* Copyright (c) Zilogic Systems Pvt. Ltd., 2018 +* Email : [email protected] +*/ + +/* +* DESCRIPTION : +* +* Test-Case 1 : Testing btime +* flow : The time before and after the execution of the create +* system call is noted. +* It is checked whether the birth time returned by statx lies in +* this range. +* +* Test-Case 2 : Testing mtime +* flow : The time before and after the execution of the write +* system call is noted. +* It is checked whether the modification time returned +* by statx lies in this range. +* +* Test-Case 3 : Testing atime +* flow : The time before and after the execution of the read +* system call is noted. +* It is checked whether the access time returned by statx lies in +* this range. +* +* Test-Case 4 : Testing ctime +* flow : The time before and after the execution of the chmod +* system call is noted. +* It is checked whether the status change time returned by statx +* lies in this range. +* +*/ + +#include <stdio.h> +#include "tst_test.h" +#include "lapi/stat.h" +#include "tst_safe_clocks.h" +#include "tst_safe_macros.h" +#include "tst_timer.h" +#include <sys/mount.h> +#include <time.h> + +#define MOUNT_POINT "mount_ext" +#define TEST_FILE MOUNT_POINT"/test_file.txt" +#define SIZE 2 + +static int fd; + +static void timestamp_to_timespec (const struct statx_timestamp *timestamp, +struct timespec *timespec) +{ + timespec->tv_sec = timestamp->tv_sec; + timespec->tv_nsec = timestamp->tv_nsec; +} + +static void clock_wait_tick (void ) +{ +struct timespec res; +unsigned int usecs; + +SAFE_CLOCK_GETRES (CLOCK_REALTIME_COARSE , &res); + usecs =tst_timespec_to_us (res);
testcases/kernel/syscalls/statx/statx06.c line 74
Quoted 10 lines
testcases/kernel/syscalls/statx/statx06.c new file +10
-0+ +usleep (usecs); +} + +static void create_file (void ) +{ +if (fd >0 ) { +SAFE_CLOSE (fd); +SAFE_UNLINK (TEST_FILE ); + }
^
Spaces instead of tab
Such things could be easily identified by running checkpatch.pl which is shipped with linux kernel sources on the patch.
Quoted 87 lines
testcases/kernel/syscalls/statx/statx06.c new file +87
-0+ fd =SAFE_OPEN (TEST_FILE ,O_CREAT |O_RDWR ,0666 ); +} + +static void write_file (void ) +{ +char data[SIZE ] ="hi" ; + +SAFE_WRITE (0 , fd, data,sizeof (data)); +} + +static void read_file (void ) +{ +char data[SIZE ]; + +SAFE_READ (0 , fd, data,sizeof (data)); +} + +static void change_mode (void ) +{ +SAFE_CHMOD (TEST_FILE ,0777 ); +} + +static struct test_case { +void (*operation)(void ); +char *op_name; +} tcases[] = { + {.operation = create_file, + .op_name ="Birth time" }, + {.operation = write_file, + .op_name ="Modified time" }, + {.operation = read_file, + .op_name ="Access time" }, + {.operation = change_mode, + .op_name ="Change time" } +}; + +static void test_statx (unsigned int test_nr) +{ +struct statx buff; +struct timespec before_time; +struct timespec after_time; +struct timespec statx_time = {0 ,0 }; + +struct test_case *tc = &tcases[test_nr]; + +SAFE_CLOCK_GETTIME (CLOCK_REALTIME_COARSE , &before_time); +clock_wait_tick (); + tc->operation (); +clock_wait_tick (); +SAFE_CLOCK_GETTIME (CLOCK_REALTIME_COARSE , &after_time); + +TEST (statx (AT_FDCWD ,TEST_FILE ,0 ,STATX_ALL , &buff)); +if (TST_RET !=0 ) +tst_brk (TFAIL |TTERRNO , +"statx(AT_FDCWD, %s, 0, STATX_ALL, &buff)" , +TEST_FILE ); + +switch (test_nr) { +case 0 : +timestamp_to_timespec (&buff.stx_btime, &statx_time); +break ; +case 1 : +timestamp_to_timespec (&buff.stx_mtime, &statx_time); +break ; +case 2 : +timestamp_to_timespec (&buff.stx_atime, &statx_time); +break ; +case 3 : +timestamp_to_timespec (&buff.stx_ctime, &statx_time); +break ; + } +if (tst_timespec_lt (statx_time, before_time)) +tst_res (TFAIL ,"%s < before time" , tc->op_name); +else if (tst_timespec_lt (after_time, statx_time)) +tst_res (TFAIL ,"%s > after_time" , tc->op_name); +else +tst_res (TPASS ,"%s Passed\n" , tc->op_name); +} + + +static void cleanup (void ) +{ +if (fd >0 ) +SAFE_CLOSE (fd); +} + +static struct tst_test test = {
testcases/kernel/syscalls/statx/statx06.c line 171
Quoted 10 lines
testcases/kernel/syscalls/statx/statx06.c new file +10
-0+ .cleanup = cleanup, + .tcnt = ARRAY_SIZE(tcases), + .test = test_statx, + .min_kver = "4.11", + .needs_root = 1, + .needs_tmpdir = 1, + .mntpoint = MOUNT_POINT, + .mount_device = 1, + .dev_fs_type = "ext4", + .dev_min_size = 512,
Again do we really need 512MB for the test?
I doubt so.
testcases/kernel/syscalls/statx/statx06.c line 173
Quoted 2 lines
testcases/kernel/syscalls/statx/statx06.c new file +2
-0+ .mnt_flags = MS_STRICTATIME, +};
Otherwise it's good.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH v4 1/1 Testing statx syscall Timestamp fields
Hi,
Quoted 20 lines
include/tst_safe_clocks.h line 10
Quoted 11 lines
include/tst_safe_clocks.h new file +4
-0+#include <time.h> +#include "tst_test.h" + +static inline void safe_clock_getres(const char *file, const intlineno,
include/tst_safe_clocks.h new file +6
-0+ clockid_t clk_id, struct timespec *res) +{ + int rval; + + rval =clock_getres (clk_id, res); +if (rval ==-1 )^ rval != 0 is a bit more robustinclude/tst_safe_clocks.h line 12
Quoted 2 lines
include/tst_safe_clocks.h new file +2
-0+tst_brk (TBROK |TERRNO , +"%s:%d:, clock_getres() failed" , file, lineno);^ ^
| We should print the
parameters here
No comma here please.
Quoted 3 lines
include/tst_safe_clocks.h line 15
Quoted 3 lines
include/tst_safe_clocks.h new file +3
-0+ +} +
Since file and lineno are error indicating parameters and not the actual function arguments we preferred printing it before the actual error message.
Also as the second parameter is a structure we weren't sure if it is necessary to print individual structure members. That is why we preferred printing a plain error message with just the lineno and file name.
Quoted 16 lines
testcases/kernel/syscalls/statx/statx06.c line 171
Quoted 11 lines
testcases/kernel/syscalls/statx/statx06.c new file +11
-0+static struct tst_test test = { + .cleanup = cleanup, + .tcnt =ARRAY_SIZE (tcases), + .test = test_statx, + .min_kver ="4.11" , + .needs_root =1 , + .needs_tmpdir =1 , + .mntpoint =MOUNT_POINT , + .mount_device =1 , + .dev_fs_type ="ext4" , + .dev_min_size =512 ,Again do we really need 512MB for the test?
I doubt so.
Quoted 9 lines
testcases/kernel/syscalls/statx/statx06.c line 173
Quoted 2 lines
testcases/kernel/syscalls/statx/statx06.c new file +2
-0+ .mnt_flags = MS_STRICTATIME, +};Otherwise it's good.
--
Cyril Hrubis
[email protected]
For the ext4 to provide nanosecond precision to the timestamp fields the INODE size has to be atleast 256bytes.
If the file system size is smaller than 512MB then by default the INODE size will be only 128bytes and hence will not support birth time and nano second precision.
With Regards
Subash G
PATCH v4 1/1 Testing statx syscall Timestamp fields
Hi!
Quoted 11 lines
Quoted 11 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ rval = clock_getres(clk_id, res); + if (rval == -1)^ rval != 0 is a bit more robustinclude/tst_safe_clocks.h line 12
Quoted 2 lines
include/tst_safe_clocks.h new file +2
-0+tst_brk (TBROK |TERRNO , +"%s:%d:, clock_getres() failed" , file, lineno);^ ^
| We should print the
parameters here
No comma here please.
Quoted 7 lines
Quoted 3 lines
include/tst_safe_clocks.h line 15
Quoted 3 lines
include/tst_safe_clocks.h new file +3
-0+ +} +Since file and lineno are error indicating parameters and not the actual function arguments we preferred printing it before the actual error message.
Well the clk_id could be computed on the fly and passed to the function, hence it would be better to print it here.
Quoted 3 lines
Also as the second parameter is a structure we weren't sure if it is necessary to print individual structure members. That is why we preferred printing a plain error message with just the lineno and file name.
We usually print structure pointers passed just as %p. There is no point in printing out the structure members here becaues if the call fails the structure will not be initialized and will likely contain random garbage.
Quoted 16 lines
Quoted 4 lines
Again do we really need 512MB for the test?
I doubt so.
Quoted 9 lines
testcases/kernel/syscalls/statx/statx06.c line 173
Quoted 2 lines
testcases/kernel/syscalls/statx/statx06.c new file +2
-0+ .mnt_flags = MS_STRICTATIME, +};Otherwise it's good.
--
Cyril Hrubis
[email protected]
Quoted 6 lines
For the ext4 to provide nanosecond precision to the timestamp fields the INODE size has to be atleast 256bytes.
If the file system size is smaller than 512MB then by default the INODE size will be only 128bytes and hence will not support birth time and nano second precision.
Here we are assuming something that may change in the future, shouldn't we rather pass "-I 256" to the mkfs the same way we pass "-b $PAGESIZE" in statx05.c? Then we can go with whatever the default filesystem size is.
Signature · 2 lines
Cyril Hrubis [email protected]