Skip to contentSkip to conversation

nvmetcli: ANA configuration support

PATCH Superseded Hannes Reinecke 4 participants 6 messages Nov 8, 2018 – Feb 11, 2019 NVMe

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 nvmetcli: ANA configuration support

Add support for ANA configuration.

Signed-off-by Hannes Reinecke <hare at suse.com>
---
 nvmet/__init__.py |   2 +-
 nvmet/nvme.py     | 105 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
 nvmetcli          |  64 +++++++++++++++++++++++++++++++++
 3 files changed, 169 insertions(+), 2 deletions(-)
nvmet/__init__.py +1 -1
index 6542d87..ca05de4 100644
@@ -1 +1 @@
-from .nvme import Root, Subsystem, Namespace, Port, Host, Referral
+from .nvme import Root, Subsystem, Namespace, Port, Host, Referral, ANAGroup
nvmet/nvme.py +104 -1

154 lines not on this page · raw message

nvmetcli +64 -0

88 lines not on this page · raw message

Signature · 1 line
2.12.3
maintainer
#1 lore raw

PATCH v2 1/1 nvmetcli: ANA configuration support

Reviewed-by Sagi Grimberg <sagi at grimberg.me>
#2 lore raw

PATCH v2 1/1 nvmetcli: ANA configuration support

In reply to Hannes Reinecke

This fails to restore a config that doesn't have the ANA fields yet (actual config attached):

Traceback (most recent call last):
File "./nvmetcli", line 740, in <module>

    main()
  File "./nvmetcli", line 722, in main
    funcs[sys.argv[1]](savefile)
  File "./nvmetcli", line 678, in restore
    errors = nvme.Root().restore_from_file(from_file)
  File "/root/nvmetcli/nvmet/nvme.py", line 382, in restore_from_file
    abort_on_error=abort_on_error)
  File "/root/nvmetcli/nvmet/nvme.py", line 356, in restore
    Subsystem.setup(t, err_func)
  File "/root/nvmetcli/nvmet/nvme.py", line 497, in setup
    Namespace.setup(s, ns, err_func)
  File "/root/nvmetcli/nvmet/nvme.py", line 610, in setup
    ns.set_grpid(int(n['ana_grpid']))

KeyError: 'ana_grpid'
-------------- next part --------------
A non-text attachment was scrubbed...
Name: loop2.json
Type: application/json
Size: 1221 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20181114/aaa1f9c0/attachment.json>

#3 lore raw

PATCH v2 1/1 nvmetcli: ANA configuration support

Quoted 18 lines · Christoph Hellwig

This fails to restore a config that doesn't have the ANA fields yet (actual config attached):

Traceback (most recent call last):
File "./nvmetcli", line 740, in <module>

     main()
   File "./nvmetcli", line 722, in main
     funcs[sys.argv[1]](savefile)
   File "./nvmetcli", line 678, in restore
     errors = nvme.Root().restore_from_file(from_file)
   File "/root/nvmetcli/nvmet/nvme.py", line 382, in restore_from_file
     abort_on_error=abort_on_error)
   File "/root/nvmetcli/nvmet/nvme.py", line 356, in restore
     Subsystem.setup(t, err_func)
   File "/root/nvmetcli/nvmet/nvme.py", line 497, in setup
     Namespace.setup(s, ns, err_func)
   File "/root/nvmetcli/nvmet/nvme.py", line 610, in setup
     ns.set_grpid(int(n['ana_grpid']))
Quoted 2 lines

KeyError: 'ana_grpid'

Gnaa. My python skills are crap.

Will see to have it fixed.

Cheers,

Hannes

Signature · 5 lines
Dr. Hannes Reinecke		               zSeries & Storage
hare at suse.com			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)
#4 lore raw

PATCH v2 1/1 nvmetcli: ANA configuration support

Quoted 3 lines · Hannes Reinecke

Gnaa. My python skills are crap.

Will see to have it fixed.

Did you get a chance to look at it?

#5 lore raw

PATCH v2 1/1 nvmetcli: ANA configuration support

In reply to Hannes Reinecke

Did you get a chance to look into this or should I spend some time on it?

Quoted 21 lines · Hannes Reinecke
Quoted 18 lines · Christoph Hellwig

This fails to restore a config that doesn't have the ANA fields yet (actual config attached):

Traceback (most recent call last):
File "./nvmetcli", line 740, in <module>

     main()
   File "./nvmetcli", line 722, in main
     funcs[sys.argv[1]](savefile)
   File "./nvmetcli", line 678, in restore
     errors = nvme.Root().restore_from_file(from_file)
   File "/root/nvmetcli/nvmet/nvme.py", line 382, in restore_from_file
     abort_on_error=abort_on_error)
   File "/root/nvmetcli/nvmet/nvme.py", line 356, in restore
     Subsystem.setup(t, err_func)
   File "/root/nvmetcli/nvmet/nvme.py", line 497, in setup
     Namespace.setup(s, ns, err_func)
   File "/root/nvmetcli/nvmet/nvme.py", line 610, in setup
     ns.set_grpid(int(n['ana_grpid']))
Quoted 2 lines

KeyError: 'ana_grpid'

Quoted 13 lines

Gnaa. My python skills are crap.

Will see to have it fixed.

Cheers,

Hannes

Signature · 5 lines
Dr. Hannes Reinecke		               zSeries & Storage
hare at suse.com			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

---end quoted text---