s390/vdso: add missing FORCE to build targets
Subsystems (9)
Sasha Levin
maintainerPATCH 1/27 s390/vdso: add missing FORCE to build targets
From: Vasily Gorbik <[email protected]>
[ Upstream commit b44b136a3773d8a9c7853f8df716bd1483613cbb ]
According to Documentation/kbuild/makefiles.txt all build targets using if_changed should use FORCE as well. Add missing FORCE to make sure vdso targets are rebuild properly when not just immediate prerequisites have changed but also when build command differs.
--- arch/s390/kernel/vdso32/Makefile | 6 +++--- arch/s390/kernel/vdso64/Makefile | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
arch/s390/kernel/vdso32/Makefile +3 -3
@@ -33,7 +33,7 @@ UBSAN_SANITIZE := n $(obj)/vdso32_wrapper.o : $(obj)/vdso32.so # link rule for the .so file, .lds has to be first -$(obj)/vdso32.so.dbg: $(src)/vdso32.lds $(obj-vdso32) +$(obj)/vdso32.so.dbg: $(src)/vdso32.lds $(obj-vdso32) FORCE $(call if_changed,vdso32ld) # strip rule for the .so file
@@ -42,12 +42,12 @@ $(obj)/%.so: $(obj)/%.so.dbg FORCE $(call if_changed,objcopy) # assembly rules for the .S files -$(obj-vdso32): %.o: %.S +$(obj-vdso32): %.o: %.S FORCE $(call if_changed_dep,vdso32as) # actual build commands quiet_cmd_vdso32ld = VDSO32L $@ - cmd_vdso32ld = $(CC) $(c_flags) -Wl,-T $^ -o $@ + cmd_vdso32ld = $(CC) $(c_flags) -Wl,-T $(filter %.lds %.o,$^) -o $@ quiet_cmd_vdso32as = VDSO32A $@ cmd_vdso32as = $(CC) $(a_flags) -c -o $@ $<
arch/s390/kernel/vdso64/Makefile +3 -3
@@ -33,7 +33,7 @@ UBSAN_SANITIZE := n $(obj)/vdso64_wrapper.o : $(obj)/vdso64.so # link rule for the .so file, .lds has to be first -$(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64) +$(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64) FORCE $(call if_changed,vdso64ld) # strip rule for the .so file
@@ -42,12 +42,12 @@ $(obj)/%.so: $(obj)/%.so.dbg FORCE $(call if_changed,objcopy) # assembly rules for the .S files -$(obj-vdso64): %.o: %.S +$(obj-vdso64): %.o: %.S FORCE $(call if_changed_dep,vdso64as) # actual build commands quiet_cmd_vdso64ld = VDSO64L $@ - cmd_vdso64ld = $(CC) $(c_flags) -Wl,-T $^ -o $@ + cmd_vdso64ld = $(CC) $(c_flags) -Wl,-T $(filter %.lds %.o,$^) -o $@ quiet_cmd_vdso64as = VDSO64A $@ cmd_vdso64as = $(CC) $(a_flags) -c -o $@ $<
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 2/27 netfilter: ipset: list:set: Decrease refcount synchronously on deletion and replace
From: Stefano Brivio <[email protected]>
[ Upstream commit 439cd39ea136d2c026805264d58a91f36b6b64ca ]
Commit 45040978c899 ("netfilter: ipset: Fix set:list type crash when flush/dump set in parallel") postponed decreasing set reference counters to the RCU callback.
An 'ipset del' command can terminate before the RCU grace period is elapsed, and if sets are listed before then, the reference counter shown in userspace will be wrong:
# ipset create h hash:ip; ipset create l list:set; ipset add l # ipset del l h; ipset list h Name: h Type: hash:ip Revision: 4 Header: family inet hashsize 1024 maxelem 65536 Size in memory: 88 References: 1 Number of entries: 0 Members: # sleep 1; ipset list h Name: h Type: hash:ip Revision: 4 Header: family inet hashsize 1024 maxelem 65536 Size in memory: 88 References: 0 Number of entries: 0 Members:
Fix this by making the reference count update synchronous again.
As a result, when sets are listed, ip_set_name_byindex() might now fetch a set whose reference count is already zero. Instead of relying on the reference count to protect against concurrent set renaming, grab ip_set_ref_lock as reader and copy the name, while holding the same lock in ip_set_rename() as writer instead.
--- include/linux/netfilter/ipset/ip_set.h | 2 +- net/netfilter/ipset/ip_set_core.c | 23 +++++++++++------------ net/netfilter/ipset/ip_set_list_set.c | 17 +++++++++++------ 3 files changed, 23 insertions(+), 19 deletions(-)
include/linux/netfilter/ipset/ip_set.h +1 -1
@@ -312,7 +312,7 @@ enum {extern ip_set_id_t ip_set_get_byname (struct net *net,const char *name,struct ip_set **set);extern void ip_set_put_byindex (struct net *net,ip_set_id_t index); -extern const char *ip_set_name_byindex (struct net *net,ip_set_id_t index); +extern void ip_set_name_byindex (struct net *net,ip_set_id_t index,char *name);extern ip_set_id_t ip_set_nfnl_get_byindex (struct net *net,ip_set_id_t index);extern void ip_set_nfnl_put (struct net *net,ip_set_id_t index);
net/netfilter/ipset/ip_set_core.c +11 -12
@@ -668,21 +668,20 @@ ip_set_put_byindex(struct net *net, ip_set_id_t index)EXPORT_SYMBOL_GPL (ip_set_put_byindex);/* Get the name of a set behind a set index. -* We assume the set is referenced, so it does exist and -* can't be destroyed. The set cannot be renamed due to -* the referencing either. -* +* Set itself is protected by RCU, but its name isn't: to protect against +* renaming, grab ip_set_ref_lock as reader (see ip_set_rename()) and copy the +* name. */ -const char * -ip_set_name_byindex (struct net *net,ip_set_id_t index) +void +ip_set_name_byindex (struct net *net,ip_set_id_t index,char *name) { -const struct ip_set *set =ip_set_rcu_get (net, index); +struct ip_set *set =ip_set_rcu_get (net, index);BUG_ON (!set); -BUG_ON (set->ref ==0 ); -/* Referenced, so it's safe */ -return set->name; +read_lock_bh (&ip_set_ref_lock); +strncpy (name, set->name,IPSET_MAXNAMELEN ); +read_unlock_bh (&ip_set_ref_lock); }EXPORT_SYMBOL_GPL (ip_set_name_byindex);
@@ -1128,7 +1127,7 @@ static int ip_set_rename(struct net *net, struct sock *ctnl,if (!set)return -ENOENT ; -read_lock_bh (&ip_set_ref_lock); +write_lock_bh (&ip_set_ref_lock);if (set->ref !=0 ) { ret = -IPSET_ERR_REFERENCED ; goto out;
@@ -1145,7 +1144,7 @@ static int ip_set_rename(struct net *net, struct sock *ctnl,strncpy (set->name, name2,IPSET_MAXNAMELEN ); out: -read_unlock_bh (&ip_set_ref_lock); +write_unlock_bh (&ip_set_ref_lock);return ret; }
net/netfilter/ipset/ip_set_list_set.c +11 -6
@@ -156,9 +156,7 @@ __list_set_del_rcu(struct rcu_head * rcu) { struct set_elem *e = container_of(rcu, struct set_elem, rcu);struct ip_set *set = e->set; -struct list_set *map = set->data; -ip_set_put_byindex (map->net, e->id);ip_set_ext_destroy (set, e);kfree (e); }
@@ -166,15 +164,21 @@ __list_set_del_rcu(struct rcu_head * rcu)static inline void list_set_del (struct ip_set *set,struct set_elem *e) { +struct list_set *map = set->data; + set->elements--;list_del_rcu (&e->list); +ip_set_put_byindex (map->net, e->id);call_rcu (&e->rcu, __list_set_del_rcu); }static inline void -list_set_replace (struct set_elem *e,struct set_elem *old) +list_set_replace (struct ip_set *set,struct set_elem *e,struct set_elem *old) { +struct list_set *map = set->data; +list_replace_rcu (&old->list, &e->list); +ip_set_put_byindex (map->net, old->id);call_rcu (&old->rcu, __list_set_del_rcu); }
@@ -306,7 +310,7 @@ list_set_uadd(struct ip_set *set, void *value, const struct ip_set_ext *ext,INIT_LIST_HEAD (&e->list);list_set_init_extensions (set, ext, e);if (n) -list_set_replace (e, n); +list_set_replace (set, e, n);else if (next)list_add_tail_rcu (&e->list, &next->list);else if (prev)
@@ -497,6 +501,7 @@ list_set_list(const struct ip_set *set,const struct list_set *map = set->data;struct nlattr *atd, *nested;u32 i =0 , first = cb->args[IPSET_CB_ARG0 ]; +char name[IPSET_MAXNAMELEN ];struct set_elem *e;int ret =0 ;
@@ -515,8 +520,8 @@ list_set_list(const struct ip_set *set, nested =ipset_nest_start (skb,IPSET_ATTR_DATA );if (!nested) goto nla_put_failure; -if (nla_put_string (skb,IPSET_ATTR_NAME , -ip_set_name_byindex (map->net, e->id))) +ip_set_name_byindex (map->net, e->id, name); +if (nla_put_string (skb,IPSET_ATTR_NAME , name)) goto nla_put_failure;if (ip_set_put_extensions (skb, set, e, true)) goto nla_put_failure;
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 3/27 netfilter: ipset: actually allow allowable CIDR 0 in hash:net,port,net
In reply to Sasha LevinFrom: Eric Westbrook <[email protected]>
[ Upstream commit 886503f34d63e681662057448819edb5b1057a97 ]
Allow /0 as advertised for hash:net,port,net sets.
For "hash:net,port,net", ipset(8) says that "either subnet is permitted to be a /0 should you wish to match port between all destinations."
Make that statement true.
Before:
# ipset create cidrzero hash:net,port,net
# ipset add cidrzero 0.0.0.0/0,12345,0.0.0.0/0
ipset v6.34: The value of the CIDR parameter of the IP address is invalid # ipset create cidrzero6 hash:net,port,net family inet6
# ipset add cidrzero6 ::/0,12345,::/0
ipset v6.34: The value of the CIDR parameter of the IP address is invalidAfter:
# ipset create cidrzero hash:net,port,net
# ipset add cidrzero 0.0.0.0/0,12345,0.0.0.0/0
# ipset test cidrzero 192.168.205.129,12345,172.16.205.129
192.168.205.129,tcp:12345,172.16.205.129 is in set cidrzero. # ipset create cidrzero6 hash:net,port,net family inet6
# ipset add cidrzero6 ::/0,12345,::/0
# ipset test cidrzero6 fe80::1,12345,ff00::1
fe80::1,tcp:12345,ff00::1 is in set cidrzero6.See also:
https://bugzilla.kernel.org/show_bug.cgi?id=200897
https://github.com/ewestbrook/linux/commit/df7ff6efb0934ab6acc11f003ff1a7580d6c1d9c
--- net/netfilter/ipset/ip_set_hash_netportnet.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
net/netfilter/ipset/ip_set_hash_netportnet.c +4 -4
@@ -213,13 +213,13 @@ hash_netportnet4_uadt(struct ip_set *set, struct nlattr *tb[],if (tb[IPSET_ATTR_CIDR ]) { e.cidr[0 ] =nla_get_u8 (tb[IPSET_ATTR_CIDR ]); -if (!e.cidr[0 ] || e.cidr[0 ] >HOST_MASK ) +if (e.cidr[0 ] >HOST_MASK )return -IPSET_ERR_INVALID_CIDR ; }if (tb[IPSET_ATTR_CIDR2 ]) { e.cidr[1 ] =nla_get_u8 (tb[IPSET_ATTR_CIDR2 ]); -if (!e.cidr[1 ] || e.cidr[1 ] >HOST_MASK ) +if (e.cidr[1 ] >HOST_MASK )return -IPSET_ERR_INVALID_CIDR ; }
@@ -492,13 +492,13 @@ hash_netportnet6_uadt(struct ip_set *set, struct nlattr *tb[],if (tb[IPSET_ATTR_CIDR ]) { e.cidr[0 ] =nla_get_u8 (tb[IPSET_ATTR_CIDR ]); -if (!e.cidr[0 ] || e.cidr[0 ] >HOST_MASK ) +if (e.cidr[0 ] >HOST_MASK )return -IPSET_ERR_INVALID_CIDR ; }if (tb[IPSET_ATTR_CIDR2 ]) { e.cidr[1 ] =nla_get_u8 (tb[IPSET_ATTR_CIDR2 ]); -if (!e.cidr[1 ] || e.cidr[1 ] >HOST_MASK ) +if (e.cidr[1 ] >HOST_MASK )return -IPSET_ERR_INVALID_CIDR ; }
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 4/27 s390/mm: Fix ERROR: "__node_distance" undefined!
In reply to Sasha LevinFrom: "Justin M. Forbes" <[email protected]>
[ Upstream commit a541f0ebcc08ed8bc0cc492eec9a86cb280a9f24 ]
Fixes:
ERROR: "__node_distance" [drivers/nvme/host/nvme-core.ko] undefined! make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
make: *** [Makefile:1275: modules] Error 2
+ exit 1
--- arch/s390/numa/numa.c | 1 + 1 file changed, 1 insertion(+)
arch/s390/numa/numa.c +1 -0
@@ -54,6 +54,7 @@ int __node_distance(int a, int b) {return mode->distance ? mode->distance (a, b) :0 ; } +EXPORT_SYMBOL (__node_distance);int numa_debug_enabled;
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 5/27 usbnet: smsc95xx: disable carrier check while suspending
In reply to Sasha LevinFrom: Frieder Schrempf <[email protected]>
[ Upstream commit 7b900ead6cc66b2ee873cb042dfba169aa68b56c ]
We need to make sure, that the carrier check polling is disabled while suspending. Otherwise we can end up with usbnet_read_cmd() being issued when only usbnet_read_cmd_nopm() is allowed. If this happens, read operations lock up.
--- drivers/net/usb/smsc95xx.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/net/usb/smsc95xx.c +7 -0
@@ -1598,6 +1598,8 @@ static int smsc95xx_suspend(struct usb_interface *intf, pm_message_t message)return ret; } +cancel_delayed_work_sync (&pdata->carrier_check); +if (pdata->suspend_flags) {netdev_warn (dev->net,"error during last resume\n" ); pdata->suspend_flags =0 ;
@@ -1840,6 +1842,11 @@ static int smsc95xx_suspend(struct usb_interface *intf, pm_message_t message)*/ if (ret &&PMSG_IS_AUTO (message))usbnet_resume (intf); + +if (ret) +schedule_delayed_work (&pdata->carrier_check, +CARRIER_CHECK_DELAY ); +return ret; }
Sasha Levin
maintainerPATCH 6/27 net: dsa: microchip: initialize mutex before use
In reply to Sasha LevinFrom: Tristram Ha <[email protected]>
[ Upstream commit 284fb78ed7572117846f8e1d1d8e3dbfd16880c2 ]
Initialize mutex before use. Avoid kernel complaint when CONFIG_DEBUG_LOCK_ALLOC is enabled.
--- drivers/net/dsa/microchip/ksz_common.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/dsa/microchip/ksz_common.c +5 -5
@@ -1104,11 +1104,6 @@ static int ksz_switch_init(struct ksz_device *dev) {int i; -mutex_init (&dev->reg_mutex); -mutex_init (&dev->stats_mutex); -mutex_init (&dev->alu_mutex); -mutex_init (&dev->vlan_mutex); - dev->ds->ops = &ksz_switch_ops;for (i =0 ; i <ARRAY_SIZE (ksz_switch_chips); i++) {
@@ -1193,6 +1188,11 @@ int ksz_switch_register(struct ksz_device *dev)if (dev->pdata) dev->chip_id = dev->pdata->chip_id; +mutex_init (&dev->reg_mutex); +mutex_init (&dev->stats_mutex); +mutex_init (&dev->alu_mutex); +mutex_init (&dev->vlan_mutex); +if (ksz_switch_detect (dev))return -EINVAL ;
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 7/27 net: systemport: Protect stop from timeout
In reply to Sasha LevinFrom: Florian Fainelli <[email protected]>
[ Upstream commit 7cb6a2a2c72c1ed8f42fb01f1a661281b568dead ]
A timing hazard exists when the network interface is stopped that allows a watchdog timeout to be processed by a separate core in parallel. This creates the potential for the timeout handler to wake the queues while the driver is shutting down, or access registers after their clocks have been removed.
The more common case is that the watchdog timeout will produce a warning message which doesn't lead to a crash. The chances of this are greatly increased by the fact that bcm_sysport_netif_stop stops the transmit queues which can easily precipitate a watchdog time- out because of stale trans_start data in the queues.
This commit corrects the behavior by ensuring that the watchdog timeout is disabled before enterring bcm_sysport_netif_stop. There are currently only two users of the bcm_sysport_netif_stop function:
close and suspend.
The close case already handles the issue by exiting the RUNNING state before invoking the driver close service.
The suspend case now performs the netif_device_detach to exit the PRESENT state before the call to bcm_sysport_netif_stop rather than after it.
These behaviors prevent any future scheduling of the driver timeout service during the window. The netif_tx_stop_all_queues function in bcm_sysport_netif_stop is replaced with netif_tx_disable to ensure synchronization with any transmit or timeout threads that may already be executing on other cores.
For symmetry, the netif_device_attach call upon resume is moved to after the call to bcm_sysport_netif_start. Since it wakes the transmit queues it is not necessary to invoke netif_tx_start_all_queues from bcm_sysport_netif_start so it is moved into the driver open service.
--- drivers/net/ethernet/broadcom/bcmsysport.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
drivers/net/ethernet/broadcom/bcmsysport.c +7 -8
@@ -1774,9 +1774,6 @@ static void bcm_sysport_netif_start(struct net_device *dev)intrl2_1_mask_clear (priv,0xffffffff ); elseintrl2_0_mask_clear (priv ,INTRL2_0_TDMA_MBDONE_MASK ); - -/* Last call before we start the real business */ -netif_tx_start_all_queues (dev); }static void rbuf_init (struct bcm_sysport_priv *priv)
@@ -1922,6 +1919,8 @@ static int bcm_sysport_open(struct net_device *dev)bcm_sysport_netif_start (dev); +netif_tx_start_all_queues (dev); +return 0 ; out_clear_rx_int:
@@ -1945,7 +1944,7 @@ static void bcm_sysport_netif_stop(struct net_device *dev)struct bcm_sysport_priv *priv =netdev_priv (dev);/* stop all software from updating hardware */ -netif_tx_stop_all_queues (dev); +netif_tx_disable (dev);napi_disable (&priv->napi);phy_stop (dev->phydev);
@@ -2267,12 +2266,12 @@ static int bcm_sysport_suspend(struct device *d)if (!netif_running (dev))return 0 ; +netif_device_detach (dev); +bcm_sysport_netif_stop (dev);phy_suspend (dev->phydev); -netif_device_detach (dev); -/* Disable UniMAC RX */ umac_enable_set (priv,CMD_RX_EN ,0 );
@@ -2356,8 +2355,6 @@ static int bcm_sysport_resume(struct device *d) goto out_free_rx_ring; } -netif_device_attach (dev); -/* RX pipe enable */ topctrl_writel (priv,0 ,RX_FLUSH_CNTL );
@@ -2402,6 +2399,8 @@ static int bcm_sysport_resume(struct device *d)bcm_sysport_netif_start (dev); +netif_device_attach (dev); +return 0 ; out_free_rx_ring:
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 8/27 netfilter: ipset: Correct rcu_dereference() call in ip_set_put_comment()
In reply to Sasha LevinFrom: Jozsef Kadlecsik <[email protected]>
[ Upstream commit 17b8b74c0f8dbf9b9e3301f9ca5b65dd1c079951 ]
The function is called when rcu_read_lock() is held and not when rcu_read_lock_bh() is held.
--- include/linux/netfilter/ipset/ip_set_comment.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/netfilter/ipset/ip_set_comment.h +2 -2
@@ -43,11 +43,11 @@ ip_set_init_comment(struct ip_set *set, struct ip_set_comment *comment,rcu_assign_pointer (comment->c, c); } -/* Used only when dumping a set, protected by rcu_read_lock_bh() */ +/* Used only when dumping a set, protected by rcu_read_lock() */ static inline int ip_set_put_comment (struct sk_buff *skb,const struct ip_set_comment *comment) { -struct ip_set_comment_rcu *c =rcu_dereference_bh (comment->c); +struct ip_set_comment_rcu *c =rcu_dereference (comment->c);if (!c)return 0 ;
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 9/27 netfilter: xt_IDLETIMER: add sysfs filename checking routine
In reply to Sasha LevinFrom: Taehee Yoo <[email protected]>
[ Upstream commit 54451f60c8fa061af9051a53be9786393947367c ]
When IDLETIMER rule is added, sysfs file is created under /sys/class/xt_idletimer/timers/
But some label name shouldn't be used.
".", "..", "power", "uevent", "subsystem", etc... So that sysfs filename checking routine is needed.
test commands:
%iptables -I INPUT -j IDLETIMER --timeout 1 --label "power"
splat looks like:
[95765.423132] sysfs: cannot create duplicate filename '/devices/virtual/xt_idletimer/timers/power' [95765.433418] CPU: 0 PID: 8446 Comm: iptables Not tainted 4.19.0-rc6+ #20 [95765.449755] Call Trace: [95765.449755] dump_stack+0xc9/0x16b [95765.449755] ? show_regs_print_info+0x5/0x5 [95765.449755] sysfs_warn_dup+0x74/0x90 [95765.449755] sysfs_add_file_mode_ns+0x352/0x500 [95765.449755] sysfs_create_file_ns+0x179/0x270 [95765.449755] ? sysfs_add_file_mode_ns+0x500/0x500 [95765.449755] ? idletimer_tg_checkentry+0x3e5/0xb1b [xt_IDLETIMER] [95765.449755] ? rcu_read_lock_sched_held+0x114/0x130 [95765.449755] ? __kmalloc_track_caller+0x211/0x2b0 [95765.449755] ? memcpy+0x34/0x50 [95765.449755] idletimer_tg_checkentry+0x4e2/0xb1b [xt_IDLETIMER]
[ ... ]
--- net/netfilter/xt_IDLETIMER.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
net/netfilter/xt_IDLETIMER.c +20 -0
@@ -116,6 +116,22 @@ static void idletimer_tg_expired(unsigned long data)schedule_work (&timer->work); } +static int idletimer_check_sysfs_name (const char *name,unsigned int size) +{ +int ret; + + ret =xt_check_proc_name (name, size); +if (ret <0 ) +return ret; + +if (!strcmp (name,"power" ) || + !strcmp (name,"subsystem" ) || + !strcmp (name,"uevent" )) +return -EINVAL ; + +return 0 ; +} +static int idletimer_tg_create (struct idletimer_tg_info *info) {int ret;
@@ -126,6 +142,10 @@ static int idletimer_tg_create(struct idletimer_tg_info *info) goto out; } + ret =idletimer_check_sysfs_name (info->label,sizeof (info->label)); +if (ret <0 ) + goto out_free_timer; +sysfs_attr_init (&info->timer->attr.attr); info->timer->attr.attr.name =kstrdup (info->label,GFP_KERNEL );if (!info->timer->attr.attr.name) {
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 10/27 s390/qeth: fix HiperSockets sniffer
In reply to Sasha LevinFrom: Julian Wiedmann <[email protected]>
[ Upstream commit bd74a7f9cc033cf4d405788f80292268987dc0c5 ]
Sniffing mode for L3 HiperSockets requires that no IP addresses are registered with the HW. The preferred way to achieve this is for userspace to delete all the IPs on the interface. But qeth is expected to also tolerate a configuration where that is not the case, by skipping the IP registration when in sniffer mode.
Since commit 5f78e29ceebf ("qeth: optimize IP handling in rx_mode callback") reworked the IP registration logic in the L3 subdriver, this no longer works. When the qeth device is set online, qeth_l3_recover_ip() now unconditionally registers all unicast addresses from our internal IP table.
While we could fix this particular problem by skipping qeth_l3_recover_ip() on a sniffer device, the more future-proof change is to skip the IP address registration at the lowest level. This way we
a) catch any future code path that attempts to register an IP address without considering the sniffer scenario, and
b) continue to build up our internal IP table, so that if sniffer mode is switched off later we can operate just like normal.
--- drivers/s390/net/qeth_l3_main.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/s390/net/qeth_l3_main.c +5 -3
@@ -358,9 +358,6 @@ static void qeth_l3_clear_ip_htable(struct qeth_card *card, int recover)QETH_CARD_TEXT (card,4 ,"clearip" ); -if (recover && card->options.sniffer) -return ; -spin_lock_bh (&card->ip_lock);hash_for_each_safe (card->ip_htable, i, tmp, addr, hnode) {
@@ -818,6 +815,8 @@ static int qeth_l3_register_addr_entry(struct qeth_card *card,int rc =0 ;int cnt =3 ; +if (card->options.sniffer) +return 0 ;if (addr->proto ==QETH_PROT_IPV4 ) {QETH_CARD_TEXT (card,2 ,"setaddr4" );
@@ -853,6 +852,9 @@ static int qeth_l3_deregister_addr_entry(struct qeth_card *card, {int rc =0 ; +if (card->options.sniffer) +return 0 ; +if (addr->proto ==QETH_PROT_IPV4 ) {QETH_CARD_TEXT (card,2 ,"deladdr4" );QETH_CARD_HEX (card,3 , &addr->u.a4.addr,sizeof (int ));
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 11/27 mlxsw: spectrum: Fix IP2ME CPU policer configuration
In reply to Sasha LevinFrom: Shalom Toledo <[email protected]>
[ Upstream commit 96801552f846460fe9ac10f1b189602992f004e1 ]
The CPU policer used to police packets being trapped via a local route (IP2ME) was incorrectly configured to police based on bytes per second instead of packets per second.
Change the policer to police based on packets per second and avoid packet loss under certain circumstances.
--- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/ethernet/mellanox/mlxsw/spectrum.c +0 -1
@@ -3471,7 +3471,6 @@ static int mlxsw_sp_cpu_policers_set(struct mlxsw_core *mlxsw_core) burst_size =7 ;break ;case MLXSW_REG_HTGT_TRAP_GROUP_SP_IP2ME : - is_bytes = true; rate =4 *1024 ; burst_size =4 ;break ;
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 12/27 hwmon: (ibmpowernv) Remove bogus __init annotations
In reply to Sasha LevinFrom: Geert Uytterhoeven <[email protected]>
[ Upstream commit e3e61f01d755188cb6c2dcf5a244b9c0937c258e ]
If gcc decides not to inline make_sensor_label():
WARNING: vmlinux.o(.text+0x4df549c): Section mismatch in reference from the function .create_device_attrs() to the function .init.text:.make_sensor_label() The function .create_device_attrs() references
the function __init .make_sensor_label().
This is often because .create_device_attrs lacks a __init
annotation or the annotation of .make_sensor_label is wrong.
As .probe() can be called after freeing of __init memory, all __init annotiations in the driver are bogus, and should be removed.
--- drivers/hwmon/ibmpowernv.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/hwmon/ibmpowernv.c +3 -4
@@ -126,7 +126,7 @@ static ssize_t show_label(struct device *dev, struct device_attribute *devattr,return sprintf (buf,"%s\n" , sdata->label); } -static int __init get_logical_cpu (int hwcpu) +static int get_logical_cpu (int hwcpu) {int cpu;
@@ -137,9 +137,8 @@ static int __init get_logical_cpu(int hwcpu)return -ENOENT ; } -static void __init make_sensor_label (struct device_node *np, -struct sensor_data *sdata, -const char *label) +static void make_sensor_label (struct device_node *np, +struct sensor_data *sdata,const char *label) {u32 id;size_t n;
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 13/27 Revert "drm/exynos/decon5433: implement frame counter"
In reply to Sasha LevinFrom: Inki Dae <[email protected]>
[ Upstream commit 6ca469e22a30992b4478d2ab88737c70667c1e00 ]
This reverts commit 0586feba322e1de05075700eb4b835c8b683e62b
This patch makes it to need get_vblank_counter callback in crtc to get frame counter from decon driver.
However, drm_dev->max_vblank_count is a member unique to vendor's DRM driver but in case of ARM DRM, some CRTC devices don't provide the frame counter value. As a result, this patch made extension and clone mode not working.
Instead of this patch, we may need separated max_vblank_count which belongs to each CRTC device, or need to implement frame counter emulation for them who don't support HW frame counter.
--- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 9 --------- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 11 ----------- drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 - 3 files changed, 21 deletions(-)
drivers/gpu/drm/exynos/exynos5433_drm_decon.c +0 -9
@@ -160,13 +160,6 @@ static u32 decon_get_frame_count(struct decon_context *ctx, bool end)return frm; } -static u32 decon_get_vblank_counter (struct exynos_drm_crtc *crtc) -{ -struct decon_context *ctx = crtc->ctx; - -return decon_get_frame_count (ctx, false); -} -static void decon_setup_trigger (struct decon_context *ctx) {if (!ctx->crtc->i80_mode && !(ctx->out_type &I80_HW_TRG ))
@@ -532,7 +525,6 @@ static const struct exynos_drm_crtc_ops decon_crtc_ops = { .disable = decon_disable, .enable_vblank = decon_enable_vblank, .disable_vblank = decon_disable_vblank, - .get_vblank_counter = decon_get_vblank_counter, .atomic_begin = decon_atomic_begin, .update_plane = decon_update_plane, .disable_plane = decon_disable_plane,
@@ -550,7 +542,6 @@ static int decon_bind(struct device *dev, struct device *master, void *data)int ret; ctx->drm_dev = drm_dev; - drm_dev->max_vblank_count =0xffffffff ;for (win = ctx->first_win; win <WINDOWS_NR ; win++) {int tmp = (win == ctx->first_win) ?0 : win;
drivers/gpu/drm/exynos/exynos_drm_crtc.c +0 -11
@@ -147,16 +147,6 @@ static void exynos_drm_crtc_disable_vblank(struct drm_crtc *crtc) exynos_crtc->ops->disable_vblank (exynos_crtc); } -static u32 exynos_drm_crtc_get_vblank_counter (struct drm_crtc *crtc) -{ -struct exynos_drm_crtc *exynos_crtc =to_exynos_crtc (crtc); - -if (exynos_crtc->ops->get_vblank_counter) -return exynos_crtc->ops->get_vblank_counter (exynos_crtc); - -return 0 ; -} -static const struct drm_crtc_funcs exynos_crtc_funcs = { .set_config = drm_atomic_helper_set_config, .page_flip = drm_atomic_helper_page_flip,
@@ -166,7 +156,6 @@ static const struct drm_crtc_funcs exynos_crtc_funcs = { .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state, .enable_vblank = exynos_drm_crtc_enable_vblank, .disable_vblank = exynos_drm_crtc_disable_vblank, - .get_vblank_counter = exynos_drm_crtc_get_vblank_counter, }; struct exynos_drm_crtc *exynos_drm_crtc_create(struct drm_device *drm_dev,
drivers/gpu/drm/exynos/exynos_drm_drv.h +0 -1
@@ -133,7 +133,6 @@ struct exynos_drm_crtc_ops {void (*disable)(struct exynos_drm_crtc *crtc);int (*enable_vblank)(struct exynos_drm_crtc *crtc);void (*disable_vblank)(struct exynos_drm_crtc *crtc); -u32 (*get_vblank_counter)(struct exynos_drm_crtc *crtc);enum drm_mode_status (*mode_valid)(struct exynos_drm_crtc *crtc,const struct drm_display_mode *mode); int (*atomic_check)(struct exynos_drm_crtc *crtc,
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 14/27 clk: fixed-factor: fix of_node_get-put imbalance
In reply to Sasha LevinFrom: Ricardo Ribalda Delgado <[email protected]>
[ Upstream commit f98e8a572bddbf27032114127d2fcc78fa5e6a9d ]
When the fixed factor clock is created by devicetree, of_clk_add_provider is called. Add a call to of_clk_del_provider in the remove function to balance it out.
--- drivers/clk/clk-fixed-factor.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/clk-fixed-factor.c +1 -0
@@ -210,6 +210,7 @@ static int of_fixed_factor_clk_remove(struct platform_device *pdev) {struct clk *clk =platform_get_drvdata (pdev); +of_clk_del_provider (pdev->dev.of_node);clk_unregister_fixed_factor (clk);return 0 ;
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 15/27 lib/raid6: Fix arm64 test build
In reply to Sasha LevinFrom: Jeremy Linton <[email protected]>
[ Upstream commit 313a06e636808387822af24c507cba92703568b1 ]
The lib/raid6/test fails to build the neon objects on arm64 because the correct machine type is 'aarch64'.
Once this is correctly enabled, the neon recovery objects need to be added to the build.
--- lib/raid6/test/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/raid6/test/Makefile +2 -2
@@ -27,7 +27,7 @@ ifeq ($(ARCH),arm) CFLAGS += -I../../../arch/arm/include -mfpu=neon HAS_NEON = yes endif -ifeq ($(ARCH),arm64) +ifeq ($(ARCH),aarch64) CFLAGS += -I../../../arch/arm64/include HAS_NEON = yes endif
@@ -41,7 +41,7 @@ ifeq ($(IS_X86),yes) gcc -c -x assembler - >&/dev/null && \ rm ./-.o && echo -DCONFIG_AS_AVX512=1) else ifeq ($(HAS_NEON),yes) - OBJS += neon.o neon1.o neon2.o neon4.o neon8.o + OBJS += neon.o neon1.o neon2.o neon4.o neon8.o recov_neon.o recov_neon_inner.o CFLAGS += -DCONFIG_KERNEL_MODE_NEON=1 else HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector int a;\n' |\
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 16/27 s390/perf: Change CPUM_CF return code in event init function
In reply to Sasha LevinFrom: Thomas Richter <[email protected]>
[ Upstream commit 0bb2ae1b26e1fb7543ec7474cdd374ac4b88c4da ]
The function perf_init_event() creates a new event and assignes it to a PMU. This a done in a loop over all existing PMUs. For each listed PMU the event init function is called and if this function does return any other error than -ENOENT, the loop is terminated the creation of the event fails.
If the event is invalid, return -ENOENT to try other PMUs.
--- arch/s390/kernel/perf_cpum_cf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kernel/perf_cpum_cf.c +1 -1
@@ -376,7 +376,7 @@ static int __hw_perf_event_init(struct perf_event *event)return -ENOENT ;if (ev >PERF_CPUM_CF_MAX_CTR ) -return -EINVAL ; +return -ENOENT ;/* Obtain the counter set to which the specified counter belongs */ set =get_counter_set (ev);
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 17/27 i2c: omap: Enable for ARCH_K3
In reply to Sasha LevinFrom: Vignesh R <[email protected]>
[ Upstream commit 5b277402deac0691226a947df71c581686bd4020 ]
Allow I2C_OMAP to be built for K3 platforms.
--- drivers/i2c/busses/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +1 -1
@@ -759,7 +759,7 @@ config I2C_OCORES config I2C_OMAP tristate "OMAP I2C adapter" - depends on ARCH_OMAP + depends on ARCH_OMAP || ARCH_K3 default y if MACH_OMAP_H3 || MACH_OMAP_OSK help If you say yes to this option, support will be included for the
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 18/27 sched/core: Take the hotplug lock in sched_init_smp()
In reply to Sasha LevinFrom: Valentin Schneider <[email protected]>
[ Upstream commit 40fa3780bac2b654edf23f6b13f4e2dd550aea10 ]
When running on linux-next (8c60c36d0b8c ("Add linux-next specific files for 20181019")) + CONFIG_PROVE_LOCKING=y on a big.LITTLE system (e.g. Juno or HiKey960), we get the following report:
[ 0.748225] Call trace: [ 0.750685] lockdep_assert_cpus_held+0x30/0x40 [ 0.755236] static_key_enable_cpuslocked+0x20/0xc8 [ 0.760137] build_sched_domains+0x1034/0x1108 [ 0.764601] sched_init_domains+0x68/0x90 [ 0.768628] sched_init_smp+0x30/0x80 [ 0.772309] kernel_init_freeable+0x278/0x51c [ 0.776685] kernel_init+0x10/0x108 [ 0.780190] ret_from_fork+0x10/0x18
The static_key in question is 'sched_asym_cpucapacity' introduced by commit:
df054e8445a4 ("sched/topology: Add static_key for asymmetric CPU capacity optimizations")
In this particular case, we enable it because smp_prepare_cpus() will end up fetching the capacity-dmips-mhz entry from the devicetree, so we already have some asymmetry detected when entering sched_init_smp().
This didn't get detected in tip/sched/core because we were missing:
commit cb538267ea1e ("jump_label/lockdep: Assert we hold the hotplug lock for _cpuslocked() operations")
Calls to build_sched_domains() post sched_init_smp() will hold the hotplug lock, it just so happens that this very first call is a special case. As stated by a comment in sched_init_smp(), "There's no userspace yet to cause hotplug operations" so this is a harmless warning.
However, to both respect the semantics of underlying callees and make lockdep happy, take the hotplug lock in sched_init_smp(). This also satisfies the comment atop sched_init_domains() that says "Callers must hold the hotplug lock".
--- kernel/sched/core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
kernel/sched/core.c +4 -1
@@ -5733,14 +5733,17 @@ void __init sched_init_smp(void)/* * There's no userspace yet to cause hotplug operations; hence all the * CPU masks are stable and all blatant races in the below code cannot -* happen. +* happen. The hotplug lock is nevertheless taken to satisfy lockdep, +* but there won't be any contention on it. */ +cpus_read_lock ();mutex_lock (&sched_domains_mutex);sched_init_domains (cpu_active_mask);cpumask_andnot (non_isolated_cpus, cpu_possible_mask, cpu_isolated_map);if (cpumask_empty (non_isolated_cpus))cpumask_set_cpu (smp_processor_id (), non_isolated_cpus);mutex_unlock (&sched_domains_mutex); +cpus_read_unlock ();/* Move init over to a non-isolated CPU */ if (set_cpus_allowed_ptr (current, non_isolated_cpus) <0 )
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 19/27 perf tools: Fix undefined symbol scnprintf in libperf-jvmti.so
In reply to Sasha LevinFrom: Gustavo Romero <[email protected]>
[ Upstream commit 6ac2226229d931153331a93d90655a3de05b9290 ]
Currently jvmti agent can not be used because function scnprintf is not present in the agent libperf-jvmti.so. As a result the JVM when using such agent to record JITed code profiling information will fail on looking up scnprintf:
java: symbol lookup error: lib/libperf-jvmti.so: undefined symbol: scnprintf
This commit fixes that by reverting to the use of snprintf, that can be looked up, instead of scnprintf, adding a proper check for the returned value in order to print a better error message when the jitdump file pathname is too long. Checking the returned value also helps to comply with some recent gcc versions, like gcc8, which will fail due to truncated writing checks related to the -Werror=format-truncation= flag.
LPU-Reference: [email protected]
--- tools/perf/jvmti/jvmti_agent.c | 49 ++++++++++++++++++++++++++-------- 1 file changed, 38 insertions(+), 11 deletions(-)
tools/perf/jvmti/jvmti_agent.c +38 -11
@@ -125,7 +125,7 @@ perf_get_timestamp(void) }static int -debug_cache_init (void ) +create_jit_cache_dir (void ) {char str[32 ];char *base, *p;
@@ -144,8 +144,13 @@ debug_cache_init(void)strftime (str,sizeof (str),JIT_LANG "-jit-%Y%m%d" , &tm); -snprintf (jit_path,PATH_MAX -1 ,"%s/.debug/" , base); - + ret =snprintf (jit_path,PATH_MAX ,"%s/.debug/" , base); +if (ret >=PATH_MAX ) { +warnx ("jvmti: cannot generate jit cache dir because %s/.debug/" +" is too long, please check the cwd, JITDUMPDIR, and" +" HOME variables" , base); +return -1 ; + } ret =mkdir (jit_path,0755 );if (ret ==-1 ) {if (errno !=EEXIST ) {
@@ -154,20 +159,32 @@ debug_cache_init(void) } } -snprintf (jit_path,PATH_MAX -1 ,"%s/.debug/jit" , base); + ret =snprintf (jit_path,PATH_MAX ,"%s/.debug/jit" , base); +if (ret >=PATH_MAX ) { +warnx ("jvmti: cannot generate jit cache dir because" +" %s/.debug/jit is too long, please check the cwd," +" JITDUMPDIR, and HOME variables" , base); +return -1 ; + } ret =mkdir (jit_path,0755 );if (ret ==-1 ) {if (errno !=EEXIST ) { -warn ("cannot create jit cache dir %s" , jit_path); +warn ("jvmti: cannot create jit cache dir %s" , jit_path);return -1 ; } } -snprintf (jit_path,PATH_MAX -1 ,"%s/.debug/jit/%s.XXXXXXXX" , base, str); - + ret =snprintf (jit_path,PATH_MAX ,"%s/.debug/jit/%s.XXXXXXXX" , base, str); +if (ret >=PATH_MAX ) { +warnx ("jvmti: cannot generate jit cache dir because" +" %s/.debug/jit/%s.XXXXXXXX is too long, please check" +" the cwd, JITDUMPDIR, and HOME variables" , + base, str); +return -1 ; + } p =mkdtemp (jit_path);if (p != jit_path) { -warn ("cannot create jit cache dir %s" , jit_path); +warn ("jvmti: cannot create jit cache dir %s" , jit_path);return -1 ; }
@@ -228,7 +245,7 @@ void *jvmti_open(void) {char dump_path[PATH_MAX ];struct jitheader header; -int fd; +int fd, ret;FILE *fp;init_arch_timestamp ();
@@ -245,12 +262,22 @@ void *jvmti_open(void)memset (&header,0 ,sizeof (header)); -debug_cache_init (); +/* +* jitdump file dir +*/ +if (create_jit_cache_dir () <0 ) +return NULL ;/* * jitdump file name */ -scnprintf (dump_path,PATH_MAX ,"%s/jit-%i.dump" , jit_path,getpid ()); + ret =snprintf (dump_path,PATH_MAX ,"%s/jit-%i.dump" , jit_path,getpid ()); +if (ret >=PATH_MAX ) { +warnx ("jvmti: cannot generate jitdump file full path because" +" %s/jit-%i.dump is too long, please check the cwd," +" JITDUMPDIR, and HOME variables" , jit_path,getpid ()); +return NULL ; + } fd =open (dump_path,O_CREAT |O_TRUNC |O_RDWR ,0666 );if (fd ==-1 )
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 20/27 i40e: restore NETIF_F_GSO_IPXIP[46] to netdev features
In reply to Sasha LevinFrom: Jacob Keller <[email protected]>
[ Upstream commit ba766b8b99c30ad3c55ed8cf224d1185ecff1476 ]
Since commit bacd75cfac8a ("i40e/i40evf: Add capability exchange for outer checksum", 2017-04-06) the i40e driver has not reported support for IP-in-IP offloads. This likely occurred due to a bad rebase, as the commit extracts hw_enc_features into its own variable. As part of this change, it dropped the NETIF_F_FSO_IPXIP flags from the netdev->hw_enc_features. This was unfortunately not caught during code review.
Fix this by adding back the missing feature flags.
For reference, NETIF_F_GSO_IPXIP4 was added in commit 7e13318daa4a ("net: define gso types for IPx over IPv4 and IPv6", 2016-05-20), replacing NETIF_F_GSO_IPIP and NETIF_F_GSO_SIT.
NETIF_F_GSO_IPXIP6 was added in commit bf2d1df39502 ("intel: Add support for IPv6 IP-in-IP offload", 2016-05-20).
--- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_main.c +2 -0
@@ -9688,6 +9688,8 @@ static int i40e_config_netdev(struct i40e_vsi *vsi)NETIF_F_GSO_GRE |NETIF_F_GSO_GRE_CSUM |NETIF_F_GSO_PARTIAL | +NETIF_F_GSO_IPXIP4 | +NETIF_F_GSO_IPXIP6 |NETIF_F_GSO_UDP_TUNNEL |NETIF_F_GSO_UDP_TUNNEL_CSUM | NETIF_F_SCTP_CRC |
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 21/27 ibmvnic: fix accelerated VLAN handling
In reply to Sasha LevinFrom: Michał Mirosław <[email protected]>
[ Upstream commit e84b47941e15e6666afb8ee8b21d1c3fc1a013af ]
Don't request tag insertion when it isn't present in outgoing skb.
--- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/ibm/ibmvnic.c +1 -1
@@ -1259,7 +1259,7 @@ static int ibmvnic_xmit(struct sk_buff *skb, struct net_device *netdev) tx_crq.v1.sge_len =cpu_to_be32 (skb->len); tx_crq.v1.ioba =cpu_to_be64 (data_dma_addr); -if (adapter->vlan_header_insertion) { +if (adapter->vlan_header_insertion &&skb_vlan_tag_present (skb)) { tx_crq.v1.flags2 |=IBMVNIC_TX_VLAN_INSERT ; tx_crq.v1.vlan_id =cpu_to_be16 (skb->vlan_tci); }
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 22/27 qed: Fix memory/entry leak in qed_init_sp_request()
In reply to Sasha LevinFrom: Denis Bolotin <[email protected]>
[ Upstream commit 39477551df940ddb1339203817de04f5caaacf7a ]
Free the allocated SPQ entry or return the acquired SPQ entry to the free list in error flows.
--- .../net/ethernet/qlogic/qed/qed_sp_commands.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/net/ethernet/qlogic/qed/qed_sp_commands.c +14 -2
@@ -80,7 +80,7 @@ int qed_sp_init_request(struct qed_hwfn *p_hwfn,case QED_SPQ_MODE_BLOCK :if (!p_data->p_comp_data) -return -EINVAL ; + goto err; p_ent->comp_cb.cookie = p_data->p_comp_data->cookie;break ;
@@ -95,7 +95,7 @@ int qed_sp_init_request(struct qed_hwfn *p_hwfn,default :DP_NOTICE (p_hwfn,"Unknown SPQE completion mode %d\n" , p_ent->comp_mode); -return -EINVAL ; + goto err; } DP_VERBOSE(p_hwfn, QED_MSG_SPQ,
@@ -109,6 +109,18 @@ int qed_sp_init_request(struct qed_hwfn *p_hwfn,memset (&p_ent->ramrod,0 ,sizeof (p_ent->ramrod));return 0 ; + +err: +/* qed_spq_get_entry() can either get an entry from the free_pool, +* or, if no entries are left, allocate a new entry and add it to +* the unlimited_pending list. +*/ +if (p_ent->queue == &p_hwfn->p_spq->unlimited_pending) +kfree (p_ent); +else +qed_spq_return_entry (p_hwfn, p_ent); + +return -EINVAL ; }static enum tunnel_clss qed_tunn_clss_to_fw_clss (u8 type)
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 23/27 qed: Fix blocking/unlimited SPQ entries leak
In reply to Sasha LevinFrom: Denis Bolotin <[email protected]>
[ Upstream commit 2632f22ebd08da249c2017962a199a0cfb2324bf ]
When there are no SPQ entries left in the free_pool, new entries are allocated and are added to the unlimited list. When an entry in the pool is available, the content is copied from the original entry, and the new entry is sent to the device. qed_spq_post() is not aware of that, so the additional entry is stored in the original entry as p_post_ent, which can later be returned to the pool.
--- drivers/net/ethernet/qlogic/qed/qed_sp.h | 3 ++ drivers/net/ethernet/qlogic/qed/qed_spq.c | 57 ++++++++++++----------- 2 files changed, 33 insertions(+), 27 deletions(-)
drivers/net/ethernet/qlogic/qed/qed_sp.h +3 -0
@@ -167,6 +167,9 @@ struct qed_spq_entry {enum spq_mode comp_mode;struct qed_spq_comp_cb comp_cb;struct qed_spq_comp_done comp_done;/* SPQ_MODE_EBLOCK */ + +/* Posted entry for unlimited list entry in EBLOCK mode */ +struct qed_spq_entry *post_ent; };struct qed_eq {
drivers/net/ethernet/qlogic/qed/qed_spq.c +30 -27
96 lines not on this page · raw message
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 24/27 qed: Fix potential memory corruption
In reply to Sasha LevinFrom: Sagiv Ozeri <[email protected]>
[ Upstream commit fa5c448d98f0df660bfcad3dd5facc027ef84cd3 ]
A stuck ramrod should be deleted from the completion_pending list, otherwise it will be added again in the future and corrupt the list.
Return error value to inform that ramrod is stuck and should be deleted.
--- drivers/net/ethernet/qlogic/qed/qed_spq.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/net/ethernet/qlogic/qed/qed_spq.c +5 -7
@@ -144,6 +144,7 @@ static int qed_spq_block(struct qed_hwfn *p_hwfn,DP_INFO (p_hwfn,"Ramrod is stuck, requesting MCP drain\n" ); rc =qed_mcp_drain (p_hwfn, p_ptt); +qed_ptt_release (p_hwfn, p_ptt);if (rc) {DP_NOTICE (p_hwfn,"MCP drain failed\n" ); goto err;
@@ -152,18 +153,15 @@ static int qed_spq_block(struct qed_hwfn *p_hwfn,/* Retry after drain */ rc =__qed_spq_block (p_hwfn, p_ent, p_fw_ret, true);if (!rc) - goto out; +return 0 ; comp_done = (struct qed_spq_comp_done *)p_ent->comp_cb.cookie; -if (comp_done->done ==1 ) +if (comp_done->done ==1 ) {if (p_fw_ret) *p_fw_ret = comp_done->fw_return_code; -out: -qed_ptt_release (p_hwfn, p_ptt); -return 0 ; - +return 0 ; + } err: -qed_ptt_release (p_hwfn, p_ptt); DP_NOTICE(p_hwfn, "Ramrod is stuck [CID %08x cmd %02x protocol %02x echo %04x]\n", le32_to_cpu(p_ent->elem.hdr.cid),
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 25/27 net: stmmac: Fix RX packet size > 8191
In reply to Sasha LevinFrom: Thor Thayer <[email protected]>
[ Upstream commit 8137b6ef0ce469154e5cf19f8e7fe04d9a72ac5e ]
Ping problems with packets > 8191 as shown:
PING 192.168.1.99 (192.168.1.99) 8150(8178) bytes of data. 8158 bytes from 192.168.1.99: icmp_seq=1 ttl=64 time=0.669 ms wrong data byte 8144 should be 0xd0 but was 0x0
16 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f
20 21 22 23 24 25 26 27 28 29 2a 2b 2c 2d 2e 2f
%< ---------------snip-------------------------------------- 8112 b0 b1 b2 b3 b4 b5 b6 b7 b8 b9 ba bb bc bd be bf
c0 c1 c2 c3 c4 c5 c6 c7 c8 c9 ca cb cc cd ce cf
8144 0 0 0 0 d0 d1
^^^^^^^
Notice the 4 bytes of 0 before the expected byte of d0.
Databook notes that the RX buffer must be a multiple of 4/8/16 bytes [1].
Update the DMA Buffer size define to 8188 instead of 8192. Remove the -1 from the RX buffer size allocations and use the new DMA Buffer size directly.
[1] Synopsys DesignWare Cores Ethernet MAC Universal v3.70a
[section 8.4.2 - Table 8-24]
Tested on SoCFPGA Stratix10 with ping sweep from 100 to 8300 byte packets.
--- drivers/net/ethernet/stmicro/stmmac/common.h | 3 ++- drivers/net/ethernet/stmicro/stmmac/descs_com.h | 2 +- drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 2 +- drivers/net/ethernet/stmicro/stmmac/ring_mode.c | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-)
drivers/net/ethernet/stmicro/stmmac/common.h +2 -1
@@ -340,7 +340,8 @@ struct dma_features {/* GMAC TX FIFO is 8K, Rx FIFO is 16K */ #define BUF_SIZE_16KiB 16384 -#define BUF_SIZE_8KiB 8192 +/* RX Buffer size must be < 8191 and multiple of 4/8/16 bytes */ +#define BUF_SIZE_8KiB 8188#define BUF_SIZE_4KiB 4096#define BUF_SIZE_2KiB 2048
drivers/net/ethernet/stmicro/stmmac/descs_com.h +1 -1
@@ -31,7 +31,7 @@/* Enhanced descriptors */ static inline void ehn_desc_rx_set_on_ring (struct dma_desc *p,int end) { - p->des1 |=cpu_to_le32 (((BUF_SIZE_8KiB -1 ) + p->des1 |=cpu_to_le32 ((BUF_SIZE_8KiB <<ERDES1_BUFFER2_SIZE_SHIFT ) &ERDES1_BUFFER2_SIZE_MASK );
drivers/net/ethernet/stmicro/stmmac/enh_desc.c +1 -1
@@ -262,7 +262,7 @@ static void enh_desc_init_rx_desc(struct dma_desc *p, int disable_rx_ic, int mode, int end) { p->des0 |=cpu_to_le32 (RDES0_OWN ); - p->des1 |=cpu_to_le32 ((BUF_SIZE_8KiB -1 ) &ERDES1_BUFFER1_SIZE_MASK ); + p->des1 |=cpu_to_le32 (BUF_SIZE_8KiB &ERDES1_BUFFER1_SIZE_MASK );if (mode ==STMMAC_CHAIN_MODE )ehn_desc_rx_set_on_chain (p);
drivers/net/ethernet/stmicro/stmmac/ring_mode.c +1 -1
@@ -143,7 +143,7 @@ static void stmmac_clean_desc3(void *priv_ptr, struct dma_desc *p)static int stmmac_set_16kib_bfsize (int mtu) {int ret =0 ; -if (unlikely (mtu >= BUF_SIZE_8KiB)) +if (unlikely (mtu > BUF_SIZE_8KiB)) ret = BUF_SIZE_16KiB;return ret; }
Signature · 1 line
2.17.1
Sasha Levin
maintainerPATCH 26/27 net: smsc95xx: Fix MTU range
In reply to Sasha LevinFrom: Stefan Wahren <[email protected]>
[ Upstream commit 85b18b0237ce9986a81a1b9534b5e2ee116f5504 ]
The commit f77f0aee4da4 ("net: use core MTU range checking in USB NIC drivers") introduce a common MTU handling for usbnet. But it's missing the necessary changes for smsc95xx. So set the MTU range accordingly.
This patch has been tested on a Raspberry Pi 3.
--- drivers/net/usb/smsc95xx.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/usb/smsc95xx.c +2 -0
@@ -1321,6 +1321,8 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf) dev->net->ethtool_ops = &smsc95xx_ethtool_ops; dev->net->flags |=IFF_MULTICAST ; dev->net->hard_header_len +=SMSC95XX_TX_OVERHEAD_CSUM ; + dev->net->min_mtu =ETH_MIN_MTU ; + dev->net->max_mtu =ETH_DATA_LEN ; dev->hard_mtu = dev->net->mtu + dev->net->hard_header_len; pdata->dev = dev;
Sasha Levin
maintainerPATCH 27/27 ext4: missing !bh check in ext4_xattr_inode_write()
In reply to Sasha LevinFrom: Vasily Averin <[email protected]>
[ Upstream commit eb6984fa4ce2837dcb1f66720a600f31b0bb3739 ]
According to Ted Ts'o ext4_getblk() called in ext4_xattr_inode_write() should not return bh = NULL
The only time that bh could be NULL, then, would be in the case of something really going wrong; a programming error elsewhere (perhaps a wild pointer dereference) or I/O error causing on-disk file system corruption (although that would be highly unlikely given that we had *just* allocated the blocks and so the metadata blocks in question probably would still be in the cache).
--- fs/ext4/xattr.c | 6 ++++++ 1 file changed, 6 insertions(+)
fs/ext4/xattr.c +6 -0
@@ -1387,6 +1387,12 @@ static int ext4_xattr_inode_write(handle_t *handle, struct inode *ea_inode, bh =ext4_getblk (handle, ea_inode, block,0 );if (IS_ERR (bh))return PTR_ERR (bh); +if (!bh) { +WARN_ON_ONCE (1 ); +EXT4_ERROR_INODE (ea_inode, +"ext4_getblk() return bh = NULL" ); +return -EFSCORRUPTED ; + } ret =ext4_journal_get_write_access (handle, bh);if (ret) goto out;
Signature · 1 line
2.17.1