Skip to contentSkip to conversation

xfs: make xfs_file_remap_range() static

PATCH In review Eric Biggers 3 participants 3 messages Nov 15, 2018 – Nov 16, 2018 XFS filesystem

lore
Share & tools
lore

Eric Biggers

author
#0 lore raw

PATCH 1/1 xfs: make xfs_file_remap_range() static

From: Eric Biggers <[email protected]>

xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it static.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

Signed-off-by Eric Biggers <[email protected]>
---
 fs/xfs/xfs_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_file.c +1 -1
index 53c9ab8fb777f..e47425071e654 100644
@@ -920,7 +920,7 @@ xfs_file_fallocate(
 }
 
 
-loff_t
+STATIC loff_t
 xfs_file_remap_range(
 	struct file		*file_in,
 	loff_t			pos_in,
Signature · 1 line
2.19.1.930.g4563a0d9d0-goog
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Eric Biggers

From: Eric Biggers <[email protected]>

xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it static.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

Signed-off-by Eric Biggers <[email protected]>

Looks ok,

Reviewed-by Darrick J. Wong <[email protected]>

--D

Quoted 20 lines
---
 fs/xfs/xfs_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_file.c +1 -1
index 53c9ab8fb777f..e47425071e654 100644
@@ -920,7 +920,7 @@ xfs_file_fallocate(
 }
 
 
-loff_t
+STATIC loff_t
 xfs_file_remap_range(
 	struct file		*file_in,
 	loff_t			pos_in,
Signature · 1 line
2.19.1.930.g4563a0d9d0-goog
Reviewed-by on v1 1/1
#2 lore raw
In reply to Eric Biggers
Quoted 18 lines · Eric Biggers

From: Eric Biggers <[email protected]>

xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it static.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

Signed-off-by Eric Biggers <[email protected]>
---
  fs/xfs/xfs_file.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_file.c +0 -0
index 53c9ab8fb777f..e47425071e654 100644

fs/xfs/xfs_file.c xfs_file_fallocate( · line 926

Quoted 8 lines
fs/xfs/xfs_file.c +1 -1
@@ -920,7 +920,7 @@ xfs_file_fallocate(
  }
 
 
-loff_t
+STATIC loff_t
  xfs_file_remap_range(
  	struct file		*file_in,
  	loff_t			pos_in,

Looks ok to me. You can add my review:

Reviewed-by Allison Henderson <[email protected]>

Thanks!
Allison