Skip to contentSkip to conversation

hyper-v: Fix wakeup from suspend-to-idle

PATCH RESEND In review Vitaly Kuznetsov 2 participants 2 messages Nov 15, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 hyper-v: Fix wakeup from suspend-to-idle

It makes little sense but still possible to put Hyper-V guests into suspend-to-idle state. To wake them up two wakeup sources were registered in the past: hyperv-keyboard and hid-hyperv. However, since commit eed4d47efe95 ("ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle") pm_wakeup_event() from these devices is ignored. Switch to pm_wakeup_hard_event() API as these devices are actually the only possible way to wakeup Hyper-V guests.

Fixes eed4d47efe95 (ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle)

---
- It seems the patch slipped through the cracks, resending.

---
 drivers/hid/hid-hyperv.c              | 2 +-
 drivers/input/serio/hyperv-keyboard.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/hid/hid-hyperv.c +1 -1
index b372854cf38d..704049e62d58 100644
@@ -309,7 +309,7 @@ static void mousevsc_on_receive(struct hv_device *device,
 		hid_input_report(input_dev->hid_device, HID_INPUT_REPORT,
 				 input_dev->input_buf, len, 1);
 
-		pm_wakeup_event(&input_dev->device->device, 0);
+		pm_wakeup_hard_event(&input_dev->device->device);
 
 		break;
 	default:
drivers/input/serio/hyperv-keyboard.c +1 -1
index 47a0e81a2989..a8b9be3e28db 100644
@@ -177,7 +177,7 @@ static void hv_kbd_on_receive(struct hv_device *hv_dev,
 		 * state because the Enter-UP can trigger a wakeup at once.
 		 */
 		if (!(info & IS_BREAK))
-			pm_wakeup_event(&hv_dev->device, 0);
+			pm_wakeup_hard_event(&hv_dev->device);
 
 		break;
 
Signature · 1 line
2.17.2
maintainer
#1 lore raw
Quoted 8 lines · Vitaly Kuznetsov

It makes little sense but still possible to put Hyper-V guests into suspend-to-idle state. To wake them up two wakeup sources were registered in the past: hyperv-keyboard and hid-hyperv. However, since commit eed4d47efe95 ("ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle") pm_wakeup_event() from these devices is ignored. Switch to pm_wakeup_hard_event() API as these devices are actually the only possible way to wakeup Hyper-V guests.

Quoted 7 lines
Fixes eed4d47efe95 (ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle)

---
- It seems the patch slipped through the cracks, resending.

OK, so since nobody else took it I'll push it through my tree.

Thanks.

Signature · 1 line
Dmitry