Skip to contentSkip to conversation

cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size

PATCH Applied Arjun Vynipadath 2 participants 2 messages Nov 16, 2018 – Nov 18, 2018

Subsystems (3)
Networking Network drivers CXGB4 Ethernet driver (CXGB4)
lore
Share & tools
lore

Arjun Vynipadath

author
#0 lore raw

PATCH 1/1 cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size

The SGE Host Page Size has nothing to do with the actual Host Page Size. It's the SGE's BAR2 Doorbell/GTS Page Size for interpreting the SGE Ingress/Egress Queue per Page values. Firmware reads all of these things and makes all the subsequent changes necessary. The Host Driver uses the SGE Host Page Size in order to properly calculate BAR2 Offsets.

Signed-off-by Casey Leedom <[email protected]>
Signed-off-by Arjun Vynipadath <[email protected]>
Signed-off-by Ganesh Goudar <[email protected]>
---
 drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 11 -----------
 1 file changed, 11 deletions(-)
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +0 -11
index cb52394..fc6a087 100644
@@ -7141,21 +7141,10 @@ int t4_fixup_host_params(struct adapter *adap, unsigned int page_size,
 			 unsigned int cache_line_size)
 {
 	unsigned int page_shift = fls(page_size) - 1;
-	unsigned int sge_hps = page_shift - 10;
 	unsigned int stat_len = cache_line_size > 64 ? 128 : 64;
 	unsigned int fl_align = cache_line_size < 32 ? 32 : cache_line_size;
 	unsigned int fl_align_log = fls(fl_align) - 1;
 
-	t4_write_reg(adap, SGE_HOST_PAGE_SIZE_A,
-		     HOSTPAGESIZEPF0_V(sge_hps) |
-		     HOSTPAGESIZEPF1_V(sge_hps) |
-		     HOSTPAGESIZEPF2_V(sge_hps) |
-		     HOSTPAGESIZEPF3_V(sge_hps) |
-		     HOSTPAGESIZEPF4_V(sge_hps) |
-		     HOSTPAGESIZEPF5_V(sge_hps) |
-		     HOSTPAGESIZEPF6_V(sge_hps) |
-		     HOSTPAGESIZEPF7_V(sge_hps));
-
 	if (is_t4(adap->params.chip)) {
 		t4_set_reg_field(adap, SGE_CONTROL_A,
 				 INGPADBOUNDARY_V(INGPADBOUNDARY_M) |
Signature · 1 line
2.9.5
maintainer Applied
#1 lore raw

From: Arjun Vynipadath <[email protected]>
Date: Fri, 16 Nov 2018 09:15:42 +0530

Quoted 10 lines

The SGE Host Page Size has nothing to do with the actual Host Page Size. It's the SGE's BAR2 Doorbell/GTS Page Size for interpreting the SGE Ingress/Egress Queue per Page values. Firmware reads all of these things and makes all the subsequent changes necessary. The Host Driver uses the SGE Host Page Size in order to properly calculate BAR2 Offsets.

Signed-off-by Casey Leedom <[email protected]>
Signed-off-by Arjun Vynipadath <[email protected]>
Signed-off-by Ganesh Goudar <[email protected]>

Applied.