Skip to contentSkip to conversation

build: document that Meson < 0.45 will fail to list private deps

PATCH Superseded Luca Boccassi 3 participants 7 messages Nov 15, 2018 – Nov 18, 2018 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: document that Meson < 0.45 will fail to list private deps

Meson can generate the list of private dependencies of libraries automatically for the pkgconfig file only since version 0.45.0.

---
 doc/build-sdk-meson.txt | 6 ++++++
 1 file changed, 6 insertions(+)
doc/build-sdk-meson.txt +6 -0
index 508e2cb64..229398bb0 100644
@@ -203,3 +203,9 @@ From examples/helloworld/Makefile::
 
 	build:
 		@mkdir -p $@
+
+NOTE: for --static builds, DPDK needs to be built with Meson >= 0.45 in order to
+fully generate the list of private dependencies. If DPDK is built with an older
+version of Meson, it might be necessary to manually specify dependencies of DPDK
+PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or the static link
+step might fail.
Signature · 1 line
2.19.1
#1 lore raw
Quoted 13 lines · Luca Boccassi

Meson can generate the list of private dependencies of libraries automatically for the pkgconfig file only since version 0.45.0.

---
 doc/build-sdk-meson.txt | 6 ++++++
 1 file changed, 6 insertions(+)
doc/build-sdk-meson.txt +0 -0
index 508e2cb64..229398bb0 100644

doc/build-sdk-meson.txt From examples/helloworld/Makefile:: · line 211

Quoted 9 lines
doc/build-sdk-meson.txt +6 -0
@@ -203,3 +203,9 @@ From examples/helloworld/Makefile::
 
 	build:
 		@mkdir -p $@
+
+NOTE: for --static builds, DPDK needs to be built with Meson >= 0.45 in order to
+fully generate the list of private dependencies. If DPDK is built with an older
+version of Meson, it might be necessary to manually specify dependencies of DPDK
+PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or the static link
+step might fail.

Thinking about it more, this doesn't seem to actually be the root-cause of the reported problem. You said in the other thread that you reproduced the problem with v0.45.2 which is >= 0.45

/Bruce

#2 lore raw
Quoted 34 lines · Bruce Richardson
Quoted 18 lines · Luca Boccassi

Meson can generate the list of private dependencies of libraries automatically for the pkgconfig file only since version 0.45.0.

---
 doc/build-sdk-meson.txt | 6 ++++++

 1 file changed, 6 insertions(+)
doc/build-sdk-meson.txt +0 -0
index 508e2cb64..229398bb0 100644
@@ -203,3 +203,9 @@ From examples/helloworld/Makefile::


  build:
  @mkdir -p $@

doc/build-sdk-meson.txt +2 -0
+
+NOTE: for --static builds, DPDK needs to be built with Meson >=
Quoted 8 lines

0.45 in order to
+fully generate the list of private dependencies. If DPDK is built with an older
+version of Meson, it might be necessary to manually specify dependencies of DPDK
+PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or the static link
+step might fail.

Thinking about it more, this doesn't seem to actually be the root- cause of
the reported problem. You said in the other thread that you reproduced the
problem with v0.45.2 which is >= 0.45

Quoted 1 line

/Bruce

I think the documentation linked there is wrong - looking at the release notes in the repository, it's 0.46 that mentions that new feature, not 0.45:

https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-0.46.0.md#improved-generation-of-pkg-config-files-for-static-only-libraries

I'll check if I can repro with 0.46 to confirm

Signature · 2 lines
Kind regards,
Luca Boccassi
#3 lore raw
Quoted 42 lines · Luca Boccassi
Quoted 35 lines · Bruce Richardson
Quoted 19 lines · Luca Boccassi

Meson can generate the list of private dependencies of libraries automatically for the pkgconfig file only since version 0.45.0.

---
 doc/build-sdk-meson.txt | 6 ++++++

 1 file changed, 6 insertions(+)
doc/build-sdk-meson.txt +0 -0
index 508e2cb64..229398bb0 100644
@@ -203,3 +203,9 @@ From examples/helloworld/Makefile::


  build:
  @mkdir -p $@

doc/build-sdk-meson.txt +2 -0
+
+NOTE: for --static builds, DPDK needs to be built with Meson >=

0.45 in order to

Quoted 8 lines

+fully generate the list of private dependencies. If DPDK is built
with an older
+version of Meson, it might be necessary to manually specify dependencies of DPDK
+PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or the static link
+step might fail.

Thinking about it more, this doesn't seem to actually be the root- cause of
the reported problem. You said in the other thread that you reproduced the
problem with v0.45.2 which is >= 0.45

Quoted 1 line

/Bruce

I think the documentation linked there is wrong - looking at the release notes in the repository, it's 0.46 that mentions that new feature, not 0.45:

Quoted 5 lines

https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release
-notes-for-0.46.0.md#improved-generation-of-pkg-config-files-for- static-only-libraries

I'll check if I can repro with 0.46 to confirm

Yes I can confirm that it's 0.46 that actually fixes the issue, so I'll send a v2 with the updated version.

Signature · 2 lines
Kind regards,
Luca Boccassi
#4 lore raw

PATCH v2 1/1 build: document that Meson < 0.46 will fail to list private deps

In reply to Luca Boccassi

Meson can generate the list of private dependencies of libraries automatically for the pkgconfig file only since version 0.46.0.

---
v2: corrected version, minimum required is meson 0.46

 doc/build-sdk-meson.txt | 6 ++++++
 1 file changed, 6 insertions(+)
doc/build-sdk-meson.txt +6 -0
index 508e2cb64..3d8a69c29 100644
@@ -203,3 +203,9 @@ From examples/helloworld/Makefile::
 
 	build:
 		@mkdir -p $@
+
+NOTE: for --static builds, DPDK needs to be built with Meson >= 0.46 in order to
+fully generate the list of private dependencies. If DPDK is built with an older
+version of Meson, it might be necessary to manually specify dependencies of DPDK
+PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or the static link
+step might fail.
Signature · 1 line
2.19.1
Acked-by on v2 1/1
#5 lore raw

Re: [PATCH v2] build: document that Meson < 0.46 will fail to list private deps

Quoted 11 lines

-----Original Message-----
From: Luca Boccassi [mailto:[email protected]]
Sent: Friday, November 16, 2018 10:58 AM
To: [email protected]
Cc: Richardson, Bruce <[email protected]>; [email protected]; Luca Boccassi <[email protected]>
Subject: [PATCH v2] build: document that Meson < 0.46 will fail to list private deps

Quoted 7 lines

Meson can generate the list of private dependencies of libraries automatically for the pkgconfig file only since version 0.46.0.

---
v2: corrected version, minimum required is meson 0.46