Skip to contentSkip to conversation

gstreamer: fix build on riscv

PATCH New Fabrice Fontaine 3 participants 3 messages Nov 17, 2018 – Nov 18, 2018

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/1 gstreamer: fix build on riscv

RISC-V supports unaligned accesses, but these might run extremely slowly depending on the implementation so set as_cv_unaligned_access to no on this architecture, see:
https://gitlab.freedesktop.org/gstreamer/gstreamer/commit/8a156d1725ecd03f2e8cdc8874e081dda2d3b43d

Fixes:
- http://autobuild.buildroot.org/results/dca32c929350311fca1a85e251d318b43c4a3177

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/gstreamer/gstreamer/gstreamer.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/gstreamer/gstreamer/gstreamer.mk +1 -1
index 88cc798828..2ec360c94d 100644
@@ -15,7 +15,7 @@ GSTREAMER_LICENSE_FILES = COPYING
 # Checking if unaligned memory access works correctly cannot be done when cross
 # compiling. For the following architectures there is no information available
 # in the configure script.
-ifeq ($(BR2_arc)$(BR2_xtensa)$(BR2_microblaze)$(BR2_nios2)$(BR2_or1k),y)
+ifeq ($(BR2_arc)$(BR2_xtensa)$(BR2_microblaze)$(BR2_nios2)$(BR2_or1k)$(BR2_riscv),y)
 GSTREAMER_CONF_ENV = as_cv_unaligned_access=no
 endif
 ifeq ($(BR2_aarch64)$(BR2_aarch64_be),y)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 gstreamer: fix build on riscv

Hello Fabrice,

Quoted 18 lines · Fabrice Fontaine

RISC-V supports unaligned accesses, but these might run extremely slowly depending on the implementation so set as_cv_unaligned_access to no on this architecture, see:
https://gitlab.freedesktop.org/gstreamer/gstreamer/commit/8a156d1725ecd03f2e8cdc8874e081dda2d3b43d

Fixes:
- http://autobuild.buildroot.org/results/dca32c929350311fca1a85e251d318b43c4a3177

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/gstreamer/gstreamer/gstreamer.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/gstreamer/gstreamer/gstreamer.mk +0 -0
index 88cc798828..2ec360c94d 100644

package/gstreamer/gstreamer/gstreamer.mk GSTREAMER_LICENSE_FILES = COPYING · line 21

Quoted 8 lines
package/gstreamer/gstreamer/gstreamer.mk +1 -1
@@ -15,7 +15,7 @@ GSTREAMER_LICENSE_FILES = COPYING
 # Checking if unaligned memory access works correctly cannot be done when cross
 # compiling. For the following architectures there is no information available
 # in the configure script.
-ifeq ($(BR2_arc)$(BR2_xtensa)$(BR2_microblaze)$(BR2_nios2)$(BR2_or1k),y)
+ifeq ($(BR2_arc)$(BR2_xtensa)$(BR2_microblaze)$(BR2_nios2)$(BR2_or1k)$(BR2_riscv),y)
 GSTREAMER_CONF_ENV = as_cv_unaligned_access=no
 endif
 ifeq ($(BR2_aarch64)$(BR2_aarch64_be),y)
Reviewed-by Peter Seiderer <[email protected]>

Regards,
Peter

#2 lore raw

PATCH 1/1 gstreamer: fix build on riscv

In reply to Fabrice Fontaine
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

RISC-V supports unaligned accesses, but these might run extremely slowly depending on the implementation so set as_cv_unaligned_access to no on this architecture, see:
https://gitlab.freedesktop.org/gstreamer/gstreamer/commit/8a156d1725ecd03f2e8cdc8874e081dda2d3b43d

Fixes:
- http://autobuild.buildroot.org/results/dca32c929350311fca1a85e251d318b43c4a3177

Signed-off-by Fabrice Fontaine <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard