Skip to contentSkip to conversation

tpm2-tss: depend on shared libraries

PATCH Superseded Carlos Santos 2 participants 3 messages Nov 19, 2018 – Nov 20, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Carlos Santos

author
#0 lore raw

PATCH 1/1 tpm2-tss: depend on shared libraries

The code includes dlfcn.h even if --enable-static and --disable-shared are passed to configure. There is an "#ifndef NO_DL ... #endif" wrapper but NO_DL is never defined and adding "-DNO_DL" to CFLAGS causes other compilation errors.

Fixes:
http://autobuild.buildroot.net/results/cfc3bfef5e93329bf944a57947086d9ddc4fece3

Signed-off-by Carlos Santos <[email protected]>
---
 package/tpm2-tss/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/tpm2-tss/Config.in +4 -0
index 4e299eccc1..26a120c46b 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_TPM2_TSS
 	bool "tpm2-tss"
+	depends on !BR2_STATIC_LIBS # dlfcn.h
 	select BR2_PACKAGE_LIBURIPARSER
 	select BR2_PACKAGE_OPENSSL
 	help

@@ -30,3 +31,6 @@ config BR2_PACKAGE_TPM2_TSS
 	    Microsoft software TPM2 simulator.
 
 	  https://github.com/tpm2-software/tpm2-tss
+
+comment "tpm2-tss needs a toolchain w/ dynamic library"
+	depends BR2_STATIC_LIBS
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 tpm2-tss: depend on shared libraries

Hello Carlos,

Quoted 9 lines · Carlos Santos

The code includes dlfcn.h even if --enable-static and --disable-shared are passed to configure. There is an "#ifndef NO_DL ... #endif" wrapper but NO_DL is never defined and adding "-DNO_DL" to CFLAGS causes other compilation errors.

Fixes:
http://autobuild.buildroot.net/results/cfc3bfef5e93329bf944a57947086d9ddc4fece3

Signed-off-by Carlos Santos <[email protected]>

You need to propagate this dependency to the reverse dependencies of tpm2-tss.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com