4.14.82-stable review
Subsystems (9)
Greg Kroah-Hartman
maintainercover 4.14.82-stable review
This is the start of the stable review cycle for the 4.14.82 release. There are 124 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Nov 21 16:25:07 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.82-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.14.82-rc1
Doug Berger <[email protected]>
gpio: brcmstb: release the bgpio lock during irq handlers
Ming Lei <[email protected]>
nvme-loop: fix kernel oops in case of unhandled command
Sergey Senozhatsky <[email protected]>
printk: Never set console_may_schedule in console_trylock()
Miklos Szeredi <[email protected]>
ovl: check whiteout in ovl_create_over_whiteout()
Stefano Stabellini <[email protected]>
CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM
Chris Wilson <[email protected]>
drm/i915/execlists: Force write serialisation into context image vs execution
Chris Wilson <[email protected]>
drm/i915: Mark pin flags as u64
Ville Syrjälä <[email protected]>
drm/i915: Don't oops during modeset shutdown after lpe audio deinit
Clint Taylor <[email protected]>
drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
Chris Wilson <[email protected]>
drm/i915: Large page offsets for pread/pwrite
Lyude Paul <[email protected]>
drm/i915: Skip vcpi allocation for MSTB ports that are gone
Lyude Paul <[email protected]>
drm/i915: Don't unset intel_connector->mst_port
Ville Syrjälä <[email protected]>
drm/i915: Restore vblank interrupts earlier
Lyude Paul <[email protected]>
drm/atomic_helper: Disallow new modesets on unregistered connectors
Stanislav Lisovskiy <[email protected]>
drm/dp_mst: Check if primary mstb is null
Lyude Paul <[email protected]>
drm/nouveau: Check backlight IDs are >= 0, not > 0
Alex Deucher <[email protected]>
drm/amdgpu: add missing CHIP_HAINAN in amdgpu_ucode_get_load_type
Marc Zyngier <[email protected]>
drm/rockchip: Allow driver to be shutdown on reboot/kexec
Ard Biesheuvel <[email protected]>
efi/arm/libstub: Pack FDT after populating it
Vasily Averin <[email protected]>
mm/swapfile.c: use kvzalloc for swap_info_struct allocation
Mike Kravetz <[email protected]>
hugetlbfs: fix kernel BUG at fs/hugetlbfs/inode.c:444!
Arnd Bergmann <[email protected]>
lib/ubsan.c: don't mark __ubsan_handle_builtin_unreachable as noreturn
Eric Biggers <[email protected]>
crypto: user - fix leaking uninitialized memory to userspace
Andreas Gruenbacher <[email protected]>
gfs2: Put bitmap buffers in put_super
Guenter Roeck <[email protected]>
configfs: replace strncpy with memcpy
Miklos Szeredi <[email protected]>
fuse: fix leaked notify reply
Lukas Czerner <[email protected]>
fuse: fix use-after-free in fuse_direct_IO()
Maciej W. Rozycki <[email protected]>
rtc: hctosys: Add missing range error reporting
Scott Mayhew <[email protected]>
nfsd: COPY and CLONE operations require the saved filehandle to be set
Frank Sorenson <[email protected]>
sunrpc: correct the computation for page_ptr when truncating
Christophe Leroy <[email protected]>
kdb: print real address of pointers instead of hashed addresses
Christophe Leroy <[email protected]>
kdb: use correct pointer when 'btc' calls 'btt'
Eric W. Biederman <[email protected]>
mount: Prevent MNT_DETACH from disconnecting locked mounts
Eric W. Biederman <[email protected]>
mount: Don't allow copying MNT_UNBINDABLE|MNT_LOCKED mounts
Eric W. Biederman <[email protected]>
mount: Retest MNT_LOCKED in do_umount
Vasily Averin <[email protected]>
ext4: fix buffer leak in __ext4_read_dirblock() on error path
Vasily Averin <[email protected]>
ext4: fix buffer leak in ext4_expand_extra_isize_ea() on error path
Vasily Averin <[email protected]>
ext4: fix buffer leak in ext4_xattr_move_to_block() on error path
Vasily Averin <[email protected]>
ext4: release bs.bh before re-using in ext4_xattr_block_find()
Vasily Averin <[email protected]>
ext4: fix buffer leak in ext4_xattr_get_block() on error path
Vasily Averin <[email protected]>
ext4: fix possible leak of s_journal_flag_rwsem in error path
Theodore Ts'o <[email protected]>
ext4: fix possible leak of sbi->s_group_desc_leak in error path
Theodore Ts'o <[email protected]>
ext4: avoid possible double brelse() in add_new_gdb() on error path
Vasily Averin <[email protected]>
ext4: fix missing cleanup if ext4_alloc_flex_bg_array() fails while resizing
Vasily Averin <[email protected]>
ext4: avoid buffer leak in ext4_orphan_add() after prior errors
Vasily Averin <[email protected]>
ext4: avoid buffer leak on shutdown in ext4_mark_iloc_dirty()
Vasily Averin <[email protected]>
ext4: fix possible inode leak in the retry loop of ext4_resize_fs()
Vasily Averin <[email protected]>
ext4: missing !bh check in ext4_xattr_inode_write()
Vasily Averin <[email protected]>
ext4: avoid potential extra brelse in setup_new_flex_group_blocks()
Vasily Averin <[email protected]>
ext4: add missing brelse() add_new_gdb_meta_bg()'s error path
Vasily Averin <[email protected]>
ext4: add missing brelse() in set_flexbg_block_bitmap()'s error path
Vasily Averin <[email protected]>
ext4: add missing brelse() update_backups()'s error path
Michael Kelley <[email protected]>
clockevents/drivers/i8253: Add support for PIT shutdown quirk
Filipe Manana <[email protected]>
Btrfs: fix data corruption due to cloning of eof block
Filipe Manana <[email protected]>
Btrfs: fix infinite loop on inode eviction after deduplication of eof block
Robbie Ko <[email protected]>
Btrfs: fix cur_offset in the error case for nocow
Lu Fengqi <[email protected]>
btrfs: fix pinned underflow after transaction aborted
Mathieu Malaterre <[email protected]>
watchdog/core: Add missing prototypes for weak functions
H. Peter Anvin (Intel) <[email protected]>
arch/alpha, termios: implement BOTHER, IBSHIFT and termios2
H. Peter Anvin <[email protected]>
termios, tty/tty_baudrate.c: fix buffer overrun
Michael Kelley <[email protected]>
x86/hyper-v: Enable PIT shutdown quirk
Steven Rostedt (VMware) <[email protected]>
x86/cpu/vmware: Do not trace vmware_sched_clock()
John Garry <[email protected]>
of, numa: Validate some distance map rules
Arnd Bergmann <[email protected]>
mtd: docg3: don't set conflicting BCH_CONST_PARAMS option
Ard Biesheuvel <[email protected]>
ARM: 8809/1: proc-v7: fix Thumb annotation of cpu_v7_hvc_switch_mm
Vasily Khoruzhick <[email protected]>
netfilter: conntrack: fix calculation of next bucket number in early_drop
Andrea Arcangeli <[email protected]>
mm: thp: relax __GFP_THISNODE for MADV_HUGEPAGE mappings
Wengang Wang <[email protected]>
ocfs2: free up write context when direct IO failed
Changwei Ge <[email protected]>
ocfs2: fix a misuse a of brelse after failing ocfs2_check_dir_entry
Marc Zyngier <[email protected]>
soc: ti: QMSS: Fix usage of irq_set_affinity_hint
Ming Lei <[email protected]>
SCSI: fix queue cleanup race before queue initialization is done
Quinn Tran <[email protected]>
scsi: qla2xxx: Initialize port speed to avoid setting lower speed
Greg Edwards <[email protected]>
vhost/scsi: truncate T10 PI iov_iter to prot_bytes
Gustavo A. R. Silva <[email protected]>
reset: hisilicon: fix potential NULL pointer dereference
Mikulas Patocka <[email protected]>
mach64: fix image corruption due to reading accelerator registers
Mikulas Patocka <[email protected]>
mach64: fix display corruption on big endian machines
Allen Wild <[email protected]>
thermal: enable broadcom menu for arm64 bcm2835
Yan, Zheng <[email protected]>
Revert "ceph: fix dentry leak in splice_dentry()"
Ilya Dryomov <[email protected]>
libceph: bump CEPH_MSG_MAX_DATA_LEN
Lubomir Rintel <[email protected]>
media: ov7670: make "xclk" clock optional
Chris Packham <[email protected]>
clk: mvebu: use correct bit for 98DX3236 NAND
Enric Balletbo i Serra <[email protected]>
clk: rockchip: Fix static checker warning in rockchip_ddrclk_get_parent call
Ronald Wahl <[email protected]>
clk: at91: Fix division by zero in PLL recalc_rate()
Krzysztof Kozlowski <[email protected]>
clk: s2mps11: Fix matching when built as module and DT node contains compatible
Richard Weinberger <[email protected]>
um: Drop own definition of PTRACE_SYSEMU/_SINGLESTEP
Max Filippov <[email protected]>
xtensa: fix boot parameters address translation
Max Filippov <[email protected]>
xtensa: make sure bFLT stack is 16 byte aligned
Max Filippov <[email protected]>
xtensa: add NOTES section to the linker script
Huacai Chen <[email protected]>
MIPS: Loongson-3: Fix BRIDGE irq delivery problem
Huacai Chen <[email protected]>
MIPS: Loongson-3: Fix CPU UART irq delivery problem
Amir Goldstein <[email protected]>
ovl: fix recursive oi->lock in ovl_link()
Miklos Szeredi <[email protected]>
fuse: set FR_SENT while locked
Miklos Szeredi <[email protected]>
fuse: fix blocked_waitq wakeup
Kirill Tkhai <[email protected]>
fuse: Fix use-after-free in fuse_dev_do_write()
Kirill Tkhai <[email protected]>
fuse: Fix use-after-free in fuse_dev_do_read()
Quinn Tran <[email protected]>
scsi: qla2xxx: Fix re-using LoopID when handle is in use
Quinn Tran <[email protected]>
scsi: qla2xxx: shutdown chip if reset fail
Quinn Tran <[email protected]>
scsi: qla2xxx: Remove stale debug trace message from tcm_qla2xxx
Quinn Tran <[email protected]>
scsi: qla2xxx: Fix process response queue for ISP26XX and above
Himanshu Madhani <[email protected]>
scsi: qla2xxx: Fix incorrect port speed being set for FC adapters
Amir Goldstein <[email protected]>
ovl: fix error handling in ovl_verify_set_fh()
Young_X <[email protected]>
cdrom: fix improper type cast, which can leat to information leak.
Dominique Martinet <[email protected]>
9p: clear dangling pointers in p9stat_free
Dominique Martinet <[email protected]>
9p locks: fix glock.client_id leak in do_lock
Alexandru Ardelean <[email protected]>
staging:iio:ad7606: fix voltage scales
Breno Leitao <[email protected]>
powerpc/selftests: Wait all threads to join
Marco Felsch <[email protected]>
media: tvp5150: fix width alignment during set_selection()
Phil Elwell <[email protected]>
sc16is7xx: Fix for multi-channel stall
Huacai Chen <[email protected]>
MIPS/PCI: Call pcie_bus_configure_settings() to set MPS/MRRS
Rashmica Gupta <[email protected]>
powerpc/memtrace: Remove memory in chunks
Joel Stanley <[email protected]>
powerpc/boot: Ensure _zimage_start is a weak symbol
Dengcheng Zhu <[email protected]>
MIPS: kexec: Mark CPU offline before disabling local IRQ
Lucas Stach <[email protected]>
media: coda: don't overwrite h.264 profile_idc on decoder instance
Nicholas Mc Guire <[email protected]>
media: pci: cx23885: handle adding to list failure
John Garry <[email protected]>
drm/hisilicon: hibmc: Do not carry error code in HiBMC framebuffer pointer
Tomi Valkeinen <[email protected]>
drm/omap: fix memory barrier bug in DMM driver
Christophe Leroy <[email protected]>
powerpc/mm: Don't report hugepage tables as memory leaks when using kmemleak
Daniel Axtens <[email protected]>
powerpc/nohash: fix undefined behaviour when testing page size support
Fabio Estevam <[email protected]>
ARM: imx_v6_v7_defconfig: Select CONFIG_TMPFS_POSIX_ACL
Miles Chen <[email protected]>
tty: check name length in tty_find_polling_driver()
Sam Bobroff <[email protected]>
powerpc/eeh: Fix possible null deref in eeh_dump_dev_log()
Michael Ellerman <[email protected]>
powerpc/mm: Fix page table dump to work on Radix
Nicholas Piggin <[email protected]>
powerpc/64/module: REL32 relocation range check
Christophe Leroy <[email protected]>
powerpc/traps: restore recoverability of machine_check interrupts
-------------
Diffstat:
Makefile | 4 +- arch/alpha/include/asm/termios.h | 8 +++- arch/alpha/include/uapi/asm/ioctls.h | 5 ++ arch/alpha/include/uapi/asm/termbits.h | 17 +++++++ arch/arm/configs/imx_v6_v7_defconfig | 1 + arch/arm/mm/proc-v7.S | 2 +- arch/mips/include/asm/mach-loongson64/irq.h | 2 +- arch/mips/kernel/crash.c | 3 ++ arch/mips/kernel/machine_kexec.c | 3 ++ arch/mips/loongson64/loongson-3/irq.c | 56 +++-------------------- arch/mips/pci/pci-legacy.c | 4 ++ arch/powerpc/boot/crt0.S | 4 +- arch/powerpc/kernel/eeh.c | 5 ++ arch/powerpc/kernel/module_64.c | 9 +++- arch/powerpc/kernel/traps.c | 9 +++- arch/powerpc/mm/dump_linuxpagetables.c | 12 +++-- arch/powerpc/mm/hugetlbpage.c | 3 ++ arch/powerpc/mm/tlb_nohash.c | 3 ++ arch/powerpc/platforms/powernv/memtrace.c | 21 +++++++-- arch/x86/kernel/cpu/mshyperv.c | 11 +++++ arch/x86/kernel/cpu/vmware.c | 2 +- arch/x86/um/shared/sysdep/ptrace_32.h | 10 ---- arch/xtensa/boot/Makefile | 2 +- arch/xtensa/include/asm/processor.h | 6 ++- arch/xtensa/kernel/head.S | 7 ++- arch/xtensa/kernel/vmlinux.lds.S | 1 + block/blk-core.c | 5 +- crypto/crypto_user.c | 18 ++++---- drivers/cdrom/cdrom.c | 2 +- drivers/clk/at91/clk-pll.c | 3 ++ drivers/clk/clk-s2mps11.c | 30 ++++++++++++ drivers/clk/hisilicon/reset.c | 5 +- drivers/clk/mvebu/clk-corediv.c | 2 +- drivers/clk/rockchip/clk-ddr.c | 4 -- drivers/clocksource/i8253.c | 14 +++++- drivers/firmware/efi/libstub/fdt.c | 4 ++ drivers/gpio/gpio-brcmstb.c | 21 +++++++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 1 + drivers/gpu/drm/drm_atomic_helper.c | 21 ++++++++- drivers/gpu/drm/drm_dp_mst_topology.c | 3 ++ drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 1 + drivers/gpu/drm/i915/i915_gem.c | 12 +---- drivers/gpu/drm/i915/i915_gem_gtt.h | 28 ++++++------ drivers/gpu/drm/i915/intel_audio.c | 17 +++++++ drivers/gpu/drm/i915/intel_display.c | 23 ++++++---- drivers/gpu/drm/i915/intel_dp_mst.c | 41 +++++++++-------- drivers/gpu/drm/i915/intel_lpe_audio.c | 4 +- drivers/gpu/drm/i915/intel_lrc.c | 14 +++++- drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 +- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 11 +++++ drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 +++ drivers/media/i2c/ov7670.c | 30 +++++++----- drivers/media/i2c/tvp5150.c | 14 ++++-- drivers/media/pci/cx23885/altera-ci.c | 10 ++++ drivers/media/platform/coda/coda-common.c | 3 +- drivers/mtd/devices/Kconfig | 2 +- drivers/nvme/target/loop.c | 9 +--- drivers/of/of_numa.c | 9 +++- drivers/rtc/hctosys.c | 4 +- drivers/scsi/qla2xxx/qla_init.c | 23 +++------- drivers/scsi/qla2xxx/qla_iocb.c | 17 ------- drivers/scsi/qla2xxx/qla_mbx.c | 5 +- drivers/scsi/qla2xxx/qla_target.c | 3 +- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 -- drivers/scsi/scsi_lib.c | 8 ++++ drivers/soc/ti/knav_qmss.h | 4 +- drivers/soc/ti/knav_qmss_acc.c | 10 ++-- drivers/soc/ti/knav_qmss_queue.c | 22 ++++++--- drivers/staging/iio/adc/ad7606.c | 7 ++- drivers/thermal/Kconfig | 2 +- drivers/tty/serial/sc16is7xx.c | 19 +++++--- drivers/tty/tty_baudrate.c | 4 +- drivers/tty/tty_io.c | 2 +- drivers/vhost/scsi.c | 4 +- drivers/video/fbdev/aty/mach64_accel.c | 28 +++++------- fs/9p/vfs_file.c | 16 ++++++- fs/btrfs/disk-io.c | 12 ++++- fs/btrfs/inode.c | 5 +- fs/btrfs/ioctl.c | 14 +++++- fs/ceph/inode.c | 8 +++- fs/configfs/symlink.c | 2 +- fs/ext4/inode.c | 5 +- fs/ext4/namei.c | 5 +- fs/ext4/resize.c | 28 +++++++----- fs/ext4/super.c | 17 +++---- fs/ext4/xattr.c | 21 +++++++-- fs/fuse/dev.c | 29 +++++++++--- fs/fuse/file.c | 4 +- fs/gfs2/rgrp.c | 3 +- fs/namespace.c | 22 +++++++-- fs/nfsd/nfs4proc.c | 3 ++ fs/ocfs2/aops.c | 12 ++++- fs/ocfs2/cluster/masklog.h | 9 ++++ fs/ocfs2/dir.c | 3 +- fs/overlayfs/dir.c | 9 ++++ fs/overlayfs/namei.c | 4 +- include/linux/ceph/libceph.h | 8 +++- include/linux/i8253.h | 1 + include/linux/nmi.h | 2 + include/xen/xen-ops.h | 2 +- kernel/debug/kdb/kdb_bt.c | 4 +- kernel/debug/kdb/kdb_main.c | 14 +++--- kernel/debug/kdb/kdb_support.c | 12 ++--- kernel/printk/printk.c | 22 ++++----- lib/ubsan.c | 3 +- mm/hugetlb.c | 23 ++++++++-- mm/mempolicy.c | 32 ++++++++++++- mm/swapfile.c | 6 +-- net/9p/protocol.c | 5 ++ net/netfilter/nf_conntrack_core.c | 13 ++++-- net/sunrpc/xdr.c | 5 +- tools/testing/selftests/powerpc/tm/tm-tmspr.c | 27 +++++++---- 112 files changed, 757 insertions(+), 400 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/124 powerpc/traps: restore recoverability of machine_check interrupts
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christophe Leroy <[email protected]>
[ Upstream commit daf00ae71dad8aa05965713c62558aeebf2df48e ]
commit b96672dd840f ("powerpc: Machine check interrupt is a non- maskable interrupt") added a call to nmi_enter() at the beginning of machine check restart exception handler. Due to that, in_interrupt() always returns true regardless of the state before entering the exception, and die() panics even when the system was not already in interrupt.
This patch calls nmi_exit() before calling die() in order to restore the interrupt state we had before calling nmi_enter()
--- arch/powerpc/kernel/traps.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
arch/powerpc/kernel/traps.c +7 -2
@@ -694,12 +694,17 @@ void machine_check_exception(struct pt_rif (check_io_access (regs)) goto bail; -die ("Machine check" , regs,SIGBUS ); -/* Must die if the interrupt is not recoverable */ if (!(regs->msr &MSR_RI ))nmi_panic (regs,"Unrecoverable Machine check" ); +if (!nested) +nmi_exit (); + +die ("Machine check" , regs,SIGBUS ); + +return ; + bail:if (!nested)nmi_exit ();
Greg Kroah-Hartman
maintainerPATCH 2/124 powerpc/64/module: REL32 relocation range check
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nicholas Piggin <[email protected]>
[ Upstream commit b851ba02a6f3075f0f99c60c4bc30a4af80cf428 ]
The recent module relocation overflow crash demonstrated that we have no range checking on REL32 relative relocations. This patch implements a basic check, the same kernel that previously oopsed and rebooted now continues with some of these errors when loading the module:
module_64: x_tables: REL32 527703503449812 out of range!
Possibly other relocations (ADDR32, REL16, TOC16, etc.) should also have overflow checks.
--- arch/powerpc/kernel/module_64.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
arch/powerpc/kernel/module_64.c +8 -1
@@ -656,7 +656,14 @@ int apply_relocate_add(Elf64_Shdr *sechdcase R_PPC64_REL32 :/* 32 bits relative (used by relative exception tables) */ - *(u32 *)location = value - (unsigned long )location; +/* Convert value to relative */ + value -= (unsigned long )location; +if (value +0x80000000 >0xffffffff ) { +pr_err ("%s: REL32 %li out of range!\n" , + me->name, (long int )value); +return -ENOEXEC ; + } + *(u32 *)location = value;break ;case R_PPC64_TOCSAVE :
Greg Kroah-Hartman
maintainerPATCH 3/124 powerpc/mm: Fix page table dump to work on Radix
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michael Ellerman <[email protected]>
[ Upstream commit 0d923962ab69c27cca664a2d535e90ef655110ca ]
When we're running on Book3S with the Radix MMU enabled the page table dump currently prints the wrong addresses because it uses the wrong start address.
Fix it to use PAGE_OFFSET rather than KERN_VIRT_START.
--- arch/powerpc/mm/dump_linuxpagetables.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
arch/powerpc/mm/dump_linuxpagetables.c +9 -3
@@ -422,12 +422,13 @@ static void walk_pagetables(struct pg_stunsigned int i;unsigned long addr; + addr = st->start_address; +/* * Traverse the linux pagetable structure and dump pages that are in * the hash pagetable. */ -for (i =0 ; i <PTRS_PER_PGD ; i++, pgd++) { - addr =KERN_VIRT_START + i *PGDIR_SIZE ; +for (i =0 ; i <PTRS_PER_PGD ; i++, pgd++, addr +=PGDIR_SIZE ) {if (!pgd_none (*pgd) && !pgd_huge (*pgd))/* pgd exists */ walk_pud (st, pgd, addr);
@@ -476,9 +477,14 @@ static int ptdump_show(struct seq_file * {struct pg_state st = { .seq = m, - .start_address =KERN_VIRT_START , .marker = address_markers, }; + +if (radix_enabled ()) + st.start_address =PAGE_OFFSET ; +else + st.start_address =KERN_VIRT_START ; +/* Traverse kernel page tables */ walk_pagetables (&st);note_page (&st,0 ,0 ,0 );
Greg Kroah-Hartman
maintainerPATCH 4/124 powerpc/eeh: Fix possible null deref in eeh_dump_dev_log()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sam Bobroff <[email protected]>
[ Upstream commit f9bc28aedfb5bbd572d2d365f3095c1becd7209b ]
If an error occurs during an unplug operation, it's possible for eeh_dump_dev_log() to be called when edev->pdn is null, which currently leads to dereferencing a null pointer.
Handle this by skipping the error log for those devices.
--- arch/powerpc/kernel/eeh.c | 5 +++++ 1 file changed, 5 insertions(+)
arch/powerpc/kernel/eeh.c +5 -0
@@ -169,6 +169,11 @@ static size_t eeh_dump_dev_log(struct eeint n =0 , l =0 ;char buffer[128 ]; +if (!pdn) { +pr_warn ("EEH: Note: No error log for absent device.\n" ); +return 0 ; + } + n +=scnprintf (buf+n, len-n,"%04x:%02x:%02x.%01x\n" , pdn->phb->global_number, pdn->busno,PCI_SLOT (pdn->devfn),PCI_FUNC (pdn->devfn));
Greg Kroah-Hartman
maintainerPATCH 5/124 tty: check name length in tty_find_polling_driver()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Miles Chen <[email protected]>
[ Upstream commit 33a1a7be198657c8ca26ad406c4d2a89b7162bcc ]
The issue is found by a fuzzing test.
If tty_find_polling_driver() recevies an incorrect input such as ',,' or '0b', the len becomes 0 and strncmp() always return 0. In this case, a null p->ops->poll_init() is called and it causes a kernel panic.
Fix this by checking name length against zero in tty_find_polling_driver().
$echo ,, > /sys/module/kgdboc/parameters/kgdboc
[ 20.804451] WARNING: CPU: 1 PID: 104 at drivers/tty/serial/serial_core.c:457 uart_get_baud_rate+0xe8/0x190 [ 20.804917] Modules linked in: [ 20.805317] CPU: 1 PID: 104 Comm: sh Not tainted 4.19.0-rc7ajb #8 [ 20.805469] Hardware name: linux,dummy-virt (DT) [ 20.805732] pstate: 20000005 (nzCv daif -PAN -UAO) [ 20.805895] pc : uart_get_baud_rate+0xe8/0x190 [ 20.806042] lr : uart_get_baud_rate+0xc0/0x190 [ 20.806476] sp : ffffffc06acff940 [ 20.806676] x29: ffffffc06acff940 x28: 0000000000002580 [ 20.806977] x27: 0000000000009600 x26: 0000000000009600 [ 20.807231] x25: ffffffc06acffad0 x24: 00000000ffffeff0 [ 20.807576] x23: 0000000000000001 x22: 0000000000000000 [ 20.807807] x21: 0000000000000001 x20: 0000000000000000 [ 20.808049] x19: ffffffc06acffac8 x18: 0000000000000000 [ 20.808277] x17: 0000000000000000 x16: 0000000000000000 [ 20.808520] x15: ffffffffffffffff x14: ffffffff00000000 [ 20.808757] x13: ffffffffffffffff x12: 0000000000000001 [ 20.809011] x11: 0101010101010101 x10: ffffff880d59ff5f [ 20.809292] x9 : ffffff880d59ff5e x8 : ffffffc06acffaf3 [ 20.809549] x7 : 0000000000000000 x6 : ffffff880d59ff5f [ 20.809803] x5 : 0000000080008001 x4 : 0000000000000003 [ 20.810056] x3 : ffffff900853e6b4 x2 : dfffff9000000000 [ 20.810693] x1 : ffffffc06acffad0 x0 : 0000000000000cb0 [ 20.811005] Call trace: [ 20.811214] uart_get_baud_rate+0xe8/0x190 [ 20.811479] serial8250_do_set_termios+0xe0/0x6f4 [ 20.811719] serial8250_set_termios+0x48/0x54 [ 20.811928] uart_set_options+0x138/0x1bc [ 20.812129] uart_poll_init+0x114/0x16c [ 20.812330] tty_find_polling_driver+0x158/0x200 [ 20.812545] configure_kgdboc+0xbc/0x1bc [ 20.812745] param_set_kgdboc_var+0xb8/0x150 [ 20.812960] param_attr_store+0xbc/0x150 [ 20.813160] module_attr_store+0x40/0x58 [ 20.813364] sysfs_kf_write+0x8c/0xa8 [ 20.813563] kernfs_fop_write+0x154/0x290 [ 20.813764] vfs_write+0xf0/0x278 [ 20.813951] __arm64_sys_write+0x84/0xf4 [ 20.814400] el0_svc_common+0xf4/0x1dc [ 20.814616] el0_svc_handler+0x98/0xbc [ 20.814804] el0_svc+0x8/0xc [ 20.822005] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 20.826913] Mem abort info: [ 20.827103] ESR = 0x84000006 [ 20.827352] Exception class = IABT (current EL), IL = 16 bits [ 20.827655] SET = 0, FnV = 0 [ 20.827855] EA = 0, S1PTW = 0 [ 20.828135] user pgtable: 4k pages, 39-bit VAs, pgdp = (____ptrval____) [ 20.828484] [0000000000000000] pgd=00000000aadee003, pud=00000000aadee003, pmd=0000000000000000 [ 20.829195] Internal error: Oops: 84000006 [#1] SMP [ 20.829564] Modules linked in: [ 20.829890] CPU: 1 PID: 104 Comm: sh Tainted: G W 4.19.0-rc7ajb #8 [ 20.830545] Hardware name: linux,dummy-virt (DT) [ 20.830829] pstate: 60000085 (nZCv daIf -PAN -UAO) [ 20.831174] pc : (null) [ 20.831457] lr : serial8250_do_set_termios+0x358/0x6f4 [ 20.831727] sp : ffffffc06acff9b0 [ 20.831936] x29: ffffffc06acff9b0 x28: ffffff9008d7c000 [ 20.832267] x27: ffffff900969e16f x26: 0000000000000000 [ 20.832589] x25: ffffff900969dfb0 x24: 0000000000000000 [ 20.832906] x23: ffffffc06acffad0 x22: ffffff900969e160 [ 20.833232] x21: 0000000000000000 x20: ffffffc06acffac8 [ 20.833559] x19: ffffff900969df90 x18: 0000000000000000 [ 20.833878] x17: 0000000000000000 x16: 0000000000000000 [ 20.834491] x15: ffffffffffffffff x14: ffffffff00000000 [ 20.834821] x13: ffffffffffffffff x12: 0000000000000001 [ 20.835143] x11: 0101010101010101 x10: ffffff880d59ff5f [ 20.835467] x9 : ffffff880d59ff5e x8 : ffffffc06acffaf3 [ 20.835790] x7 : 0000000000000000 x6 : ffffff880d59ff5f [ 20.836111] x5 : c06419717c314100 x4 : 0000000000000007 [ 20.836419] x3 : 0000000000000000 x2 : 0000000000000000 [ 20.836732] x1 : 0000000000000001 x0 : ffffff900969df90 [ 20.837100] Process sh (pid: 104, stack limit = 0x(____ptrval____)) [ 20.837396] Call trace: [ 20.837566] (null) [ 20.837816] serial8250_set_termios+0x48/0x54 [ 20.838089] uart_set_options+0x138/0x1bc [ 20.838570] uart_poll_init+0x114/0x16c [ 20.838834] tty_find_polling_driver+0x158/0x200 [ 20.839119] configure_kgdboc+0xbc/0x1bc [ 20.839380] param_set_kgdboc_var+0xb8/0x150 [ 20.839658] param_attr_store+0xbc/0x150 [ 20.839920] module_attr_store+0x40/0x58 [ 20.840183] sysfs_kf_write+0x8c/0xa8 [ 20.840183] sysfs_kf_write+0x8c/0xa8 [ 20.840440] kernfs_fop_write+0x154/0x290 [ 20.840702] vfs_write+0xf0/0x278 [ 20.840942] __arm64_sys_write+0x84/0xf4 [ 20.841209] el0_svc_common+0xf4/0x1dc [ 20.841471] el0_svc_handler+0x98/0xbc [ 20.841713] el0_svc+0x8/0xc [ 20.842057] Code: bad PC value [ 20.842764] ---[ end trace a8835d7de79aaadf ]--- [ 20.843134] Kernel panic - not syncing: Fatal exception [ 20.843515] SMP: stopping secondary CPUs [ 20.844289] Kernel Offset: disabled [ 20.844634] CPU features: 0x0,21806002 [ 20.844857] Memory Limit: none [ 20.845172] ---[ end Kernel panic - not syncing: Fatal exception ]---
--- drivers/tty/tty_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/tty_io.c +1 -1
@@ -407,7 +407,7 @@ struct tty_driver *tty_find_polling_drivmutex_lock (&tty_mutex);/* Search through the tty devices to look for a match */ list_for_each_entry (p, &tty_drivers, tty_drivers) { -if (strncmp (name, p->name, len) !=0 ) +if (!len ||strncmp (name, p->name, len) !=0 )continue ; stp = str;if (*stp ==',' )
Greg Kroah-Hartman
maintainerPATCH 6/124 ARM: imx_v6_v7_defconfig: Select CONFIG_TMPFS_POSIX_ACL
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Fabio Estevam <[email protected]>
[ Upstream commit 35d3cbe84544da74e39e1cec01374092467e3119 ]
Andreas Müller reports:
"Fixes:
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[220]: Failed to apply ACL on /dev/v4l-subdev0: Operation not supported | Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[224]: Failed to apply ACL on /dev/v4l-subdev1: Operation not supported | Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[215]: Failed to apply ACL on /dev/v4l-subdev10: Operation not supported | Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[228]: Failed to apply ACL on /dev/v4l-subdev2: Operation not supported | Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[232]: Failed to apply ACL on /dev/v4l-subdev5: Operation not supported | Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[217]: Failed to apply ACL on /dev/v4l-subdev11: Operation not supported | Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[214]: Failed to apply ACL on /dev/dri/card1: Operation not supported | Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[216]: Failed to apply ACL on /dev/v4l-subdev8: Operation not supported | Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[226]: Failed to apply ACL on /dev/v4l-subdev9: Operation not supported
and nasty follow-ups: Starting weston from sddm as unpriviledged user fails with some hints on missing access rights."
Select the CONFIG_TMPFS_POSIX_ACL option to fix these issues.
--- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/configs/imx_v6_v7_defconfig +1 -0
@@ -383,6 +383,7 @@ CONFIG_ZISOFS=y CONFIG_UDF_FS=m CONFIG_MSDOS_FS=m CONFIG_VFAT_FS=y +CONFIG_TMPFS_POSIX_ACL=y CONFIG_JFFS2_FS=y CONFIG_UBIFS_FS=y CONFIG_NFS_FS=y
Greg Kroah-Hartman
maintainerPATCH 7/124 powerpc/nohash: fix undefined behaviour when testing page size support
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Daniel Axtens <[email protected]>
[ Upstream commit f5e284803a7206d43e26f9ffcae5de9626d95e37 ]
When enumerating page size definitions to check hardware support, we construct a constant which is (1U << (def->shift - 10)).
However, the array of page size definitions is only initalised for various MMU_PAGE_* constants, so it contains a number of 0-initialised elements with def->shift == 0. This means we end up shifting by a very large number, which gives the following UBSan splat:
================================================================================
UBSAN: Undefined behaviour in /home/dja/dev/linux/linux/arch/powerpc/mm/tlb_nohash.c:506:21 shift exponent 4294967286 is too large for 32-bit type 'unsigned int' CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc3-00045-ga604f927b012-dirty #6 Call Trace: [c00000000101bc20] [c000000000a13d54] .dump_stack+0xa8/0xec (unreliable) [c00000000101bcb0] [c0000000004f20a8] .ubsan_epilogue+0x18/0x64 [c00000000101bd30] [c0000000004f2b10] .__ubsan_handle_shift_out_of_bounds+0x110/0x1a4 [c00000000101be20] [c000000000d21760] .early_init_mmu+0x1b4/0x5a0 [c00000000101bf10] [c000000000d1ba28] .early_setup+0x100/0x130 [c00000000101bf90] [c000000000000528] start_here_multiplatform+0x68/0x80 ================================================================================
Fix this by first checking if the element exists (shift != 0) before constructing the constant.
--- arch/powerpc/mm/tlb_nohash.c | 3 +++ 1 file changed, 3 insertions(+)
arch/powerpc/mm/tlb_nohash.c +3 -0
@@ -500,6 +500,9 @@ static void setup_page_sizes(void)for (psize =0 ; psize <MMU_PAGE_COUNT ; ++psize) {struct mmu_psize_def *def = &mmu_psize_defs[psize]; +if (!def->shift) +continue ; +if (tlb1ps & (1U << (def->shift -10 ))) { def->flags |=MMU_PAGE_SIZE_DIRECT ;
Greg Kroah-Hartman
maintainerPATCH 8/124 powerpc/mm: Dont report hugepage tables as memory leaks when using kmemleak
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christophe Leroy <[email protected]>
[ Upstream commit 803d690e68f0c5230183f1a42c7d50a41d16e380 ]
When a process allocates a hugepage, the following leak is reported by kmemleak. This is a false positive which is due to the pointer to the table being stored in the PGD as physical memory address and not virtual memory pointer.
unreferenced object 0xc30f8200 (size 512):
comm "mmap", pid 374, jiffies 4872494 (age 627.630s) hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<e32b68da>] huge_pte_alloc+0xdc/0x1f8
[<9e0df1e1>] hugetlb_fault+0x560/0x8f8
[<7938ec6c>] follow_hugetlb_page+0x14c/0x44c
[<afbdb405>] __get_user_pages+0x1c4/0x3dc
[<b8fd7cd9>] __mm_populate+0xac/0x140
[<3215421e>] vm_mmap_pgoff+0xb4/0xb8
[<c148db69>] ksys_mmap_pgoff+0xcc/0x1fc
[<4fcd760f>] ret_from_syscall+0x0/0x38See commit a984506c542e2 ("powerpc/mm: Don't report PUDs as memory leaks when using kmemleak") for detailed explanation.
To fix that, this patch tells kmemleak to ignore the allocated hugepage table.
--- arch/powerpc/mm/hugetlbpage.c | 3 +++ 1 file changed, 3 insertions(+)
arch/powerpc/mm/hugetlbpage.c +3 -0
@@ -19,6 +19,7 @@#include <linux/moduleparam.h> #include <linux/swap.h> #include <linux/swapops.h> +#include <linux/kmemleak.h> #include <asm/pgtable.h> #include <asm/pgalloc.h> #include <asm/tlb.h>
@@ -110,6 +111,8 @@ static int __hugepte_alloc(struct mm_strfor (i = i -1 ; i >=0 ; i--, hpdp--) *hpdp =__hugepd (0 );kmem_cache_free (cachep, new); + }else { +kmemleak_ignore (new); }spin_unlock (&mm->page_table_lock);return 0 ;
Greg Kroah-Hartman
maintainerPATCH 9/124 drm/omap: fix memory barrier bug in DMM driver
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tomi Valkeinen <[email protected]>
[ Upstream commit 538f66ba204944470a653a4cccc5f8befdf97c22 ]
A DMM timeout "timed out waiting for done" has been observed on DRA7 devices. The timeout happens rarely, and only when the system is under heavy load.
Debugging showed that the timeout can be made to happen much more frequently by optimizing the DMM driver, so that there's almost no code between writing the last DMM descriptors to RAM, and writing to DMM register which starts the DMM transaction.
The current theory is that a wmb() does not properly ensure that the data written to RAM is observable by all the components in the system.
This DMM timeout has caused interesting (and rare) bugs as the error handling was not functioning properly (the error handling has been fixed in previous commits):
* If a DMM timeout happened when a GEM buffer was being pinned for display on the screen, a timeout error would be shown, but the driver would continue programming DSS HW with broken buffer, leading to SYNCLOST floods and possible crashes.
* If a DMM timeout happened when other user (say, video decoder) was pinning a GEM buffer, a timeout would be shown but if the user handled the error properly, no other issues followed.
* If a DMM timeout happened when a GEM buffer was being released, the driver does not even notice the error, leading to crashes or hang later.
This patch adds wmb() and readl() calls after the last bit is written to RAM, which should ensure that the execution proceeds only after the data is actually in RAM, and thus observable by DMM.
The read-back should not be needed. Further study is required to understand if DMM is somehow special case and read-back is ok, or if DRA7's memory barriers do not work correctly.
--- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c +11 -0
@@ -273,6 +273,17 @@ static int dmm_txn_commit(struct dmm_txn } txn->last_pat->next_pa =0 ; +/* ensure that the written descriptors are visible to DMM */ +wmb (); + +/* +* NOTE: the wmb() above should be enough, but there seems to be a bug +* in OMAP's memory barrier implementation, which in some rare cases may +* cause the writes not to be observable after wmb(). +*/ + +/* read back to ensure the data is in RAM */ +readl (&txn->last_pat->next_pa);/* write to PAT_DESCR to clear out any pending transaction */ dmm_write (dmm,0x0 , reg[PAT_DESCR ][engine->id]);
Greg Kroah-Hartman
maintainerPATCH 10/124 drm/hisilicon: hibmc: Do not carry error code in HiBMC framebuffer pointer
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: John Garry <[email protected]>
[ Upstream commit 331d880b35a76b5de0eec8cbcecbf615d758a5f9 ]
In hibmc_drm_fb_create(), when the call to hibmc_framebuffer_init() fails with error, do not store the error code in the HiBMC device frame-buffer pointer, as this will be later checked for non-zero value in hibmc_fbdev_destroy() when our intention is to check for a valid function pointer.
This fixes the following crash:
[ 9.699791] Unable to handle kernel NULL pointer dereference at virtual address 000000000000001a [ 9.708672] Mem abort info: [ 9.711489] ESR = 0x96000004 [ 9.714570] Exception class = DABT (current EL), IL = 32 bits [ 9.720551] SET = 0, FnV = 0 [ 9.723631] EA = 0, S1PTW = 0 [ 9.726799] Data abort info: [ 9.729702] ISV = 0, ISS = 0x00000004 [ 9.733573] CM = 0, WnR = 0 [ 9.736566] [000000000000001a] user address but active_mm is swapper [ 9.742987] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 9.748614] Modules linked in: [ 9.751694] CPU: 16 PID: 293 Comm: kworker/16:1 Tainted: G W 4.19.0-rc4-next-20180920-00001-g9b0012c #322 [ 9.762681] Hardware name: Huawei Taishan 2280 /D05, BIOS Hisilicon D05 IT21 Nemo 2.0 RC0 04/18/2018 [ 9.771915] Workqueue: events work_for_cpu_fn [ 9.776312] pstate: 60000005 (nZCv daif -PAN -UAO) [ 9.781150] pc : drm_mode_object_put+0x0/0x20 [ 9.785547] lr : hibmc_fbdev_fini+0x40/0x58 [ 9.789767] sp : ffff00000af1bcf0 [ 9.793108] x29: ffff00000af1bcf0 x28: 0000000000000000 [ 9.798473] x27: 0000000000000000 x26: ffff000008f66630 [ 9.803838] x25: 0000000000000000 x24: ffff0000095abb98 [ 9.809203] x23: ffff8017db92fe00 x22: ffff8017d2b13000 [ 9.814568] x21: ffffffffffffffea x20: ffff8017d2f80018 [ 9.819933] x19: ffff8017d28a0018 x18: ffffffffffffffff [ 9.825297] x17: 0000000000000000 x16: 0000000000000000 [ 9.830662] x15: ffff0000092296c8 x14: ffff00008939970f [ 9.836026] x13: ffff00000939971d x12: ffff000009229940 [ 9.841391] x11: ffff0000085f8fc0 x10: ffff00000af1b9a0 [ 9.846756] x9 : 000000000000000d x8 : 6620657a696c6169 [ 9.852121] x7 : ffff8017d3340580 x6 : ffff8017d4168000 [ 9.857486] x5 : 0000000000000000 x4 : ffff8017db92fb20 [ 9.862850] x3 : 0000000000002690 x2 : ffff8017d3340480 [ 9.868214] x1 : 0000000000000028 x0 : 0000000000000002 [ 9.873580] Process kworker/16:1 (pid: 293, stack limit = 0x(____ptrval____)) [ 9.880788] Call trace: [ 9.883252] drm_mode_object_put+0x0/0x20 [ 9.887297] hibmc_unload+0x1c/0x80 [ 9.890815] hibmc_pci_probe+0x170/0x3c8 [ 9.894773] local_pci_probe+0x3c/0xb0 [ 9.898555] work_for_cpu_fn+0x18/0x28 [ 9.902337] process_one_work+0x1e0/0x318 [ 9.906382] worker_thread+0x228/0x450 [ 9.910164] kthread+0x128/0x130 [ 9.913418] ret_from_fork+0x10/0x18 [ 9.917024] Code: a94153f3 a8c27bfd d65f03c0 d503201f (f9400c01) [ 9.923180] ---[ end trace 2695ffa0af5be375 ]---
--- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c +1 -0
@@ -122,6 +122,7 @@ static int hibmc_drm_fb_create(struct dr hi_fbdev->fb =hibmc_framebuffer_init (priv->dev, &mode_cmd, gobj);if (IS_ERR (hi_fbdev->fb)) { ret =PTR_ERR (hi_fbdev->fb); + hi_fbdev->fb =NULL ;DRM_ERROR ("failed to initialize framebuffer: %d\n" , ret); goto out_release_fbi; }
Greg Kroah-Hartman
maintainerPATCH 11/124 media: pci: cx23885: handle adding to list failure
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nicholas Mc Guire <[email protected]>
[ Upstream commit c5d59528e24ad22500347b199d52b9368e686a42 ]
altera_hw_filt_init() which calls append_internal() assumes that the node was successfully linked in while in fact it can silently fail. So the call-site needs to set return to -ENOMEM on append_internal() returning NULL and exit through the err path.
--- drivers/media/pci/cx23885/altera-ci.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/media/pci/cx23885/altera-ci.c +10 -0
@@ -665,6 +665,10 @@ static int altera_hw_filt_init(struct al } temp_int =append_internal (inter); +if (!temp_int) { + ret = -ENOMEM ; + goto err; + } inter->filts_used =1 ; inter->dev = config->dev; inter->fpga_rw = config->fpga_rw;
@@ -699,6 +703,7 @@ err: __func__, ret);kfree (pid_filt); +kfree (inter);return ret; }
@@ -733,6 +738,10 @@ int altera_ci_init(struct altera_ci_conf } temp_int =append_internal (inter); +if (!temp_int) { + ret = -ENOMEM ; + goto err; + } inter->cis_used =1 ; inter->dev = config->dev; inter->fpga_rw = config->fpga_rw;
@@ -801,6 +810,7 @@ err:ci_dbg_print ("%s: Cannot initialize CI: Error %d.\n" , __func__, ret);kfree (state); +kfree (inter);return ret; }
Greg Kroah-Hartman
maintainerPATCH 12/124 media: coda: dont overwrite h.264 profile_idc on decoder instance
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lucas Stach <[email protected]>
[ Upstream commit 1f32061e843205f6fe8404d5100d5adcec334e75 ]
On a decoder instance, after the profile has been parsed from the stream __v4l2_ctrl_s_ctrl() is called to notify userspace about changes in the read-only profile control. This ends up calling back into the CODA driver where a missing check on the s_ctrl caused the profile information that has just been parsed from the stream to be overwritten with the default baseline profile.
Later on the driver fails to enable frame reordering, based on the wrong profile information.
profile/level controls)
--- drivers/media/platform/coda/coda-common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/platform/coda/coda-common.c +2 -1
@@ -1686,7 +1686,8 @@ static int coda_s_ctrl(struct v4l2_ctrlbreak ;case V4L2_CID_MPEG_VIDEO_H264_PROFILE :/* TODO: switch between baseline and constrained baseline */ - ctx->params.h264_profile_idc =66 ; +if (ctx->inst_type ==CODA_INST_ENCODER ) + ctx->params.h264_profile_idc =66 ;break ;case V4L2_CID_MPEG_VIDEO_H264_LEVEL :/* nothing to do, this is set by the encoder */
Greg Kroah-Hartman
maintainerPATCH 13/124 MIPS: kexec: Mark CPU offline before disabling local IRQ
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dengcheng Zhu <[email protected]>
[ Upstream commit dc57aaf95a516f70e2d527d8287a0332c481a226 ]
After changing CPU online status, it will not be sent any IPIs such as in __flush_cache_all() on software coherency systems. Do this before disabling local IRQ.
Patchwork: https://patchwork.linux-mips.org/patch/20571/
--- arch/mips/kernel/crash.c | 3 +++ arch/mips/kernel/machine_kexec.c | 3 +++ 2 files changed, 6 insertions(+)
arch/mips/kernel/crash.c +3 -0
@@ -36,6 +36,9 @@ static void crash_shutdown_secondary(voiif (!cpu_online (cpu))return ; +/* We won't be sent IPIs any more. */ +set_cpu_online (cpu, false); +local_irq_disable ();if (!cpumask_test_cpu (cpu, &cpus_in_crash))crash_save_cpu (regs, cpu);
arch/mips/kernel/machine_kexec.c +3 -0
@@ -118,6 +118,9 @@ machine_kexec(struct kimage *image) *ptr = (unsigned long )phys_to_virt (*ptr); } +/* Mark offline BEFORE disabling local irq. */ +set_cpu_online (smp_processor_id (), false); +/* * we do not want to be bothered. */
Greg Kroah-Hartman
maintainerPATCH 14/124 powerpc/boot: Ensure _zimage_start is a weak symbol
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Joel Stanley <[email protected]>
[ Upstream commit ee9d21b3b3583712029a0db65a4b7c081d08d3b3 ]
When building with clang crt0's _zimage_start is not marked weak, which breaks the build when linking the kernel image:
$ objdump -t arch/powerpc/boot/crt0.o |grep _zimage_start$ 0000000000000058 g .text 0000000000000000 _zimage_start
ld: arch/powerpc/boot/wrapper.a(crt0.o): in function '_zimage_start':
(.text+0x58): multiple definition of '_zimage_start'; arch/powerpc/boot/pseries-head.o:(.text+0x0): first defined here
Clang requires the .weak directive to appear after the symbol is declared. The binutils manual says:
This directive sets the weak attribute on the comma separated list of symbol names. If the symbols do not already exist, they will be created.
So it appears this is different with clang. The only reference I could see for this was an OpenBSD mailing list post[1].
Changing it to be after the declaration fixes building with Clang, and still works with GCC.
$ objdump -t arch/powerpc/boot/crt0.o |grep _zimage_start$ 0000000000000058 w .text 0000000000000000 _zimage_start
Reported to clang as https://bugs.llvm.org/show_bug.cgi?id=38921
[1] https://groups.google.com/forum/#!topic/fa.openbsd.tech/PAgKKen2YCY
--- arch/powerpc/boot/crt0.S | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
arch/powerpc/boot/crt0.S +3 -1
@@ -47,8 +47,10 @@ p_end: .long _end p_pstack: .long _platform_stack_top #endif - .weak _zimage_start .globl _zimage_start + /* Clang appears to require the .weak directive to be after the symbol + * is defined. See https://bugs.llvm.org/show_bug.cgi?id=38921 */ + .weak _zimage_start _zimage_start: .globl _zimage_start_lib _zimage_start_lib:
Greg Kroah-Hartman
maintainerPATCH 15/124 powerpc/memtrace: Remove memory in chunks
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Rashmica Gupta <[email protected]>
[ Upstream commit 3f7daf3d7582dc6628ac40a9045dd1bbd80c5f35 ]
When hot-removing memory release_mem_region_adjustable() splits iomem resources if they are not the exact size of the memory being hot-deleted. Adding this memory back to the kernel adds a new resource.
Eg a node has memory 0x0 - 0xfffffffff. Hot-removing 1GB from 0xf40000000 results in the single resource 0x0-0xfffffffff being split into two resources: 0x0-0xf3fffffff and 0xf80000000-0xfffffffff.
When we hot-add the memory back we now have three resources:
0x0-0xf3fffffff, 0xf40000000-0xf7fffffff, and 0xf80000000-0xfffffffff.
This is an issue if we try to remove some memory that overlaps resources. Eg when trying to remove 2GB at address 0xf40000000, release_mem_region_adjustable() fails as it expects the chunk of memory to be within the boundaries of a single resource. We then get the
warning: "Unable to release resource" and attempting to use memtrace again gives us this error: "bash: echo: write error: Resource temporarily unavailable"
This patch makes memtrace remove memory in chunks that are always the same size from an address that is always equal to end_of_memory - n*size, for some n. So hotremoving and hotadding memory of different sizes will now not attempt to remove memory that spans multiple resources.
--- arch/powerpc/platforms/powernv/memtrace.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-)
arch/powerpc/platforms/powernv/memtrace.c +16 -5
@@ -119,17 +119,15 @@ static bool memtrace_offline_pages(u32 nwalk_memory_range (start_pfn, end_pfn, (void *)MEM_OFFLINE , change_memblock_state); -lock_device_hotplug (); -remove_memory (nid, start_pfn <<PAGE_SHIFT , nr_pages <<PAGE_SHIFT ); -unlock_device_hotplug ();return true; }static u64 memtrace_alloc_node (u32 nid,u64 size) { -u64 start_pfn, end_pfn, nr_pages; +u64 start_pfn, end_pfn, nr_pages, pfn;u64 base_pfn; +u64 bytes =memory_block_size_bytes ();if (!NODE_DATA (nid) || !node_spanned_pages (nid))return 0 ;
@@ -142,8 +140,21 @@ static u64 memtrace_alloc_node(u32 nid, end_pfn =round_down (end_pfn - nr_pages, nr_pages);for (base_pfn = end_pfn; base_pfn > start_pfn; base_pfn -= nr_pages) { -if (memtrace_offline_pages (nid, base_pfn, nr_pages) == true) +if (memtrace_offline_pages (nid, base_pfn, nr_pages) == true) { +/* +* Remove memory in memory block size chunks so that +* iomem resources are always split to the same size and +* we never try to remove memory that spans two iomem +* resources. +*/ +lock_device_hotplug (); + end_pfn = base_pfn + nr_pages; +for (pfn = base_pfn; pfn < end_pfn; pfn += bytes>>PAGE_SHIFT ) { +remove_memory (nid, pfn <<PAGE_SHIFT , bytes); + } +unlock_device_hotplug ();return base_pfn <<PAGE_SHIFT ; + } }return 0 ;
Greg Kroah-Hartman
maintainerPATCH 16/124 MIPS/PCI: Call pcie_bus_configure_settings() to set MPS/MRRS
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Huacai Chen <[email protected]>
[ Upstream commit 2794f688b2c336e0da85e9f91fed33febbd9f54a ]
Call pcie_bus_configure_settings() on MIPS, like for other platforms. The function pcie_bus_configure_settings() makes sure the MPS (Max Payload Size) across the bus is uniform and provides the ability to tune the MRSS (Max Read Request Size) and MPS (Max Payload Size) to higher performance values. Some devices will not operate properly if these aren't set correctly because the firmware doesn't always do it.
Patchwork: https://patchwork.linux-mips.org/patch/20649/
--- arch/mips/pci/pci-legacy.c | 4 ++++ 1 file changed, 4 insertions(+)
arch/mips/pci/pci-legacy.c +4 -0
@@ -127,8 +127,12 @@ static void pcibios_scanbus(struct pci_cif (pci_has_flag (PCI_PROBE_ONLY )) {pci_bus_claim_resources (bus); }else { +struct pci_bus *child; +pci_bus_size_bridges (bus);pci_bus_assign_resources (bus); +list_for_each_entry (child, &bus->children, node) +pcie_bus_configure_settings (child); }pci_bus_add_devices (bus); }
Greg Kroah-Hartman
maintainerPATCH 17/124 sc16is7xx: Fix for multi-channel stall
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Phil Elwell <[email protected]>
[ Upstream commit 8344498721059754e09d30fe255a12dab8fb03ef ]
The SC16IS752 is a dual-channel device. The two channels are largely independent, but the IRQ signals are wired together as an open-drain, active low signal which will be driven low while either of the channels requires attention, which can be for significant periods of time until operations complete and the interrupt can be acknowledged. In that respect it is should be treated as a true level-sensitive IRQ.
The kernel, however, needs to be able to exit interrupt context in order to use I2C or SPI to access the device registers (which may involve sleeping). Therefore the interrupt needs to be masked out or paused in some way.
The usual way to manage sleeping from within an interrupt handler is to use a threaded interrupt handler - a regular interrupt routine does the minimum amount of work needed to triage the interrupt before waking the interrupt service thread. If the threaded IRQ is marked as IRQF_ONESHOT the kernel will automatically mask out the interrupt until the thread runs to completion. The sc16is7xx driver used to use a threaded IRQ, but a patch switched to using a kthread_worker in order to set realtime priorities on the handler thread and for other optimisations. The end result is non-threaded IRQ that schedules some work then returns IRQ_HANDLED, making the kernel think that all IRQ processing has completed.
The work-around to prevent a constant stream of interrupts is to mark the interrupt as edge-sensitive rather than level-sensitive, but interpreting an active-low source as a falling-edge source requires care to prevent a total cessation of interrupts. Whereas an edge-triggering source will generate a new edge for every interrupt condition a level-triggering source will keep the signal at the interrupting level until it no longer requires attention; in other words, the host won't see another edge until all interrupt conditions are cleared. It is therefore vital that the interrupt handler does not exit with an outstanding interrupt condition, otherwise the kernel will not receive another interrupt unless some other operation causes the interrupt state on the device to be cleared.
The existing sc16is7xx driver has a very simple interrupt "thread" (kthread_work job) that processes interrupts on each channel in turn until there are no more. If both channels are active and the first channel starts interrupting while the handler for the second channel is running then it will not be detected and an IRQ stall ensues. This could be handled easily if there was a shared IRQ status register, or a convenient way to determine if the IRQ had been deasserted for any length of time, but both appear to be lacking.
Avoid this problem (or at least make it much less likely to happen) by reducing the granularity of per-channel interrupt processing to one condition per iteration, only exiting the overall loop when both channels are no longer interrupting.
--- drivers/tty/serial/sc16is7xx.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-)
drivers/tty/serial/sc16is7xx.c +13 -6
@@ -662,7 +662,7 @@ static void sc16is7xx_handle_tx(struct uuart_write_wakeup (port); } -static void sc16is7xx_port_irq (struct sc16is7xx_port *s,int portno) +static bool sc16is7xx_port_irq (struct sc16is7xx_port *s,int portno) {struct uart_port *port = &s->p[portno].port;
@@ -671,7 +671,7 @@ static void sc16is7xx_port_irq(struct sc iir =sc16is7xx_port_read (port,SC16IS7XX_IIR_REG );if (iir &SC16IS7XX_IIR_NO_INT_BIT ) -break ; +return false; iir &=SC16IS7XX_IIR_ID_MASK ;
@@ -693,16 +693,23 @@ static void sc16is7xx_port_irq(struct sc port->line, iir);break ; } - }while (1 ); + }while (0 ); +return true; }static void sc16is7xx_ist (struct kthread_work *ws) {struct sc16is7xx_port *s =to_sc16is7xx_port (ws, irq_work); -int i; -for (i =0 ; i < s->devtype->nr_uart; ++i) -sc16is7xx_port_irq (s, i); +while (1 ) { +bool keep_polling = false; +int i; + +for (i =0 ; i < s->devtype->nr_uart; ++i) + keep_polling |=sc16is7xx_port_irq (s, i); +if (!keep_polling) +break ; + } }static irqreturn_t sc16is7xx_irq (int irq,void *dev_id)
Greg Kroah-Hartman
maintainerPATCH 18/124 media: tvp5150: fix width alignment during set_selection()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Marco Felsch <[email protected]>
[ Upstream commit bd24db04101f45a9c1d874fe21b0c7eab7bcadec ]
The driver ignored the width alignment which exists due to the UYVY colorspace format. Fix the width alignment and make use of the the provided v4l2 helper function to set the width, height and all alignments in one.
--- drivers/media/i2c/tvp5150.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
drivers/media/i2c/tvp5150.c +9 -5
@@ -900,9 +900,6 @@ static int tvp5150_set_selection(struct/* tvp5150 has some special limits */ rect.left =clamp (rect.left,0 ,TVP5150_MAX_CROP_LEFT ); - rect.width = clamp_t(unsigned int, rect.width, -TVP5150_H_MAX -TVP5150_MAX_CROP_LEFT - rect.left, -TVP5150_H_MAX - rect.left); rect.top =clamp (rect.top,0 ,TVP5150_MAX_CROP_TOP );/* Calculate height based on current standard */
@@ -916,9 +913,16 @@ static int tvp5150_set_selection(structelse hmax =TVP5150_V_MAX_OTHERS ; - rect.height = clamp_t(unsigned int, rect.height, +/* +* alignments: +* - width = 2 due to UYVY colorspace +* - height, image = no special alignment +*/ +v4l_bound_align_image (&rect.width, +TVP5150_H_MAX -TVP5150_MAX_CROP_LEFT - rect.left, +TVP5150_H_MAX - rect.left,1 , &rect.height, hmax -TVP5150_MAX_CROP_TOP - rect.top, - hmax - rect.top); + hmax - rect.top,0 ,0 );tvp5150_write (sd,TVP5150_VERT_BLANKING_START , rect.top); tvp5150_write(sd, TVP5150_VERT_BLANKING_STOP,
Greg Kroah-Hartman
maintainerPATCH 19/124 powerpc/selftests: Wait all threads to join
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Breno Leitao <[email protected]>
[ Upstream commit 693b31b2fc1636f0aa7af53136d3b49f6ad9ff39 ]
Test tm-tmspr might exit before all threads stop executing, because it just waits for the very last thread to join before proceeding/exiting.
This patch makes sure that all threads that were created will join before proceeding/exiting.
This patch also guarantees that the amount of threads being created is equal to thread_num.
--- tools/testing/selftests/powerpc/tm/tm-tmspr.c | 27 ++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-)
tools/testing/selftests/powerpc/tm/tm-tmspr.c +17 -10
@@ -98,7 +98,7 @@ void texasr(void *in)int test_tmspr () { -pthread_t thread; +pthread_t *thread;int thread_num;unsigned long i;
@@ -107,21 +107,28 @@ int test_tmspr()/* To cause some context switching */ thread_num =10 *sysconf (_SC_NPROCESSORS_ONLN); + thread =malloc (thread_num *sizeof (pthread_t)); +if (thread ==NULL ) +return EXIT_FAILURE ; +/* Test TFIAR and TFHAR */ -for (i =0 ; i < thread_num ; i +=2 ){ -if (pthread_create (&thread,NULL , (void *)tfiar_tfhar, (void *)i)) +for (i =0 ; i < thread_num; i +=2 ) { +if (pthread_create (&thread[i],NULL , (void *)tfiar_tfhar, + (void *)i))return EXIT_FAILURE ; } -if (pthread_join (thread,NULL ) !=0 ) -return EXIT_FAILURE ; -/* Test TEXASR */ -for (i =0 ; i < thread_num ; i++){ -if (pthread_create (&thread,NULL , (void *)texasr, (void *)i)) +for (i =1 ; i < thread_num; i +=2 ) { +if (pthread_create (&thread[i],NULL , (void *)texasr, (void *)i))return EXIT_FAILURE ; } -if (pthread_join (thread,NULL ) !=0 ) -return EXIT_FAILURE ; + +for (i =0 ; i < thread_num; i++) { +if (pthread_join (thread[i],NULL ) !=0 ) +return EXIT_FAILURE ; + } + +free (thread);if (passed)return 0 ;
Greg Kroah-Hartman
maintainerPATCH 20/124 staging:iio:ad7606: fix voltage scales
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alexandru Ardelean <[email protected]>
[ Upstream commit 4ee033301c898dd0835d035d0e0eb768a3d35da1 ]
Fixes commit 17be2a2905a6ec9aa27cd59521495e2f490d2af0 ("staging: iio:
ad7606: replace range/range_available with corresponding scale").
The AD7606 devices don't have a 2.5V voltage range, they have 5V & 10V voltage range, which is selectable via the gpio_range descriptor.
The scales also seem to have been miscomputed, because when they were applied to the raw values, the results differ from the expected values. After checking the ADC transfer function in the datasheet, these were re-computed.
--- drivers/staging/iio/adc/ad7606.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/iio/adc/ad7606.c +5 -2
@@ -26,9 +26,12 @@#include "ad7606.h" -/* Scales are computed as 2.5/2**16 and 5/2**16 respectively */ +/* +* Scales are computed as 5000/32768 and 10000/32768 respectively, +* so that when applied to the raw values they provide mV values +*/ static const unsigned int scale_avail[2 ][2 ] = { - {0 ,38147 }, {0 ,76294 } + {0 ,152588 }, {0 ,305176 } };static int ad7606_reset (struct ad7606_state *st)
Greg Kroah-Hartman
maintainerPATCH 21/124 9p locks: fix glock.client_id leak in do_lock
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominique Martinet <[email protected]>
[ Upstream commit b4dc44b3cac9e8327e0655f530ed0c46f2e6214c ]
the 9p client code overwrites our glock.client_id pointing to a static buffer by an allocated string holding the network provided value which we do not care about; free and reset the value as appropriate.
This is almost identical to the leak in v9fs_file_getlock() fixed by Al Viro in commit ce85dd58ad5a6 ("9p: we are leaking glock.client_id in v9fs_file_getlock()"), which was returned as an error by a coverity false positive -- while we are here attempt to make the code slightly more robust to future change of the net/9p/client code and hopefully more clear to coverity that there is no problem.
--- fs/9p/vfs_file.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
fs/9p/vfs_file.c +14 -2
@@ -204,6 +204,14 @@ static int v9fs_file_do_lock(struct filebreak ;if (schedule_timeout_interruptible (P9_LOCK_TIMEOUT ) !=0 )break ; +/* +* p9_client_lock_dotl overwrites flock.client_id with the +* server message, free and reuse the client name +*/ +if (flock.client_id != fid->clnt->name) { +kfree (flock.client_id); + flock.client_id = fid->clnt->name; + } }/* map 9p status to VFS status */
@@ -235,6 +243,8 @@ out_unlock:locks_lock_file_wait (filp, fl); fl->fl_type = fl_type; } +if (flock.client_id != fid->clnt->name) +kfree (flock.client_id); out:return res; }
@@ -269,7 +279,7 @@ static int v9fs_file_getlock(struct file res =p9_client_getlock_dotl (fid, &glock);if (res <0 ) -return res; + goto out;/* map 9p lock type to os lock type */ switch (glock.type) {case P9_LOCK_TYPE_RDLCK :
@@ -290,7 +300,9 @@ static int v9fs_file_getlock(struct file fl->fl_end = glock.start + glock.length -1 ; fl->fl_pid = -glock.proc_id; } -kfree (glock.client_id); +out: +if (glock.client_id != fid->clnt->name) +kfree (glock.client_id);return res; }
Greg Kroah-Hartman
maintainerPATCH 22/124 9p: clear dangling pointers in p9stat_free
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dominique Martinet <[email protected]>
[ Upstream commit 62e3941776fea8678bb8120607039410b1b61a65 ]
p9stat_free is more of a cleanup function than a 'free' function as it only frees the content of the struct; there are chances of use-after-free if it is improperly used (e.g. p9stat_free called twice as it used to be possible to)
Clearing dangling pointers makes the function idempotent and safer to use.
--- net/9p/protocol.c | 5 +++++ 1 file changed, 5 insertions(+)
net/9p/protocol.c +5 -0
@@ -46,10 +46,15 @@ p9pdu_writef(struct p9_fcall *pdu, int pvoid p9stat_free (struct p9_wstat *stbuf) {kfree (stbuf->name); + stbuf->name =NULL ;kfree (stbuf->uid); + stbuf->uid =NULL ;kfree (stbuf->gid); + stbuf->gid =NULL ;kfree (stbuf->muid); + stbuf->muid =NULL ;kfree (stbuf->extension); + stbuf->extension =NULL ; }EXPORT_SYMBOL (p9stat_free);
Greg Kroah-Hartman
maintainerPATCH 23/124 cdrom: fix improper type cast, which can leat to information leak.
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Young_X <[email protected]>
commit e4f3aa2e1e67bb48dfbaaf1cad59013d5a5bc276 upstream.
There is another cast from unsigned long to int which causes a bounds check to fail with specially crafted input. The value is then used as an index in the slot array in cdrom_slot_status().
This issue is similar to CVE-2018-16658 and CVE-2018-10940.
--- drivers/cdrom/cdrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cdrom/cdrom.c +1 -1
@@ -2441,7 +2441,7 @@ static int cdrom_ioctl_select_disc(strucreturn -ENOSYS ;if (arg !=CDSL_CURRENT && arg !=CDSL_NONE ) { -if ((int )arg >= cdi->capacity) +if (arg >= cdi->capacity)return -EINVAL ; }
Greg Kroah-Hartman
maintainerPATCH 24/124 ovl: fix error handling in ovl_verify_set_fh()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Amir Goldstein <[email protected]>
commit babf4770be0adc69e6d2de150f4040f175e24beb upstream.
We hit a BUG on kfree of an ERR_PTR()...
--- fs/overlayfs/namei.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/overlayfs/namei.c +3 -1
@@ -368,8 +368,10 @@ int ovl_verify_origin(struct dentry *den fh =ovl_encode_fh (origin, is_upper); err =PTR_ERR (fh); -if (IS_ERR (fh)) +if (IS_ERR (fh)) { + fh =NULL ; goto fail; + } err =ovl_verify_origin_fh (dentry, fh);if (set && err == -ENODATA )
Greg Kroah-Hartman
maintainerPATCH 25/124 scsi: qla2xxx: Fix incorrect port speed being set for FC adapters
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Himanshu Madhani <[email protected]>
commit 4c1458df9635c7e3ced155f594d2e7dfd7254e21 upstream.
--- drivers/scsi/qla2xxx/qla_mbx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/scsi/qla2xxx/qla_mbx.c +1 -4
@@ -3682,10 +3682,7 @@ qla2x00_set_idma_speed(scsi_qla_host_t * mcp->mb[0 ] =MBC_PORT_PARAMS ; mcp->mb[1 ] = loop_id; mcp->mb[2 ] =BIT_0 ; -if (IS_CNA_CAPABLE (vha->hw)) - mcp->mb[3 ] = port_speed & (BIT_5 |BIT_4 |BIT_3 |BIT_2 |BIT_1 |BIT_0 ); -else - mcp->mb[3 ] = port_speed & (BIT_2 |BIT_1 |BIT_0 ); + mcp->mb[3 ] = port_speed & (BIT_5 |BIT_4 |BIT_3 |BIT_2 |BIT_1 |BIT_0 ); mcp->mb[9 ] = vha->vp_idx; mcp->out_mb =MBX_9 |MBX_3 |MBX_2 |MBX_1 |MBX_0 ; mcp->in_mb =MBX_3 |MBX_1 |MBX_0 ;
Greg Kroah-Hartman
maintainerPATCH 26/124 scsi: qla2xxx: Fix process response queue for ISP26XX and above
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Quinn Tran <[email protected]>
commit b86ac8fd4b2f6ec2f9ca9194c56eac12d620096f upstream.
This patch improves performance for 16G and above adapter by removing additional call to process_response_queue().
[mkp: typo]
--- drivers/scsi/qla2xxx/qla_init.c | 2 -- drivers/scsi/qla2xxx/qla_iocb.c | 17 ----------------- 2 files changed, 19 deletions(-)
drivers/scsi/qla2xxx/qla_init.c +0 -2
@@ -7591,7 +7591,6 @@ qla81xx_nvram_config(scsi_qla_host_t *vh } icb->firmware_options_2 &=cpu_to_le32 ( ~(BIT_3 |BIT_2 |BIT_1 |BIT_0 )); - vha->flags.process_response_queue =0 ;if (ha->zio_mode !=QLA_ZIO_DISABLED ) { ha->zio_mode =QLA_ZIO_MODE_6 ;
@@ -7603,7 +7602,6 @@ qla81xx_nvram_config(scsi_qla_host_t *vh icb->firmware_options_2 |=cpu_to_le32 ( (uint32_t )ha->zio_mode); icb->interrupt_delay_timer =cpu_to_le16 (ha->zio_timer); - vha->flags.process_response_queue =1 ; }/* enable RIDA Format2 */
drivers/scsi/qla2xxx/qla_iocb.c +0 -17
@@ -1524,12 +1524,6 @@ qla24xx_start_scsi(srb_t *sp)/* Set chip new ring index. */ WRT_REG_DWORD (req->req_q_in, req->ring_index); -RD_REG_DWORD_RELAXED (&ha->iobase->isp24.hccr); - -/* Manage unprocessed RIO/ZIO commands in response queue. */ -if (vha->flags.process_response_queue && - rsp->ring_ptr->signature !=RESPONSE_PROCESSED ) -qla24xx_process_response_queue (vha, rsp);spin_unlock_irqrestore (&ha->hardware_lock, flags);return QLA_SUCCESS ;
@@ -1723,12 +1717,6 @@ qla24xx_dif_start_scsi(srb_t *sp)/* Set chip new ring index. */ WRT_REG_DWORD (req->req_q_in, req->ring_index); -RD_REG_DWORD_RELAXED (&ha->iobase->isp24.hccr); - -/* Manage unprocessed RIO/ZIO commands in response queue. */ -if (vha->flags.process_response_queue && - rsp->ring_ptr->signature !=RESPONSE_PROCESSED ) -qla24xx_process_response_queue (vha, rsp);spin_unlock_irqrestore (&ha->hardware_lock, flags);
@@ -1878,11 +1866,6 @@ qla2xxx_start_scsi_mq(srb_t *sp)/* Set chip new ring index. */ WRT_REG_DWORD (req->req_q_in, req->ring_index); -/* Manage unprocessed RIO/ZIO commands in response queue. */ -if (vha->flags.process_response_queue && - rsp->ring_ptr->signature !=RESPONSE_PROCESSED ) -qla24xx_process_response_queue (vha, rsp); -spin_unlock_irqrestore (&qpair->qp_lock, flags);return QLA_SUCCESS ;
Greg Kroah-Hartman
maintainerPATCH 27/124 scsi: qla2xxx: Remove stale debug trace message from tcm_qla2xxx
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Quinn Tran <[email protected]>
commit 7c388f91ec1a59b0ed815b07b90536e2d57e1e1f upstream.
Remove stale debug trace.
--- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/scsi/qla2xxx/tcm_qla2xxx.c +0 -4
@@ -693,10 +693,6 @@ static int tcm_qla2xxx_queue_status(stru cmd->sg_cnt =0 ; cmd->offset =0 ; cmd->dma_data_direction =target_reverse_dma_direction (se_cmd); -if (cmd->trc_flags &TRC_XMIT_STATUS ) { -pr_crit ("Multiple calls for status = %p.\n" , cmd); -dump_stack (); - } cmd->trc_flags |=TRC_XMIT_STATUS ;if (se_cmd->data_direction ==DMA_FROM_DEVICE ) {
Greg Kroah-Hartman
maintainerPATCH 28/124 scsi: qla2xxx: shutdown chip if reset fail
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Quinn Tran <[email protected]>
commit 1e4ac5d6fe0a4af17e4b6251b884485832bf75a3 upstream.
If chip unable to fully initialize, use full shutdown sequence to clear out any stale FW state.
--- drivers/scsi/qla2xxx/qla_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_init.c +1 -1
@@ -6077,7 +6077,7 @@ qla2x00_abort_isp(scsi_qla_host_t *vha)* The next call disables the board * completely. */ - ha->isp_ops->reset_adapter (vha); +qla2x00_abort_isp_cleanup (vha); vha->flags.online =0 ;clear_bit (ISP_ABORT_RETRY , &vha->dpc_flags);
Greg Kroah-Hartman
maintainerPATCH 29/124 scsi: qla2xxx: Fix re-using LoopID when handle is in use
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Quinn Tran <[email protected]>
commit 5c6400536481d9ef44ef94e7bf2c7b8e81534db7 upstream.
This patch fixes issue where driver clears NPort ID map instead of marking handle in use. Once driver clears NPort ID from the database, it can reuse the same NPort ID resulting in a PLOGI failure.
[mkp: fixed Himanshu's SoB]
--- drivers/scsi/qla2xxx/qla_init.c | 18 ++++-------------- drivers/scsi/qla2xxx/qla_target.c | 3 ++- 2 files changed, 6 insertions(+), 15 deletions(-)
drivers/scsi/qla2xxx/qla_init.c +4 -14
@@ -1511,25 +1511,15 @@ qla24xx_handle_plogi_done_event(struct s cid.b.rsvd_1 =0 ;ql_dbg (ql_dbg_disc, vha,0x20ec , -"%s %d %8phC LoopID 0x%x in use post gnl\n" , +"%s %d %8phC lid %#x in use with pid %06x post gnl\n" , __func__, __LINE__, ea->fcport->port_name, - ea->fcport->loop_id); + ea->fcport->loop_id, cid.b24); -if (IS_SW_RESV_ADDR (cid)) { -set_bit (ea->fcport->loop_id, vha->hw->loop_id_map); - ea->fcport->loop_id =FC_NO_LOOP_ID ; - }else { -qla2x00_clear_loop_id (ea->fcport); - } +set_bit (ea->fcport->loop_id, vha->hw->loop_id_map); + ea->fcport->loop_id =FC_NO_LOOP_ID ;qla24xx_post_gnl_work (vha, ea->fcport);break ;case MBS_PORT_ID_USED : -ql_dbg (ql_dbg_disc, vha,0x20ed , -"%s %d %8phC NPortId %02x%02x%02x inuse post gidpn\n" , - __func__, __LINE__, ea->fcport->port_name, - ea->fcport->d_id.b.domain, ea->fcport->d_id.b.area, - ea->fcport->d_id.b.al_pa); - lid = ea->iop[1 ] &0xffff ; qlt_find_sess_invalidate_other(vha, wwn_to_u64(ea->fcport->port_name),
drivers/scsi/qla2xxx/qla_target.c +2 -1
@@ -1203,7 +1203,8 @@ void qlt_schedule_sess_for_deletion(struqla24xx_chk_fcp_state (sess);ql_dbg (ql_dbg_tgt, sess->vha,0xe001 , -"Scheduling sess %p for deletion\n" , sess); +"Scheduling sess %p for deletion %8phC\n" , + sess, sess->port_name);INIT_WORK (&sess->del_work, qla24xx_delete_sess_fn);queue_work (sess->vha->hw->wq, &sess->del_work);
Greg Kroah-Hartman
maintainerPATCH 30/124 fuse: Fix use-after-free in fuse_dev_do_read()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kirill Tkhai <[email protected]>
commit bc78abbd55dd28e2287ec6d6502b842321a17c87 upstream.
We may pick freed req in this way:
[cpu0] [cpu1]
fuse_dev_do_read() fuse_dev_do_write()
list_move_tail(&req->list, ...); ...
spin_unlock(&fpq->lock); ...
... request_end(fc, req);
... fuse_put_request(fc, req);
if (test_bit(FR_INTERRUPTED, ...))
queue_interrupt(fiq, req);Fix that by keeping req alive until we finish all manipulations.
--- fs/fuse/dev.c | 2 ++ 1 file changed, 2 insertions(+)
fs/fuse/dev.c +2 -0
@@ -1309,12 +1309,14 @@ static ssize_t fuse_dev_do_read(struct f goto out_end; }list_move_tail (&req->list, &fpq->processing); +__fuse_get_request (req);spin_unlock (&fpq->lock);set_bit (FR_SENT , &req->flags);/* matches barrier in request_wait_answer() */ smp_mb__after_atomic ();if (test_bit (FR_INTERRUPTED , &req->flags))queue_interrupt (fiq, req); +fuse_put_request (fc, req);return reqsize;
Greg Kroah-Hartman
maintainerPATCH 31/124 fuse: Fix use-after-free in fuse_dev_do_write()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kirill Tkhai <[email protected]>
commit d2d2d4fb1f54eff0f3faa9762d84f6446a4bc5d0 upstream.
After we found req in request_find() and released the lock, everything may happen with the req in parallel:
cpu0 cpu1
fuse_dev_do_write() fuse_dev_do_write()
req = request_find(fpq, ...) ...
spin_unlock(&fpq->lock) ...
... req = request_find(fpq, oh.unique)
... spin_unlock(&fpq->lock)
queue_interrupt(&fc->iq, req); ...
... ...
... ...
request_end(fc, req);
fuse_put_request(fc, req); ... queue_interrupt(&fc->iq, req);
--- fs/fuse/dev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
fs/fuse/dev.c +5 -1
@@ -1874,16 +1874,20 @@ static ssize_t fuse_dev_do_write(struct/* Is it an interrupt reply? */ if (req->intr_unique == oh.unique) { +__fuse_get_request (req);spin_unlock (&fpq->lock); err = -EINVAL ; -if (nbytes !=sizeof (struct fuse_out_header )) +if (nbytes !=sizeof (struct fuse_out_header )) { +fuse_put_request (fc, req); goto err_finish; + }if (oh.error == -ENOSYS ) fc->no_interrupt =1 ;else if (oh.error == -EAGAIN )queue_interrupt (&fc->iq, req); +fuse_put_request (fc, req);fuse_copy_finish (cs);return nbytes;
Greg Kroah-Hartman
maintainerPATCH 32/124 fuse: fix blocked_waitq wakeup
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Miklos Szeredi <[email protected]>
commit 908a572b80f6e9577b45e81b3dfe2e22111286b8 upstream.
Using waitqueue_active() is racy. Make sure we issue a wake_up() unconditionally after storing into fc->blocked. After that it's okay to optimize with waitqueue_active() since the first wake up provides the necessary barrier for all waiters, not the just the woken one.
--- fs/fuse/dev.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
fs/fuse/dev.c +11 -4
@@ -384,12 +384,19 @@ static void request_end(struct fuse_connif (test_bit (FR_BACKGROUND , &req->flags)) {spin_lock (&fc->lock);clear_bit (FR_BACKGROUND , &req->flags); -if (fc->num_background == fc->max_background) +if (fc->num_background == fc->max_background) { fc->blocked =0 ; - -/* Wake up next waiter, if any */ -if (!fc->blocked &&waitqueue_active (&fc->blocked_waitq))wake_up (&fc->blocked_waitq); + }else if (!fc->blocked) { +/* +* Wake up next waiter, if any. It's okay to use +* waitqueue_active(), as we've already synced up +* fc->blocked with waiters with the wake_up() call +* above. +*/ +if (waitqueue_active (&fc->blocked_waitq)) +wake_up (&fc->blocked_waitq); + }if (fc->num_background == fc->congestion_threshold && fc->sb) {clear_bdi_congested (fc->sb->s_bdi,BLK_RW_SYNC );
Greg Kroah-Hartman
maintainerPATCH 33/124 fuse: set FR_SENT while locked
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Miklos Szeredi <[email protected]>
commit 4c316f2f3ff315cb48efb7435621e5bfb81df96d upstream.
Otherwise fuse_dev_do_write() could come in and finish off the request, and the set_bit(FR_SENT, ...) could trigger the WARN_ON(test_bit(FR_SENT, ...)) in request_end().
--- fs/fuse/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fuse/dev.c +1 -1
@@ -1317,8 +1317,8 @@ static ssize_t fuse_dev_do_read(struct f }list_move_tail (&req->list, &fpq->processing);__fuse_get_request (req); -spin_unlock (&fpq->lock);set_bit (FR_SENT , &req->flags); +spin_unlock (&fpq->lock);/* matches barrier in request_wait_answer() */ smp_mb__after_atomic ();if (test_bit (FR_INTERRUPTED , &req->flags))
Greg Kroah-Hartman
maintainerPATCH 34/124 ovl: fix recursive oi->lock in ovl_link()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Amir Goldstein <[email protected]>
commit 6cd078702f2f33cb6b19a682de3e9184112f1a46 upstream.
linking a non-copied-up file into a non-copied-up parent results in a nested call to mutex_lock_interruptible(&oi->lock). Fix this by copying up target parent before ovl_nlink_start(), same as done in ovl_rename().
~/unionmount-testsuite$ ./run --ov -s ~/unionmount-testsuite$ ln /mnt/a/foo100 /mnt/a/dir100/
WARNING: possible recursive locking detected
--------------------------------------------
ln/1545 is trying to acquire lock:
00000000bcce7c4c (&ovl_i_lock_key[depth]){+.+.}, at:
ovl_copy_up_start+0x28/0x7d
but task is already holding lock:
0000000026d73d5b (&ovl_i_lock_key[depth]){+.+.}, at:
ovl_nlink_start+0x3c/0xc1[SzM: this seems to be a false positive, but doing the copy-up first is harmless and removes the lockdep splat]
--- fs/overlayfs/dir.c | 5 +++++ 1 file changed, 5 insertions(+)
fs/overlayfs/dir.c +5 -0
@@ -595,6 +595,11 @@ static int ovl_link(struct dentry *old,if (err) goto out_drop_write; + err =ovl_copy_up (new->d_parent); +if (err) + goto out_drop_write; + + err =ovl_nlink_start (old, &locked);if (err) goto out_drop_write;
Greg Kroah-Hartman
maintainerPATCH 35/124 MIPS: Loongson-3: Fix CPU UART irq delivery problem
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
[ Upstream commit d06f8a2f1befb5a3d0aa660ab1c05e9b744456ea ]
Masking/unmasking the CPU UART irq in CP0_Status (and redirecting it to other CPUs) may cause interrupts be lost, especially in multi-package machines (Package-0's UART irq cannot be delivered to others). So make mask_loongson_irq() and unmask_loongson_irq() be no-ops.
The original problem (UART IRQ may deliver to any core) is also because of masking/unmasking the CPU UART irq in CP0_Status. So it is safe to remove all of the stuff.
Patchwork: https://patchwork.linux-mips.org/patch/20433/
--- arch/mips/loongson64/loongson-3/irq.c | 43 ++------------------------- 1 file changed, 3 insertions(+), 40 deletions(-)
arch/mips/loongson64/loongson-3/irq.c +3 -40
@@ -102,45 +102,8 @@ static struct irqaction cascade_irqaction = { .name = "cascade", }; -static inline void mask_loongson_irq (struct irq_data *d) -{ -clear_c0_status (0x100 << (d->irq -MIPS_CPU_IRQ_BASE )); -irq_disable_hazard (); - -/* Workaround: UART IRQ may deliver to any core */ -if (d->irq ==LOONGSON_UART_IRQ ) { -int cpu =smp_processor_id (); -int node_id =cpu_logical_map (cpu) / loongson_sysconf.cores_per_node; -int core_id =cpu_logical_map (cpu) % loongson_sysconf.cores_per_node; -u64 intenclr_addr = smp_group[node_id] | - (u64)(&LOONGSON_INT_ROUTER_INTENCLR ); -u64 introuter_lpc_addr = smp_group[node_id] | - (u64)(&LOONGSON_INT_ROUTER_LPC ); - - *(volatile u32 *)intenclr_addr =1 <<10 ; - *(volatile u8 *)introuter_lpc_addr =0x10 + (1 <<core_id); - } -} - -static inline void unmask_loongson_irq (struct irq_data *d) -{ -/* Workaround: UART IRQ may deliver to any core */ -if (d->irq ==LOONGSON_UART_IRQ ) { -int cpu =smp_processor_id (); -int node_id =cpu_logical_map (cpu) / loongson_sysconf.cores_per_node; -int core_id =cpu_logical_map (cpu) % loongson_sysconf.cores_per_node; -u64 intenset_addr = smp_group[node_id] | - (u64)(&LOONGSON_INT_ROUTER_INTENSET ); -u64 introuter_lpc_addr = smp_group[node_id] | - (u64)(&LOONGSON_INT_ROUTER_LPC ); - - *(volatile u32 *)intenset_addr =1 <<10 ; - *(volatile u8 *)introuter_lpc_addr =0x10 + (1 <<core_id); - } - -set_c0_status (0x100 << (d->irq -MIPS_CPU_IRQ_BASE )); -irq_enable_hazard (); -} +static inline void mask_loongson_irq (struct irq_data *d) { } +static inline void unmask_loongson_irq (struct irq_data *d) { }/* For MIPS IRQs which shared by all cores */ static struct irq_chip loongson_irq_chip = {
@@ -183,7 +146,7 @@ void __init mach_init_irq(void) chip->irq_set_affinity = plat_set_irq_affinity;irq_set_chip_and_handler (LOONGSON_UART_IRQ , - &loongson_irq_chip, handle_level_irq); + &loongson_irq_chip, handle_percpu_irq);/* setup HT1 irq */ setup_irq (LOONGSON_HT1_IRQ , &cascade_irqaction);
Signature · 1 line
2.17.1
Greg Kroah-Hartman
maintainerPATCH 36/124 MIPS: Loongson-3: Fix BRIDGE irq delivery problem
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
[ Upstream commit 360fe725f8849aaddc53475fef5d4a0c439b05ae ]
After commit e509bd7da149dc349160 ("genirq: Allow migration of chained interrupts by installing default action") Loongson-3 fails at here:
setup_irq(LOONGSON_HT1_IRQ, &cascade_irqaction);
This is because both chained_action and cascade_irqaction don't have IRQF_SHARED flag. This will cause Loongson-3 resume fails because HPET timer interrupt can't be delivered during S3. So we set the irqchip of the chained irq to loongson_irq_chip which doesn't disable the chained irq in CP0.Status.
Patchwork: https://patchwork.linux-mips.org/patch/20434/
--- arch/mips/include/asm/mach-loongson64/irq.h | 2 +- arch/mips/loongson64/loongson-3/irq.c | 13 +++---------- 2 files changed, 4 insertions(+), 11 deletions(-)
arch/mips/include/asm/mach-loongson64/irq.h +1 -1
@@ -10,7 +10,7 @@#define MIPS_CPU_IRQ_BASE 56#define LOONGSON_UART_IRQ (MIPS_CPU_IRQ_BASE + 2)/* UART */ -#define LOONGSON_HT1_IRQ (MIPS_CPU_IRQ_BASE + 3)/* HT1 */ +#define LOONGSON_BRIDGE_IRQ (MIPS_CPU_IRQ_BASE + 3)/* CASCADE */ #define LOONGSON_TIMER_IRQ (MIPS_CPU_IRQ_BASE + 7)/* CPU Timer */ #define LOONGSON_HT1_CFG_BASE loongson_sysconf.ht_control_base
arch/mips/loongson64/loongson-3/irq.c +3 -10
@@ -96,12 +96,6 @@ void mach_irq_dispatch(unsigned int pending) } } -static struct irqaction cascade_irqaction = { - .handler = no_action, - .flags =IRQF_NO_SUSPEND , - .name ="cascade" , -}; -static inline void mask_loongson_irq (struct irq_data *d) { }static inline void unmask_loongson_irq (struct irq_data *d) { }
@@ -147,11 +141,10 @@ void __init mach_init_irq(void)irq_set_chip_and_handler (LOONGSON_UART_IRQ , &loongson_irq_chip, handle_percpu_irq); +irq_set_chip_and_handler (LOONGSON_BRIDGE_IRQ , + &loongson_irq_chip, handle_percpu_irq); -/* setup HT1 irq */ -setup_irq (LOONGSON_HT1_IRQ , &cascade_irqaction); - -set_c0_status (STATUSF_IP2 |STATUSF_IP6 ); +set_c0_status (STATUSF_IP2 |STATUSF_IP3 |STATUSF_IP6 ); }#ifdef CONFIG_HOTPLUG_CPU
Signature · 1 line
2.17.1
Greg Kroah-Hartman
maintainerPATCH 37/124 xtensa: add NOTES section to the linker script
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Max Filippov <[email protected]>
commit 4119ba211bc4f1bf638f41e50b7a0f329f58aa16 upstream.
This section collects all source .note.* sections together in the vmlinux image. Without it .note.Linux section may be placed at address 0, while the rest of the kernel is at its normal address, resulting in a huge vmlinux.bin image that may not be linked into the xtensa Image.elf.
--- arch/xtensa/boot/Makefile | 2 +- arch/xtensa/kernel/vmlinux.lds.S | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)
arch/xtensa/boot/Makefile +1 -1
@@ -34,7 +34,7 @@ boot-elf boot-redboot: $(addprefix $(obj $(addprefix $(obj)/,$(host-progs)) $(Q)$(MAKE) $(build)=$(obj)/$@ $(MAKECMDGOALS) -OBJCOPYFLAGS = --strip-all -R .comment -R .note.gnu.build-id -O binary +OBJCOPYFLAGS = --strip-all -R .comment -R .notes -O binary vmlinux.bin: vmlinux FORCE $(call if_changed,objcopy)
arch/xtensa/kernel/vmlinux.lds.S +1 -0
@@ -146,6 +146,7 @@ SECTIONS .fixup : { *(.fixup) } EXCEPTION_TABLE(16) + NOTES /* Data section */ _sdata = .;
Greg Kroah-Hartman
maintainerPATCH 38/124 xtensa: make sure bFLT stack is 16 byte aligned
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Max Filippov <[email protected]>
commit 0773495b1f5f1c5e23551843f87b5ff37e7af8f7 upstream.
Xtensa ABI requires stack alignment to be at least 16. In noMMU configuration ARCH_SLAB_MINALIGN is used to align stack. Make it at least 16.
This fixes the following runtime error in noMMU configuration, caused by interaction between insufficiently aligned stack and alloca function, that results in corruption of on-stack variable in the libc function glob:
Caught unhandled exception in 'sh' (pid = 47, pc = 0x02d05d65)
- should not happen
EXCCAUSE is 15
--- arch/xtensa/include/asm/processor.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
arch/xtensa/include/asm/processor.h +5 -1
@@ -24,7 +24,11 @@# error Linux requires the Xtensa Windowed Registers Option.#endif -#define ARCH_SLAB_MINALIGN XCHAL_DATA_WIDTH +/* Xtensa ABI requires stack alignment to be at least 16 */ + +#define STACK_ALIGN (XCHAL_DATA_WIDTH > 16 ? XCHAL_DATA_WIDTH : 16) + +#define ARCH_SLAB_MINALIGN STACK_ALIGN/* * User space process size: 1 GB.
Greg Kroah-Hartman
maintainerPATCH 39/124 xtensa: fix boot parameters address translation
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Max Filippov <[email protected]>
commit 40dc948f234b73497c3278875eb08a01d5854d3f upstream.
The bootloader may pass physical address of the boot parameters structure to the MMUv3 kernel in the register a2. Code in the _SetupMMU block in the arch/xtensa/kernel/head.S is supposed to map that physical address to the virtual address in the configured virtual memory layout.
This code haven't been updated when additional 256+256 and 512+512 memory layouts were introduced and it may produce wrong addresses when used with these layouts.
--- arch/xtensa/kernel/head.S | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
arch/xtensa/kernel/head.S +5 -2
@@ -88,9 +88,12 @@ _SetupMMU: initialize_mmu #if defined(CONFIG_MMU) && XCHAL_HAVE_PTP_MMU && XCHAL_HAVE_SPANNING_WAY rsr a2, excsave1 - movi a3, 0x08000000 + movi a3, XCHAL_KSEG_PADDR + bltu a2, a3, 1f + sub a2, a2, a3 + movi a3, XCHAL_KSEG_SIZE bgeu a2, a3, 1f - movi a3, 0xd0000000 + movi a3, XCHAL_KSEG_CACHED_VADDR add a2, a2, a3 wsr a2, excsave1 1:
Greg Kroah-Hartman
maintainerPATCH 40/124 um: Drop own definition of PTRACE_SYSEMU/_SINGLESTEP
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Richard Weinberger <[email protected]>
commit 0676b957c24bfb6e495449ba7b7e72c5b5d79233 upstream.
32bit UML used to define PTRACE_SYSEMU and PTRACE_SYSEMU_SINGLESTEP own its own because many years ago not all libcs had these request codes in their UAPI.
These days PTRACE_SYSEMU/_SINGLESTEP is well known and part of glibc and our own define becomes problematic.
With change c48831d0eebf ("linux/x86: sync sys/ptrace.h with Linux 4.14 [BZ #22433]") glibc turned PTRACE_SYSEMU/_SINGLESTEP into a enum and UML failed to build.
Let's drop our define and rely on the fact that every libc has PTRACE_SYSEMU/_SINGLESTEP.
--- arch/x86/um/shared/sysdep/ptrace_32.h | 10 ---------- 1 file changed, 10 deletions(-)
arch/x86/um/shared/sysdep/ptrace_32.h +0 -10
@@ -10,20 +10,10 @@static inline void update_debugregs (int seq) {} -/* syscall emulation path in ptrace */ - -#ifndef PTRACE_SYSEMU -#define PTRACE_SYSEMU 31 -#endif -void set_using_sysemu (int value);int get_using_sysemu (void );extern int sysemu_supported; -#ifndef PTRACE_SYSEMU_SINGLESTEP -#define PTRACE_SYSEMU_SINGLESTEP 32 -#endif -#define UPT_SYSCALL_ARG1 (r) UPT_BX(r)#define UPT_SYSCALL_ARG2 (r) UPT_CX(r)#define UPT_SYSCALL_ARG3 (r) UPT_DX(r)
Greg Kroah-Hartman
maintainerPATCH 41/124 clk: s2mps11: Fix matching when built as module and DT node contains compatible
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Krzysztof Kozlowski <[email protected]>
commit 8985167ecf57f97061599a155bb9652c84ea4913 upstream.
When driver is built as module and DT node contains clocks compatible (e.g. "samsung,s2mps11-clk"), the module will not be autoloaded because module aliases won't match.
The modalias from uevent: of:NclocksT<NULL>Csamsung,s2mps11-clk The modalias from driver: platform:s2mps11-clk
The devices are instantiated by parent's MFD. However both Device Tree bindings and parent define the compatible for clocks devices. In case of module matching this DT compatible will be used.
The issue will not happen if this is a built-in (no need for module matching) or when clocks DT node does not contain compatible (not correct from bindings perspective but working for driver).
Note when backporting to stable kernels: adjust the list of device ID entries.
--- drivers/clk/clk-s2mps11.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
drivers/clk/clk-s2mps11.c +30 -0
@@ -245,6 +245,36 @@ static const struct platform_device_id s };MODULE_DEVICE_TABLE (platform, s2mps11_clk_id); +#ifdef CONFIG_OF +/* +* Device is instantiated through parent MFD device and device matching is done +* through platform_device_id. +* +* However if device's DT node contains proper clock compatible and driver is +* built as a module, then the *module* matching will be done trough DT aliases. +* This requires of_device_id table. In the same time this will not change the +* actual *device* matching so do not add .of_match_table. +*/ +static const struct of_device_id s2mps11_dt_match[] = { + { + .compatible ="samsung,s2mps11-clk" , + .data = (void *)S2MPS11X , + }, { + .compatible ="samsung,s2mps13-clk" , + .data = (void *)S2MPS13X , + }, { + .compatible ="samsung,s2mps14-clk" , + .data = (void *)S2MPS14X , + }, { + .compatible ="samsung,s5m8767-clk" , + .data = (void *)S5M8767X , + }, { +/* Sentinel */ + }, +}; +MODULE_DEVICE_TABLE (of, s2mps11_dt_match); +#endif +static struct platform_driver s2mps11_clk_driver = { .driver = { .name ="s2mps11-clk" ,
Greg Kroah-Hartman
maintainerPATCH 42/124 clk: at91: Fix division by zero in PLL recalc_rate()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ronald Wahl <[email protected]>
commit 0f5cb0e6225cae2f029944cb8c74617aab6ddd49 upstream.
Commit a982e45dc150 ("clk: at91: PLL recalc_rate() now using cached MUL and DIV values") removed a check that prevents a division by zero. This now causes a stacktrace when booting the kernel on a at91 platform if the PLL DIV register contains zero. This commit reintroduces this check.
--- drivers/clk/at91/clk-pll.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/clk/at91/clk-pll.c +3 -0
@@ -133,6 +133,9 @@ static unsigned long clk_pll_recalc_rate {struct clk_pll *pll =to_clk_pll (hw); +if (!pll->div || !pll->mul) +return 0 ; +return (parent_rate / pll->div) * (pll->mul +1 ); }
Greg Kroah-Hartman
maintainerPATCH 43/124 clk: rockchip: Fix static checker warning in rockchip_ddrclk_get_parent call
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Enric Balletbo i Serra <[email protected]>
commit 665636b2940d0897c4130253467f5e8c42eea392 upstream.
Fixes the signedness bug returning '(-22)' on the return type by removing the sanity checker in rockchip_ddrclk_get_parent(). The function should return and unsigned value only and it's safe to remove the sanity checker as the core functions that call get_parent like clk_core_get_parent_by_index already ensures the validity of the clk index returned (index >= core->num_parents).
--- drivers/clk/rockchip/clk-ddr.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/clk/rockchip/clk-ddr.c +0 -4
@@ -80,16 +80,12 @@ static long rockchip_ddrclk_sip_round_rastatic u8 rockchip_ddrclk_get_parent (struct clk_hw *hw) {struct rockchip_ddrclk *ddrclk =to_rockchip_ddrclk_hw (hw); -int num_parents =clk_hw_get_num_parents (hw);u32 val; val =clk_readl (ddrclk->reg_base + ddrclk->mux_offset) >> ddrclk->mux_shift; val &=GENMASK (ddrclk->mux_width -1 ,0 ); -if (val >= num_parents) -return -EINVAL ; -return val; }
Greg Kroah-Hartman
maintainerPATCH 44/124 clk: mvebu: use correct bit for 98DX3236 NAND
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Packham <[email protected]>
commit 00c5a926af12a9f0236928dab3dc9faf621406a1 upstream.
The correct fieldbit value for the NAND PLL reload trigger is 27.
--- drivers/clk/mvebu/clk-corediv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/mvebu/clk-corediv.c +1 -1
@@ -72,7 +72,7 @@ static const struct clk_corediv_desc mve };static const struct clk_corediv_desc mv98dx3236_corediv_desc[] = { - { .mask =0x0f , .offset =6 , .fieldbit =26 },/* NAND clock */ + { .mask =0x0f , .offset =6 , .fieldbit =27 },/* NAND clock */ };#define to_corediv_clk (p) container_of(p, struct clk_corediv, hw)
Greg Kroah-Hartman
maintainerPATCH 45/124 media: ov7670: make "xclk" clock optional
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lubomir Rintel <[email protected]>
commit 786fa584eda86d6598db3b87c61dc81f68808d11 upstream.
When the "xclk" clock was added, it was made mandatory. This broke the driver on an OLPC plaform which doesn't know such clock. Make it optional.
Tested on a OLPC XO-1 laptop.
--- drivers/media/i2c/ov7670.c | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-)
drivers/media/i2c/ov7670.c +18 -12
@@ -1612,23 +1612,29 @@ static int ov7670_probe(struct i2c_clien info->pclk_hb_disable = true; } - info->clk =devm_clk_get (&client->dev,"xclk" ); -if (IS_ERR (info->clk)) -return PTR_ERR (info->clk); - ret =clk_prepare_enable (info->clk); -if (ret) -return ret; + info->clk =devm_clk_get (&client->dev,"xclk" );/* optional */ +if (IS_ERR (info->clk)) { + ret =PTR_ERR (info->clk); +if (ret == -ENOENT ) + info->clk =NULL ; +else +return ret; + } +if (info->clk) { + ret =clk_prepare_enable (info->clk); +if (ret) +return ret; + info->clock_speed =clk_get_rate (info->clk) /1000000 ; +if (info->clock_speed <10 || info->clock_speed >48 ) { + ret = -EINVAL ; + goto clk_disable; + } + } ret =ov7670_init_gpio (client, info);if (ret) goto clk_disable; - info->clock_speed =clk_get_rate (info->clk) /1000000 ; -if (info->clock_speed <10 || info->clock_speed >48 ) { - ret = -EINVAL ; - goto clk_disable; - } -/* Make sure it's an ov7670 */ ret =ov7670_detect (sd);if (ret) {
Greg Kroah-Hartman
maintainerPATCH 46/124 libceph: bump CEPH_MSG_MAX_DATA_LEN
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ilya Dryomov <[email protected]>
commit 94e6992bb560be8bffb47f287194adf070b57695 upstream.
If the read is large enough, we end up spinning in the messenger:
libceph: osd0 192.168.122.1:6801 io error
libceph: osd0 192.168.122.1:6801 io error
libceph: osd0 192.168.122.1:6801 io error
This is a receive side limit, so only reads were affected.
--- include/linux/ceph/libceph.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
include/linux/ceph/libceph.h +7 -1
@@ -81,7 +81,13 @@ struct ceph_options {#define CEPH_MSG_MAX_FRONT_LEN (16*1024*1024)#define CEPH_MSG_MAX_MIDDLE_LEN (16*1024*1024) -#define CEPH_MSG_MAX_DATA_LEN (16*1024*1024) + +/* +* Handle the largest possible rbd object in one message. +* There is no limit on the size of cephfs objects, but it has to obey +* rsize and wsize mount options anyway. +*/ +#define CEPH_MSG_MAX_DATA_LEN (32*1024*1024)#define CEPH_AUTH_NAME_DEFAULT "guest"
Greg Kroah-Hartman
maintainerPATCH 47/124 Revert "ceph: fix dentry leak in splice_dentry()"
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Yan, Zheng <[email protected]>
commit efe328230dc01aa0b1269aad0b5fae73eea4677a upstream.
This reverts commit 8b8f53af1ed9df88a4c0fbfdf3db58f62060edf3.
splice_dentry() is used by three places. For two places, req->r_dentry is passed to splice_dentry(). In the case of error, req->r_dentry does not get updated. So splice_dentry() should not drop reference.
--- fs/ceph/inode.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
fs/ceph/inode.c +6 -2
@@ -1087,8 +1087,12 @@ static struct dentry *splice_dentry(struif (IS_ERR (realdn)) {pr_err ("splice_dentry error %ld %p inode %p ino %llx.%llx\n" ,PTR_ERR (realdn), dn, in,ceph_vinop (in)); -dput (dn); - dn = realdn;/* note realdn contains the error */ + dn = realdn; +/* +* Caller should release 'dn' in the case of error. +* If 'req->r_dentry' is passed to this function, +* caller should leave 'req->r_dentry' untouched. +*/ goto out; }else if (realdn) { dout("dn %p (%d) spliced with %p (%d) "
Greg Kroah-Hartman
maintainerPATCH 48/124 thermal: enable broadcom menu for arm64 bcm2835
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Allen Wild <[email protected]>
commit fec3624f0bcdb6b20ef9ccf9d9d55d0d75d776f8 upstream.
Moving the bcm2835 thermal driver to the broadcom directory prevented it from getting enabled for arm64 builds, since the broadcom directory is only available when 32-bit specific ARCH_BCM is set.
Fix this by enabling the Broadcom menu for ARCH_BCM or ARCH_BCM2835.
--- drivers/thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/Kconfig +1 -1
@@ -408,7 +408,7 @@ config MTK_THERMAL controller present in Mediatek SoCs menu "Broadcom thermal drivers" -depends on ARCH_BCM || COMPILE_TEST +depends on ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST source "drivers/thermal/broadcom/Kconfig" endmenu
Greg Kroah-Hartman
maintainerPATCH 49/124 mach64: fix display corruption on big endian machines
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mikulas Patocka <[email protected]>
commit 3c6c6a7878d00a3ac997a779c5b9861ff25dfcc8 upstream.
The code for manual bit triple is not endian-clean. It builds the variable "hostdword" using byte accesses, therefore we must read the variable with "le32_to_cpu".
The patch also enables (hardware or software) bit triple only if the image is monochrome (image->depth). If we want to blit full-color image, we shouldn't use the triple code.
--- drivers/video/fbdev/aty/mach64_accel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/video/fbdev/aty/mach64_accel.c +3 -3
@@ -345,7 +345,7 @@ void atyfb_imageblit(struct fb_info *inf* since Rage 3D IIc we have DP_HOST_TRIPLE_EN bit * this hwaccelerated triple has an issue with not aligned data */ -if (M64_HAS (HW_TRIPLE ) && image->width %8 ==0 ) +if (image->depth ==1 &&M64_HAS (HW_TRIPLE ) && image->width %8 ==0 ) pix_width |=DP_HOST_TRIPLE_EN ; }
@@ -382,7 +382,7 @@ void atyfb_imageblit(struct fb_info *inf src_bytes = (((image->width * image->depth) +7 ) /8 ) * image->height;/* manual triple each pixel */ -if (info->var.bits_per_pixel ==24 && !(pix_width &DP_HOST_TRIPLE_EN )) { +if (image->depth ==1 && info->var.bits_per_pixel ==24 && !(pix_width &DP_HOST_TRIPLE_EN )) {int inbit, outbit, mult24, byte_id_in_dword, width;u8 *pbitmapin = (u8 *)image->data, *pbitmapout;u32 hostdword;
@@ -415,7 +415,7 @@ void atyfb_imageblit(struct fb_info *inf } }wait_for_fifo (1 , par); -aty_st_le32 (HOST_DATA0 , hostdword, par); +aty_st_le32 (HOST_DATA0 ,le32_to_cpu (hostdword), par); } }else {u32 *pbitmap, dwords = (src_bytes +3 ) /4 ;
Greg Kroah-Hartman
maintainerPATCH 50/124 mach64: fix image corruption due to reading accelerator registers
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mikulas Patocka <[email protected]>
commit c09bcc91bb94ed91f1391bffcbe294963d605732 upstream.
Reading the registers without waiting for engine idle returns unpredictable values. These unpredictable values result in display corruption - if atyfb_imageblit reads the content of DP_PIX_WIDTH with the bit DP_HOST_TRIPLE_EN set (from previous invocation), the driver would never ever clear the bit, resulting in display corruption.
We don't want to wait for idle because it would degrade performance, so this patch modifies the driver so that it never reads accelerator registers.
HOST_CNTL doesn't have to be read, we can just write it with HOST_BYTE_ALIGN because no other part of the driver cares if HOST_BYTE_ALIGN is set.
DP_PIX_WIDTH is written in the functions atyfb_copyarea and atyfb_fillrect with the default value and in atyfb_imageblit with the value set according to the source image data.
--- drivers/video/fbdev/aty/mach64_accel.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-)
drivers/video/fbdev/aty/mach64_accel.c +9 -13
@@ -127,7 +127,7 @@ void aty_init_engine(struct atyfb_par *p/* set host attributes */ wait_for_fifo (13 , par); -aty_st_le32 (HOST_CNTL ,0 , par); +aty_st_le32 (HOST_CNTL ,HOST_BYTE_ALIGN , par);/* set pattern attributes */ aty_st_le32 (PAT_REG0 ,0 , par);
@@ -233,7 +233,8 @@ void atyfb_copyarea(struct fb_info *info rotation =rotation24bpp (dx, direction); } -wait_for_fifo (4 , par); +wait_for_fifo (5 , par); +aty_st_le32 (DP_PIX_WIDTH , par->crtc.dp_pix_width, par);aty_st_le32 (DP_SRC ,FRGD_SRC_BLIT , par);aty_st_le32 (SRC_Y_X , (sx <<16 ) | sy, par);aty_st_le32 (SRC_HEIGHT1_WIDTH1 , (width <<16 ) | area->height, par);
@@ -269,7 +270,8 @@ void atyfb_fillrect(struct fb_info *info rotation =rotation24bpp (dx,DST_X_LEFT_TO_RIGHT ); } -wait_for_fifo (3 , par); +wait_for_fifo (4 , par); +aty_st_le32 (DP_PIX_WIDTH , par->crtc.dp_pix_width, par);aty_st_le32 (DP_FRGD_CLR , color, par); aty_st_le32(DP_SRC, BKGD_SRC_BKGD_CLR | FRGD_SRC_FRGD_CLR | MONO_SRC_ONE,
@@ -284,7 +286,7 @@ void atyfb_imageblit(struct fb_info *inf {struct atyfb_par *par = (struct atyfb_par *) info->par;u32 src_bytes, dx = image->dx, dy = image->dy, width = image->width; -u32 pix_width_save, pix_width, host_cntl, rotation =0 , src, mix; +u32 pix_width, rotation =0 , src, mix;if (par->asleep)return ;
@@ -296,8 +298,7 @@ void atyfb_imageblit(struct fb_info *infreturn ; } - pix_width = pix_width_save =aty_ld_le32 (DP_PIX_WIDTH , par); - host_cntl =aty_ld_le32 (HOST_CNTL , par) |HOST_BYTE_ALIGN ; + pix_width = par->crtc.dp_pix_width;switch (image->depth) {case 1 :
@@ -370,12 +371,11 @@ void atyfb_imageblit(struct fb_info *inf mix =FRGD_MIX_D_XOR_S |BKGD_MIX_D ; } -wait_for_fifo (6 , par); -aty_st_le32 (DP_WRITE_MASK ,0xFFFFFFFF , par); +wait_for_fifo (5 , par);aty_st_le32 (DP_PIX_WIDTH , pix_width, par);aty_st_le32 (DP_MIX , mix, par);aty_st_le32 (DP_SRC , src, par); -aty_st_le32 (HOST_CNTL , host_cntl, par); +aty_st_le32 (HOST_CNTL ,HOST_BYTE_ALIGN , par);aty_st_le32 (DST_CNTL ,DST_Y_TOP_TO_BOTTOM |DST_X_LEFT_TO_RIGHT | rotation, par);draw_rect (dx, dy, width, image->height, par);
@@ -424,8 +424,4 @@ void atyfb_imageblit(struct fb_info *infaty_st_le32 (HOST_DATA0 ,get_unaligned_le32 (pbitmap), par); } } - -/* restore pix_width */ -wait_for_fifo (1 , par); -aty_st_le32 (DP_PIX_WIDTH , pix_width_save, par); }
Greg Kroah-Hartman
maintainerPATCH 51/124 reset: hisilicon: fix potential NULL pointer dereference
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Gustavo A. R. Silva <[email protected]>
commit e9a2310fb689151166df7fd9971093362d34bd79 upstream.
There is a potential execution path in which function platform_get_resource() returns NULL. If this happens, we will end up having a NULL pointer dereference.
Fix this by replacing devm_ioremap with devm_ioremap_resource, which has the NULL check and the memory region request.
This code was detected with the help of Coccinelle.
--- drivers/clk/hisilicon/reset.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/clk/hisilicon/reset.c +2 -3
@@ -109,9 +109,8 @@ struct hisi_reset_controller *hisi_resetreturn NULL ; res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - rstc->membase =devm_ioremap (&pdev->dev, - res->start,resource_size (res)); -if (!rstc->membase) + rstc->membase =devm_ioremap_resource (&pdev->dev, res); +if (IS_ERR (rstc->membase))return NULL ;spin_lock_init (&rstc->lock);
Greg Kroah-Hartman
maintainerPATCH 52/124 vhost/scsi: truncate T10 PI iov_iter to prot_bytes
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Greg Edwards <[email protected]>
commit 4542d623c7134bc1738f8a68ccb6dd546f1c264f upstream.
Commands with protection information included were not truncating the protection iov_iter to the number of protection bytes in the command. This resulted in vhost_scsi mis-calculating the size of the protection SGL in vhost_scsi_calc_sgls(), and including both the protection and data SG entries in the protection SGL.
--- drivers/vhost/scsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/vhost/scsi.c +3 -1
@@ -993,7 +993,8 @@ vhost_scsi_handle_vq(struct vhost_scsi * prot_bytes =vhost32_to_cpu (vq, v_req_pi.pi_bytesin); }/* -* Set prot_iter to data_iter, and advance past any +* Set prot_iter to data_iter and truncate it to +* prot_bytes, and advance data_iter past any * preceeding prot_bytes that may be present. * * Also fix up the exp_data_len to reflect only the
@@ -1002,6 +1003,7 @@ vhost_scsi_handle_vq(struct vhost_scsi *if (prot_bytes) { exp_data_len -= prot_bytes; prot_iter = data_iter; +iov_iter_truncate (&prot_iter, prot_bytes);iov_iter_advance (&data_iter, prot_bytes); } tag =vhost64_to_cpu (vq, v_req_pi.tag);
Greg Kroah-Hartman
maintainerPATCH 53/124 scsi: qla2xxx: Initialize port speed to avoid setting lower speed
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Quinn Tran <[email protected]>
commit f635e48e866ee1a47d2d42ce012fdcc07bf55853 upstream.
This patch initializes port speed so that firmware does not set lower operating speed. Setting lower speed in firmware impacts WRITE perfomance.
--- drivers/scsi/qla2xxx/qla_init.c | 1 + 1 file changed, 1 insertion(+)
drivers/scsi/qla2xxx/qla_init.c +1 -0
@@ -4236,6 +4236,7 @@ qla2x00_alloc_fcport(scsi_qla_host_t *vh fcport->loop_id =FC_NO_LOOP_ID ;qla2x00_set_fcport_state (fcport,FCS_UNCONFIGURED ); fcport->supported_classes =FC_COS_UNSPECIFIED ; + fcport->fp_speed =PORT_SPEED_UNKNOWN ; fcport->ct_desc.ct_sns = dma_alloc_coherent(&vha->hw->pdev->dev, sizeof(struct ct_sns_pkt), &fcport->ct_desc.ct_sns_dma,
Greg Kroah-Hartman
maintainerPATCH 54/124 SCSI: fix queue cleanup race before queue initialization is done
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ming Lei <[email protected]>
commit 8dc765d438f1e42b3e8227b3b09fad7d73f4ec9a upstream.
c2856ae2f315d ("blk-mq: quiesce queue before freeing queue") has already fixed this race, however the implied synchronize_rcu() in blk_mq_quiesce_queue() can slow down LUN probe a lot, so caused performance regression.
Then 1311326cf4755c7 ("blk-mq: avoid to synchronize rcu inside blk_cleanup_queue()") tried to quiesce queue for avoiding unnecessary synchronize_rcu()
only when queue initialization is done, because it is usual to see lots of inexistent LUNs which need to be probed.
However, turns out it isn't safe to quiesce queue only when queue initialization is done. Because when one SCSI command is completed, the user of sending command can be waken up immediately, then the scsi device may be removed, meantime the run queue in scsi_end_request() is still in-progress, so kernel panic can be caused.
In Red Hat QE lab, there are several reports about this kind of kernel panic triggered during kernel booting.
This patch tries to address the issue by grabing one queue usage counter during freeing one request and the following run queue.
--- block/blk-core.c | 5 ++--- drivers/scsi/scsi_lib.c | 8 ++++++++ 2 files changed, 10 insertions(+), 3 deletions(-)
block/blk-core.c +2 -3
@@ -671,9 +671,8 @@ void blk_cleanup_queue(struct request_qu* dispatch may still be in-progress since we dispatch requests * from more than one contexts. * -* No need to quiesce queue if it isn't initialized yet since -* blk_freeze_queue() should be enough for cases of passthrough -* request. +* We rely on driver to deal with the race in case that queue +* initialization isn't done. */ if (q->mq_ops &&blk_queue_init_done (q))blk_mq_quiesce_queue (q);
drivers/scsi/scsi_lib.c +8 -0
@@ -683,6 +683,12 @@ static bool scsi_end_request(struct requ*/ scsi_mq_uninit_cmd (cmd); +/* +* queue is still alive, so grab the ref for preventing it +* from being cleaned up during running queue. +*/ +percpu_ref_get (&q->q_usage_counter); +__blk_mq_end_request (req, error); if (scsi_target(sdev)->single_lun ||
@@ -690,6 +696,8 @@ static bool scsi_end_request(struct requkblockd_schedule_work (&sdev->requeue_work); elseblk_mq_run_hw_queues (q ,true ); + +percpu_ref_put (&q->q_usage_counter); }else {unsigned long flags;
Greg Kroah-Hartman
maintainerPATCH 55/124 soc: ti: QMSS: Fix usage of irq_set_affinity_hint
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Marc Zyngier <[email protected]>
commit 832ad0e3da4510fd17f98804abe512ea9a747035 upstream.
The Keystone QMSS driver is pretty damaged, in the sense that it does things like this:
irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
where cpu_map is a local variable. As we leave the function, this will point to nowhere-land, and things will end-up badly.
Instead, let's use a proper cpumask that gets allocated, giving the driver a chance to actually work with things like irqbalance as well as have a hypothetical 64bit future.
--- drivers/soc/ti/knav_qmss.h | 4 ++-- drivers/soc/ti/knav_qmss_acc.c | 10 +++++----- drivers/soc/ti/knav_qmss_queue.c | 22 +++++++++++++++------- 3 files changed, 22 insertions(+), 14 deletions(-)
drivers/soc/ti/knav_qmss.h +2 -2
@@ -321,8 +321,8 @@ struct knav_range_ops { };struct knav_irq_info { -int irq; -u32 cpu_map; +int irq; +struct cpumask *cpu_mask; };struct knav_range_info {
drivers/soc/ti/knav_qmss_acc.c +5 -5
@@ -205,18 +205,18 @@ static int knav_range_setup_acc_irq(stru {struct knav_device *kdev = range->kdev;struct knav_acc_channel *acc; -unsigned long cpu_map; +struct cpumask *cpu_mask;int ret =0 , irq;u32 old, new;if (range->flags &RANGE_MULTI_QUEUE ) { acc = range->acc; irq = range->irqs[0 ].irq; - cpu_map = range->irqs[0 ].cpu_map; + cpu_mask = range->irqs[0 ].cpu_mask; }else { acc = range->acc + queue; irq = range->irqs[queue].irq; - cpu_map = range->irqs[queue].cpu_map; + cpu_mask = range->irqs[queue].cpu_mask; } old = acc->open_mask;
@@ -239,8 +239,8 @@ static int knav_range_setup_acc_irq(stru acc->name, acc->name); ret =request_irq (irq, knav_acc_int_handler,0 , acc->name, range); -if (!ret && cpu_map) { - ret =irq_set_affinity_hint (irq,to_cpumask (&cpu_map)); +if (!ret && cpu_mask) { + ret =irq_set_affinity_hint (irq, cpu_mask);if (ret) {dev_warn (range->kdev->dev,"Failed to set IRQ affinity\n" );
drivers/soc/ti/knav_qmss_queue.c +15 -7
@@ -102,19 +102,17 @@ static int knav_queue_setup_irq(struct k struct knav_queue_inst *inst) {unsigned queue = inst->id - range->queue_base; -unsigned long cpu_map;int ret =0 , irq;if (range->flags &RANGE_HAS_IRQ ) { irq = range->irqs[queue].irq; - cpu_map = range->irqs[queue].cpu_map; ret =request_irq (irq, knav_queue_int_handler,0 , inst->irq_name, inst);if (ret)return ret;disable_irq (irq); -if (cpu_map) { - ret =irq_set_affinity_hint (irq,to_cpumask (&cpu_map)); +if (range->irqs[queue].cpu_mask) { + ret =irq_set_affinity_hint (irq, range->irqs[queue].cpu_mask);if (ret) {dev_warn (range->kdev->dev,"Failed to set IRQ affinity\n" );
@@ -1222,9 +1220,19 @@ static int knav_setup_queue_range(struct range->num_irqs++; -if (IS_ENABLED (CONFIG_SMP ) && oirq.args_count ==3 ) - range->irqs[i].cpu_map = - (oirq.args[2 ] &0x0000ff00 ) >>8 ; +if (IS_ENABLED (CONFIG_SMP ) && oirq.args_count ==3 ) { +unsigned long mask; +int bit; + + range->irqs[i].cpu_mask =devm_kzalloc (dev, +cpumask_size (),GFP_KERNEL ); +if (!range->irqs[i].cpu_mask) +return -ENOMEM ; + + mask = (oirq.args[2 ] &0x0000ff00 ) >>8 ; +for_each_set_bit (bit, &mask,BITS_PER_LONG ) +cpumask_set_cpu (bit, range->irqs[i].cpu_mask); + } } range->num_irqs =min (range->num_irqs, range->num_queues);
Greg Kroah-Hartman
maintainerPATCH 56/124 ocfs2: fix a misuse a of brelse after failing ocfs2_check_dir_entry
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Changwei Ge <[email protected]>
commit 29aa30167a0a2e6045a0d6d2e89d8168132333d5 upstream.
Somehow, file system metadata was corrupted, which causes ocfs2_check_dir_entry() to fail in function ocfs2_dir_foreach_blk_el().
According to the original design intention, if above happens we should skip the problematic block and continue to retrieve dir entry. But there is obviouse misuse of brelse around related code.
After failure of ocfs2_check_dir_entry(), current code just moves to next position and uses the problematic buffer head again and again during which the problematic buffer head is released for multiple times. I suppose, this a serious issue which is long-lived in ocfs2. This may cause other file systems which is also used in a the same host insane.
So we should also consider about bakcporting this patch into linux -stable.
--- fs/ocfs2/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
fs/ocfs2/dir.c +1 -2
@@ -1896,8 +1896,7 @@ static int ocfs2_dir_foreach_blk_el(stru/* On error, skip the f_pos to the next block. */ ctx->pos = (ctx->pos | (sb->s_blocksize -1 )) +1 ; -brelse (bh); -continue ; +break ; }if (le64_to_cpu (de->inode)) {unsigned char d_type =DT_UNKNOWN ;
Greg Kroah-Hartman
maintainerPATCH 57/124 ocfs2: free up write context when direct IO failed
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Wengang Wang <[email protected]>
commit 5040f8df56fb90c7919f1c9b0b6e54c843437456 upstream.
The write context should also be freed even when direct IO failed. Otherwise a memory leak is introduced and entries remain in oi->ip_unwritten_list causing the following BUG later in unlink path:
ERROR: bug expression: !list_empty(&oi->ip_unwritten_list)
ERROR: Clear inode of 215043, inode has unwritten extents
...
Call Trace: ? __set_current_blocked+0x42/0x68 ocfs2_evict_inode+0x91/0x6a0 [ocfs2] ? bit_waitqueue+0x40/0x33 evict+0xdb/0x1af iput+0x1a2/0x1f7 do_unlinkat+0x194/0x28f SyS_unlinkat+0x1b/0x2f do_syscall_64+0x79/0x1ae entry_SYSCALL_64_after_hwframe+0x151/0x0
This patch also logs, with frequency limit, direct IO failures.
--- fs/ocfs2/aops.c | 12 ++++++++++-- fs/ocfs2/cluster/masklog.h | 9 +++++++++ 2 files changed, 19 insertions(+), 2 deletions(-)
fs/ocfs2/aops.c +10 -2
@@ -2404,8 +2404,16 @@ static int ocfs2_dio_end_io(struct kiocb/* this io's submitter should not have unlocked this before we could */ BUG_ON (!ocfs2_iocb_is_rw_locked (iocb)); -if (bytes >0 && private) - ret =ocfs2_dio_end_io_write (inode, private, offset, bytes); +if (bytes <=0 ) +mlog_ratelimited (ML_ERROR ,"Direct IO failed, bytes = %lld" , + (long long )bytes); +if (private) { +if (bytes >0 ) + ret =ocfs2_dio_end_io_write (inode, private, offset, + bytes); +else +ocfs2_dio_free_write_ctx (inode, private); + }ocfs2_iocb_clear_rw_locked (iocb);
fs/ocfs2/cluster/masklog.h +9 -0
@@ -178,6 +178,15 @@ do { \ ##__VA_ARGS__); \ } while (0) +#define mlog_ratelimited (mask, fmt, ...) \ +do { \ + static DEFINE_RATELIMIT_STATE(_rs, \ + DEFAULT_RATELIMIT_INTERVAL, \ + DEFAULT_RATELIMIT_BURST); \ + if (__ratelimit(&_rs)) \ + mlog(mask, fmt, ##__VA_ARGS__); \ +} while (0) +#define mlog_errno (st) ({ \ int _st = (st); \ if (_st != -ERESTARTSYS && _st != -EINTR && \
Greg Kroah-Hartman
maintainerPATCH 58/124 mm: thp: relax __GFP_THISNODE for MADV_HUGEPAGE mappings
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andrea Arcangeli <[email protected]>
commit ac5b2c18911ffe95c08d69273917f90212cf5659 upstream.
THP allocation might be really disruptive when allocated on NUMA system with the local node full or hard to reclaim. Stefan has posted an allocation stall report on 4.12 based SLES kernel which suggests the same issue:
kvm: page allocation stalls for 194572ms, order:9, mode:0x4740ca(__GFP_HIGHMEM|__GFP_IO|__GFP_FS|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_HARDWALL|__GFP_THISNODE|__GFP_MOVABLE|__GFP_DIRECT_RECLAIM), nodemask=(null) kvm cpuset=/ mems_allowed=0-1
CPU: 10 PID: 84752 Comm: kvm Tainted: G W 4.12.0+98-ph <a href="/view.php?id=1" title="[geschlossen] Integration Ramdisk" class="resolved">0000001</a> SLE15 (unreleased) Hardware name: Supermicro SYS-1029P-WTRT/X11DDW-NT, BIOS 2.0 12/05/2017 Call Trace: dump_stack+0x5c/0x84 warn_alloc+0xe0/0x180 __alloc_pages_slowpath+0x820/0xc90 __alloc_pages_nodemask+0x1cc/0x210 alloc_pages_vma+0x1e5/0x280 do_huge_pmd_wp_page+0x83f/0xf00 __handle_mm_fault+0x93d/0x1060 handle_mm_fault+0xc6/0x1b0 __do_page_fault+0x230/0x430 do_page_fault+0x2a/0x70 page_fault+0x7b/0x80 [...] Mem-Info: active_anon:126315487 inactive_anon:1612476 isolated_anon:5 active_file:60183 inactive_file:245285 isolated_file:0 unevictable:15657 dirty:286 writeback:1 unstable:0 slab_reclaimable:75543 slab_unreclaimable:2509111 mapped:81814 shmem:31764 pagetables:370616 bounce:0 free:32294031 free_pcp:6233 free_cma:0 Node 0 active_anon:254680388kB inactive_anon:1112760kB active_file:240648kB inactive_file:981168kB unevictable:13368kB isolated(anon):0kB isolated(file):0kB mapped:280240kB dirty:1144kB writeback:0kB shmem:95832kB shmem_thp: 0kB shmem_pmdmapped: 0kB anon_thp: 81225728kB writeback_tmp:0kB unstable:0kB all_unreclaimable? no Node 1 active_anon:250583072kB inactive_anon:5337144kB active_file:84kB inactive_file:0kB unevictable:49260kB isolated(anon):20kB isolated(file):0kB mapped:47016kB dirty:0kB writeback:4kB shmem:31224kB shmem_thp: 0kB shmem_pmdmapped: 0kB anon_thp: 31897600kB writeback_tmp:0kB unstable:0kB all_unreclaimable? no
The defrag mode is "madvise" and from the above report it is clear that the THP has been allocated for MADV_HUGEPAGA vma.
Andrea has identified that the main source of the problem is __GFP_THISNODE usage:
: The problem is that direct compaction combined with the NUMA : __GFP_THISNODE logic in mempolicy.c is telling reclaim to swap very : hard the local node, instead of failing the allocation if there's no : THP available in the local node.
:
: Such logic was ok until __GFP_THISNODE was added to the THP allocation : path even with MPOL_DEFAULT.
:
: The idea behind the __GFP_THISNODE addition, is that it is better to : provide local memory in PAGE_SIZE units than to use remote NUMA THP : backed memory. That largely depends on the remote latency though, on : threadrippers for example the overhead is relatively low in my : experience.
:
: The combination of __GFP_THISNODE and __GFP_DIRECT_RECLAIM results in : extremely slow qemu startup with vfio, if the VM is larger than the : size of one host NUMA node. This is because it will try very hard to : unsuccessfully swapout get_user_pages pinned pages as result of the : __GFP_THISNODE being set, instead of falling back to PAGE_SIZE : allocations and instead of trying to allocate THP on other nodes (it : would be even worse without vfio type1 GUP pins of course, except it'd : be swapping heavily instead).
Fix this by removing __GFP_THISNODE for THP requests which are requesting the direct reclaim. This effectivelly reverts 5265047ac301 on the grounds that the zone/node reclaim was known to be disruptive due to premature reclaim when there was memory free. While it made sense at the time for HPC workloads without NUMA awareness on rare machines, it was ultimately harmful in the majority of cases. The existing behaviour is similar, if not as widespare as it applies to a corner case but crucially, it cannot be tuned around like zone_reclaim_mode can. The default behaviour should always be to cause the least harm for the common case.
If there are specialised use cases out there that want zone_reclaim_mode in specific cases, then it can be built on top. Longterm we should consider a memory policy which allows for the node reclaim like behavior for the specific memory ranges which would allow a
[1] http://lkml.kernel.org/r/[email protected]
Mel said:
: Both patches look correct to me but I'm responding to this one because : it's the fix. The change makes sense and moves further away from the : severe stalling behaviour we used to see with both THP and zone reclaim : mode.
:
: I put together a basic experiment with usemem configured to reference a : buffer multiple times that is 80% the size of main memory on a 2-socket : box with symmetric node sizes and defrag set to "always". The defrag : setting is not the default but it would be functionally similar to : accessing a buffer with madvise(MADV_HUGEPAGE). Usemem is configured to : reference the buffer multiple times and while it's not an interesting : workload, it would be expected to complete reasonably quickly as it fits : within memory. The results were;
:
: usemem
: vanilla noreclaim-v1
: Amean Elapsd-1 42.78 ( 0.00%) 26.87 ( 37.18%) : Amean Elapsd-3 27.55 ( 0.00%) 7.44 ( 73.00%) : Amean Elapsd-4 5.72 ( 0.00%) 5.69 ( 0.45%)
:
: This shows the elapsed time in seconds for 1 thread, 3 threads and 4 : threads referencing buffers 80% the size of memory. With the patches : applied, it's 37.18% faster for the single thread and 73% faster with two : threads. Note that 4 threads showing little difference does not indicate : the problem is related to thread counts. It's simply the case that 4 : threads gets spread so their workload mostly fits in one node. :
: The overall view from /proc/vmstats is more startling
:
: 4.19.0-rc1 4.19.0-rc1
: vanillanoreclaim-v1r1
: Minor Faults 35593425 708164
: Major Faults 484088 36
: Swap Ins 3772837 0 : Swap Outs 3932295 0 : : Massive amounts of swap in/out without the patch : : Direct pages scanned 6013214 0 : Kswapd pages scanned 0 0 : Kswapd pages reclaimed 0 0 : Direct pages reclaimed 4033009 0
:
: Lots of reclaim activity without the patch
:
: Kswapd efficiency 100% 100%
: Kswapd velocity 0.000 0.000
: Direct efficiency 67% 100%
: Direct velocity 11191.956 0.000
:
: Mostly from direct reclaim context as you'd expect without the patch. :
: Page writes by reclaim 3932314.000 0.000
: Page writes file 19 0 : Page writes anon 3932295 0 : Page reclaim immediate 42336 0
:
: Writes from reclaim context is never good but the patch eliminates it. :
: We should never have default behaviour to thrash the system for such a : basic workload. If zone reclaim mode behaviour is ever desired but on a : single task instead of a global basis then the sensible option is to build : a mempolicy that enforces that behaviour.
This was a severe regression compared to previous kernels that made important workloads unusable and it starts when __GFP_THISNODE was added to THP allocations under MADV_HUGEPAGE. It is not a significant risk to go to the previous behavior before __GFP_THISNODE was added, it worked like that for years.
This was simply an optimization to some lucky workloads that can fit in a single node, but it ended up breaking the VM for others that can't possibly fit in a single node, so going back is safe.
--- mm/mempolicy.c | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-)
mm/mempolicy.c +30 -2
@@ -2012,8 +2012,36 @@ alloc_pages_vma(gfp_t gfp, int order, st nmask =policy_nodemask (gfp, pol);if (!nmask ||node_isset (hpage_node, *nmask)) {mpol_cond_put (pol); - page =__alloc_pages_node (hpage_node, - gfp | __GFP_THISNODE, order); +/* +* We cannot invoke reclaim if __GFP_THISNODE +* is set. Invoking reclaim with +* __GFP_THISNODE set, would cause THP +* allocations to trigger heavy swapping +* despite there may be tons of free memory +* (including potentially plenty of THP +* already available in the buddy) on all the +* other NUMA nodes. +* +* At most we could invoke compaction when +* __GFP_THISNODE is set (but we would need to +* refrain from invoking reclaim even if +* compaction returned COMPACT_SKIPPED because +* there wasn't not enough memory to succeed +* compaction). For now just avoid +* __GFP_THISNODE instead of limiting the +* allocation path to a strict and single +* compaction invocation. +* +* Supposedly if direct reclaim was enabled by +* the caller, the app prefers THP regardless +* of the node it comes from so this would be +* more desiderable behavior than only +* providing THP originated from the local +* node in such case. +*/ +if (!(gfp & __GFP_DIRECT_RECLAIM)) + gfp |= __GFP_THISNODE; + page =__alloc_pages_node (hpage_node, gfp, order); goto out; } }
Greg Kroah-Hartman
maintainerPATCH 59/124 netfilter: conntrack: fix calculation of next bucket number in early_drop
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Khoruzhick <[email protected]>
commit f393808dc64149ccd0e5a8427505ba2974a59854 upstream.
If there's no entry to drop in bucket that corresponds to the hash, early_drop() should look for it in other buckets. But since it increments hash instead of bucket number, it actually looks in the same bucket 8
times: hsize is 16k by default (14 bits) and hash is 32-bit value, so reciprocal_scale(hash, hsize) returns the same value for hash..hash+7 in most cases.
Fix it by increasing bucket number instead of hash and rename _hash to bucket to avoid future confusion.
--- net/netfilter/nf_conntrack_core.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)
net/netfilter/nf_conntrack_core.c +8 -5
@@ -932,19 +932,22 @@ static unsigned int early_drop_list(strureturn drops; } -static noinline int early_drop(struct net *net, unsigned int _hash) +static noinline int early_drop(struct net *net, unsigned int hash) { -unsigned int i; +unsigned int i, bucket;for (i =0 ; i <NF_CT_EVICTION_RANGE ; i++) {struct hlist_nulls_head *ct_hash; -unsigned int hash, hsize, drops; +unsigned int hsize, drops;rcu_read_lock ();nf_conntrack_get_ht (&ct_hash, &hsize); - hash =reciprocal_scale (_hash++, hsize); +if (!i) + bucket =reciprocal_scale (hash, hsize); +else + bucket = (bucket +1 ) % hsize; - drops =early_drop_list (net, &ct_hash[hash]); + drops =early_drop_list (net, &ct_hash[bucket]);rcu_read_unlock ();if (drops) {
Greg Kroah-Hartman
maintainerPATCH 60/124 ARM: 8809/1: proc-v7: fix Thumb annotation of cpu_v7_hvc_switch_mm
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ard Biesheuvel <[email protected]>
commit 6282e916f774e37845c65d1eae9f8c649004f033 upstream.
Due to what appears to be a copy/paste error, the opening ENTRY() of cpu_v7_hvc_switch_mm() lacks a matching ENDPROC(), and instead, the one for cpu_v7_smc_switch_mm() is duplicated.
Given that it is ENDPROC() that emits the Thumb annotation, the cpu_v7_hvc_switch_mm() routine will be called in ARM mode on a Thumb2 kernel, resulting in the following splat:
Internal error: Oops - undefined instruction: 0 [#1] SMP THUMB2 Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.18.0-rc1-00030-g4d28ad89189d-dirty #488 Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015 PC is at cpu_v7_hvc_switch_mm+0x12/0x18 LR is at flush_old_exec+0x31b/0x570 pc : [<c0316efe>] lr : [<c04117c7>] psr: 00000013 sp : ee899e50 ip : 00000000 fp : 00000001 r10: eda28f34 r9 : eda31800 r8 : c12470e0 r7 : eda1fc00 r6 : eda53000 r5 : 00000000 r4 : ee88c000 r3 : c0316eec r2 : 00000001 r1 : eda53000 r0 : 6da6c000 Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none
Note the 'ISA ARM' in the last line.
Fix this by using the correct name in ENDPROC().
--- arch/arm/mm/proc-v7.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/proc-v7.S +1 -1
@@ -112,7 +112,7 @@ ENTRY(cpu_v7_hvc_switch_mm) hvc #0 ldmfd sp!, {r0 - r3} b cpu_v7_switch_mm -ENDPROC(cpu_v7_smc_switch_mm) +ENDPROC(cpu_v7_hvc_switch_mm) #endif ENTRY(cpu_v7_iciallu_switch_mm) mov r3, #0
Greg Kroah-Hartman
maintainerPATCH 61/124 mtd: docg3: dont set conflicting BCH_CONST_PARAMS option
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Arnd Bergmann <[email protected]>
commit be2e1c9dcf76886a83fb1c433a316e26d4ca2550 upstream.
I noticed during the creation of another bugfix that the BCH_CONST_PARAMS option that is set by DOCG3 breaks setting variable parameters for any other users of the BCH library code.
The only other user we have today is the MTD_NAND software BCH implementation (most flash controllers use hardware BCH these days and are not affected). I considered removing BCH_CONST_PARAMS entirely because of the inherent conflict, but according to the description in lib/bch.c there is a significant performance benefit in keeping it.
To avoid the immediate problem of the conflict between MTD_NAND_BCH and DOCG3, this only sets the constant parameters if MTD_NAND_BCH is disabled, which should fix the problem for all cases that are affected. This should also work for all stable kernels.
Note that there is only one machine that actually seems to use the DOCG3 driver (arch/arm/mach-pxa/mioa701.c), so most users should have the driver disabled, but it almost certainly shows up if we wanted to test random kernels on machines that use software BCH in MTD.
--- drivers/mtd/devices/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/devices/Kconfig +1 -1
@@ -206,7 +206,7 @@ comment "Disk-On-Chip Device Drivers" config MTD_DOCG3 tristate "M-Systems Disk-On-Chip G3" select BCH - select BCH_CONST_PARAMS + select BCH_CONST_PARAMS if !MTD_NAND_BCH select BITREVERSE ---help--- This provides an MTD device driver for the M-Systems DiskOnChip
Greg Kroah-Hartman
maintainerPATCH 62/124 of, numa: Validate some distance map rules
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: John Garry <[email protected]>
commit 89c38422e072bb453e3045b8f1b962a344c3edea upstream.
Currently the NUMA distance map parsing does not validate the distance table for the distance-matrix rules 1-2 in [1].
However the arch NUMA code may enforce some of these rules, but not all. Such is the case for the arm64 port, which does not enforce the rule that the distance between separates nodes cannot equal LOCAL_DISTANCE.
The patch adds the following rules validation:
- distance of node to self equals LOCAL_DISTANCE
- distance of separate nodes > LOCAL_DISTANCE
This change avoids a yet-unresolved crash reported in [2].
A note on dealing with symmetrical distances between nodes:
Validating symmetrical distances between nodes is difficult. If it were mandated in the bindings that every distance must be recorded in the table, then it would be easy. However, it isn't.
In addition to this, it is also possible to record [b, a] distance only (and not [a, b]). So, when processing the table for [b, a], we cannot assert that current distance of [a, b] != [b, a] as invalid, as [a, b] distance may not be present in the table and current distance would be default at REMOTE_DISTANCE.
As such, we maintain the policy that we overwrite distance [a, b] = [b, a] for b > a. This policy is different to kernel ACPI SLIT validation, which allows non-symmetrical distances (ACPI spec SLIT rules allow it). However, the distance debug message is dropped as it may be misleading (for a distance which is later overwritten).
Some final notes on semantics:
- It is implied that it is the responsibility of the arch NUMA code to reset the NUMA distance map for an error in distance map parsing.
- It is the responsibility of the FW NUMA topology parsing (whether OF or ACPI) to enforce NUMA distance rules, and not arch NUMA code.
[1] Documents/devicetree/bindings/numa.txt
[2] https://www.spinics.net/lists/arm-kernel/msg683304.html
--- drivers/of/of_numa.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/of/of_numa.c +7 -2
@@ -126,9 +126,14 @@ static int __init of_numa_parse_distance distance =of_read_number (matrix,1 ); matrix++; +if ((nodea == nodeb && distance !=LOCAL_DISTANCE ) || + (nodea != nodeb && distance <=LOCAL_DISTANCE )) { +pr_err ("Invalid distance[node%d -> node%d] = %d\n" , + nodea, nodeb, distance); +return -EINVAL ; + } +numa_set_distance (nodea, nodeb, distance); -pr_debug ("distance[node%d -> node%d] = %d\n" , - nodea, nodeb, distance);/* Set default distance of node B->A same as A->B */ if (nodeb > nodea)
Greg Kroah-Hartman
maintainerPATCH 63/124 x86/cpu/vmware: Do not trace vmware_sched_clock()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Steven Rostedt (VMware) <[email protected]>
commit 15035388439f892017d38b05214d3cda6578af64 upstream.
When running function tracing on a Linux guest running on VMware Workstation, the guest would crash. This is due to tracing of the sched_clock internal call of the VMware vmware_sched_clock(), which causes an infinite recursion within the tracing code (clock calls must not be traced).
Make vmware_sched_clock() not traced by ftrace.
--- arch/x86/kernel/cpu/vmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/vmware.c +1 -1
@@ -77,7 +77,7 @@ static __init int setup_vmw_sched_clock( }early_param ("no-vmw-sched-clock" , setup_vmw_sched_clock); -static unsigned long long vmware_sched_clock (void ) +static unsigned long long notrace vmware_sched_clock (void ) {unsigned long long ns;
Greg Kroah-Hartman
maintainerPATCH 63/124 x86/cpu/vmware: Do not trace vmware_sched_clock()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Steven Rostedt (VMware) <[email protected]>
commit 15035388439f892017d38b05214d3cda6578af64 upstream.
When running function tracing on a Linux guest running on VMware Workstation, the guest would crash. This is due to tracing of the sched_clock internal call of the VMware vmware_sched_clock(), which causes an infinite recursion within the tracing code (clock calls must not be traced).
Make vmware_sched_clock() not traced by ftrace.
--- arch/x86/kernel/cpu/vmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/vmware.c +1 -1
@@ -77,7 +77,7 @@ static __init int setup_vmw_sched_clock( }early_param ("no-vmw-sched-clock" , setup_vmw_sched_clock); -static unsigned long long vmware_sched_clock (void ) +static unsigned long long notrace vmware_sched_clock (void ) {unsigned long long ns;
Greg Kroah-Hartman
maintainerPATCH 64/124 x86/hyper-v: Enable PIT shutdown quirk
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michael Kelley <[email protected]>
commit 1de72c706488b7be664a601cf3843bd01e327e58 upstream.
Hyper-V emulation of the PIT has a quirk such that the normal PIT shutdown path doesn't work, because clearing the counter register restarts the timer.
Disable the counter clearing on PIT shutdown.
--- arch/x86/kernel/cpu/mshyperv.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/x86/kernel/cpu/mshyperv.c +11 -0
@@ -20,6 +20,7 @@#include <linux/interrupt.h> #include <linux/irq.h> #include <linux/kexec.h> +#include <linux/i8253.h> #include <asm/processor.h> #include <asm/hypervisor.h> #include <asm/hyperv.h>
@@ -243,6 +244,16 @@ static void __init ms_hyperv_init_platfoif (efi_enabled (EFI_BOOT )) x86_platform.get_nmi_reason = hv_get_nmi_reason; +/* +* Hyper-V VMs have a PIT emulation quirk such that zeroing the +* counter register during PIT shutdown restarts the PIT. So it +* continues to interrupt @18.2 HZ. Setting i8253_clear_counter +* to false tells pit_shutdown() not to zero the counter so that +* the PIT really is shutdown. Generation 2 VMs don't have a PIT, +* and setting this value has no effect. +*/ + i8253_clear_counter_on_shutdown = false; +#if IS_ENABLED (CONFIG_HYPERV )/* * Setup the hook to get control post apic initialization.
Greg Kroah-Hartman
maintainerPATCH 64/124 x86/hyper-v: Enable PIT shutdown quirk
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michael Kelley <[email protected]>
commit 1de72c706488b7be664a601cf3843bd01e327e58 upstream.
Hyper-V emulation of the PIT has a quirk such that the normal PIT shutdown path doesn't work, because clearing the counter register restarts the timer.
Disable the counter clearing on PIT shutdown.
--- arch/x86/kernel/cpu/mshyperv.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/x86/kernel/cpu/mshyperv.c +11 -0
@@ -20,6 +20,7 @@#include <linux/interrupt.h> #include <linux/irq.h> #include <linux/kexec.h> +#include <linux/i8253.h> #include <asm/processor.h> #include <asm/hypervisor.h> #include <asm/hyperv.h>
@@ -243,6 +244,16 @@ static void __init ms_hyperv_init_platfoif (efi_enabled (EFI_BOOT )) x86_platform.get_nmi_reason = hv_get_nmi_reason; +/* +* Hyper-V VMs have a PIT emulation quirk such that zeroing the +* counter register during PIT shutdown restarts the PIT. So it +* continues to interrupt @18.2 HZ. Setting i8253_clear_counter +* to false tells pit_shutdown() not to zero the counter so that +* the PIT really is shutdown. Generation 2 VMs don't have a PIT, +* and setting this value has no effect. +*/ + i8253_clear_counter_on_shutdown = false; +#if IS_ENABLED (CONFIG_HYPERV )/* * Setup the hook to get control post apic initialization.
Greg Kroah-Hartman
maintainerPATCH 65/124 termios, tty/tty_baudrate.c: fix buffer overrun
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: H. Peter Anvin <[email protected]>
commit 991a25194097006ec1e0d2e0814ff920e59e3465 upstream.
On architectures with CBAUDEX == 0 (Alpha and PowerPC), the code in tty_baudrate.c does not do any limit checking on the tty_baudrate[] array, and in fact a buffer overrun is possible on both architectures. Add a limit check to prevent that situation.
This will be followed by a much bigger cleanup/simplification patch.
--- drivers/tty/tty_baudrate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/tty_baudrate.c +2 -2
@@ -76,7 +76,7 @@ speed_t tty_termios_baud_rate(struct kteelse cbaud +=15 ; } -return baud_table[cbaud]; +return cbaud >= n_baud_table ?0 : baud_table[cbaud]; }EXPORT_SYMBOL (tty_termios_baud_rate);
@@ -112,7 +112,7 @@ speed_t tty_termios_input_baud_rate(stru else cbaud += 15; } -return baud_table[cbaud]; +return cbaud >= n_baud_table ?0 : baud_table[cbaud];#else return tty_termios_baud_rate (termios);#endif
Greg Kroah-Hartman
maintainerPATCH 66/124 arch/alpha, termios: implement BOTHER, IBSHIFT and termios2
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: H. Peter Anvin (Intel) <[email protected]>
commit d0ffb805b729322626639336986bc83fc2e60871 upstream.
Alpha has had c_ispeed and c_ospeed, but still set speeds in c_cflags using arbitrary flags. Because BOTHER is not defined, the general Linux code doesn't allow setting arbitrary baud rates, and because CBAUDEX == 0, we can have an array overrun of the baud_rate[] table in drivers/tty/tty_baudrate.c if (c_cflags & CBAUD) == 037.
Resolve both problems by #defining BOTHER to 037 on Alpha.
However, userspace still needs to know if setting BOTHER is actually safe given legacy kernels (does anyone actually care about that on Alpha anymore?), so enable the TCGETS2/TCSETS*2 ioctls on Alpha, even though they use the same structure. Define struct termios2 just for compatibility; it is the exact same structure as struct termios. In a future patchset, this will be cleaned up so the uapi headers are usable from libc.
--- arch/alpha/include/asm/termios.h | 8 +++++++- arch/alpha/include/uapi/asm/ioctls.h | 5 +++++ arch/alpha/include/uapi/asm/termbits.h | 17 +++++++++++++++++ 3 files changed, 29 insertions(+), 1 deletion(-)
arch/alpha/include/asm/termios.h +7 -1
@@ -73,9 +73,15 @@ })#define user_termios_to_kernel_termios (k, u) \ - copy_from_user(k, u, sizeof(struct termios)) + copy_from_user(k, u, sizeof(struct termios2))#define kernel_termios_to_user_termios (u, k) \ + copy_to_user(u, k, sizeof(struct termios2)) + +#define user_termios_to_kernel_termios_1 (k, u) \ + copy_from_user(k, u, sizeof(struct termios)) + +#define kernel_termios_to_user_termios_1 (u, k) \ copy_to_user(u, k, sizeof(struct termios))#endif /* _ALPHA_TERMIOS_H */
arch/alpha/include/uapi/asm/ioctls.h +5 -0
@@ -32,6 +32,11 @@#define TCXONC _IO('t', 30)#define TCFLSH _IO('t', 31) +#define TCGETS2 _IOR('T', 42, struct termios2) +#define TCSETS2 _IOW('T', 43, struct termios2) +#define TCSETSW2 _IOW('T', 44, struct termios2) +#define TCSETSF2 _IOW('T', 45, struct termios2) +#define TIOCSWINSZ _IOW('t', 103, struct winsize)#define TIOCGWINSZ _IOR('t', 104, struct winsize)#define TIOCSTART _IO('t', 110)/* start output, like ^Q */
arch/alpha/include/uapi/asm/termbits.h +17 -0
@@ -26,6 +26,19 @@ struct termios {speed_t c_ospeed;/* output speed */ }; +/* Alpha has identical termios and termios2 */ + +struct termios2 { +tcflag_t c_iflag;/* input mode flags */ +tcflag_t c_oflag;/* output mode flags */ +tcflag_t c_cflag;/* control mode flags */ +tcflag_t c_lflag;/* local mode flags */ +cc_t c_cc[NCCS ];/* control characters */ +cc_t c_line;/* line discipline (== c_cc[19]) */ +speed_t c_ispeed;/* input speed */ +speed_t c_ospeed;/* output speed */ +}; +/* Alpha has matching termios and ktermios */ struct ktermios {
@@ -148,6 +161,7 @@ struct ktermios {#define B3000000 00034#define B3500000 00035#define B4000000 00036 +#define BOTHER 00037#define CSIZE 00001400#define CS5 00000000
@@ -165,6 +179,9 @@ struct ktermios {#define CMSPAR 010000000000/* mark or space (stick) parity */ #define CRTSCTS 020000000000/* flow control */ +#define CIBAUD 07600000 +#define IBSHIFT 16 +/* c_lflag bits */ #define ISIG 0x00000080#define ICANON 0x00000100
Greg Kroah-Hartman
maintainerPATCH 67/124 watchdog/core: Add missing prototypes for weak functions
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mathieu Malaterre <[email protected]>
commit 81bd415c91eb966118d773dddf254aebf3022411 upstream.
The split out of the hard lockup detector exposed two new weak functions, but no prototypes for them, which triggers the build warning:
kernel/watchdog.c:109:12: warning: no previous prototype for ‘watchdog_nmi_enable’ [-Wmissing-prototypes] kernel/watchdog.c:115:13: warning: no previous prototype for ‘watchdog_nmi_disable’ [-Wmissing-prototypes]
Add the prototypes.
--- include/linux/nmi.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/nmi.h +2 -0
@@ -113,6 +113,8 @@ static inline int hardlockup_detector_pevoid watchdog_nmi_stop (void );void watchdog_nmi_start (void );int watchdog_nmi_probe (void ); +int watchdog_nmi_enable (unsigned int cpu); +void watchdog_nmi_disable (unsigned int cpu);/** * touch_nmi_watchdog - restart NMI watchdog timeout.
Greg Kroah-Hartman
maintainerPATCH 68/124 btrfs: fix pinned underflow after transaction aborted
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lu Fengqi <[email protected]>
commit fcd5e74288f7d36991b1f0fb96b8c57079645e38 upstream.
When running generic/475, we may get the following warning in dmesg:
[ 6902.102154] WARNING: CPU: 3 PID: 18013 at fs/btrfs/extent-tree.c:9776 btrfs_free_block_groups+0x2af/0x3b0 [btrfs] [ 6902.109160] CPU: 3 PID: 18013 Comm: umount Tainted: G W O 4.19.0-rc8+ #8 [ 6902.110971] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015 [ 6902.112857] RIP: 0010:btrfs_free_block_groups+0x2af/0x3b0 [btrfs] [ 6902.118921] RSP: 0018:ffffc9000459bdb0 EFLAGS: 00010286 [ 6902.120315] RAX: ffff880175050bb0 RBX: ffff8801124a8000 RCX: 0000000000170007 [ 6902.121969] RDX: 0000000000000002 RSI: 0000000000170007 RDI: ffffffff8125fb74 [ 6902.123716] RBP: ffff880175055d10 R08: 0000000000000000 R09: 0000000000000000 [ 6902.125417] R10: 0000000000000000 R11: 0000000000000000 R12: ffff880175055d88 [ 6902.127129] R13: ffff880175050bb0 R14: 0000000000000000 R15: dead000000000100 [ 6902.129060] FS: 00007f4507223780(0000) GS:ffff88017ba00000(0000) knlGS:0000000000000000 [ 6902.130996] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 6902.132558] CR2: 00005623599cac78 CR3: 000000014b700001 CR4: 00000000003606e0 [ 6902.134270] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 6902.135981] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 6902.137836] Call Trace: [ 6902.138939] close_ctree+0x171/0x330 [btrfs] [ 6902.140181] ? kthread_stop+0x146/0x1f0 [ 6902.141277] generic_shutdown_super+0x6c/0x100 [ 6902.142517] kill_anon_super+0x14/0x30 [ 6902.143554] btrfs_kill_super+0x13/0x100 [btrfs] [ 6902.144790] deactivate_locked_super+0x2f/0x70 [ 6902.146014] cleanup_mnt+0x3b/0x70 [ 6902.147020] task_work_run+0x9e/0xd0 [ 6902.148036] do_syscall_64+0x470/0x600 [ 6902.149142] ? trace_hardirqs_off_thunk+0x1a/0x1c [ 6902.150375] entry_SYSCALL_64_after_hwframe+0x49/0xbe [ 6902.151640] RIP: 0033:0x7f45077a6a7b [ 6902.157324] RSP: 002b:00007ffd589f3e68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6 [ 6902.159187] RAX: 0000000000000000 RBX: 000055e8eec732b0 RCX: 00007f45077a6a7b [ 6902.160834] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 000055e8eec73490 [ 6902.162526] RBP: 0000000000000000 R08: 000055e8eec734b0 R09: 00007ffd589f26c0 [ 6902.164141] R10: 0000000000000000 R11: 0000000000000246 R12: 000055e8eec73490 [ 6902.165815] R13: 00007f4507ac61a4 R14: 0000000000000000 R15: 00007ffd589f40d8 [ 6902.167553] irq event stamp: 0 [ 6902.168998] hardirqs last enabled at (0): [<0000000000000000>] (null) [ 6902.170731] hardirqs last disabled at (0): [<ffffffff810cd810>] copy_process.part.55+0x3b0/0x1f00 [ 6902.172773] softirqs last enabled at (0): [<ffffffff810cd810>] copy_process.part.55+0x3b0/0x1f00 [ 6902.174671] softirqs last disabled at (0): [<0000000000000000>] (null) [ 6902.176407] ---[ end trace 463138c2986b275c ]--- [ 6902.177636] BTRFS info (device dm-3): space_info 4 has 273465344 free, is not full [ 6902.179453] BTRFS info (device dm-3): space_info total=276824064, used=4685824, pinned=18446744073708158976, reserved=0, may_use=0, readonly=65536
In the above line there's "pinned=18446744073708158976" which is an unsigned u64 value of -1392640, an obvious underflow.
When transaction_kthread is running cleanup_transaction(), another fsstress is running btrfs_commit_transaction(). The btrfs_finish_extent_commit() may get the same range as btrfs_destroy_pinned_extent() got, which causes the pinned underflow.
--- fs/btrfs/disk-io.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
fs/btrfs/disk-io.c +11 -1
@@ -4428,13 +4428,23 @@ static int btrfs_destroy_pinned_extent(s unpin = pinned_extents; again:while (1 ) { +/* +* The btrfs_finish_extent_commit() may get the same range as +* ours between find_first_extent_bit and clear_extent_dirty. +* Hence, hold the unused_bg_unpin_mutex to avoid double unpin +* the same extent range. +*/ +mutex_lock (&fs_info->unused_bg_unpin_mutex); ret =find_first_extent_bit (unpin,0 , &start, &end,EXTENT_DIRTY ,NULL ); -if (ret) +if (ret) { +mutex_unlock (&fs_info->unused_bg_unpin_mutex);break ; + }clear_extent_dirty (unpin, start, end);btrfs_error_unpin_extent_range (fs_info, start, end); +mutex_unlock (&fs_info->unused_bg_unpin_mutex);cond_resched (); }
Greg Kroah-Hartman
maintainerPATCH 69/124 Btrfs: fix cur_offset in the error case for nocow
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Robbie Ko <[email protected]>
commit 506481b20e818db40b6198815904ecd2d6daee64 upstream.
When the cow_file_range fails, the related resources are unlocked according to the range [start..end), so the unlock cannot be repeated in run_delalloc_nocow.
In some cases (e.g. cur_offset <= end && cow_start != -1), cur_offset is not updated correctly, so move the cur_offset update before cow_file_range.
kernel BUG at mm/page-writeback.c:2663!
Internal error: Oops - BUG: 0 [#1] SMP CPU: 3 PID: 31525 Comm: kworker/u8:7 Tainted: P O Hardware name: Realtek_RTD1296 (DT) Workqueue: writeback wb_workfn (flush-btrfs-1) task: ffffffc076db3380 ti: ffffffc02e9ac000 task.ti: ffffffc02e9ac000 PC is at clear_page_dirty_for_io+0x1bc/0x1e8 LR is at clear_page_dirty_for_io+0x14/0x1e8 pc : [<ffffffc00033c91c>] lr : [<ffffffc00033c774>] pstate: 40000145 sp : ffffffc02e9af4f0 Process kworker/u8:7 (pid: 31525, stack limit = 0xffffffc02e9ac020) Call trace: [<ffffffc00033c91c>] clear_page_dirty_for_io+0x1bc/0x1e8 [<ffffffbffc514674>] extent_clear_unlock_delalloc+0x1e4/0x210 [btrfs] [<ffffffbffc4fb168>] run_delalloc_nocow+0x3b8/0x948 [btrfs] [<ffffffbffc4fb948>] run_delalloc_range+0x250/0x3a8 [btrfs] [<ffffffbffc514c0c>] writepage_delalloc.isra.21+0xbc/0x1d8 [btrfs] [<ffffffbffc516048>] __extent_writepage+0xe8/0x248 [btrfs] [<ffffffbffc51630c>] extent_write_cache_pages.isra.17+0x164/0x378 [btrfs] [<ffffffbffc5185a8>] extent_writepages+0x48/0x68 [btrfs] [<ffffffbffc4f5828>] btrfs_writepages+0x20/0x30 [btrfs] [<ffffffc00033d758>] do_writepages+0x30/0x88 [<ffffffc0003ba0f4>] __writeback_single_inode+0x34/0x198 [<ffffffc0003ba6c4>] writeback_sb_inodes+0x184/0x3c0 [<ffffffc0003ba96c>] __writeback_inodes_wb+0x6c/0xc0 [<ffffffc0003bac20>] wb_writeback+0x1b8/0x1c0 [<ffffffc0003bb0f0>] wb_workfn+0x150/0x250 [<ffffffc0002b0014>] process_one_work+0x1dc/0x388 [<ffffffc0002b02f0>] worker_thread+0x130/0x500 [<ffffffc0002b6344>] kthread+0x10c/0x110 [<ffffffc000284590>] ret_from_fork+0x10/0x40 Code: d503201f a9025bb5 a90363b7 f90023b9 (d4210000)
--- fs/btrfs/inode.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
fs/btrfs/inode.c +2 -3
@@ -1565,12 +1565,11 @@ out_check: }btrfs_release_path (path); -if (cur_offset <= end && cow_start == (u64)-1 ) { +if (cur_offset <= end && cow_start == (u64)-1 ) cow_start = cur_offset; - cur_offset = end; - }if (cow_start != (u64)-1 ) { + cur_offset = end; ret =cow_file_range (inode, locked_page, cow_start, end, end, page_started, nr_written,1 ,NULL );if (ret)
Greg Kroah-Hartman
maintainerPATCH 70/124 Btrfs: fix infinite loop on inode eviction after deduplication of eof block
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Filipe Manana <[email protected]>
commit 11023d3f5fdf89bba5e1142127701ca6e6014587 upstream.
If we attempt to deduplicate the last block of a file A into the middle of a file B, and file A's size is not a multiple of the block size, we end rounding the deduplication length to 0 bytes, to avoid the data corruption issue fixed by commit de02b9f6bb65 ("Btrfs: fix data corruption when deduplicating between different files"). However a length of zero will cause the insertion of an extent state with a start value greater (by 1) then the end value, leading to a corrupt extent state that will trigger a warning and cause chaos such as an infinite loop during inode eviction. Example trace:
[96049.833585] ------------[ cut here ]------------ [96049.833714] WARNING: CPU: 0 PID: 24448 at fs/btrfs/extent_io.c:436 insert_state+0x101/0x120 [btrfs] [96049.833767] CPU: 0 PID: 24448 Comm: xfs_io Not tainted 4.19.0-rc7-btrfs-next-39 #1 [96049.833768] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.11.2-0-gf9626ccb91-prebuilt.qemu-project.org 04/01/2014 [96049.833780] RIP: 0010:insert_state+0x101/0x120 [btrfs] [96049.833783] RSP: 0018:ffffafd2c3707af0 EFLAGS: 00010282 [96049.833785] RAX: 0000000000000000 RBX: 000000000004dfff RCX: 0000000000000006 [96049.833786] RDX: 0000000000000007 RSI: ffff99045c143230 RDI: ffff99047b2168a0 [96049.833787] RBP: ffff990457851cd0 R08: 0000000000000001 R09: 0000000000000000 [96049.833787] R10: ffffafd2c3707ab8 R11: 0000000000000000 R12: ffff9903b93b12c8 [96049.833788] R13: 000000000004e000 R14: ffffafd2c3707b80 R15: ffffafd2c3707b78 [96049.833790] FS: 00007f5c14e7d700(0000) GS:ffff99047b200000(0000) knlGS:0000000000000000 [96049.833791] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [96049.833792] CR2: 00007f5c146abff8 CR3: 0000000115f4c004 CR4: 00000000003606f0 [96049.833795] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [96049.833796] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [96049.833796] Call Trace: [96049.833809] __set_extent_bit+0x46c/0x6a0 [btrfs] [96049.833823] lock_extent_bits+0x6b/0x210 [btrfs] [96049.833831] ? _raw_spin_unlock+0x24/0x30 [96049.833841] ? test_range_bit+0xdf/0x130 [btrfs] [96049.833853] lock_extent_range+0x8e/0x150 [btrfs] [96049.833864] btrfs_double_extent_lock+0x78/0xb0 [btrfs] [96049.833875] btrfs_extent_same_range+0x14e/0x550 [btrfs] [96049.833885] ? rcu_read_lock_sched_held+0x3f/0x70 [96049.833890] ? __kmalloc_node+0x2b0/0x2f0 [96049.833899] ? btrfs_dedupe_file_range+0x19a/0x280 [btrfs] [96049.833909] btrfs_dedupe_file_range+0x270/0x280 [btrfs] [96049.833916] vfs_dedupe_file_range_one+0xd9/0xe0 [96049.833919] vfs_dedupe_file_range+0x131/0x1b0 [96049.833924] do_vfs_ioctl+0x272/0x6e0 [96049.833927] ? __fget+0x113/0x200 [96049.833931] ksys_ioctl+0x70/0x80 [96049.833933] __x64_sys_ioctl+0x16/0x20 [96049.833937] do_syscall_64+0x60/0x1b0 [96049.833939] entry_SYSCALL_64_after_hwframe+0x49/0xbe [96049.833941] RIP: 0033:0x7f5c1478ddd7 [96049.833943] RSP: 002b:00007ffe15b196a8 EFLAGS: 00000202 ORIG_RAX: 0000000000000010 [96049.833945] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f5c1478ddd7 [96049.833946] RDX: 00005625ece322d0 RSI: 00000000c0189436 RDI: 0000000000000004 [96049.833947] RBP: 0000000000000000 R08: 00007f5c14a46f48 R09: 0000000000000040 [96049.833948] R10: 0000000000000541 R11: 0000000000000202 R12: 0000000000000000 [96049.833949] R13: 0000000000000000 R14: 0000000000000004 R15: 00005625ece322d0 [96049.833954] irq event stamp: 6196 [96049.833956] hardirqs last enabled at (6195): [<ffffffff91b00663>] console_unlock+0x503/0x640 [96049.833958] hardirqs last disabled at (6196): [<ffffffff91a037dd>] trace_hardirqs_off_thunk+0x1a/0x1c [96049.833959] softirqs last enabled at (6114): [<ffffffff92600370>] __do_softirq+0x370/0x421 [96049.833964] softirqs last disabled at (6095): [<ffffffff91a8dd4d>] irq_exit+0xcd/0xe0 [96049.833965] ---[ end trace db7b05f01b7fa10c ]--- [96049.935816] R13: 0000000000000000 R14: 00005562e5259240 R15: 00007ffff092b910 [96049.935822] irq event stamp: 6584 [96049.935823] hardirqs last enabled at (6583): [<ffffffff91b00663>] console_unlock+0x503/0x640 [96049.935825] hardirqs last disabled at (6584): [<ffffffff91a037dd>] trace_hardirqs_off_thunk+0x1a/0x1c [96049.935827] softirqs last enabled at (6328): [<ffffffff92600370>] __do_softirq+0x370/0x421 [96049.935828] softirqs last disabled at (6313): [<ffffffff91a8dd4d>] irq_exit+0xcd/0xe0 [96049.935829] ---[ end trace db7b05f01b7fa123 ]--- [96049.935840] ------------[ cut here ]------------ [96049.936065] WARNING: CPU: 1 PID: 24463 at fs/btrfs/extent_io.c:436 insert_state+0x101/0x120 [btrfs] [96049.936107] CPU: 1 PID: 24463 Comm: umount Tainted: G W 4.19.0-rc7-btrfs-next-39 #1 [96049.936108] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.11.2-0-gf9626ccb91-prebuilt.qemu-project.org 04/01/2014 [96049.936117] RIP: 0010:insert_state+0x101/0x120 [btrfs] [96049.936119] RSP: 0018:ffffafd2c3637bc0 EFLAGS: 00010282 [96049.936120] RAX: 0000000000000000 RBX: 000000000004dfff RCX: 0000000000000006 [96049.936121] RDX: 0000000000000007 RSI: ffff990445cf88e0 RDI: ffff99047b2968a0 [96049.936122] RBP: ffff990457851cd0 R08: 0000000000000001 R09: 0000000000000000 [96049.936123] R10: ffffafd2c3637b88 R11: 0000000000000000 R12: ffff9904574301e8 [96049.936124] R13: 000000000004e000 R14: ffffafd2c3637c50 R15: ffffafd2c3637c48 [96049.936125] FS: 00007fe4b87e72c0(0000) GS:ffff99047b280000(0000) knlGS:0000000000000000 [96049.936126] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [96049.936128] CR2: 00005562e52618d8 CR3: 00000001151c8005 CR4: 00000000003606e0 [96049.936129] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [96049.936131] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [96049.936131] Call Trace: [96049.936141] __set_extent_bit+0x46c/0x6a0 [btrfs] [96049.936154] lock_extent_bits+0x6b/0x210 [btrfs] [96049.936167] btrfs_evict_inode+0x1e1/0x5a0 [btrfs] [96049.936172] evict+0xbf/0x1c0 [96049.936174] dispose_list+0x51/0x80 [96049.936176] evict_inodes+0x193/0x1c0 [96049.936180] generic_shutdown_super+0x3f/0x110 [96049.936182] kill_anon_super+0xe/0x30 [96049.936189] btrfs_kill_super+0x13/0x100 [btrfs] [96049.936191] deactivate_locked_super+0x3a/0x70 [96049.936193] cleanup_mnt+0x3b/0x80 [96049.936195] task_work_run+0x93/0xc0 [96049.936198] exit_to_usermode_loop+0xfa/0x100 [96049.936201] do_syscall_64+0x17f/0x1b0 [96049.936202] entry_SYSCALL_64_after_hwframe+0x49/0xbe [96049.936204] RIP: 0033:0x7fe4b80cfb37 [96049.936206] RSP: 002b:00007ffff092b688 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6 [96049.936207] RAX: 0000000000000000 RBX: 00005562e5259060 RCX: 00007fe4b80cfb37 [96049.936208] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 00005562e525faa0 [96049.936209] RBP: 00005562e525faa0 R08: 00005562e525f770 R09: 0000000000000015 [96049.936210] R10: 00000000000006b4 R11: 0000000000000246 R12: 00007fe4b85d1e64 [96049.936211] R13: 0000000000000000 R14: 00005562e5259240 R15: 00007ffff092b910 [96049.936211] R13: 0000000000000000 R14: 00005562e5259240 R15: 00007ffff092b910 [96049.936216] irq event stamp: 6616 [96049.936219] hardirqs last enabled at (6615): [<ffffffff91b00663>] console_unlock+0x503/0x640 [96049.936219] hardirqs last disabled at (6616): [<ffffffff91a037dd>] trace_hardirqs_off_thunk+0x1a/0x1c [96049.936222] softirqs last enabled at (6328): [<ffffffff92600370>] __do_softirq+0x370/0x421 [96049.936222] softirqs last disabled at (6313): [<ffffffff91a8dd4d>] irq_exit+0xcd/0xe0 [96049.936223] ---[ end trace db7b05f01b7fa124 ]---
The second stack trace, from inode eviction, is repeated forever due to the infinite loop during eviction.
This is the same type of problem fixed way back in 2015 by commit 113e8283869b ("Btrfs: fix inode eviction infinite loop after extent_same ioctl") and commit ccccf3d67294 ("Btrfs: fix inode eviction infinite loop after cloning into it").
So fix this by returning immediately if the deduplication range length gets rounded down to 0 bytes, as there is nothing that needs to be done in such case.
Example reproducer:
$ mkfs.btrfs -f /dev/sdb $ mount /dev/sdb /mnt
$ xfs_io -f -c "pwrite -S 0xe6 0 100" /mnt/foo $ xfs_io -f -c "pwrite -S 0xe6 0 1M" /mnt/bar
# Unmount the filesystem and mount it again so that we start without any
# extent state records when we ask for the deduplication. $ umount /mnt $ mount /dev/sdb /mnt
$ xfs_io -c "dedupe /mnt/foo 0 500K 100" /mnt/bar
# This unmount triggers the infinite loop.
$ umount /mnt
A test case for fstests will follow soon.
--- fs/btrfs/ioctl.c | 2 ++ 1 file changed, 2 insertions(+)
fs/btrfs/ioctl.c +2 -0
@@ -3178,6 +3178,8 @@ static int btrfs_extent_same(struct inodconst u64 sz =BTRFS_I (src)->root->fs_info->sectorsize; len =round_down (i_size_read (src), sz) - loff; +if (len ==0 ) +return 0 ; olen = len; } }
Greg Kroah-Hartman
maintainerPATCH 71/124 Btrfs: fix data corruption due to cloning of eof block
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Filipe Manana <[email protected]>
commit ac765f83f1397646c11092a032d4f62c3d478b81 upstream.
We currently allow cloning a range from a file which includes the last block of the file even if the file's size is not aligned to the block size. This is fine and useful when the destination file has the same size, but when it does not and the range ends somewhere in the middle of the destination file, it leads to corruption because the bytes between the EOF and the end of the block have undefined data (when there is support for discard/trimming they have a value of 0x00).
Example:
$ mkfs.btrfs -f /dev/sdb $ mount /dev/sdb /mnt
$ export foo_size=$((256 * 1024 + 100)) $ xfs_io -f -c "pwrite -S 0x3c 0 $foo_size" /mnt/foo $ xfs_io -f -c "pwrite -S 0xb5 0 1M" /mnt/bar
$ xfs_io -c "reflink /mnt/foo 0 512K $foo_size" /mnt/bar
$ od -A d -t x1 /mnt/bar 0000000 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 * 0524288 3c 3c 3c 3c 3c 3c 3c 3c 3c 3c 3c 3c 3c 3c 3c 3c * 0786528 3c 3c 3c 3c 00 00 00 00 00 00 00 00 00 00 00 00 0786544 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 * 0790528 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 b5 * 1048576
The bytes in the range from 786532 (512Kb + 256Kb + 100 bytes) to 790527 (512Kb + 256Kb + 4Kb - 1) got corrupted, having now a value of 0x00 instead of 0xb5.
This is similar to the problem we had for deduplication that got recently fixed by commit de02b9f6bb65 ("Btrfs: fix data corruption when deduplicating between different files").
Fix this by not allowing such operations to be performed and return the errno -EINVAL to user space. This is what XFS is doing as well at the VFS level. This change however now makes us return -EINVAL instead of -EOPNOTSUPP for cases where the source range maps to an inline extent and the destination range's end is smaller then the destination file's size, since the detection of inline extents is done during the actual process of dropping file extent items (at __btrfs_drop_extents()). Returning the -EINVAL error is done early on and solely based on the input parameters (offsets and length) and destination file's size. This makes us consistent with XFS and anyone else supporting cloning since this case is now checked at a higher level in the VFS and is where the -EINVAL will be returned from starting with kernel 4.20 (the VFS changed was introduced in 4.20-rc1 by commit 07d19dc9fbe9 ("vfs: avoid problematic remapping requests into partial EOF block"). So this change is more geared towards stable kernels, as it's unlikely the new VFS checks get removed intentionally.
A test case for fstests follows soon, as well as an update to filter existing tests that expect -EOPNOTSUPP to accept -EINVAL as well.
--- fs/btrfs/ioctl.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
fs/btrfs/ioctl.c +10 -2
@@ -3909,9 +3909,17 @@ static noinline int btrfs_clone_files(st goto out_unlock;if (len ==0 ) olen = len = src->i_size - off; -/* if we extend to eof, continue to block boundary */ -if (off + len == src->i_size) +/* +* If we extend to eof, continue to block boundary if and only if the +* destination end offset matches the destination file's size, otherwise +* we would be corrupting data by placing the eof block into the middle +* of a file. +*/ +if (off + len == src->i_size) { +if (!IS_ALIGNED (len, bs) && destoff + len < inode->i_size) + goto out_unlock; len =ALIGN (src->i_size, bs) - off; + }if (len ==0 ) { ret =0 ;
Greg Kroah-Hartman
maintainerPATCH 72/124 clockevents/drivers/i8253: Add support for PIT shutdown quirk
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michael Kelley <[email protected]>
commit 35b69a420bfb56b7b74cb635ea903db05e357bec upstream.
Add support for platforms where pit_shutdown() doesn't work because of a quirk in the PIT emulation. On these platforms setting the counter register to zero causes the PIT to start running again, negating the shutdown.
Provide a global variable that controls whether the counter register is zero'ed, which platform specific code can override.
--- drivers/clocksource/i8253.c | 14 ++++++++++++-- include/linux/i8253.h | 1 + 2 files changed, 13 insertions(+), 2 deletions(-)
drivers/clocksource/i8253.c +12 -2
@@ -20,6 +20,13 @@DEFINE_RAW_SPINLOCK (i8253_lock);EXPORT_SYMBOL (i8253_lock); +/* +* Handle PIT quirk in pit_shutdown() where zeroing the counter register +* restarts the PIT, negating the shutdown. On platforms with the quirk, +* platform specific code can set this to false. +*/ +bool i8253_clear_counter_on_shutdown__ro_after_init = true; +#ifdef CONFIG_CLKSRC_I8253 /* * Since the PIT overflows every tick, its not very useful
@@ -109,8 +116,11 @@ static int pit_shutdown(struct clock_everaw_spin_lock (&i8253_lock);outb_p (0x30 ,PIT_MODE ); -outb_p (0 ,PIT_CH0 ); -outb_p (0 ,PIT_CH0 ); + +if (i8253_clear_counter_on_shutdown) { +outb_p (0 ,PIT_CH0 ); +outb_p (0 ,PIT_CH0 ); + }raw_spin_unlock (&i8253_lock);return 0 ;
include/linux/i8253.h +1 -0
@@ -21,6 +21,7 @@#define PIT_LATCH ((PIT_TICK_RATE + HZ/2) / HZ)extern raw_spinlock_t i8253_lock; +extern bool i8253_clear_counter_on_shutdown;extern struct clock_event_device i8253_clockevent;extern void clockevent_i8253_init (bool oneshot);
Greg Kroah-Hartman
maintainerPATCH 73/124 ext4: add missing brelse() update_backups()s error path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit ea0abbb648452cdb6e1734b702b6330a7448fcf8 upstream.
--- fs/ext4/resize.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/ext4/resize.c +3 -1
@@ -1097,8 +1097,10 @@ static void update_backups(struct super_ backup_block, backup_block - ext4_group_first_block_no(sb, group));BUFFER_TRACE (bh,"get_write_access" ); -if ((err =ext4_journal_get_write_access (handle, bh))) +if ((err =ext4_journal_get_write_access (handle, bh))) { +brelse (bh);break ; + }lock_buffer (bh);memcpy (bh->b_data, data, size);if (rest)
Greg Kroah-Hartman
maintainerPATCH 74/124 ext4: add missing brelse() in set_flexbg_block_bitmap()s error path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit cea5794122125bf67559906a0762186cf417099c upstream.
--- fs/ext4/resize.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
fs/ext4/resize.c +4 -2
@@ -444,16 +444,18 @@ static int set_flexbg_block_bitmap(strucBUFFER_TRACE (bh,"get_write_access" ); err =ext4_journal_get_write_access (handle, bh); -if (err) +if (err) { +brelse (bh);return err; + }ext4_debug ("mark block bitmap %#04llx (+%llu/%u)\n" , block, block - start, count2);ext4_set_bits (bh->b_data, block - start, count2); err =ext4_handle_dirty_metadata (handle,NULL , bh); +brelse (bh);if (unlikely (err))return err; -brelse (bh); }return 0 ;
Greg Kroah-Hartman
maintainerPATCH 75/124 ext4: add missing brelse() add_new_gdb_meta_bg()s error path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit 61a9c11e5e7a0dab5381afa5d9d4dd5ebf18f7a0 upstream.
--- fs/ext4/resize.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
fs/ext4/resize.c +1 -2
@@ -901,6 +901,7 @@ static int add_new_gdb_meta_bg(struct susizeof (struct buffer_head *), GFP_NOFS);if (!n_group_desc) { +brelse (gdb_bh); err = -ENOMEM ;ext4_warning (sb,"not enough memory for %lu groups" , gdb_num +1 );
@@ -916,8 +917,6 @@ static int add_new_gdb_meta_bg(struct sukvfree (o_group_desc);BUFFER_TRACE (gdb_bh,"get_write_access" ); err =ext4_journal_get_write_access (handle, gdb_bh); -if (unlikely (err)) -brelse (gdb_bh);return err; }
Greg Kroah-Hartman
maintainerPATCH 76/124 ext4: avoid potential extra brelse in setup_new_flex_group_blocks()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit 9e4028935cca3f9ef9b6a90df9da6f1f94853536 upstream.
Currently bh is set to NULL only during first iteration of for cycle, then this pointer is not cleared after end of using.
Therefore rollback after errors can lead to extra brelse(bh) call, decrements bh counter and later trigger an unexpected warning in __brelse()
Patch moves brelse() calls in body of cycle to exclude requirement of brelse() call in rollback.
--- fs/ext4/resize.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
fs/ext4/resize.c +2 -6
@@ -592,7 +592,6 @@ handle_bb: bh =bclean (handle, sb, block);if (IS_ERR (bh)) { err =PTR_ERR (bh); - bh =NULL ; goto out; } overhead =ext4_group_overhead_blocks (sb, group);
@@ -604,9 +603,9 @@ handle_bb:ext4_mark_bitmap_end (group_data[i].blocks_count, sb->s_blocksize *8 , bh->b_data); err =ext4_handle_dirty_metadata (handle,NULL , bh); +brelse (bh);if (err) goto out; -brelse (bh); handle_ib:if (bg_flags[i] &EXT4_BG_INODE_UNINIT )
@@ -621,18 +620,16 @@ handle_ib: bh =bclean (handle, sb, block);if (IS_ERR (bh)) { err =PTR_ERR (bh); - bh =NULL ; goto out; }ext4_mark_bitmap_end (EXT4_INODES_PER_GROUP (sb), sb->s_blocksize *8 , bh->b_data); err =ext4_handle_dirty_metadata (handle,NULL , bh); +brelse (bh);if (err) goto out; -brelse (bh); } - bh =NULL ;/* Mark group tables in block bitmap */ for (j =0 ; j <GROUP_TABLE_COUNT ; j++) {
@@ -663,7 +660,6 @@ handle_ib: } out: -brelse (bh); err2 =ext4_journal_stop (handle);if (err2 && !err) err = err2;
Greg Kroah-Hartman
maintainerPATCH 77/124 ext4: missing !bh check in ext4_xattr_inode_write()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit eb6984fa4ce2837dcb1f66720a600f31b0bb3739 upstream.
According to Ted Ts'o ext4_getblk() called in ext4_xattr_inode_write() should not return bh = NULL
The only time that bh could be NULL, then, would be in the case of something really going wrong; a programming error elsewhere (perhaps a wild pointer dereference) or I/O error causing on-disk file system corruption (although that would be highly unlikely given that we had *just* allocated the blocks and so the metadata blocks in question probably would still be in the cache).
--- fs/ext4/xattr.c | 6 ++++++ 1 file changed, 6 insertions(+)
fs/ext4/xattr.c +6 -0
@@ -1387,6 +1387,12 @@ retry: bh =ext4_getblk (handle, ea_inode, block,0 );if (IS_ERR (bh))return PTR_ERR (bh); +if (!bh) { +WARN_ON_ONCE (1 ); +EXT4_ERROR_INODE (ea_inode, +"ext4_getblk() return bh = NULL" ); +return -EFSCORRUPTED ; + } ret =ext4_journal_get_write_access (handle, bh);if (ret) goto out;
Greg Kroah-Hartman
maintainerPATCH 78/124 ext4: fix possible inode leak in the retry loop of ext4_resize_fs()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit db6aee62406d9fbb53315fcddd81f1dc271d49fa upstream.
--- fs/ext4/resize.c | 4 ++++ 1 file changed, 4 insertions(+)
fs/ext4/resize.c +4 -0
@@ -2028,6 +2028,10 @@ retry: n_blocks_count_retry =0 ;free_flex_gd (flex_gd); flex_gd =NULL ; +if (resize_inode) { +iput (resize_inode); + resize_inode =NULL ; + } goto retry; }
Greg Kroah-Hartman
maintainerPATCH 79/124 ext4: avoid buffer leak on shutdown in ext4_mark_iloc_dirty()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit a6758309a005060b8297a538a457c88699cb2520 upstream.
ext4_mark_iloc_dirty() callers expect that it releases iloc->bh even if it returns an error.
--- fs/ext4/inode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
fs/ext4/inode.c +3 -2
@@ -5671,9 +5671,10 @@ int ext4_mark_iloc_dirty(handle_t *handl {int err =0 ; -if (unlikely (ext4_forced_shutdown (EXT4_SB (inode->i_sb)))) +if (unlikely (ext4_forced_shutdown (EXT4_SB (inode->i_sb)))) { +put_bh (iloc->bh);return -EIO ; - + }if (IS_I_VERSION (inode))inode_inc_iversion (inode);
Greg Kroah-Hartman
maintainerPATCH 80/124 ext4: avoid buffer leak in ext4_orphan_add() after prior errors
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit feaf264ce7f8d54582e2f66eb82dd9dd124c94f3 upstream.
--- fs/ext4/namei.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/ext4/namei.c +3 -1
@@ -2820,7 +2820,9 @@ int ext4_orphan_add(handle_t *handle, stlist_del_init (&EXT4_I (inode)->i_orphan);mutex_unlock (&sbi->s_orphan_lock); } - } + }else +brelse (iloc.bh); +jbd_debug (4 ,"superblock will point to %lu\n" , inode->i_ino);jbd_debug (4 ,"orphan inode %lu will point to %d\n" , inode->i_ino,NEXT_ORPHAN (inode));
Greg Kroah-Hartman
maintainerPATCH 81/124 ext4: fix missing cleanup if ext4_alloc_flex_bg_array() fails while resizing
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit f348e2241fb73515d65b5d77dd9c174128a7fbf2 upstream.
--- fs/ext4/resize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ext4/resize.c +1 -1
@@ -1992,7 +1992,7 @@ retry: err =ext4_alloc_flex_bg_array (sb, n_group +1 );if (err) -return err; + goto out; err =ext4_mb_alloc_groupinfo (sb, n_group +1 );if (err)
Greg Kroah-Hartman
maintainerPATCH 82/124 ext4: avoid possible double brelse() in add_new_gdb() on error path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Theodore Ts'o <[email protected]>
commit 4f32c38b4662312dd3c5f113d8bdd459887fb773 upstream.
--- fs/ext4/resize.c | 1 + 1 file changed, 1 insertion(+)
fs/ext4/resize.c +1 -0
@@ -846,6 +846,7 @@ static int add_new_gdb(handle_t *handle, err =ext4_handle_dirty_metadata (handle,NULL , gdb_bh);if (unlikely (err)) {ext4_std_error (sb, err); + iloc.bh =NULL ; goto exit_inode; }brelse (dind);
Greg Kroah-Hartman
maintainerPATCH 83/124 ext4: fix possible leak of sbi->s_group_desc_leak in error path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Theodore Ts'o <[email protected]>
commit 9e463084cdb22e0b56b2dfbc50461020409a5fd3 upstream.
--- fs/ext4/super.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
fs/ext4/super.c +8 -8
@@ -4012,6 +4012,14 @@ static int ext4_fill_super(struct super_ sbi->s_groups_count = blocks_count; sbi->s_blockfile_groups =min_t (ext4_group_t, sbi->s_groups_count, (EXT4_MAX_BLOCK_FILE_PHYS /EXT4_BLOCKS_PER_GROUP (sb))); +if (((u64 )sbi->s_groups_count * sbi->s_inodes_per_group) != +le32_to_cpu (es->s_inodes_count)) { +ext4_msg (sb,KERN_ERR ,"inodes count not valid: %u vs %llu" , +le32_to_cpu (es->s_inodes_count), + ((u64 )sbi->s_groups_count * sbi->s_inodes_per_group)); + ret = -EINVAL ; + goto failed_mount; + } db_count = (sbi->s_groups_count +EXT4_DESC_PER_BLOCK (sb) -1 ) /EXT4_DESC_PER_BLOCK (sb);if (ext4_has_feature_meta_bg (sb)) {
@@ -4031,14 +4039,6 @@ static int ext4_fill_super(struct super_ ret = -ENOMEM ; goto failed_mount; } -if (((u64 )sbi->s_groups_count * sbi->s_inodes_per_group) != -le32_to_cpu (es->s_inodes_count)) { -ext4_msg (sb,KERN_ERR ,"inodes count not valid: %u vs %llu" , -le32_to_cpu (es->s_inodes_count), - ((u64 )sbi->s_groups_count * sbi->s_inodes_per_group)); - ret = -EINVAL ; - goto failed_mount; - }bgl_lock_init (sbi->s_blockgroup_lock);
Greg Kroah-Hartman
maintainerPATCH 84/124 ext4: fix possible leak of s_journal_flag_rwsem in error path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit af18e35bfd01e6d65a5e3ef84ffe8b252d1628c5 upstream.
--- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+)
fs/ext4/super.c +1 -0
@@ -4442,6 +4442,7 @@ failed_mount6:percpu_counter_destroy (&sbi->s_freeinodes_counter);percpu_counter_destroy (&sbi->s_dirs_counter);percpu_counter_destroy (&sbi->s_dirtyclusters_counter); +percpu_free_rwsem (&sbi->s_journal_flag_rwsem); failed_mount5:ext4_ext_release (sb);ext4_release_system_zone (sb);
Greg Kroah-Hartman
maintainerPATCH 85/124 ext4: fix buffer leak in ext4_xattr_get_block() on error path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit ecaaf408478b6fb4d9986f9b6652f3824e374f4c upstream.
--- fs/ext4/xattr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/ext4/xattr.c +3 -1
@@ -2281,8 +2281,10 @@ static struct buffer_head *ext4_xattr_geif (!bh)return ERR_PTR (-EIO ); error =ext4_xattr_check_block (inode, bh); -if (error) +if (error) { +brelse (bh);return ERR_PTR (error); + }return bh; }
Greg Kroah-Hartman
maintainerPATCH 86/124 ext4: release bs.bh before re-using in ext4_xattr_block_find()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit 45ae932d246f721e6584430017176cbcadfde610 upstream.
bs.bh was taken in previous ext4_xattr_block_find() call, it should be released before re-using
--- fs/ext4/xattr.c | 2 ++ 1 file changed, 2 insertions(+)
fs/ext4/xattr.c +2 -0
@@ -2404,6 +2404,8 @@ retry_inode: error =ext4_xattr_block_set (handle, inode, &i, &bs); }else if (error == -ENOSPC ) {if (EXT4_I (inode)->i_file_acl && !bs.s.base) { +brelse (bs.bh); + bs.bh =NULL ; error =ext4_xattr_block_find (inode, &i, &bs);if (error) goto cleanup;
Greg Kroah-Hartman
maintainerPATCH 87/124 ext4: fix buffer leak in ext4_xattr_move_to_block() on error path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit 6bdc9977fcdedf47118d2caf7270a19f4b6d8a8f upstream.
--- fs/ext4/xattr.c | 2 ++ 1 file changed, 2 insertions(+)
fs/ext4/xattr.c +2 -0
@@ -2626,6 +2626,8 @@ out:kfree (buffer);if (is)brelse (is->iloc.bh); +if (bs) +brelse (bs->bh);kfree (is);kfree (bs);
Greg Kroah-Hartman
maintainerPATCH 88/124 ext4: fix buffer leak in ext4_expand_extra_isize_ea() on error path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit 53692ec074d00589c2cf1d6d17ca76ad0adce6ec upstream.
--- fs/ext4/xattr.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
fs/ext4/xattr.c +5 -2
@@ -2707,7 +2707,6 @@ int ext4_expand_extra_isize_ea(struct in struct ext4_inode *raw_inode, handle_t *handle) { struct ext4_xattr_ibody_header *header; -struct buffer_head *bh;struct ext4_sb_info *sbi =EXT4_SB (inode->i_sb);static unsigned int mnt_count;size_t min_offs;
@@ -2748,13 +2747,17 @@ retry:* EA block can hold new_extra_isize bytes. */ if (EXT4_I (inode)->i_file_acl) { +struct buffer_head *bh; + bh =sb_bread (inode->i_sb,EXT4_I (inode)->i_file_acl); error = -EIO ;if (!bh) goto cleanup; error =ext4_xattr_check_block (inode, bh); -if (error) +if (error) { +brelse (bh); goto cleanup; + } base =BHDR (bh); end = bh->b_data + bh->b_size; min_offs = end - base;
Greg Kroah-Hartman
maintainerPATCH 89/124 ext4: fix buffer leak in __ext4_read_dirblock() on error path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit de59fae0043f07de5d25e02ca360f7d57bfa5866 upstream.
--- fs/ext4/namei.c | 1 + 1 file changed, 1 insertion(+)
fs/ext4/namei.c +1 -0
@@ -125,6 +125,7 @@ static struct buffer_head *__ext4_read_dif (!is_dx_block && type ==INDEX ) {ext4_error_inode (inode, func, line, block,"directory leaf block found instead of index block" ); +brelse (bh);return ERR_PTR (-EFSCORRUPTED ); } if (!ext4_has_metadata_csum(inode->i_sb) ||
Greg Kroah-Hartman
maintainerPATCH 90/124 mount: Retest MNT_LOCKED in do_umount
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric W. Biederman <[email protected]>
commit 25d202ed820ee347edec0bf3bf553544556bf64b upstream.
It was recently pointed out that the one instance of testing MNT_LOCKED outside of the namespace_sem is in ksys_umount.
Fix that by adding a test inside of do_umount with namespace_sem and the mount_lock held. As it helps to fail fails the existing test is maintained with an additional comment pointing out that it may be racy because the locks are not held.
--- fs/namespace.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
fs/namespace.c +8 -2
@@ -1625,8 +1625,13 @@ static int do_umount(struct mount *mnt,namespace_lock ();lock_mount_hash (); - event++; +/* Recheck MNT_LOCKED with the locks held */ + retval = -EINVAL ; +if (mnt->mnt.mnt_flags &MNT_LOCKED ) + goto out; + + event++;if (flags &MNT_DETACH ) {if (!list_empty (&mnt->mnt_list))umount_tree (mnt,UMOUNT_PROPAGATE );
@@ -1640,6 +1645,7 @@ static int do_umount(struct mount *mnt, retval =0 ; } } +out:unlock_mount_hash ();namespace_unlock ();return retval;
@@ -1730,7 +1736,7 @@ SYSCALL_DEFINE2(umount, char __user *, n goto dput_and_out;if (!check_mnt (mnt)) goto dput_and_out; -if (mnt->mnt.mnt_flags &MNT_LOCKED ) +if (mnt->mnt.mnt_flags &MNT_LOCKED )/* Check optimistically */ goto dput_and_out; retval = -EPERM ;if (flags &MNT_FORCE && !capable (CAP_SYS_ADMIN ))
Greg Kroah-Hartman
maintainerPATCH 91/124 mount: Dont allow copying MNT_UNBINDABLE|MNT_LOCKED mounts
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric W. Biederman <[email protected]>
commit df7342b240185d58d3d9665c0bbf0a0f5570ec29 upstream.
Jonathan Calmels from NVIDIA reported that he's able to bypass the mount visibility security check in place in the Linux kernel by using a combination of the unbindable property along with the private mount propagation option to allow a unprivileged user to see a path which was purposefully hidden by the root user.
Reproducer:
# Hide a path to all users using a tmpfs
root@castiana:~# mount -t tmpfs tmpfs /sys/devices/ root@castiana:~#
# As an unprivileged user, unshare user namespace and mount namespace
stgraber@castiana:~$ unshare -U -m -r
# Confirm the path is still not accessible
root@castiana:~# ls /sys/devices/
# Make /sys recursively unbindable and private root@castiana:~# mount --make-runbindable /sys root@castiana:~# mount --make-private /sys # Recursively bind-mount the rest of /sys over to /mnnt root@castiana:~# mount --rbind /sys/ /mnt
# Access our hidden /sys/device as an unprivileged user
root@castiana:~# ls /mnt/devices/ breakpoint cpu cstate_core cstate_pkg i915 intel_pt isa kprobe LNXSYSTM:00 msr pci0000:00 platform pnp0 power software system tracepoint uncore_arb uncore_cbox_0 uncore_cbox_1 uprobe virtual
Solve this by teaching copy_tree to fail if a mount turns out to be both unbindable and locked.
--- fs/namespace.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
fs/namespace.c +8 -2
@@ -1814,8 +1814,14 @@ struct mount *copy_tree(struct mount *mnfor (s = r; s; s =next_mnt (s, r)) {if (!(flag &CL_COPY_UNBINDABLE ) &&IS_MNT_UNBINDABLE (s)) { - s =skip_mnt_tree (s); -continue ; +if (s->mnt.mnt_flags &MNT_LOCKED ) { +/* Both unbindable and locked. */ + q =ERR_PTR (-EPERM ); + goto out; + }else { + s =skip_mnt_tree (s); +continue ; + } }if (!(flag &CL_COPY_MNT_NS_FILE ) &&is_mnt_ns_file (s->mnt.mnt_root)) {
Greg Kroah-Hartman
maintainerPATCH 92/124 mount: Prevent MNT_DETACH from disconnecting locked mounts
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric W. Biederman <[email protected]>
commit 9c8e0a1b683525464a2abe9fb4b54404a50ed2b4 upstream.
Quoted 40 lines · Timothy Baldwin
As per
mount_namespaces(7)unprivileged users should not be able to look under mount points:Mounts that come as a single unit from more privileged mount are locked together and may not be separated in a less privileged mount namespace.
However they can:
1. Create a mount namespace.
2. In the mount namespace open a file descriptor to the parent of a mount point.
3. Destroy the mount namespace.
4. Use the file descriptor to look under the mount point.I have reproduced this with Linux 4.16.18 and Linux 4.18-rc8.
The setup:
$ sudo sysctl kernel.unprivileged_userns_clone=1 kernel.unprivileged_userns_clone = 1 $ mkdir -p A/B/Secret $ sudo mount -t tmpfs hide A/B"Secret" is indeed hidden as expected:
$ ls -lR A A: total 0 drwxrwxrwt 2 root root 40 Feb 12 21:08 BA/B:
total 0The attack revealing "Secret":
$ unshare -Umr sh -c "exec unshare -m ls -lR /proc/self/fd/4/ 4<A" /proc/self/fd/4/: total 0 drwxr-xr-x 3 root root 60 Feb 12 21:08 B
Quoted 6 lines
/proc/self/fd/4/B:
total 0
drwxr-xr-x 2 root root 40 Feb 12 21:08 Secret
/proc/self/fd/4/B/Secret:
total 0
I tracked this down to put_mnt_ns running passing UMOUNT_SYNC and disconnecting all of the mounts in a mount namespace. Fix this by factoring drop_mounts out of drop_collected_mounts and passing 0 instead of UMOUNT_SYNC.
There are two possible behavior differences that result from this.
- No longer setting UMOUNT_SYNC will no longer set MNT_SYNC_UMOUNT on the vfsmounts being unmounted. This effects the lazy rcu walk by kicking the walk out of rcu mode and forcing it to be a non-lazy walk.
- No longer disconnecting locked mounts will keep some mounts around longer as they stay because the are locked to other mounts.
There are only two users of drop_collected mounts: audit_tree.c and put_mnt_ns.
In audit_tree.c the mounts are private and there are no rcu lazy walks only calls to iterate_mounts. So the changes should have no effect except for a small timing effect as the connected mounts are disconnected.
In put_mnt_ns there may be references from process outside the mount namespace to the mounts. So the mounts remaining connected will be the bug fix that is needed. That rcu walks are allowed to continue appears not to be a problem especially as the rcu walk change was about an implementation detail not about semantics.
--- fs/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namespace.c +1 -1
@@ -1874,7 +1874,7 @@ void drop_collected_mounts(struct vfsmou {namespace_lock ();lock_mount_hash (); -umount_tree (real_mount (mnt),UMOUNT_SYNC ); +umount_tree (real_mount (mnt),0 );unlock_mount_hash ();namespace_unlock (); }
Greg Kroah-Hartman
maintainerPATCH 93/124 kdb: use correct pointer when btc calls btt
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christophe Leroy <[email protected]>
commit dded2e159208a9edc21dd5c5f583afa28d378d39 upstream.
On a powerpc 8xx, 'btc' fails as follows:
Entering kdb (current=0x(ptrval), pid 282) due to Keyboard Entry kdb> btc
btc: cpu status: Currently on cpu 0
Available cpus: 0kdb_getarea: Bad address 0x0
when booting the kernel with 'debug_boot_weak_hash', it fails as well
Entering kdb (current=0xba99ad80, pid 284) due to Keyboard Entry kdb> btc
btc: cpu status: Currently on cpu 0
Available cpus: 0kdb_getarea: Bad address 0xba99ad80
On other platforms, Oopses have been observed too, see
https://github.com/linuxppc/linux/issues/139
This is due to btc calling 'btt' with %p pointer as an argument.
This patch replaces %p by %px to get the real pointer value as expected by 'btt'
--- kernel/debug/kdb/kdb_bt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/debug/kdb/kdb_bt.c +2 -2
@@ -179,14 +179,14 @@ kdb_bt(int argc, const char **argv)kdb_printf ("no process for cpu %ld\n" , cpu);return 0 ; } -sprintf (buf,"btt 0x%p\n" ,KDB_TSK (cpu)); +sprintf (buf,"btt 0x%px\n" ,KDB_TSK (cpu));kdb_parse (buf);return 0 ; }kdb_printf ("btc: cpu status: " );kdb_parse ("cpu\n" );for_each_online_cpu (cpu) { -sprintf (buf,"btt 0x%p\n" ,KDB_TSK (cpu)); +sprintf (buf,"btt 0x%px\n" ,KDB_TSK (cpu));kdb_parse (buf);touch_nmi_watchdog (); }
Greg Kroah-Hartman
maintainerPATCH 94/124 kdb: print real address of pointers instead of hashed addresses
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christophe Leroy <[email protected]>
commit 568fb6f42ac6851320adaea25f8f1b94de14e40a upstream.
Since commit ad67b74d2469 ("printk: hash addresses printed with %p"), all pointers printed with %p are printed with hashed addresses instead of real addresses in order to avoid leaking addresses in dmesg and syslog. But this applies to kdb too, with is unfortunate:
Entering kdb (current=0x(ptrval), pid 329) due to Keyboard Entry
kdb> ps
15 sleeping system daemon (state M) processes suppressed,
use 'ps A' to see all.
Task Addr Pid Parent [*] cpu State Thread Command
0x(ptrval) 329 328 1 0 R 0x(ptrval) *sh
0x(ptrval) 1 0 0 0 S 0x(ptrval) init
0x(ptrval) 3 2 0 0 D 0x(ptrval) rcu_gp
0x(ptrval) 4 2 0 0 D 0x(ptrval) rcu_par_gp
0x(ptrval) 5 2 0 0 D 0x(ptrval) kworker/0:0
0x(ptrval) 6 2 0 0 D 0x(ptrval) kworker/0:0H
0x(ptrval) 7 2 0 0 D 0x(ptrval) kworker/u2:0
0x(ptrval) 8 2 0 0 D 0x(ptrval) mm_percpu_wq
0x(ptrval) 10 2 0 0 D 0x(ptrval) rcu_preemptThe whole purpose of kdb is to debug, and for debugging real addresses need to be known. In addition, data displayed by kdb doesn't go into dmesg.
This patch replaces all %p by %px in kdb in order to display real addresses.
--- kernel/debug/kdb/kdb_main.c | 14 +++++++------- kernel/debug/kdb/kdb_support.c | 12 ++++++------ 2 files changed, 13 insertions(+), 13 deletions(-)
kernel/debug/kdb/kdb_main.c +7 -7
@@ -1182,7 +1182,7 @@ static int kdb_local(kdb_reason_t reasonif (reason ==KDB_REASON_DEBUG ) {/* special case below */ }else { -kdb_printf ("\nEntering kdb (current=0x%p, pid %d) " , +kdb_printf ("\nEntering kdb (current=0x%px, pid %d) " , kdb_current, kdb_current ? kdb_current->pid :0 );#if defined(CONFIG_SMP )kdb_printf ("on processor %d " ,raw_smp_processor_id ());
@@ -1198,7 +1198,7 @@ static int kdb_local(kdb_reason_t reason*/ switch (db_result) {case KDB_DB_BPT : -kdb_printf ("\nEntering kdb (0x%p, pid %d) " , +kdb_printf ("\nEntering kdb (0x%px, pid %d) " , kdb_current, kdb_current->pid);#if defined(CONFIG_SMP )kdb_printf ("on processor %d " ,raw_smp_processor_id ());
@@ -2037,7 +2037,7 @@ static int kdb_lsmod(int argc, const chaif (mod->state ==MODULE_STATE_UNFORMED )continue ; -kdb_printf ("%-20s%8u 0x%p " , mod->name, +kdb_printf ("%-20s%8u 0x%px " , mod->name, mod->core_layout.size, (void *)mod);#ifdef CONFIG_MODULE_UNLOAD kdb_printf ("%4d " ,module_refcount (mod));
@@ -2048,7 +2048,7 @@ static int kdb_lsmod(int argc, const chakdb_printf (" (Loading)" ); else kdb_printf(" (Live)"); -kdb_printf (" 0x%p" , mod->core_layout.base); +kdb_printf (" 0x%px" , mod->core_layout.base);#ifdef CONFIG_MODULE_UNLOAD {
@@ -2330,7 +2330,7 @@ void kdb_ps1(const struct task_struct *preturn ; cpu =kdb_process_cpu (p); - kdb_printf("0x%p %8d %8d %d %4d %c 0x%p %c%s\n", + kdb_printf("0x%px %8d %8d %d %4d %c 0x%px %c%s\n", (void *)p, p->pid, p->parent->pid, kdb_task_has_cpu(p), kdb_process_cpu(p), kdb_task_state_char(p),
@@ -2343,7 +2343,7 @@ void kdb_ps1(const struct task_struct *p }else {if (KDB_TSK (cpu) != p)kdb_printf (" Error: does not match running " -"process table (0x%p)\n" ,KDB_TSK (cpu)); +"process table (0x%px)\n" ,KDB_TSK (cpu)); } } }
@@ -2722,7 +2722,7 @@ int kdb_register_flags(char *cmd,for_each_kdbcmd (kp, i) {if (kp->cmd_name && (strcmp (kp->cmd_name, cmd) ==0 )) {kdb_printf ("Duplicate kdb command registered: " -"%s, func %p help %s\n" , cmd, func, help); +"%s, func %px help %s\n" , cmd, func, help);return 1 ; } }
kernel/debug/kdb/kdb_support.c +6 -6
@@ -40,7 +40,7 @@int kdbgetsymval (const char *symname,kdb_symtab_t *symtab) {if (KDB_DEBUG (AR )) -kdb_printf ("kdbgetsymval: symname=%s, symtab=%p\n" , symname, +kdb_printf ("kdbgetsymval: symname=%s, symtab=%px\n" , symname, symtab);memset (symtab,0 ,sizeof (*symtab)); symtab->sym_start =kallsyms_lookup_name (symname);
@@ -88,7 +88,7 @@ int kdbnearsym(unsigned long addr, kdb_schar *knt1 =NULL ;if (KDB_DEBUG (AR )) -kdb_printf ("kdbnearsym: addr=0x%lx, symtab=%p\n" , addr, symtab); +kdb_printf ("kdbnearsym: addr=0x%lx, symtab=%px\n" , addr, symtab);memset (symtab,0 ,sizeof (*symtab));if (addr <4096 )
@@ -149,7 +149,7 @@ int kdbnearsym(unsigned long addr, kdb_s symtab->mod_name ="kernel" ;if (KDB_DEBUG (AR ))kdb_printf ("kdbnearsym: returns %d symtab->sym_start=0x%lx, " -"symtab->mod_name=%p, symtab->sym_name=%p (%s)\n" , ret, +"symtab->mod_name=%px, symtab->sym_name=%px (%s)\n" , ret, symtab->sym_start, symtab->mod_name, symtab->sym_name, symtab->sym_name);
@@ -887,13 +887,13 @@ void debug_kusage(void) __func__, dah_first);if (dah_first) { h_used = (struct debug_alloc_header *)debug_alloc_pool; -kdb_printf ("%s: h_used %p size %d\n" , __func__, h_used, +kdb_printf ("%s: h_used %px size %d\n" , __func__, h_used, h_used->size); } do { h_used = (struct debug_alloc_header *) ((char *)h_free + dah_overhead + h_free->size); - kdb_printf("%s: h_used %p size %d caller %p\n", + kdb_printf("%s: h_used %px size %d caller %px\n", __func__, h_used, h_used->size, h_used->caller); h_free = (struct debug_alloc_header *) (debug_alloc_pool + h_free->next);
@@ -902,7 +902,7 @@ void debug_kusage(void) ((char *)h_free + dah_overhead + h_free->size);if ((char *)h_used - debug_alloc_pool !=sizeof (debug_alloc_pool_aligned)) -kdb_printf ("%s: h_used %p size %d caller %p\n" , +kdb_printf ("%s: h_used %px size %d caller %px\n" , __func__, h_used, h_used->size, h_used->caller); out:spin_unlock (&dap_lock);
Greg Kroah-Hartman
maintainerPATCH 95/124 sunrpc: correct the computation for page_ptr when truncating
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Frank Sorenson <[email protected]>
commit 5d7a5bcb67c70cbc904057ef52d3fcfeb24420bb upstream.
When truncating the encode buffer, the page_ptr is getting advanced, causing the next page to be skipped while encoding. The page is still included in the response, so the response contains a page of bogus data.
We need to adjust the page_ptr backwards to ensure we encode the next page into the correct place.
We saw this triggered when concurrent directory modifications caused nfsd4_encode_direct_fattr() to return nfserr_noent, and the resulting call to xdr_truncate_encode() corrupted the READDIR reply.
--- net/sunrpc/xdr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
net/sunrpc/xdr.c +2 -3
@@ -639,11 +639,10 @@ void xdr_truncate_encode(struct xdr_streWARN_ON_ONCE (xdr->iov);return ; } -if (fraglen) { +if (fraglen) xdr->end = head->iov_base + head->iov_len; - xdr->page_ptr--; - }/* (otherwise assume xdr->end is already set) */ + xdr->page_ptr--; head->iov_len = len; buf->len = len; xdr->p = head->iov_base + head->iov_len;
Greg Kroah-Hartman
maintainerPATCH 96/124 nfsd: COPY and CLONE operations require the saved filehandle to be set
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Scott Mayhew <[email protected]>
commit 01310bb7c9c98752cc763b36532fab028e0f8f81 upstream.
Make sure we have a saved filehandle, otherwise we'll oops with a null pointer dereference in nfs4_preprocess_stateid_op().
--- fs/nfsd/nfs4proc.c | 3 +++ 1 file changed, 3 insertions(+)
fs/nfsd/nfs4proc.c +3 -0
@@ -1049,6 +1049,9 @@ nfsd4_verify_copy(struct svc_rqst *rqstp {__be32 status; +if (!cstate->save_fh.fh_dentry) +return nfserr_nofilehandle; + status =nfs4_preprocess_stateid_op (rqstp, cstate, &cstate->save_fh, src_stateid,RD_STATE , src,NULL );if (status) {
Greg Kroah-Hartman
maintainerPATCH 97/124 rtc: hctosys: Add missing range error reporting
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Maciej W. Rozycki <[email protected]>
commit 7ce9a992ffde8ce93d5ae5767362a5c7389ae895 upstream.
Fix an issue with the 32-bit range error path in rtc_hctosys' where no error code is set and consequently the successful preceding call result from rtc_read_time' is propagated to rtc_hctosys_ret'. This in turn makes any subsequent call to hctosys_show' incorrectly report in sysfs that the system time has been set from this RTC while it has not.
Set the error to ERANGE then if we can't express the result due to an overflow.
--- drivers/rtc/hctosys.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/rtc/hctosys.c +3 -1
@@ -50,8 +50,10 @@ static int __init rtc_hctosys(void) tv64.tv_sec =rtc_tm_to_time64 (&tm);#if BITS_PER_LONG ==32 -if (tv64.tv_sec >INT_MAX ) +if (tv64.tv_sec >INT_MAX ) { + err = -ERANGE ; goto err_read; + }#endif err =do_settimeofday64 (&tv64);
Greg Kroah-Hartman
maintainerPATCH 98/124 fuse: fix use-after-free in fuse_direct_IO()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lukas Czerner <[email protected]>
commit ebacb81273599555a7a19f7754a1451206a5fc4f upstream.
In async IO blocking case the additional reference to the io is taken for it to survive fuse_aio_complete(). In non blocking case this additional reference is not needed, however we still reference io to figure out whether to wait for completion or not. This is wrong and will lead to use-after-free. Fix it by storing blocking information in separate variable.
This was spotted by KASAN when running generic/208 fstest.
--- fs/fuse/file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/fuse/file.c +3 -1
@@ -2912,10 +2912,12 @@ fuse_direct_IO(struct kiocb *iocb, struc }if (io->async) { +bool blocking = io->blocking; +fuse_aio_complete (io, ret <0 ? ret :0 ,-1 );/* we have a non-extending, async request, so return */ -if (!io->blocking) +if (!blocking)return -EIOCBQUEUED ;wait_for_completion (&wait);
Greg Kroah-Hartman
maintainerPATCH 99/124 fuse: fix leaked notify reply
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Miklos Szeredi <[email protected]>
commit 7fabaf303458fcabb694999d6fa772cc13d4e217 upstream.
fuse_request_send_notify_reply() may fail if the connection was reset for some reason (e.g. fs was unmounted). Don't leak request reference in this case. Besides leaking memory, this resulted in fc->num_waiting not being decremented and hence fuse_wait_aborted() left in a hanging and unkillable state.
--- fs/fuse/dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/fuse/dev.c +3 -1
@@ -1721,8 +1721,10 @@ static int fuse_retrieve(struct fuse_con req->in.args[1 ].size = total_len; err =fuse_request_send_notify_reply (fc, req, outarg->notify_unique); -if (err) +if (err) {fuse_retrieve_end (fc, req); +fuse_put_request (fc, req); + }return err; }
Greg Kroah-Hartman
maintainerPATCH 100/124 configfs: replace strncpy with memcpy
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Guenter Roeck <[email protected]>
commit 1823342a1f2b47a4e6f5667f67cd28ab6bc4d6cd upstream.
gcc 8.1.0 complains:
fs/configfs/symlink.c:67:3: warning:
'strncpy' output truncated before terminating nul copying as many bytes from a string as its lengthfs/configfs/symlink.c: In function 'configfs_get_link':fs/configfs/symlink.c:63:13: note: length computed here
Using strncpy() is indeed less than perfect since the length of data to be copied has already been determined with strlen(). Replace strncpy() with memcpy() to address the warning and optimize the code a little.
--- fs/configfs/symlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/configfs/symlink.c +1 -1
@@ -64,7 +64,7 @@ static void fill_item_path(struct config/* back up enough to print this bus id with '/' */ length -= cur; -strncpy (buffer + length,config_item_name (p),cur); +memcpy (buffer + length,config_item_name (p), cur); *(buffer + --length) ='/' ; } }
Greg Kroah-Hartman
maintainerPATCH 101/124 gfs2: Put bitmap buffers in put_super
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andreas Gruenbacher <[email protected]>
commit 10283ea525d30f2e99828978fd04d8427876a7ad upstream.
gfs2_put_super calls gfs2_clear_rgrpd to destroy the gfs2_rgrpd objects attached to the resource group glocks. That function should release the buffers attached to the gfs2_bitmap objects (bi_bh), but the call to gfs2_rgrp_brelse for doing that is missing.
When gfs2_releasepage later runs across these buffers which are still referenced, it refuses to free them. This causes the pages the buffers are attached to to remain referenced as well. With enough mount/unmount cycles, the system will eventually run out of memory.
Fix this by adding the missing call to gfs2_rgrp_brelse in gfs2_clear_rgrpd.
(Also fix a gfs2_rgrp_relse -> gfs2_rgrp_brelse typo in a comment.)
--- fs/gfs2/rgrp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/gfs2/rgrp.c +2 -1
@@ -706,6 +706,7 @@ void gfs2_clear_rgrpd(struct gfs2_sbd *sif (gl) {glock_clear_object (gl, rgd); +gfs2_rgrp_brelse (rgd);gfs2_glock_put (gl); }
@@ -1115,7 +1116,7 @@ static u32 count_unlinked(struct gfs2_rg* @rgd: the struct gfs2_rgrpd describing the RG to read in * * Read in all of a Resource Group's header and bitmap blocks. -* Caller must eventually call gfs2_rgrp_relse() to free the bitmaps. +* Caller must eventually call gfs2_rgrp_brelse() to free the bitmaps. * * Returns: errno */
Greg Kroah-Hartman
maintainerPATCH 102/124 crypto: user - fix leaking uninitialized memory to userspace
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Biggers <[email protected]>
commit f43f39958beb206b53292801e216d9b8a660f087 upstream.
All bytes of the NETLINK_CRYPTO report structures must be initialized, since they are copied to userspace. The change from strncpy() to strlcpy() broke this. As a minimal fix, change it back.
--- crypto/crypto_user.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
crypto/crypto_user.c +9 -9
@@ -83,7 +83,7 @@ static int crypto_report_cipher(struct s {struct crypto_report_cipher rcipher; -strlcpy (rcipher.type,"cipher" ,sizeof (rcipher.type)); +strncpy (rcipher.type,"cipher" ,sizeof (rcipher.type)); rcipher.blocksize = alg->cra_blocksize; rcipher.min_keysize = alg->cra_cipher.cia_min_keysize;
@@ -102,7 +102,7 @@ static int crypto_report_comp(struct sk_ {struct crypto_report_comp rcomp; -strlcpy (rcomp.type,"compression" ,sizeof (rcomp.type)); +strncpy (rcomp.type,"compression" ,sizeof (rcomp.type));if (nla_put (skb,CRYPTOCFGA_REPORT_COMPRESS ,sizeof (struct crypto_report_comp ), &rcomp)) goto nla_put_failure;
@@ -116,7 +116,7 @@ static int crypto_report_acomp(struct sk {struct crypto_report_acomp racomp; -strlcpy (racomp.type,"acomp" ,sizeof (racomp.type)); +strncpy (racomp.type,"acomp" ,sizeof (racomp.type));if (nla_put (skb,CRYPTOCFGA_REPORT_ACOMP ,sizeof (struct crypto_report_acomp ), &racomp))
@@ -131,7 +131,7 @@ static int crypto_report_akcipher(struct {struct crypto_report_akcipher rakcipher; -strlcpy (rakcipher.type,"akcipher" ,sizeof (rakcipher.type)); +strncpy (rakcipher.type,"akcipher" ,sizeof (rakcipher.type));if (nla_put (skb,CRYPTOCFGA_REPORT_AKCIPHER ,sizeof (struct crypto_report_akcipher ), &rakcipher))
@@ -146,7 +146,7 @@ static int crypto_report_kpp(struct sk_b {struct crypto_report_kpp rkpp; -strlcpy (rkpp.type,"kpp" ,sizeof (rkpp.type)); +strncpy (rkpp.type,"kpp" ,sizeof (rkpp.type));if (nla_put (skb,CRYPTOCFGA_REPORT_KPP ,sizeof (struct crypto_report_kpp ), &rkpp))
@@ -160,10 +160,10 @@ nla_put_failure:static int crypto_report_one (struct crypto_alg *alg,struct crypto_user_alg *ualg,struct sk_buff *skb) { -strlcpy (ualg->cru_name, alg->cra_name,sizeof (ualg->cru_name)); -strlcpy (ualg->cru_driver_name, alg->cra_driver_name, +strncpy (ualg->cru_name, alg->cra_name,sizeof (ualg->cru_name)); +strncpy (ualg->cru_driver_name, alg->cra_driver_name,sizeof (ualg->cru_driver_name)); -strlcpy (ualg->cru_module_name,module_name (alg->cra_module), +strncpy (ualg->cru_module_name,module_name (alg->cra_module),sizeof (ualg->cru_module_name)); ualg->cru_type =0 ;
@@ -176,7 +176,7 @@ static int crypto_report_one(struct crypif (alg->cra_flags &CRYPTO_ALG_LARVAL ) {struct crypto_report_larval rl; -strlcpy (rl.type,"larval" ,sizeof (rl.type)); +strncpy (rl.type,"larval" ,sizeof (rl.type));if (nla_put (skb,CRYPTOCFGA_REPORT_LARVAL ,sizeof (struct crypto_report_larval ), &rl)) goto nla_put_failure;
Greg Kroah-Hartman
maintainerPATCH 103/124 lib/ubsan.c: dont mark __ubsan_handle_builtin_unreachable as noreturn
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Arnd Bergmann <[email protected]>
commit 1c23b4108d716cc848b38532063a8aca4f86add8 upstream.
gcc-8 complains about the prototype for this function:
lib/ubsan.c:432:1: error: ignoring attribute 'noreturn' in declaration of a built-in function '__ubsan_handle_builtin_unreachable' because it conflicts with attribute 'const' [-Werror=attributes]
This is actually a GCC's bug. In GCC internals __ubsan_handle_builtin_unreachable() declared with both 'noreturn' and 'const' attributes instead of only 'noreturn':
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84210
Workaround this by removing the noreturn attribute.
--- lib/ubsan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
lib/ubsan.c +1 -2
@@ -451,8 +451,7 @@ void __ubsan_handle_shift_out_of_bounds(EXPORT_SYMBOL (__ubsan_handle_shift_out_of_bounds); -void __noreturn -__ubsan_handle_builtin_unreachable (struct unreachable_data *data) +void __ubsan_handle_builtin_unreachable (struct unreachable_data *data) {unsigned long flags;
Greg Kroah-Hartman
maintainerPATCH 104/124 hugetlbfs: fix kernel BUG at fs/hugetlbfs/inode.c:444!
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mike Kravetz <[email protected]>
commit 5e41540c8a0f0e98c337dda8b391e5dda0cde7cf upstream.
This bug has been experienced several times by the Oracle DB team. The BUG is in remove_inode_hugepages() as follows:
/*
* If page is mapped, it was faulted in after being
* unmapped in caller. Unmap (again) now after taking
* the fault mutex. The mutex will prevent faults
* until we finish removing the page.
*
* This race can only happen in the hole punch case.
* Getting here in a truncate operation is a bug. */
if (unlikely(page_mapped(page))) {
BUG_ON(truncate_op);
In this case, the elevated map count is not the result of a race. Rather it was incorrectly incremented as the result of a bug in the huge pmd sharing code. Consider the following:
- Process A maps a hugetlbfs file of sufficient size and alignment (PUD_SIZE) that a pmd page could be shared.
- Process B maps the same hugetlbfs file with the same size and alignment such that a pmd page is shared.
- Process B then calls mprotect() to change protections for the mapping with the shared pmd. As a result, the pmd is 'unshared'.
- Process B then calls mprotect() again to chage protections for the mapping back to their original value. pmd remains unshared.
- Process B then forks and process C is created. During the fork process, we do dup_mm -> dup_mmap -> copy_page_range to copy page tables. Copying page tables for hugetlb mappings is done in the routine copy_hugetlb_page_range.
In copy_hugetlb_page_range(), the destination pte is obtained by:
dst_pte = huge_pte_alloc(dst, addr, sz);
If pmd sharing is possible, the returned pointer will be to a pte in an existing page table. In the situation above, process C could share with either process A or process B. Since process A is first in the list, the returned pte is a pointer to a pte in process A's page table.
However, the check for pmd sharing in copy_hugetlb_page_range is:
/* If the pagetables are shared don't copy or take references */ if (dst_pte == src_pte) continue;
Since process C is sharing with process A instead of process B, the above test fails. The code in copy_hugetlb_page_range which follows assumes dst_pte points to a huge_pte_none pte. It copies the pte entry from src_pte to dst_pte and increments this map count of the associated page. This is how we end up with an elevated map count.
To solve, check the dst_pte entry for huge_pte_none. If !none, this implies PMD sharing so do not copy.
--- mm/hugetlb.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-)
mm/hugetlb.c +19 -4
@@ -3211,7 +3211,7 @@ static int is_hugetlb_entry_hwpoisoned(pint copy_hugetlb_page_range (struct mm_struct *dst,struct mm_struct *src,struct vm_area_struct *vma) { -pte_t *src_pte, *dst_pte, entry; +pte_t *src_pte, *dst_pte, entry, dst_entry;struct page *ptepage;unsigned long addr;int cow;
@@ -3239,15 +3239,30 @@ int copy_hugetlb_page_range(struct mm_stbreak ; } -/* If the pagetables are shared don't copy or take references */ -if (dst_pte == src_pte) +/* +* If the pagetables are shared don't copy or take references. +* dst_pte == src_pte is the common case of src/dest sharing. +* +* However, src could have 'unshared' and dst shares with +* another vma. If dst_pte !none, this implies sharing. +* Check here before taking page table lock, and once again +* after taking the lock below. +*/ + dst_entry =huge_ptep_get (dst_pte); +if ((dst_pte == src_pte) || !huge_pte_none (dst_entry))continue ; dst_ptl =huge_pte_lock (h, dst, dst_pte); src_ptl =huge_pte_lockptr (h, src, src_pte);spin_lock_nested (src_ptl,SINGLE_DEPTH_NESTING ); entry =huge_ptep_get (src_pte); -if (huge_pte_none (entry)) {/* skip none entry */ + dst_entry =huge_ptep_get (dst_pte); +if (huge_pte_none (entry) || !huge_pte_none (dst_entry)) { +/* +* Skip if src entry none. Also, skip in the +* unlikely case dst entry !none as this implies +* sharing with another vma. +*/ ; }else if (unlikely (is_hugetlb_entry_migration (entry) ||is_hugetlb_entry_hwpoisoned (entry))) {
Greg Kroah-Hartman
maintainerPATCH 105/124 mm/swapfile.c: use kvzalloc for swap_info_struct allocation
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasily Averin <[email protected]>
commit 873d7bcfd066663e3e50113dc4a0de19289b6354 upstream.
Commit a2468cc9bfdf ("swap: choose swap device according to numa node") changed 'avail_lists' field of 'struct swap_info_struct' to an array. In popular linux distros it increased size of swap_info_struct up to 40 Kbytes and now swap_info_struct allocation requires order-4 page. Switch to kvzmalloc allows to avoid unexpected allocation failures.
--- mm/swapfile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mm/swapfile.c +3 -3
@@ -2830,7 +2830,7 @@ static struct swap_info_struct *alloc_swunsigned int type;int i; - p =kzalloc (sizeof (*p),GFP_KERNEL ); + p =kvzalloc (sizeof (*p),GFP_KERNEL );if (!p)return ERR_PTR (-ENOMEM );
@@ -2841,7 +2841,7 @@ static struct swap_info_struct *alloc_sw }if (type >=MAX_SWAPFILES ) {spin_unlock (&swap_lock); -kfree (p); +kvfree (p);return ERR_PTR (-EPERM ); }if (type >= nr_swapfiles) {
@@ -2855,7 +2855,7 @@ static struct swap_info_struct *alloc_swsmp_wmb (); nr_swapfiles++; }else { -kfree (p); +kvfree (p); p = swap_info[type];/* * Do not memset this entry: a racing procfs swap_next()
Greg Kroah-Hartman
maintainerPATCH 106/124 efi/arm/libstub: Pack FDT after populating it
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ard Biesheuvel <[email protected]>
commit 72a58a63a164b4e9d2d914e65caeb551846883f1 upstream.
Commit:
24d7c494ce46 ("efi/arm-stub: Round up FDT allocation to mapping size")
increased the allocation size for the FDT image created by the stub to a fixed value of 2 MB, to simplify the former code that made several attempts with increasing values for the size. This is reasonable given that the allocation is of type EFI_LOADER_DATA, which is released to the kernel unless it is explicitly memblock_reserve()d by the early boot code.
However, this allocation size leaked into the 'size' field of the FDT header metadata, and so the entire allocation remains occupied by the device tree binary, even if most of it is not used to store device tree information.
So call fdt_pack() to shrink the FDT data structure to its minimum size after populating all the fields, so that the remaining memory is no longer wasted.
--- drivers/firmware/efi/libstub/fdt.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/firmware/efi/libstub/fdt.c +4 -0
@@ -158,6 +158,10 @@ static efi_status_t update_fdt(efi_systereturn efi_status; } } + +/* shrink the FDT back to its minimum size */ +fdt_pack (fdt); +return EFI_SUCCESS ; fdt_set_fail:
Greg Kroah-Hartman
maintainerPATCH 107/124 drm/rockchip: Allow driver to be shutdown on reboot/kexec
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Marc Zyngier <[email protected]>
commit 7f3ef5dedb146e3d5063b6845781ad1bb59b92b5 upstream.
Leaving the DRM driver enabled on reboot or kexec has the annoying effect of leaving the display generating transactions whilst the IOMMU has been shut down.
In turn, the IOMMU driver (which shares its interrupt line with the VOP) starts warning either on shutdown or when entering the secondary kernel in the kexec case (nothing is expected on that front).
A cheap way of ensuring that things are nicely shut down is to register a shutdown callback in the platform driver.
--- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/rockchip/rockchip_drm_drv.c +6 -0
@@ -425,6 +425,11 @@ static int rockchip_drm_platform_remove(return 0 ; } +static void rockchip_drm_platform_shutdown (struct platform_device *pdev) +{ +rockchip_drm_platform_remove (pdev); +} +static const struct of_device_id rockchip_drm_dt_ids[] = { { .compatible ="rockchip,display-subsystem" , }, {/* sentinel */ },
@@ -434,6 +439,7 @@ MODULE_DEVICE_TABLE(of, rockchip_drm_dt_static struct platform_driver rockchip_drm_platform_driver = { .probe = rockchip_drm_platform_probe, .remove = rockchip_drm_platform_remove, + .shutdown = rockchip_drm_platform_shutdown, .driver = { .name ="rockchip-drm" , .of_match_table = rockchip_drm_dt_ids,
Greg Kroah-Hartman
maintainerPATCH 108/124 drm/amdgpu: add missing CHIP_HAINAN in amdgpu_ucode_get_load_type
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit d9997b64c52b70bd98c48f443f068253621d1ffc upstream.
This caused a confusing error message, but there is functionally no problem since the default method is DIRECT.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c +1 -0
@@ -247,6 +247,7 @@ amdgpu_ucode_get_load_type(struct amdgpucase CHIP_PITCAIRN :case CHIP_VERDE :case CHIP_OLAND : +case CHIP_HAINAN :return AMDGPU_FW_LOAD_DIRECT ;#endif #ifdef CONFIG_DRM_AMDGPU_CIK
Greg Kroah-Hartman
maintainerPATCH 109/124 drm/nouveau: Check backlight IDs are >= 0, not > 0
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lyude Paul <[email protected]>
commit dc854914999d5d52ac1b31740cb0ea8d89d0372e upstream.
Remember, ida IDs start at 0, not 1!
--- drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/nouveau/nouveau_backlight.c +2 -2
@@ -116,7 +116,7 @@ nv40_backlight_init(struct drm_connector &nv40_bl_ops, &props);if (IS_ERR (bd)) { -if (bl_connector.id >0 ) +if (bl_connector.id >=0 )ida_simple_remove (&bl_ida, bl_connector.id);return PTR_ERR (bd); }
@@ -249,7 +249,7 @@ nv50_backlight_init(struct drm_connector nv_encoder, ops, &props);if (IS_ERR (bd)) { -if (bl_connector.id >0 ) +if (bl_connector.id >=0 )ida_simple_remove (&bl_ida, bl_connector.id);return PTR_ERR (bd); }
Greg Kroah-Hartman
maintainerPATCH 110/124 drm/dp_mst: Check if primary mstb is null
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stanislav Lisovskiy <[email protected]>
commit 23d8003907d094f77cf959228e2248d6db819fa7 upstream.
Unfortunately drm_dp_get_mst_branch_device which is called from both drm_dp_mst_handle_down_rep and drm_dp_mst_handle_up_rep seem to rely on that mgr->mst_primary is not NULL, which seem to be wrong as it can be cleared with simultaneous mode set, if probing fails or in other case. mgr->lock mutex doesn't protect against that as it might just get assigned to NULL right before, not simultaneously.
There are currently bugs 107738, 108616 bugs which crash in drm_dp_get_mst_branch_device, caused by this issue.
v2: Refactored the code, as it was nicely noticed.
Fixed Bugzilla bug numbers(second was 108616, but not 108816) and added links.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108616
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107738
--- drivers/gpu/drm/drm_dp_mst_topology.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/drm_dp_mst_topology.c +3 -0
@@ -1232,6 +1232,9 @@ static struct drm_dp_mst_branch *drm_dp_mutex_lock (&mgr->lock); mstb = mgr->mst_primary; +if (!mstb) + goto out; +for (i =0 ; i < lct -1 ; i++) {int shift = (i %2 ) ?0 :4 ;int port_num = (rad[i /2 ] >> shift) &0xf ;
Greg Kroah-Hartman
maintainerPATCH 111/124 drm/atomic_helper: Disallow new modesets on unregistered connectors
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lyude Paul <[email protected]>
commit e96550956fbcd090629c0e2b5b8cded2eded2adf upstream.
With the exception of modesets which would switch the DPMS state of a connector from on to off, we want to make sure that we disallow all modesets which would result in enabling a new monitor or a new mode configuration on a monitor if the connector for the display in question is no longer registered. This allows us to stop userspace from trying to enable new displays on connectors for an MST topology that were just removed from the system, without preventing userspace from disabling DPMS on those connectors.
Changes since v5:
- Fix typo in comment, nothing else
--- drivers/gpu/drm/drm_atomic_helper.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-)
drivers/gpu/drm/drm_atomic_helper.c +20 -1
@@ -306,6 +306,26 @@ update_connector_routing(struct drm_atomreturn 0 ; } + crtc_state =drm_atomic_get_new_crtc_state (state, + new_connector_state->crtc); +/* +* For compatibility with legacy users, we want to make sure that +* we allow DPMS On->Off modesets on unregistered connectors. Modesets +* which would result in anything else must be considered invalid, to +* avoid turning on new displays on dead connectors. +* +* Since the connector can be unregistered at any point during an +* atomic check or commit, this is racy. But that's OK: all we care +* about is ensuring that userspace can't do anything but shut off the +* display on a connector that was destroyed after its been notified, +* not before. +*/ +if (!READ_ONCE (connector->registered) && crtc_state->active) { +DRM_DEBUG_ATOMIC ("[CONNECTOR:%d:%s] is not registered\n" , + connector->base.id, connector->name); +return -EINVAL ; + } + funcs = connector->helper_private;if (funcs->atomic_best_encoder)
@@ -350,7 +370,6 @@ update_connector_routing(struct drm_atomset_best_encoder (state, new_connector_state, new_encoder); - crtc_state =drm_atomic_get_new_crtc_state (state, new_connector_state->crtc); crtc_state->connectors_changed = true; DRM_DEBUG_ATOMIC("[CONNECTOR:%d:%s] using [ENCODER:%d:%s] on [CRTC:%d:%s]\n",
Greg Kroah-Hartman
maintainerPATCH 112/124 drm/i915: Restore vblank interrupts earlier
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ville Syrjälä <[email protected]>
commit 7cada4d0b7a0fb813dbc9777fec092e9ed0546e9 upstream.
Plane sanitation needs vblank interrupts (on account of CxSR disable). So let's restore vblank interrupts earlier.
v2: Make it actually build
v3: Add comment to explain why we need this (Daniel)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105637
--- drivers/gpu/drm/i915/intel_display.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/intel_display.c +13 -10
@@ -14829,13 +14829,9 @@ static void intel_sanitize_crtc(struct i I915_READ(reg) & ~PIPECONF_FRAME_START_DELAY_MASK); } -/* restore vblank interrupts to correct state */ -drm_crtc_vblank_reset (&crtc->base);if (crtc->active) {struct intel_plane *plane; -drm_crtc_vblank_on (&crtc->base); -/* Disable everything but the primary plane */ for_each_intel_plane_on_crtc (dev, crtc, plane) { const struct intel_plane_state *plane_state =
@@ -15148,7 +15144,6 @@ intel_modeset_setup_hw_state(struct drm_ struct drm_modeset_acquire_ctx *ctx) {struct drm_i915_private *dev_priv =to_i915 (dev); -enum pipe pipe;struct intel_crtc *crtc;struct intel_encoder *encoder;int i;
@@ -15167,15 +15162,23 @@ intel_modeset_setup_hw_state(struct drm_/* HW state is read out, now we need to sanitize this mess. */ get_encoder_power_domains (dev_priv); -intel_sanitize_plane_mapping (dev_priv); +/* +* intel_sanitize_plane_mapping() may need to do vblank +* waits, so we need vblank interrupts restored beforehand. +*/ +for_each_intel_crtc (&dev_priv->drm, crtc) { +drm_crtc_vblank_reset (&crtc->base); -for_each_intel_encoder (dev, encoder) { -intel_sanitize_encoder (encoder); +if (crtc->active) +drm_crtc_vblank_on (&crtc->base); } -for_each_pipe (dev_priv, pipe) { - crtc =intel_get_crtc_for_pipe (dev_priv, pipe); +intel_sanitize_plane_mapping (dev_priv); + +for_each_intel_encoder (dev, encoder) +intel_sanitize_encoder (encoder); +for_each_intel_crtc (&dev_priv->drm, crtc) {intel_sanitize_crtc (crtc, ctx);intel_dump_pipe_config (crtc, crtc->config,"[setup_hw_state]" );
Greg Kroah-Hartman
maintainerPATCH 113/124 drm/i915: Dont unset intel_connector->mst_port
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lyude Paul <[email protected]>
commit 80c188695a77eddaa6e8885510ff4ef59fd478c3 upstream.
Currently we set intel_connector->mst_port to NULL to signify that the MST port has been removed from the system so that we can prevent further action on the port such as connector probes, mode probing, etc. However, we're going to need access to intel_connector->mst_port in order to fixup ->best_encoder() so that it can always return the correct encoder for an MST port to prevent legacy DPMS prop changes from failing. This should be safe, so instead keep intel_connector->mst_port always set and instead just check the status of drm_connector->regustered to signify whether or not the connector has disappeared from the system.
Changes since v2:
- Add a comment to mst_port_gone (Jani Nikula)
- Change mst_port_gone to a u8 instead of a bool, per the kernel bot. Apparently bool is discouraged in structs these days
Changes since v4:
- Don't use mst_port_gone at all! Just check if the connector is registered or not - Daniel Vetter
--- drivers/gpu/drm/i915/intel_dp_mst.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_dp_mst.c +6 -11
@@ -311,9 +311,8 @@ static int intel_dp_mst_get_ddc_modes(ststruct edid *edid;int ret; -if (!intel_dp) { +if (!READ_ONCE (connector->registered))return intel_connector_update_modes (connector,NULL ); - } edid =drm_dp_mst_get_edid (connector, &intel_dp->mst_mgr, intel_connector->port); ret =intel_connector_update_modes (connector, edid);
@@ -328,9 +327,10 @@ intel_dp_mst_detect(struct drm_connectorstruct intel_connector *intel_connector =to_intel_connector (connector);struct intel_dp *intel_dp = intel_connector->mst_port; -if (!intel_dp) +if (!READ_ONCE (connector->registered))return connector_status_disconnected; -return drm_dp_mst_detect_port (connector, &intel_dp->mst_mgr, intel_connector->port); +return drm_dp_mst_detect_port (connector, &intel_dp->mst_mgr, + intel_connector->port); } static void
@@ -370,7 +370,7 @@ intel_dp_mst_mode_valid(struct drm_conneint bpp =24 ;/* MST uses fixed bpp */ int max_rate, mode_rate, max_lanes, max_link_clock; -if (!intel_dp) +if (!READ_ONCE (connector->registered))return MODE_ERROR ; max_link_clock =intel_dp_max_link_rate (intel_dp);
@@ -399,7 +399,7 @@ static struct drm_encoder *intel_mst_atostruct intel_dp *intel_dp = intel_connector->mst_port;struct intel_crtc *crtc =to_intel_crtc (state->crtc); -if (!intel_dp) +if (!READ_ONCE (connector->registered))return NULL ;return &intel_dp->mst_encoders[crtc->pipe]->base.base; }
@@ -491,7 +491,6 @@ static void intel_dp_register_mst_connecstatic void intel_dp_destroy_mst_connector (struct drm_dp_mst_topology_mgr *mgr,struct drm_connector *connector) { -struct intel_connector *intel_connector =to_intel_connector (connector);struct drm_i915_private *dev_priv =to_i915 (connector->dev);drm_connector_unregister (connector);
@@ -499,10 +498,6 @@ static void intel_dp_destroy_mst_connectif (dev_priv->fbdev)drm_fb_helper_remove_one_connector (&dev_priv->fbdev->helper, connector); -/* prevent race with the check in ->detect */ -drm_modeset_lock (&connector->dev->mode_config.connection_mutex,NULL ); - intel_connector->mst_port =NULL ; -drm_modeset_unlock (&connector->dev->mode_config.connection_mutex);drm_connector_unreference (connector);DRM_DEBUG_KMS ("\n" );
Greg Kroah-Hartman
maintainerPATCH 114/124 drm/i915: Skip vcpi allocation for MSTB ports that are gone
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lyude Paul <[email protected]>
commit c02ba4ef16eefe663fdefcccaa57fad32d5481bf upstream.
Since we need to be able to allow DPMS on->off prop changes after an MST port has disappeared from the system, we need to be able to make sure we can compute a config for the resulting atomic commit. Currently this is impossible when the port has disappeared, since the VCPI slot searching we try to do in intel_dp_mst_compute_config() will fail with -EINVAL.
Since the only commits we want to allow on no-longer-present MST ports are ones that shut off display hardware, we already know that no VCPI allocations are needed. So, hardcode the VCPI slot count to 0 when intel_dp_mst_compute_config() is called on an MST port that's gone.
Changes since V4:
- Don't use mst_port_gone at all, just check whether or not the drm connector is registered - Daniel Vetter
--- drivers/gpu/drm/i915/intel_dp_mst.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/intel_dp_mst.c +15 -9
@@ -37,11 +37,11 @@ static bool intel_dp_mst_compute_config(struct intel_dp_mst_encoder *intel_mst =enc_to_mst (&encoder->base);struct intel_digital_port *intel_dig_port = intel_mst->primary;struct intel_dp *intel_dp = &intel_dig_port->dp; -struct intel_connector *connector = -to_intel_connector (conn_state->connector); +struct drm_connector *connector = conn_state->connector; +void *port =to_intel_connector (connector)->port;struct drm_atomic_state *state = pipe_config->base.state;int bpp; -int lane_count, slots; +int lane_count, slots =0 ;const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;int mst_pbn; bool reduce_m_n = drm_dp_has_quirk(&intel_dp->desc,
@@ -66,17 +66,23 @@ static bool intel_dp_mst_compute_config( pipe_config->port_clock =intel_dp_max_link_rate (intel_dp); -if (drm_dp_mst_port_has_audio (&intel_dp->mst_mgr, connector->port)) +if (drm_dp_mst_port_has_audio (&intel_dp->mst_mgr, port)) pipe_config->has_audio = true; mst_pbn =drm_dp_calc_pbn_mode (adjusted_mode->crtc_clock, bpp); pipe_config->pbn = mst_pbn; - slots =drm_dp_atomic_find_vcpi_slots (state, &intel_dp->mst_mgr, - connector->port, mst_pbn); -if (slots <0 ) { -DRM_DEBUG_KMS ("failed finding vcpi slots:%d\n" , slots); -return false; +/* Zombie connectors can't have VCPI slots */ +if (READ_ONCE (connector->registered)) { + slots =drm_dp_atomic_find_vcpi_slots (state, + &intel_dp->mst_mgr, + port, + mst_pbn); +if (slots <0 ) { +DRM_DEBUG_KMS ("failed finding vcpi slots:%d\n" , + slots); +return false; + } } intel_link_compute_m_n(bpp, lane_count,
Greg Kroah-Hartman
maintainerPATCH 115/124 drm/i915: Large page offsets for pread/pwrite
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Wilson <[email protected]>
commit ab0d6a141843e0b4b2709dfd37b53468b5452c3a upstream.
Handle integer overflow when computing the sub-page length for shmem backed pread/pwrite.
--- drivers/gpu/drm/i915/i915_gem.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +2 -10
@@ -980,11 +980,7 @@ i915_gem_shmem_pread(struct drm_i915_gem offset =offset_in_page (args->offset);for (idx = args->offset >>PAGE_SHIFT ; remain; idx++) {struct page *page =i915_gem_object_get_page (obj, idx); -int length; - - length = remain; -if (offset + length >PAGE_SIZE ) - length =PAGE_SIZE - offset; +unsigned int length =min_t (u64, remain,PAGE_SIZE - offset); ret = shmem_pread(page, offset, length, user_data, page_to_phys(page) & obj_do_bit17_swizzling,
@@ -1406,11 +1402,7 @@ i915_gem_shmem_pwrite(struct drm_i915_ge offset =offset_in_page (args->offset);for (idx = args->offset >>PAGE_SHIFT ; remain; idx++) {struct page *page =i915_gem_object_get_page (obj, idx); -int length; - - length = remain; -if (offset + length >PAGE_SIZE ) - length =PAGE_SIZE - offset; +unsigned int length =min_t (u64, remain,PAGE_SIZE - offset); ret = shmem_pwrite(page, offset, length, user_data, page_to_phys(page) & obj_do_bit17_swizzling,
Greg Kroah-Hartman
maintainerPATCH 116/124 drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Clint Taylor <[email protected]>
commit 6503493145cba4413ecd3d4d153faeef4a1e9b85 upstream.
HDMI 2.0 594Mhz modes were incorrectly selecting 25.200Mhz Automatic N value mode instead of HDMI specification values.
V2: Fix 88.2 Hz N value
--- drivers/gpu/drm/i915/intel_audio.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/gpu/drm/i915/intel_audio.c +17 -0
@@ -134,6 +134,9 @@ static const struct {/* HDMI N/CTS table */ #define TMDS_297M 297000#define TMDS_296M 296703 +#define TMDS_594M 594000 +#define TMDS_593M 593407 + static const struct { int sample_rate; int clock;
@@ -154,6 +157,20 @@ static const struct { { 176400, TMDS_297M, 18816, 247500 }, { 192000, TMDS_296M, 23296, 281250 }, { 192000, TMDS_297M, 20480, 247500 }, + { 44100, TMDS_593M, 8918, 937500 }, + { 44100, TMDS_594M, 9408, 990000 }, + { 48000, TMDS_593M, 5824, 562500 }, + { 48000, TMDS_594M, 6144, 594000 }, + { 32000, TMDS_593M, 5824, 843750 }, + { 32000, TMDS_594M, 3072, 445500 }, + { 88200, TMDS_593M, 17836, 937500 }, + { 88200, TMDS_594M, 18816, 990000 }, + { 96000, TMDS_593M, 11648, 562500 }, + { 96000, TMDS_594M, 12288, 594000 }, + { 176400, TMDS_593M, 35672, 937500 }, + { 176400, TMDS_594M, 37632, 990000 }, + { 192000, TMDS_593M, 23296, 562500 }, + { 192000, TMDS_594M, 24576, 594000 }, };/* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */
Greg Kroah-Hartman
maintainerPATCH 117/124 drm/i915: Dont oops during modeset shutdown after lpe audio deinit
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ville Syrjälä <[email protected]>
commit 6a8915d0f8cf323e1beb792a33095cf652db4056 upstream.
We deinit the lpe audio device before we call drm_atomic_helper_shutdown(), which means the platform device may already be gone when it comes time to shut down the crtc. As we don't know when the last reference to the platform device gets dropped by the audio driver we can't assume that the device and its data are still around when turning off the crtc. Mark the platform device as gone as soon as we do the audio deinit.
--- drivers/gpu/drm/i915/intel_lpe_audio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lpe_audio.c +3 -1
@@ -303,8 +303,10 @@ void intel_lpe_audio_teardown(struct drmlpe_audio_platdev_destroy (dev_priv);irq_free_desc (dev_priv->lpe_audio.irq); -} + dev_priv->lpe_audio.irq =-1 ; + dev_priv->lpe_audio.platdev =NULL ; +}/** * intel_lpe_audio_notify() - notify lpe audio event
Greg Kroah-Hartman
maintainerPATCH 118/124 drm/i915: Mark pin flags as u64
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Wilson <[email protected]>
commit 0014868b9c3c1dda1de6711cf58c3486fb422d07 upstream.
Since the flags are being used to operate on a u64 variable, they too need to be marked as such so that the inverses are full width (and not zero extended on 32b kernels and bdw+).
--- drivers/gpu/drm/i915/i915_gem_gtt.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.h +12 -12
@@ -584,20 +584,20 @@ int i915_gem_gtt_insert(struct i915_addr u64 start, u64 end, unsigned int flags);/* Flags used by pin/bind&friends. */ -#define PIN_NONBLOCK BIT(0) -#define PIN_MAPPABLE BIT(1) -#define PIN_ZONE_4G BIT(2) -#define PIN_NONFAULT BIT(3) -#define PIN_NOEVICT BIT(4) +#define PIN_NONBLOCK BIT_ULL(0) +#define PIN_MAPPABLE BIT_ULL(1) +#define PIN_ZONE_4G BIT_ULL(2) +#define PIN_NONFAULT BIT_ULL(3) +#define PIN_NOEVICT BIT_ULL(4) -#define PIN_MBZ BIT(5)/* I915_VMA_PIN_OVERFLOW */ -#define PIN_GLOBAL BIT(6)/* I915_VMA_GLOBAL_BIND */ -#define PIN_USER BIT(7)/* I915_VMA_LOCAL_BIND */ -#define PIN_UPDATE BIT(8) +#define PIN_MBZ BIT_ULL(5)/* I915_VMA_PIN_OVERFLOW */ +#define PIN_GLOBAL BIT_ULL(6)/* I915_VMA_GLOBAL_BIND */ +#define PIN_USER BIT_ULL(7)/* I915_VMA_LOCAL_BIND */ +#define PIN_UPDATE BIT_ULL(8) -#define PIN_HIGH BIT(9) -#define PIN_OFFSET_BIAS BIT(10) -#define PIN_OFFSET_FIXED BIT(11) +#define PIN_HIGH BIT_ULL(9) +#define PIN_OFFSET_BIAS BIT_ULL(10) +#define PIN_OFFSET_FIXED BIT_ULL(11)#define PIN_OFFSET_MASK (-I915_GTT_PAGE_SIZE)#endif
Greg Kroah-Hartman
maintainerPATCH 119/124 drm/i915/execlists: Force write serialisation into context image vs execution
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Wilson <[email protected]>
commit 0a823e8fd4fd67726697854578f3584ee3a49b1d upstream.
Ensure that the writes into the context image are completed prior to the register mmio to trigger execution. Although previously we were assured by the SDM that all writes are flushed before an uncached memory transaction (our mmio write to submit the context to HW for execution), we have empirical evidence to believe that this is not actually the case.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108656
References: https://bugs.freedesktop.org/show_bug.cgi?id=108315
References: https://bugs.freedesktop.org/show_bug.cgi?id=106887
--- drivers/gpu/drm/i915/intel_lrc.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lrc.c +13 -1
@@ -325,7 +325,8 @@ static u64 execlists_update_context(stru reg_state[CTX_RING_TAIL +1 ] =intel_ring_set_tail (rq->ring, rq->tail); -/* True 32b PPGTT with dynamic page allocation: update PDP +/* +* True 32b PPGTT with dynamic page allocation: update PDP * registers and point the unallocated PDPs to scratch page. * PML4 is allocated during ppgtt init, so this is not needed * in 48-bit mode.
@@ -333,6 +334,17 @@ static u64 execlists_update_context(struif (ppgtt && !i915_vm_is_48bit (&ppgtt->base))execlists_update_context_pdps (ppgtt, reg_state); +/* +* Make sure the context image is complete before we submit it to HW. +* +* Ostensibly, writes (including the WCB) should be flushed prior to +* an uncached write such as our mmio register access, the empirical +* evidence (esp. on Braswell) suggests that the WC write into memory +* may not be visible to the HW prior to the completion of the UC +* register write and that we may begin execution from the context +* before its image is complete leading to invalid PD chasing. +*/ +wmb ();return ce->lrc_desc; }
Greg Kroah-Hartman
maintainerPATCH 120/124 CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stefano Stabellini <[email protected]>
commit f9005571701920551bcf54a500973fb61f2e1eda upstream.
xen_create_contiguous_region has now only an implementation if CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but we do have an implementation of xen_create_contiguous_region which is required for swiotlb-xen to work correctly (although it just sets *dma_handle).
[backport: remove change to xen_remap_pfn]
--- include/xen/xen-ops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/xen/xen-ops.h +1 -1
@@ -40,7 +40,7 @@ int xen_setup_shutdown_event(void);extern unsigned long *xen_contiguous_bitmap; -#ifdef CONFIG_XEN_PV +#if defined(CONFIG_XEN_PV ) || defined(CONFIG_ARM ) || defined(CONFIG_ARM64 )int xen_create_contiguous_region (phys_addr_t pstart,unsigned int order,unsigned int address_bits,dma_addr_t *dma_handle);
Greg Kroah-Hartman
maintainerPATCH 121/124 ovl: check whiteout in ovl_create_over_whiteout()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Miklos Szeredi <[email protected]>
commit 5e1275808630ea3b2c97c776f40e475017535f72 upstream.
Kaixuxia repors that it's possible to crash overlayfs by removing the whiteout on the upper layer before creating a directory over it. This is a reproducer:
mkdir lower upper work merge
touch lower/file
mount -t overlay overlay -olowerdir=lower,upperdir=upper,workdir=work merge rm merge/file
ls -al merge/file
rm upper/file
ls -al merge/
mkdir merge/file
Before commencing with a vfs_rename(..., RENAME_EXCHANGE) verify that the lookup of "upper" is positive and is a whiteout, and return ESTALE otherwise.
Reported by: kaixuxia <[email protected]>
--- fs/overlayfs/dir.c | 4 ++++ 1 file changed, 4 insertions(+)
fs/overlayfs/dir.c +4 -0
@@ -392,6 +392,10 @@ static int ovl_create_over_whiteout(struif (IS_ERR (upper)) goto out_dput; + err = -ESTALE ; +if (d_is_negative (upper) || !IS_WHITEOUT (d_inode (upper))) + goto out_dput2; + err =ovl_create_real (wdir, newdentry, cattr, hardlink, true);if (err) goto out_dput2;
Greg Kroah-Hartman
maintainerPATCH 122/124 printk: Never set console_may_schedule in console_trylock()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sergey Senozhatsky <[email protected]>
commit fd5f7cde1b85d4c8e09ca46ce948e008a2377f64 upstream.
This patch, basically, reverts commit 6b97a20d3a79 ("printk:
set may_schedule for some of console_trylock() callers"). That commit was a mistake, it introduced a big dependency on the scheduler, by enabling preemption under console_sem in printk()->console_unlock() path, which is rather too critical. The patch did not significantly reduce the possibilities of printk() lockups, but made it possible to stall printk(), as has been reported by Tetsuo Handa [1].
Another issues is that preemption under console_sem also messes up with Steven Rostedt's hand off scheme, by making it possible to sleep with console_sem both in console_unlock() and in vprintk_emit(), after acquiring the console_sem ownership (anywhere between printk_safe_exit_irqrestore() in console_trylock_spinning() and printk_safe_enter_irqsave() in console_unlock()). This makes hand off less likely and, at the same time, may result in a significant amount of pending logbuf messages. Preempted console_sem owner makes it impossible for other CPUs to emit logbuf messages, but does not make it impossible for other CPUs to append new messages to the logbuf.
Reinstate the old behavior and make printk() non-preemptible. Should any printk() lockup reports arrive they must be handled in a different way.
To: Tetsuo Handa <[email protected]>
--- kernel/printk/printk.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-)
kernel/printk/printk.c +8 -14
@@ -1763,12 +1763,19 @@ asmlinkage int vprintk_emit(int facility/* If called from the scheduler, we can not call up(). */ if (!in_sched) {/* +* Disable preemption to avoid being preempted while holding +* console_sem which would prevent anyone from printing to +* console +*/ +preempt_disable (); +/* * Try to acquire and then immediately release the console * semaphore. The release will print out buffers and wake up * /dev/kmsg and syslog() users. */ if (console_trylock ())console_unlock (); +preempt_enable (); }return printed_len;
@@ -2083,20 +2090,7 @@ int console_trylock(void)return 0 ; } console_locked =1 ; -/* -* When PREEMPT_COUNT disabled we can't reliably detect if it's -* safe to schedule (e.g. calling printk while holding a spin_lock), -* because preempt_disable()/preempt_enable() are just barriers there -* and preempt_count() is always 0. -* -* RCU read sections have a separate preemption counter when -* PREEMPT_RCU enabled thus we must take extra care and check -* rcu_preempt_depth(), otherwise RCU read sections modify -* preempt_count(). -*/ - console_may_schedule = !oops_in_progress && -preemptible () && - !rcu_preempt_depth (); + console_may_schedule =0 ;return 1 ; }EXPORT_SYMBOL (console_trylock);
Greg Kroah-Hartman
maintainerPATCH 123/124 nvme-loop: fix kernel oops in case of unhandled command
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ming Lei <[email protected]>
commit 11d9ea6f2ca69237d35d6c55755beba3e006b106 upstream.
When nvmet_req_init() fails, __nvmet_req_complete() is called to handle the target request via .queue_response(), so nvme_loop_queue_response() shouldn't be called again for handling the failure.
This patch fixes this case by the following way:
- move blk_mq_start_request() before nvmet_req_init(), so nvme_loop_queue_response() may work well to complete this host request
- don't call nvme_cleanup_cmd() which is done in nvme_loop_complete_rq()
- don't call nvme_loop_queue_response() which is done via .queue_response()
--- drivers/nvme/target/loop.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/nvme/target/loop.c +2 -7
@@ -183,15 +183,12 @@ static blk_status_t nvme_loop_queue_rq(sif (ret)return ret; +blk_mq_start_request (req); iod->cmd.common.flags |=NVME_CMD_SGL_METABUF ; iod->req.port = nvmet_loop_port;if (!nvmet_req_init (&iod->req, &queue->nvme_cq, - &queue->nvme_sq, &nvme_loop_ops)) { -nvme_cleanup_cmd (req); -blk_mq_start_request (req); -nvme_loop_queue_response (&iod->req); + &queue->nvme_sq, &nvme_loop_ops))return BLK_STS_OK ; - }if (blk_rq_bytes (req)) { iod->sg_table.sgl = iod->first_sgl;
@@ -204,8 +201,6 @@ static blk_status_t nvme_loop_queue_rq(s iod->req.sg_cnt =blk_rq_map_sg (req->q, req, iod->sg_table.sgl); } -blk_mq_start_request (req); -schedule_work (&iod->work);return BLK_STS_OK ; }
Greg Kroah-Hartman
maintainerPATCH 124/124 gpio: brcmstb: release the bgpio lock during irq handlers
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Doug Berger <[email protected]>
commit 142c168e0e50164e67c9399c28dedd65a307cfe5 upstream.
The basic memory-mapped GPIO controller lock must be released before calling the registered GPIO interrupt handlers to allow the interrupt handlers to access the hardware.
Examples of why a GPIO interrupt handler might want to access the GPIO hardware include an interrupt that is configured to trigger on rising and falling edges that needs to read the current level of the input to know how to respond, or an interrupt that causes a change in a GPIO output in the same bank. If the lock is not released before enterring the handler the hardware accesses will deadlock when they attempt to grab the lock.
Since the lock is only needed to protect the calculation of unmasked pending interrupts create a dedicated function to perform this and hide the complexity.
--- drivers/gpio/gpio-brcmstb.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-)
drivers/gpio/gpio-brcmstb.c +16 -5
@@ -63,6 +63,21 @@ brcmstb_gpio_gc_to_priv(struct gpio_chipreturn bank->parent_priv; } +static unsigned long +brcmstb_gpio_get_active_irqs (struct brcmstb_gpio_bank *bank) +{ +void __iomem *reg_base = bank->parent_priv->reg_base; +unsigned long status; +unsigned long flags; + +spin_lock_irqsave (&bank->gc.bgpio_lock, flags); + status = bank->gc.read_reg (reg_base +GIO_STAT (bank->id)) & + bank->gc.read_reg (reg_base +GIO_MASK (bank->id)); +spin_unlock_irqrestore (&bank->gc.bgpio_lock, flags); + +return status; +} +static void brcmstb_gpio_set_imask (struct brcmstb_gpio_bank *bank,unsigned int offset,bool enable) {
@@ -205,11 +220,8 @@ static void brcmstb_gpio_irq_bank_handlestruct irq_domain *irq_domain = bank->gc.irqdomain;void __iomem *reg_base = priv->reg_base;unsigned long status; -unsigned long flags; -spin_lock_irqsave (&bank->gc.bgpio_lock, flags); -while ((status = bank->gc.read_reg (reg_base +GIO_STAT (bank->id)) & - bank->gc.read_reg (reg_base +GIO_MASK (bank->id)))) { +while ((status =brcmstb_gpio_get_active_irqs (bank))) {int bit;for_each_set_bit (bit, &status,32 ) {
@@ -224,7 +236,6 @@ static void brcmstb_gpio_irq_bank_handlegeneric_handle_irq (irq_find_mapping (irq_domain, bit)); } } -spin_unlock_irqrestore (&bank->gc.bgpio_lock, flags); }/* Each UPG GIO block has one IRQ for all banks */
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.82 release. There are 124 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Nov 21 16:25:07 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.82-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.14.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
stable-rc/linux-4.14.y boot: 77 boots: 0 failed, 59 passed with 18 offline (v4.14.81-125-g43bb46eb6e2e)
stable-rc/linux-4.14.y boot: 77 boots: 0 failed, 59 passed with 18 offline (v4.14.81-125-g43bb46eb6e2e)
Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.14.81-125-g43bb46eb6e2e/
Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.81-125-g43bb46eb6e2e/
Tree: stable-rc
Branch: linux-4.14.y
Git Describe: v4.14.81-125-g43bb46eb6e2e
Git Commit: 43bb46eb6e2eae660d29ec037de28fca0cd2e7e5
Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Tested: 50 unique boards, 20 SoC families, 14 builds out of 185
Offline Platforms:
arm:
omap2plus_defconfig:
am335x-boneblack: 1 offline lab
sunxi_defconfig:
sun5i-r8-chip: 1 offline lab
tegra_defconfig:
tegra124-jetson-tk1: 1 offline lab
bcm2835_defconfig:
bcm2835-rpi-b: 1 offline lab
exynos_defconfig:
exynos5800-peach-pi: 1 offline lab
sama5_defconfig:
at91-sama5d4_xplained: 1 offline lab
multi_v7_defconfig:
alpine-db: 1 offline lab
am335x-boneblack: 1 offline lab
at91-sama5d4_xplained: 1 offline lab
exynos5800-peach-pi: 1 offline lab socfpga_cyclone5_de0_sockit: 1 offline lab
sun5i-r8-chip: 1 offline lab
tegra124-jetson-tk1: 1 offline lab
arm64:
defconfig:
apq8016-sbc: 1 offline lab
juno-r2: 1 offline lab
meson-gxl-s905d-p230: 1 offline lab
meson-gxl-s905x-p212: 1 offline lab
mt7622-rfb1: 1 offline lab---
For more info write to <[email protected]>
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.82 release. There are 124 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Nov 21 16:25:07 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.82-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.14.y
and the diffstat can be found below.thanks,
greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
Summary
------------------------------------------------------------------------
kernel: 4.14.82-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.14.y
git commit: 43bb46eb6e2eae660d29ec037de28fca0cd2e7e5
git describe: v4.14.81-125-g43bb46eb6e2e
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.14-oe/build/v4.14.81-125-g43bb46eb6e2e
No regressions (compared to build v4.14.81)
No fixes (compared to build v4.14.81)
Ran 19592 total tests in the following environments and test suites.
Environments
--------------
- dragonboard-410c - arm64
- hi6220-hikey - arm64
- i386
- juno-r2 - arm64
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15 - arm
- x86_64
Test Suites
-----------
* boot
* install-android-platform-tools-r2600
* kselftest
* libhugetlbfs
* ltp-cap_bounds-tests
* ltp-containers-tests
* ltp-cve-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-timers-tests
* ltp-open-posix-tests
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none
Signature · 2 lines
Linaro LKFT https://lkft.linaro.org
Jon Hunter
maintainerQuoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.82 release. There are 124 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Nov 21 16:25:07 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.82-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.14.y
and the diffstat can be found below.thanks,
greg k-h
All tests are passing for Tegra ...
Test results for stable-v4.14:
8 builds: 8 pass, 0 fail
16 boots: 16 pass, 0 fail
14 tests: 14 pass, 0 failLinux version: 4.14.82-rc1-g43bb46e
Boards tested: tegra124-jetson-tk1, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04
Cheers
Jon
Signature · 1 line
nvpublic
Greg Kroah-Hartman
maintainerQuoted 21 lines · Jon Hunter
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.82 release. There are 124 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Nov 21 16:25:07 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.82-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.14.y
and the diffstat can be found below.thanks,
greg k-h
All tests are passing for Tegra ...
Quoted 9 lines
Test results for stable-v4.14:
8 builds: 8 pass, 0 fail 16 boots: 16 pass, 0 fail 14 tests: 14 pass, 0 failLinux version: 4.14.82-rc1-g43bb46e
Boards tested: tegra124-jetson-tk1, tegra20-ventana,tegra210-p2371-2180, tegra30-cardhu-a04
Thanks for testing these and letting me know.
greg k-h
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.82 release. There are 124 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Nov 21 16:25:07 UTC 2018. Anything received after that time might be too late.
Build results:
total: 150 pass: 150 fail: 0 Qemu test results: total: 293 pass: 293 fail: 0
Details are available at https://kerneltests.org/builders/.
Guenter