nvmet-rdma: Add unlikely for response allocated check

PATCH New Israel Rukshin 3 participants 5 messages Nov 19, 2018 – Nov 20, 2018

Subsystems (2)

NVMe NVMe target

lore

Share & tools

lore

Israel Rukshin

author

2018-11-19 10:58 UTC #0 lore raw

PATCH 1/2 nvmet-rdma: Add unlikely for response allocated check

Signed-off-by Israel Rukshin <israelr at mellanox.com>

Reviewed-by Max Gurtovoy <maxg at mellanox.com>

---
 drivers/nvme/target/rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/nvme/target/rdma.c +1 -1

index 3f7971d3..932242e 100644
@@ -196,7 +196,7 @@ static inline bool nvmet_rdma_need_data_out(struct nvmet_rdma_rsp *rsp)
 {
 	unsigned long flags;
 
-	if (rsp->allocated) {
+	if (unlikely(rsp->allocated)) {
 		kfree(rsp);
 		return;
 	}

Signature · 1 line

1.8.3.1

Israel Rukshin

author

2018-11-19 10:58 UTC #1 lore raw

PATCH 2/2 nvme: Remove unused forward declaration

Signed-off-by Israel Rukshin <israelr at mellanox.com>

Reviewed-by Max Gurtovoy <maxg at mellanox.com>

---
 drivers/nvme/host/core.c | 1 -
 1 file changed, 1 deletion(-)

drivers/nvme/host/core.c +0 -1

index 559d567..6b83809 100644
@@ -97,7 +97,6 @@
 static struct class *nvme_class;
 static struct class *nvme_subsys_class;
 
-static void nvme_ns_remove(struct nvme_ns *ns);
 static int nvme_revalidate_disk(struct gendisk *disk);
 static void nvme_put_subsystem(struct nvme_subsystem *subsys);
 static void nvme_remove_invalid_namespaces(struct nvme_ctrl *ctrl,