Skip to contentSkip to conversation

ARM: dts: sun8i: Add the H3/H5 CSI controller

PATCH Superseded Maxime Ripard 2 participants 5 messages Nov 20, 2018 – Nov 27, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 ARM: dts: sun8i: Add the H3/H5 CSI controller

From: Myl?ne Josserand <[email protected]>

The H3 and H5 features the same CSI controller that was initially found on the A31.

Add a DT node for it.

---

Changes from v3:
- Removed the CSI MCLK pin from the default pin group

---
 arch/arm/boot/dts/sunxi-h3-h5.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm/boot/dts/sunxi-h3-h5.dtsi +22 -0
index 4b1530ebe427..39cd445f796a 100644
@@ -393,6 +393,13 @@
 			interrupt-controller;
 			#interrupt-cells = <3>;
 
+			csi_pins: csi {
+				pins = "PE1", "PE2", "PE3", "PE4", "PE5",
+				       "PE6", "PE7", "PE8", "PE9", "PE10",
+				       "PE11";
+				function = "csi";
+			};
+
 			emac_rgmii_pins: emac0 {
 				pins = "PD0", "PD1", "PD2", "PD3", "PD4",
 				       "PD5", "PD7", "PD8", "PD9", "PD10",
@@ -744,6 +751,21 @@
 			interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
 		};
 
+		csi: camera at 1cb0000 {
+			compatible = "allwinner,sun8i-h3-csi",
+				     "allwinner,sun6i-a31-csi";
+			reg = <0x01cb0000 0x1000>;
+			interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&ccu CLK_BUS_CSI>,
+				 <&ccu CLK_CSI_SCLK>,
+				 <&ccu CLK_DRAM_CSI>;
+			clock-names = "bus", "mod", "ram";
+			resets = <&ccu RST_BUS_CSI>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&csi_pins>;
+			status = "disabled";
+		};
+
 		hdmi: hdmi at 1ee0000 {
 			compatible = "allwinner,sun8i-h3-dw-hdmi",
 				     "allwinner,sun8i-a83t-dw-hdmi";
Signature · 1 line
2.19.1
#1 lore raw

PATCH v3 1/1 ARM: dts: sun8i: Add the H3/H5 CSI controller

Quoted 8 lines · Maxime Ripard

From: Myl?ne Josserand <[email protected]>

The H3 and H5 features the same CSI controller that was initially found on the A31.

Add a DT node for it.

Quoted 7 lines

---

Changes from v3:
- Removed the CSI MCLK pin from the default pin group

If I'm not wrong, PE1 is CSI_MCLK and PE0 is CSI_PCLK so we have PE0 and PE1 removed.

#2 lore raw

PATCH v3 1/1 ARM: dts: sun8i: Add the H3/H5 CSI controller

Quoted 12 lines · Jagan Teki
Quoted 11 lines · Maxime Ripard

From: Myl?ne Josserand <[email protected]>

The H3 and H5 features the same CSI controller that was initially found on the A31.

Add a DT node for it.

Quoted 7 lines
Quoted 4 lines

---

Changes from v3:
- Removed the CSI MCLK pin from the default pin group

If I'm not wrong, PE1 is CSI_MCLK and PE0 is CSI_PCLK so we have PE0 and PE1 removed.

i'm not sure what you mean, PCLK is still in that patch.

Maxime

Signature · 3 lines
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH v3 1/1 ARM: dts: sun8i: Add the H3/H5 CSI controller

Quoted 16 lines · Maxime Ripard
Quoted 14 lines · Jagan Teki
Quoted 13 lines · Maxime Ripard

From: Myl?ne Josserand <[email protected]>

The H3 and H5 features the same CSI controller that was initially found on the A31.

Add a DT node for it.

---

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Changes from v3:
- Removed the CSI MCLK pin from the default pin group

If I'm not wrong, PE1 is CSI_MCLK and PE0 is CSI_PCLK so we have PE0 and PE1 removed.

i'm not sure what you mean, PCLK is still in that patch.

PE0 -> CSI_PCLK
PE1 -> CSI_MCLK

So, removing CSI MCLK in "Changes from v3" means, removing PE1 right? but csi_pins removed PE0 which is CSI_PCLK, we need to remove PE1 from csi_pins and keep PE0. isn't it?

#4 lore raw

PATCH v3 1/1 ARM: dts: sun8i: Add the H3/H5 CSI controller

Quoted 23 lines · Jagan Teki
Quoted 22 lines · Maxime Ripard
Quoted 19 lines · Jagan Teki
Quoted 8 lines · Maxime Ripard

From: Myl?ne Josserand <[email protected]>

The H3 and H5 features the same CSI controller that was initially found on the A31.

Add a DT node for it.

Quoted 7 lines

---

Changes from v3:
- Removed the CSI MCLK pin from the default pin group

If I'm not wrong, PE1 is CSI_MCLK and PE0 is CSI_PCLK so we have PE0 and PE1 removed.

Quoted 8 lines
Quoted 1 line

i'm not sure what you mean, PCLK is still in that patch.

PE0 -> CSI_PCLK
PE1 -> CSI_MCLK

So, removing CSI MCLK in "Changes from v3" means, removing PE1 right? but csi_pins removed PE0 which is CSI_PCLK, we need to remove PE1 from csi_pins and keep PE0. isn't it?

Ah, right. I've fixed it up while applying.

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181127/bb525883/attachment.sig>