Skip to contentSkip to conversation

dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5

PATCH In review Sibi Sankar 4 participants 5 messages Nov 20, 2018 – Dec 13, 2018

Subsystems (3)
Device tree bindings Arm Qualcomm mailing list Remote processor (remoteproc)
lore
Share & tools
lore

Sibi Sankar

author
#0 lore raw

PATCH 1/1 dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5

Add power-domain bindings for Q6V5 MSS on SDM845 SoCs.

Signed-off-by Sibi Sankar <[email protected]>

---

Add dt-binding corresponding to https://patchwork.kernel.org/patch/10586893/
(remoteproc: q6v5: Add support to vote for rpmh power domains)

 .../devicetree/bindings/remoteproc/qcom,q6v5.txt      | 11 +++++++++++
 1 file changed, 11 insertions(+)
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt +11 -0
index 14947562bc67..bd9f4882fcf0 100644
@@ -75,6 +75,17 @@ on the Qualcomm Hexagon core.
 	Definition: reference to the regulators to be held on behalf of the
 		    booting of the Hexagon core
 
+- power-domains:
+	Usage: required
+	Value type: <phandle>
+	Definition: reference to the cx, mx and mss power-domains to be held on
+		    behalf of the booting the Hexagon core
+
+- power-domain-names:
+	Usage: required
+	Value type: <stringlist>
+	Definition: must be "cx", "mx", "mss"
+
 - qcom,smem-states:
 	Usage: required
 	Value type: <phandle>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#2 lore raw
In reply to Sibi Sankar
Quoted 2 lines · Sibi Sankar

Add power-domain bindings for Q6V5 MSS on SDM845 SoCs.

Thanks Sibi,

Quoted 14 lines
Signed-off-by Sibi Sankar <[email protected]>

---

Add dt-binding corresponding to https://patchwork.kernel.org/patch/10586893/
(remoteproc: q6v5: Add support to vote for rpmh power domains)

 .../devicetree/bindings/remoteproc/qcom,q6v5.txt      | 11 +++++++++++
 1 file changed, 11 insertions(+)
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt +0 -0
index 14947562bc67..bd9f4882fcf0 100644

Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt on the Qualcomm Hexagon core. · line 82

Quoted 8 lines
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt +5 -0
@@ -75,6 +75,17 @@ on the Qualcomm Hexagon core.
 	Definition: reference to the regulators to be held on behalf of the
 		    booting of the Hexagon core
 
+- power-domains:
+	Usage: required
+	Value type: <phandle>
+	Definition: reference to the cx, mx and mss power-domains to be held on
+		    behalf of the booting the Hexagon core

This should mention that these are the domains for SDM845, as the list seems to differ somewhat between platforms. Please also define the requirements for MSM8996 (cx & mx) here, while you're at it.

Let's also make sure it includes the "load_state", for SDM845.

Regards,
Bjorn

Quoted 13 lines
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt +6 -0
+
+- power-domain-names:
+	Usage: required
+	Value type: <stringlist>
+	Definition: must be "cx", "mx", "mss"
+
 - qcom,smem-states:
 	Usage: required
 	Value type: <phandle>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#3 lore raw

Hi Bjorn,
Thanks for the review!

Quoted 36 lines · Bjorn Andersson
Quoted 2 lines · Sibi Sankar

Add power-domain bindings for Q6V5 MSS on SDM845 SoCs.

Thanks Sibi,

Quoted 23 lines
Signed-off-by Sibi Sankar <[email protected]>

---

Add dt-binding corresponding to https://patchwork.kernel.org/patch/10586893/
(remoteproc: q6v5: Add support to vote for rpmh power domains)

 .../devicetree/bindings/remoteproc/qcom,q6v5.txt      | 11 
+++++++++++
 1 file changed, 11 insertions(+)
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt +4 -0
index 14947562bc67..bd9f4882fcf0 100644
@@ -75,6 +75,17 @@ on the Qualcomm Hexagon core.
 	Definition: reference to the regulators to be held on behalf of the
 		    booting of the Hexagon core
 
+- power-domains:
+	Usage: required
+	Value type: <phandle>
+	Definition: reference to the cx, mx and mss power-domains to be held

on

Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt on the Qualcomm Hexagon core. · line 82

Quoted 1 line
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt +1 -0
+		    behalf of the booting the Hexagon core

This should mention that these are the domains for SDM845, as the list seems to differ somewhat between platforms. Please also define the requirements for MSM8996 (cx & mx) here, while you're at it.

Quoted 2 lines

Let's also make sure it includes the "load_state", for SDM845.

I'll list the power domains per SoC in the next respin

Quoted 16 lines

Regards,
Bjorn

Quoted 13 lines
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt +6 -1
+
+- power-domain-names:
+	Usage: required
+	Value type: <stringlist>
+	Definition: must be "cx", "mx", "mss"
+
 - qcom,smem-states:
 	Usage: required
 	Value type: <phandle>
--

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

Signature · 3 lines
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
#4 lore raw
In reply to Sibi Sankar

Hi,

Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt on the Qualcomm Hexagon core. · line 79

Quoted 10 lines · Sibi Sankar
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt +2 -0
index 14947562bc67..bd9f4882fcf0 100644
@@ -75,6 +75,17 @@ on the Qualcomm Hexagon core.
        Definition: reference to the regulators to be held on behalf of the
                    booting of the Hexagon core
 
+- power-domains:
+       Usage: required

Assuming I understand correctly, presumably you want to say that it's required to list _either_ power-domains or supplies. Right now you have the bindings saying that you need both regulators and power-domains on all boards.

Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt on the Qualcomm Hexagon core. · line 87

Quoted 8 lines
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt +8 -0
+       Value type: <phandle>
+       Definition: reference to the cx, mx and mss power-domains to be held on
+                   behalf of the booting the Hexagon core
+
+- power-domain-names:
+       Usage: required
+       Value type: <stringlist>
+       Definition: must be "cx", "mx", "mss"

Comparing to the patch you posted at
<https://lkml.kernel.org/r/[email protected]>,
it seems like maybe you also need "aop" listed here?

-Doug