Skip to contentSkip to conversation

Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus

PATCH In review Lyude Paul 3 participants 3 messages Nov 21, 2018 – Nov 29, 2018

Subsystems (2)
lore
Share & tools
lore

Lyude Paul

author
#0 lore raw

PATCH 1/1 Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus

Noticed the other day the trackpoint felt different on my P50, then realized it was because rmi4 wasn't loading for this machine automatically. Suspend/resume, hibernate, and everything else seem to work perfectly fine on here.

---
 drivers/input/mouse/synaptics.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/mouse/synaptics.c +1 -0
index 5e85f3cca867..c42813d50591 100644
@@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN0048", /* X1 Carbon 3 */
 	"LEN0046", /* X250 */
 	"LEN004a", /* W541 */
+	"LEN005b", /* P50 */
 	"LEN0071", /* T480 */
 	"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
 	"LEN0073", /* X1 Carbon G5 (Elantech) */
Signature · 1 line
2.19.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Lyude Paul

Noticed the other day the trackpoint felt different on my P50, then realized it was because rmi4 wasn't loading for this machine automatically. Suspend/resume, hibernate, and everything else seem to work perfectly fine on here.

Cheers,
Peter

Quoted 19 lines
---
 drivers/input/mouse/synaptics.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/mouse/synaptics.c +1 -0
index 5e85f3cca867..c42813d50591 100644
@@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN0048", /* X1 Carbon 3 */
 	"LEN0046", /* X250 */
 	"LEN004a", /* W541 */
+	"LEN005b", /* P50 */
 	"LEN0071", /* T480 */
 	"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
 	"LEN0073", /* X1 Carbon G5 (Elantech) */
Signature · 1 line
2.19.1
#2 lore raw
Quoted 10 lines · Peter Hutterer
Quoted 6 lines · Lyude Paul

Noticed the other day the trackpoint felt different on my P50, then realized it was because rmi4 wasn't loading for this machine automatically. Suspend/resume, hibernate, and everything else seem to work perfectly fine on here.

Cheers,
Benjamin

Quoted 23 lines

Cheers,
Peter

Quoted 19 lines
---
 drivers/input/mouse/synaptics.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/mouse/synaptics.c +1 -1
index 5e85f3cca867..c42813d50591 100644
@@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = {
      "LEN0048", /* X1 Carbon 3 */
      "LEN0046", /* X250 */
      "LEN004a", /* W541 */
+     "LEN005b", /* P50 */
      "LEN0071", /* T480 */
      "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
      "LEN0073", /* X1 Carbon G5 (Elantech) */
--

2.19.1