Skip to contentSkip to conversation

ipc/shm.c: removed 'int err' from shm_get_policy()

PATCH In review [email protected] 2 participants 2 messages Nov 18, 2018 – Nov 22, 2018

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 ipc/shm.c: removed 'int err' from shm_get_policy()

From: Daniel Robson <[email protected]>

removed unneeded variable in shm_get_policy()

Signed-off-by Daniel Robson <[email protected]>
---
 ipc/shm.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
ipc/shm.c +2 -3
index 0842411cb0e9..2cb493214108 100644
@@ -461,11 +461,10 @@ static int shm_set_policy(struct vm_area_struct *vma, struct mempolicy *new)
 {
 	struct file *file = vma->vm_file;
 	struct shm_file_data *sfd = shm_file_data(file);
-	int err = 0;
 
 	if (sfd->vm_ops->set_policy)
-		err = sfd->vm_ops->set_policy(vma, new);
-	return err;
+		return sfd->vm_ops->set_policy(vma, new);
+	return 0;
 }
 
 static struct mempolicy *shm_get_policy(struct vm_area_struct *vma,
Signature · 1 line
2.18.0
#1 lore raw
Quoted 8 lines · On Sun, 18 Nov 2018 23:49:11 +0000 [email protected] wrote:

removed unneeded variable in shm_get_policy()

...

ipc/shm.c +0 -0
@@ -461,11 +461,10 @@ static int shm_set_policy(struct vm_area_struct *vma, struct mempolicy *new)
 {

ipc/shm.c static int shm_set_policy(struct vm_area_struct *vma, struct mempolicy *new) · line 468

Quoted 10 lines
ipc/shm.c +2 -3
 	struct file *file = vma->vm_file;
 	struct shm_file_data *sfd = shm_file_data(file);
-	int err = 0;
 
 	if (sfd->vm_ops->set_policy)
-		err = sfd->vm_ops->set_policy(vma, new);
-	return err;
+		return sfd->vm_ops->set_policy(vma, new);
+	return 0;
 }

Sorry, I don't think this is enough of an improvement to justify adding the patch.