Skip to contentSkip to conversation

infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent

PATCH Applied Sabyasachi Gupta 4 participants 4 messages Nov 9, 2018 – Nov 21, 2018 InfiniBand

lore
Share & tools
lore

Sabyasachi Gupta

author
#0 lore raw

PATCH 1/1 infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent

Replaced dma_alloc_coherent + memset with dma_zalloc_coherent

Signed-off-by Sabyasachi Gupta <[email protected]>
---
 drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/infiniband/hw/cxgb3/cxio_hal.c +1 -2
index dcb4bba..df4f7a3 100644
@@ -291,13 +291,12 @@ int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain,
 	if (!wq->sq)
 		goto err3;
 
-	wq->queue = dma_alloc_coherent(&(rdev_p->rnic_info.pdev->dev),
+	wq->queue = dma_zalloc_coherent(&(rdev_p->rnic_info.pdev->dev),
 					     depth * sizeof(union t3_wr),
 					     &(wq->dma_addr), GFP_KERNEL);
 	if (!wq->queue)
 		goto err4;
 
-	memset(wq->queue, 0, depth * sizeof(union t3_wr));
 	dma_unmap_addr_set(wq, mapping, wq->dma_addr);
 	wq->doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;
 	if (!kernel_domain)
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Sabyasachi Gupta

Replaced dma_alloc_coherent + memset with dma_zalloc_coherent

Signed-off-by Sabyasachi Gupta <[email protected]>
---
 drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/infiniband/hw/cxgb3/cxio_hal.c +0 -1
index dcb4bba..df4f7a3 100644
@@ -291,13 +291,12 @@ int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain,
 	if (!wq->sq)
 		goto err3;
 
-	wq->queue = dma_alloc_coherent(&(rdev_p->rnic_info.pdev->dev),

drivers/infiniband/hw/cxgb3/cxio_hal.c int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain, · line 302

Quoted 10 lines
drivers/infiniband/hw/cxgb3/cxio_hal.c +1 -1
+	wq->queue = dma_zalloc_coherent(&(rdev_p->rnic_info.pdev->dev),
 					     depth * sizeof(union t3_wr),
 					     &(wq->dma_addr), GFP_KERNEL);
 	if (!wq->queue)
 		goto err4;
 
-	memset(wq->queue, 0, depth * sizeof(union t3_wr));
 	dma_unmap_addr_set(wq, mapping, wq->dma_addr);
 	wq->doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;
 	if (!kernel_domain)
Acked-by Steve Wise <[email protected]>
Acked-by on v1 1/1
#2 lore raw
In reply to Sabyasachi Gupta
Quoted 17 lines · Sabyasachi Gupta

Replaced dma_alloc_coherent + memset with dma_zalloc_coherent

Signed-off-by Sabyasachi Gupta <[email protected]>
---
 drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/infiniband/hw/cxgb3/cxio_hal.c +0 -1
index dcb4bba..df4f7a3 100644
@@ -291,13 +291,12 @@ int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain,
 	if (!wq->sq)
 		goto err3;
 
-	wq->queue = dma_alloc_coherent(&(rdev_p->rnic_info.pdev->dev),

drivers/infiniband/hw/cxgb3/cxio_hal.c int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain, · line 302

Quoted 10 lines
drivers/infiniband/hw/cxgb3/cxio_hal.c +1 -1
+	wq->queue = dma_zalloc_coherent(&(rdev_p->rnic_info.pdev->dev),
 					     depth * sizeof(union t3_wr),
 					     &(wq->dma_addr), GFP_KERNEL);
 	if (!wq->queue)
 		goto err4;
 
-	memset(wq->queue, 0, depth * sizeof(union t3_wr));
 	dma_unmap_addr_set(wq, mapping, wq->dma_addr);
 	wq->doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;
 	if (!kernel_domain)
Acked-by Steve Wise <[email protected]>