Skip to contentSkip to conversation

ata: pata_macio: add of_node_put()

PATCH New Yangtao Li 1 participant 1 message Nov 22, 2018 libata

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH v2 1/1 ata: pata_macio: add of_node_put()

of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place doesn't do that, so fix it.

---
Changes in v2:
-update changelog

---
 drivers/ata/pata_macio.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/ata/pata_macio.c +2 -0
index 9588e685d994..8cc9c429ad95 100644
@@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap)
 		struct device_node *root = of_find_node_by_path("/");
 		const char *model = of_get_property(root, "model", NULL);
 
+		of_node_put(root);
+
 		if (cable && !strncmp(cable, "80-", 3)) {
 			/* Some drives fail to detect 80c cable in PowerBook
 			 * These machine use proprietary short IDE cable
Signature · 1 line
2.17.0