Skip to contentSkip to conversation

Bluetooth: hci_serdev: Remove setting of HCI_QUIRK_RESET_ON_CLOSE.

PATCH In review Balakrishna Godavarthi 2 participants 2 messages Nov 22, 2018 – Dec 18, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: hci_serdev: Remove setting of HCI_QUIRK_RESET_ON_CLOSE.

HCI_QUIRK_RESET_ON_CLOSE quirk is required for BT v1.0 based devices, to send a reset command to the chip during hci device close. Serdev architecture is used for the latest BT chips, which doesn't require to send the reset command during close. If still chips required reset command during close, it would be better enabling it in the vendor probes or in proto setup.

---
 drivers/bluetooth/hci_serdev.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/bluetooth/hci_serdev.c +0 -3
index c445aa9ac511..490abba94363 100644
@@ -333,9 +333,6 @@ int hci_uart_register_device(struct hci_uart *hu,
 	if (test_bit(HCI_UART_EXT_CONFIG, &hu->hdev_flags))
 		set_bit(HCI_QUIRK_EXTERNAL_CONFIG, &hdev->quirks);
 
-	if (!test_bit(HCI_UART_RESET_ON_INIT, &hu->hdev_flags))
-		set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks);
-
 	if (test_bit(HCI_UART_CREATE_AMP, &hu->hdev_flags))
 		hdev->dev_type = HCI_AMP;
 	else
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer
#1 lore raw

Hi Balakrishna,

Quoted 11 lines

HCI_QUIRK_RESET_ON_CLOSE quirk is required for BT v1.0 based devices, to send a reset command to the chip during hci device close. Serdev architecture is used for the latest BT chips, which doesn't require to send the reset command during close. If still chips required reset command during close, it would be better enabling it in the vendor probes or in proto setup.

---
drivers/bluetooth/hci_serdev.c | 3 ---

1 file changed, 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel