Skip to contentSkip to conversation

power: supply: axp288_fuel_gauge: Change to use DEFINE_SHOW_ATTRIBUTE macro

PATCH In review Yangtao Li 2 participants 3 messages Nov 22, 2018 – Jan 20, 2019

Subsystems (3)
Power supply X-powers multifunction PMIC device drivers X-powers AXP288 PMIC drivers
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 power: supply: axp288_fuel_gauge: Change to use DEFINE_SHOW_ATTRIBUTE macro

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>
---
 drivers/power/supply/axp288_fuel_gauge.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)
drivers/power/supply/axp288_fuel_gauge.c +2 -12
index 084c8ba9749d..9ff2461820d8 100644
@@ -307,22 +307,12 @@ static int fuel_gauge_debug_show(struct seq_file *s, void *data)
 	return 0;
 }
 
-static int debug_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, fuel_gauge_debug_show, inode->i_private);
-}
-
-static const struct file_operations fg_debug_fops = {
-	.open       = debug_open,
-	.read       = seq_read,
-	.llseek     = seq_lseek,
-	.release    = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(fuel_gauge_debug);
 
 static void fuel_gauge_create_debugfs(struct axp288_fg_info *info)
 {
 	info->debug_file = debugfs_create_file("fuelgauge", 0666, NULL,
-		info, &fg_debug_fops);
+		info, &fuel_gauge_debug_fops);
 }
 
 static void fuel_gauge_remove_debugfs(struct axp288_fg_info *info)
Signature · 1 line
2.17.0
maintainer
#2 lore raw
In reply to Yangtao Li

Hi,

Quoted 4 lines · Yangtao Li

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>

---

Thanks, queued to power-supply-next. Sorry for the delay, I missed this when I collected patches for the 5.0 kernel.

-- Sebastian

Quoted 35 lines
 drivers/power/supply/axp288_fuel_gauge.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)
drivers/power/supply/axp288_fuel_gauge.c +2 -12
index 084c8ba9749d..9ff2461820d8 100644
@@ -307,22 +307,12 @@ static int fuel_gauge_debug_show(struct seq_file *s, void *data)
 	return 0;
 }
 
-static int debug_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, fuel_gauge_debug_show, inode->i_private);
-}
-
-static const struct file_operations fg_debug_fops = {
-	.open       = debug_open,
-	.read       = seq_read,
-	.llseek     = seq_lseek,
-	.release    = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(fuel_gauge_debug);
 
 static void fuel_gauge_create_debugfs(struct axp288_fg_info *info)
 {
 	info->debug_file = debugfs_create_file("fuelgauge", 0666, NULL,
-		info, &fg_debug_fops);
+		info, &fuel_gauge_debug_fops);
 }
 
 static void fuel_gauge_remove_debugfs(struct axp288_fg_info *info)
Signature · 1 line
2.17.0