Makefile: Add a warning for boards that don't use CONFIG_BLK
PATCH 1/3 Makefile: Add a warning for boards that don't use CONFIG_BLK
The deadline for this has passed and we are starting to remove boards that do not use driver model for block devices.
Add a noisy Makefile warning.
---
Makefile | 7 +++++++ 1 file changed, 7 insertions(+)
Makefile +7 -0
@@ -917,6 +917,13 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "(possibly in a subsequent patch in your series)" @echo "before sending patches to the mailing list." @echo "====================================================" +endif +ifneq ($(CONFIG_BLK),y) + @echo "===================== WARNING ======================" + @echo "This board does not use CONFIG_BLK. Please update" + @echo "the board to use CONFIG_BLK before the end of 2018." + @echo "See doc/driver-model/MIGRATION.txt for more info." + @echo "====================================================" endif @# Check that this build does not use CONFIG options that we do not @# know about unless they are in Kconfig. All the existing CONFIG
Signature · 1 line
2.19.1.1215.g8438c0b245-goog
PATCH 1/3 Makefile: Add a warning for boards that don't use CONFIG_BLK
Quoted 16 lines · Simon Glass
The deadline for this has passed and we are starting to remove boards that do not use driver model for block devices.
Add a noisy
Makefilewarning.Signed-off-by Simon Glass <[email protected]>---
Makefile | 7 +++++++ 1 file changed, 7 insertions(+)Makefile +0
-0
Makefile ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) · line 924
Quoted 8 lines
Makefile +5
-0@@ -917,6 +917,13 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "(possibly in a subsequent patch in your series)" @echo "before sending patches to the mailing list." @echo "====================================================" +endif +ifneq ($(CONFIG_BLK),y) + @echo "===================== WARNING ======================" + @echo "This board does not use CONFIG_BLK. Please update" + @echo "the board to use CONFIG_BLK before the end of 2018."
End of 2018 ? Not happening :-)
Quoted 6 lines
Makefile +2
-0+ @echo "See doc/driver-model/MIGRATION.txt for more info." + @echo "====================================================" endif @# Check that this build does not use CONFIG options that we do not @# know about unless they are in Kconfig. All the existing CONFIG
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/3 Makefile: Add a warning for boards that don't use CONFIG_BLK
In reply to Simon GlassQuoted 17 lines · Simon Glass
The deadline for this has passed and we are starting to remove boards that do not use driver model for block devices.
Add a noisy
Makefilewarning.Signed-off-by Simon Glass <[email protected]>---
Makefile | 7 +++++++ 1 file changed, 7 insertions(+)Makefile +0
-0@@ -917,6 +917,13 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "(possibly in a subsequent patch in your series)"
Makefile ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) · line 927
Quoted 10 lines
Makefile +7
-0@echo "before sending patches to the mailing list." @echo "====================================================" +endif +ifneq ($(CONFIG_BLK),y) + @echo "===================== WARNING ======================" + @echo "This board does not use CONFIG_BLK. Please update" + @echo "the board to use CONFIG_BLK before the end of 2018." + @echo "See doc/driver-model/MIGRATION.txt for more info." + @echo "====================================================" endif
The problem with this is that it doesn't catch most of the problem combinations. I'm still working on a series that highlights what the problem cases we have left are. But it's also not, in a lot of cases, a board problem, but a lack of driver being updated problem so I suspect we'll really be marking a bunch of stuff as depends on BROKEN.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181122/61dea168/attachment.sig>
PATCH 1/3 Makefile: Add a warning for boards that don't use CONFIG_BLK
Hi Tom,
Quoted 28 lines · Tom Rini
Quoted 25 lines · Simon Glass
The deadline for this has passed and we are starting to remove boards that do not use driver model for block devices.
Add a noisy
Makefilewarning.Signed-off-by Simon Glass <[email protected]>---
Makefile | 7 +++++++ 1 file changed, 7 insertions(+)Makefile +6
-0@@ -917,6 +917,13 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "(possibly in a subsequent patch in your series)" @echo "before sending patches to the mailing list." @echo "====================================================" +endif +ifneq ($(CONFIG_BLK),y) + @echo "===================== WARNING ======================" + @echo "This board does not use CONFIG_BLK. Please update" + @echo "the board to use CONFIG_BLK before the end of 2018." + @echo "See doc/driver-model/MIGRATION.txt for more info."
Quoted 8 lines
Makefile ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) · line 927
Quoted 2 lines
Makefile +1
-0+ @echo "====================================================" endifThe problem with this is that it doesn't catch most of the problem combinations. I'm still working on a series that highlights what the problem cases we have left are. But it's also not, in a lot of cases, a board problem, but a lack of driver being updated problem so I suspect we'll really be marking a bunch of stuff as depends on BROKEN.
Are you saying that CONFIG_BLK is set to y but the board is still not converted? I'm not sure I understand the issue here.
Of course, one problem here is that CONFIG_BLK might not be needed if the board doesn't use block devices.
Regards,
Simon
PATCH 1/3 Makefile: Add a warning for boards that don't use CONFIG_BLK
Quoted 40 lines · Simon Glass
Hi Tom,
Quoted 28 lines · Tom Rini
Quoted 25 lines · Simon Glass
The deadline for this has passed and we are starting to remove boards that do not use driver model for block devices.
Add a noisy
Makefilewarning.Signed-off-by Simon Glass <[email protected]>---
Makefile | 7 +++++++ 1 file changed, 7 insertions(+)Makefile +6
-0@@ -917,6 +917,13 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "(possibly in a subsequent patch in your series)" @echo "before sending patches to the mailing list." @echo "====================================================" +endif +ifneq ($(CONFIG_BLK),y) + @echo "===================== WARNING ======================" + @echo "This board does not use CONFIG_BLK. Please update" + @echo "the board to use CONFIG_BLK before the end of 2018." + @echo "See doc/driver-model/MIGRATION.txt for more info."Quoted 8 lines
Makefile ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) · line 927
Quoted 2 lines
Makefile +1
-0+ @echo "====================================================" endifThe problem with this is that it doesn't catch most of the problem combinations. I'm still working on a series that highlights what the problem cases we have left are. But it's also not, in a lot of cases, a board problem, but a lack of driver being updated problem so I suspect we'll really be marking a bunch of stuff as depends on BROKEN.
Quoted 5 lines
Are you saying that
CONFIG_BLKis set to y but the board is still not converted? I'm not sure I understand the issue here.Of course, one problem here is that
CONFIG_BLKmight not be needed if the board doesn't use block devices.
Right, I'm saying that yes, we do have a good chunk of boards that aren't using a subsystem that uses BLK.
But yes, we also have a chunk, and this easily fixed, of boards that could but don't set BLK. I'll take a swing at taking care of those at least.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181124/c0f3f496/attachment.sig>