Skip to contentSkip to conversation

alsa-utils: add optional systemd dependency

PATCH New Peter Seiderer 3 participants 3 messages Nov 21, 2018 – Nov 23, 2018

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH 1/1 alsa-utils: add optional systemd dependency

Fixes (reported by Yann E. MORIN, [1]):

/usr/bin/install -D -m 0644 .../build/alsa-utils-1.1.6/alsactl/alsa-restore.service .../target/usr/lib/systemd/system/alsa-restore.service /usr/bin/install: cannot stat '.../build/alsa-utils-1.1.6/alsactl/alsa-restore.service': No such file or directory

[1] http://lists.busybox.net/pipermail/buildroot/2018-November/236355.html

Signed-off-by Peter Seiderer <[email protected]>
---
 package/alsa-utils/alsa-utils.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/alsa-utils/alsa-utils.mk +2 -1
index 0c65082a14..986a745399 100644
@@ -82,7 +82,8 @@ define ALSA_UTILS_INSTALL_TARGET_CMDS
 	fi
 endef
 
-ifeq ($(BR2_PACKAGE_ALSA_UTILS_ALSACTL),y)
+ifeq ($(BR2_PACKAGE_ALSA_UTILS_ALSACTL)$(BR2_INIT_SYSTEMD),yy)
+ALSA_UTILS_DEPENDENCIES += systemd
 define ALSA_UTILS_INSTALL_INIT_SYSTEMD
 	$(INSTALL) -D -m 0644 $(@D)/alsactl/alsa-restore.service \
 		$(TARGET_DIR)/usr/lib/systemd/system/alsa-restore.service
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 alsa-utils: add optional systemd dependency

Peter, All,

On 2018-11-21 23:01 +0100, Peter Seiderer spake thusly:

Quoted 8 lines

Fixes (reported by Yann E. MORIN, [1]):

/usr/bin/install -D -m 0644 .../build/alsa-utils-1.1.6/alsactl/alsa-restore.service .../target/usr/lib/systemd/system/alsa-restore.service /usr/bin/install: cannot stat '.../build/alsa-utils-1.1.6/alsactl/alsa-restore.service': No such file or directory

[1] http://lists.busybox.net/pipermail/buildroot/2018-November/236355.html

Signed-off-by Peter Seiderer <[email protected]>

Thanks for the quick fix! :-)

Tested-by "Yann E. MORIN" <[email protected]>

Still one comment, see below...

Quoted 9 lines
---
 package/alsa-utils/alsa-utils.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/alsa-utils/alsa-utils.mk +0 -0
index 0c65082a14..986a745399 100644

package/alsa-utils/alsa-utils.mk define ALSA_UTILS_INSTALL_TARGET_CMDS · line 85

Quoted 5 lines
package/alsa-utils/alsa-utils.mk +1 -1
@@ -82,7 +82,8 @@ define ALSA_UTILS_INSTALL_TARGET_CMDS
 	fi
 endef
 
-ifeq ($(BR2_PACKAGE_ALSA_UTILS_ALSACTL),y)
+ifeq ($(BR2_PACKAGE_ALSA_UTILS_ALSACTL)$(BR2_INIT_SYSTEMD),yy)

I was going to argue that I'd prefer the dependency to be on BR2_PACKAGE_SYSTEMD instead, as I seemed to recall that's what we do elsewhere.

So I grepped the code, and we have 22 instances where the dependencies is on the package, and 20 where it is on the init system.

And in the end, it does make sense that this is done on the init sytem, not the package, so I'm OK with the patch as is, and I would even argue that the others should be changed (when they install unit files).

So:

Acked-by "Yann E. MORIN" <[email protected]>

(Yeah, I'm putting two tags at different places in the reply, just to see how patchwork handles that. Niark! ;-) )

Regards,
Yann E. MORIN.

Quoted 7 lines
package/alsa-utils/alsa-utils.mk +1 -0
+ALSA_UTILS_DEPENDENCIES += systemd
 define ALSA_UTILS_INSTALL_INIT_SYSTEMD
 	$(INSTALL) -D -m 0644 $(@D)/alsactl/alsa-restore.service \
 		$(TARGET_DIR)/usr/lib/systemd/system/alsa-restore.service
Signature · 1 line
2.19.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH 1/1 alsa-utils: add optional systemd dependency

In reply to Peter Seiderer

Hello,

Quoted 11 lines · Peter Seiderer

Fixes (reported by Yann E. MORIN, [1]):

/usr/bin/install -D -m 0644 .../build/alsa-utils-1.1.6/alsactl/alsa-restore.service .../target/usr/lib/systemd/system/alsa-restore.service /usr/bin/install: cannot stat '.../build/alsa-utils-1.1.6/alsactl/alsa-restore.service': No such file or directory

[1] http://lists.busybox.net/pipermail/buildroot/2018-November/236355.html

Signed-off-by Peter Seiderer <[email protected]>
---
 package/alsa-utils/alsa-utils.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com