Skip to contentSkip to conversation

usb_modeswitch: disable parallel build

PATCH New Fabrice Fontaine 3 participants 3 messages Nov 22, 2018 – Nov 26, 2018

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/1 usb_modeswitch: disable parallel build

Build of package will sometime fails because of the following issue:
install-static target has two dependencies: dispatcher-static and install-common

Because dispatcher-static is not a file but only a target, it will always be called to build usb_modeswitch_dispatcher.
So, even if install-common depends on usb_modeswitch_dispatcher, in some rare cases, install-static won't be able to install usb_modeswitch_dispatcher because it is being rebuild by dispatcher-static

To fix this issue, disable parallel build

Fixes:
- http://autobuild.buildroot.org/results/8297be35725b816ff5afaf909605ceb41223efb6

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/usb_modeswitch/usb_modeswitch.mk | 2 ++
 1 file changed, 2 insertions(+)
package/usb_modeswitch/usb_modeswitch.mk +2 -0
index d0c33cc187..bb0d6ab1bf 100644
@@ -10,6 +10,8 @@ USB_MODESWITCH_SITE = http://www.draisberghof.de/usb_modeswitch
 USB_MODESWITCH_DEPENDENCIES = libusb
 USB_MODESWITCH_LICENSE = GPL-2.0+
 USB_MODESWITCH_LICENSE_FILES = COPYING
+#?Package does not build in parallel due to improper make rules
+USB_MODESWITCH_MAKE = $(MAKE1)
 
 USB_MODESWITCH_BUILD_TARGETS = static
 USB_MODESWITCH_INSTALL_TARGETS = install-static
Signature · 1 line
2.14.1
Applied
#1 lore raw

PATCH 1/1 usb_modeswitch: disable parallel build

Hello,

Quoted 13 lines · Fabrice Fontaine

Build of package will sometime fails because of the following issue:
install-static target has two dependencies: dispatcher-static and install-common

Because dispatcher-static is not a file but only a target, it will always be called to build usb_modeswitch_dispatcher.
So, even if install-common depends on usb_modeswitch_dispatcher, in some rare cases, install-static won't be able to install usb_modeswitch_dispatcher because it is being rebuild by dispatcher-static

To fix this issue, disable parallel build

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/8297be35725b816ff5afaf909605ceb41223efb6

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/usb_modeswitch/usb_modeswitch.mk | 2 ++
 1 file changed, 2 insertions(+)

Applied to master, thanks. It would be nice to report the issue upstream. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 usb_modeswitch: disable parallel build

In reply to Fabrice Fontaine
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Build of package will sometime fails because of the following issue:
install-static target has two dependencies: dispatcher-static and install-common

Because dispatcher-static is not a file but only a target, it will always be called to build usb_modeswitch_dispatcher.
So, even if install-common depends on usb_modeswitch_dispatcher, in some rare cases, install-static won't be able to install usb_modeswitch_dispatcher because it is being rebuild by dispatcher-static

Quoted 6 lines

To fix this issue, disable parallel build

Fixes:
- http://autobuild.buildroot.org/results/8297be35725b816ff5afaf909605ceb41223efb6

Signed-off-by Fabrice Fontaine <[email protected]>

Committed to 2018.02.x and 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard