Skip to contentSkip to conversation

devres: no print device_node.name in devres_log()

PATCH In review Yangtao Li 1 participant 2 messages Nov 24, 2018 Driver core

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 devres: no print device_node.name in devres_log()

In preparation to remove the node name pointer from struct device_node, avoid to printf node name.

---
 drivers/base/devres.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/base/devres.c +2 -2
index 4aaf00d2098b..34c07e9faaf9 100644
@@ -52,8 +52,8 @@ static void devres_log(struct device *dev, struct devres_node *node,
 		       const char *op)
 {
 	if (unlikely(log_devres))
-		dev_err(dev, "DEVRES %3s %p %s (%lu bytes)\n",
-			op, node, node->name, (unsigned long)node->size);
+		dev_err(dev, "DEVRES %3s %p (%lu bytes)\n",
+			op, node, (unsigned long)node->size);
 }
 #else /* CONFIG_DEBUG_DEVRES */
 #define set_node_dbginfo(node, n, s)	do {} while (0)
Signature · 1 line
2.17.0
author
#1 lore raw
Quoted 14 lines · Yangtao Li

In preparation to remove the node name pointer from struct device_node, avoid to printf node name.

---
 drivers/base/devres.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/base/devres.c +0 -0
index 4aaf00d2098b..34c07e9faaf9 100644

drivers/base/devres.c static void devres_log(struct device *dev, struct devres_node *node, · line 56

Quoted 5 lines
drivers/base/devres.c +0 -2
@@ -52,8 +52,8 @@ static void devres_log(struct device *dev, struct devres_node *node,
                       const char *op)
 {
        if (unlikely(log_devres))
-               dev_err(dev, "DEVRES %3s %p %s (%lu bytes)\n",
-                       op, node, node->name, (unsigned long)node->size);

The modification of this place is a bit problematic, ignoring this email.

Yours,
Yangtao

Quoted 8 lines
drivers/base/devres.c +2 -1
+               dev_err(dev, "DEVRES %3s %p (%lu bytes)\n",
+                       op, node, (unsigned long)node->size);
 }
 #else /* CONFIG_DEBUG_DEVRES */
 #define set_node_dbginfo(node, n, s)   do {} while (0)
--

2.17.0