Skip to contentSkip to conversation

package/qemu: allow enabling virtual filesystem

PATCH New Etienne Carriere 2 participants 3 messages Nov 22, 2018 – Nov 26, 2018

lore
Share & tools
lore

Etienne Carriere

author
#0 lore raw

PATCH 1/1 package/qemu: allow enabling virtual filesystem

Introduce builrdoot package configuration directive to enable Qemu host configuration directive

Signed-off-by Etienne Carriere <[email protected]>
---
 package/qemu/Config.in.host | 6 ++++++
 package/qemu/qemu.mk        | 4 ++++
 2 files changed, 10 insertions(+)
package/qemu/Config.in.host +6 -0
index 957c7d2..8840ff5 100644
@@ -67,4 +67,10 @@ config BR2_PACKAGE_HOST_QEMU_VDE2
 	  Ethernet and can be used to create virtual switches to
 	  "plug" both physical and virtual machines in them.
 
+config BR2_PACKAGE_HOST_QEMU_VIRTFS
+	bool "Enable virtual filesystem in Qemu emulator"
+	help
+	  Enables support for virtual filesystem in Qemu allowing
+	  shared filesystem between Qemu and its emulated target.
+
 endif
package/qemu/qemu.mk +4 -0
index 709535a..8153c06 100644
@@ -254,6 +254,10 @@ HOST_QEMU_OPTS += --enable-vde
 HOST_QEMU_DEPENDENCIES += host-vde2
 endif
 
+ifdef ($(BR2_PACKAGE_HOST_QEMU_VIRTFS),y)
+HOST_QEMU_OPTS += --enable-virtfs
+endif
+
 # Override CPP, as it expects to be able to call it like it'd
 # call the compiler.
 define HOST_QEMU_CONFIGURE_CMDS
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 package/qemu: allow enabling virtual filesystem

Hello,

package/qemu/Config.in.host config BR2_PACKAGE_HOST_QEMU_VDE2 · line 71

Quoted 2 lines · Etienne Carriere
package/qemu/Config.in.host +2 -0
+config BR2_PACKAGE_HOST_QEMU_VIRTFS
+	bool "Enable virtual filesystem in Qemu emulator"

I've reworded this to:

bool "Virtual filesystem support"

to be more consistent with the existing VDE2 option. Indeed, indicating "Enable" in an option is not very useful: it's pretty obvious than an option is here to "Enable" something. Also the "in Qemu emulator" is not very useful either, since the option being added is already a sub-option of the main host-qemu option.

I've applied to next after this minor change. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 package/qemu: allow enabling virtual filesystem

Quoted 12 lines · Thomas Petazzoni

Hello,

package/qemu/Config.in.host config BR2_PACKAGE_HOST_QEMU_VDE2 · line 71

Quoted 2 lines · Etienne Carriere
package/qemu/Config.in.host +2 -0
+config BR2_PACKAGE_HOST_QEMU_VIRTFS
+     bool "Enable virtual filesystem in Qemu emulator"

I've reworded this to:

bool "Virtual filesystem support"

Quoted 7 lines

to be more consistent with the existing VDE2 option. Indeed, indicating "Enable" in an option is not very useful: it's pretty obvious than an option is here to "Enable" something. Also the "in Qemu emulator" is not very useful either, since the option being added is already a sub-option of the main host-qemu option.

I've applied to next after this minor change. Thanks!

Hello Thomas,

Ok, thanks a lot.

etienne

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com