Skip to contentSkip to conversation

i3c: Rename dw-i3c-master.c into i3c-master-dw.c

PATCH In review Boris Brezillon 2 participants 4 messages Nov 26, 2018 – Dec 4, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i3c: Rename dw-i3c-master.c into i3c-master-dw.c

Follow the naming scheme introduced by the Cadence driver to keep things consistent.

---
 drivers/i3c/master/Makefile                             | 2 +-
 drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} (100%)
drivers/i3c/master/Makefile +1 -1
index fc53939a0bb1..c5f52733aa10 100644
@@ -1,2 +1,2 @@
 obj-$(CONFIG_CDNS_I3C_MASTER)		+= i3c-master-cdns.o
-obj-$(CONFIG_DW_I3C_MASTER)		+= dw-i3c-master.o
+obj-$(CONFIG_DW_I3C_MASTER)		+= i3c-master-dw.o
drivers/i3c/master/i3c-master-dw.c renamed from drivers/i3c/master/dw-i3c-master.c +0 -0
similarity index 100%
rename from drivers/i3c/master/dw-i3c-master.c
rename to drivers/i3c/master/i3c-master-dw.c
Signature · 1 line
2.17.1
#1 lore raw

Hi Vitor,

Quoted 9 lines · On Mon, 26 Nov 2018 09:45:14 +0100 Boris Brezillon…

Follow the naming scheme introduced by the Cadence driver to keep things consistent.

---
 drivers/i3c/master/Makefile                             | 2 +-
 drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} (100%)

Any opinion on this rename. If you disagree with this, then I'd like to know it.

Regards,

Boris

Quoted 13 lines
drivers/i3c/master/Makefile +1 -1
index fc53939a0bb1..c5f52733aa10 100644
@@ -1,2 +1,2 @@
 obj-$(CONFIG_CDNS_I3C_MASTER)		+= i3c-master-cdns.o
-obj-$(CONFIG_DW_I3C_MASTER)		+= dw-i3c-master.o
+obj-$(CONFIG_DW_I3C_MASTER)		+= i3c-master-dw.o
drivers/i3c/master/i3c-master-dw.c renamed from drivers/i3c/master/dw-i3c-master.c +0 -0
similarity index 100%
rename from drivers/i3c/master/dw-i3c-master.c
rename to drivers/i3c/master/i3c-master-dw.c
#2 lore raw

Hi Boris,

Quoted 21 lines · Boris Brezillon

Hi Vitor,

Quoted 9 lines · On Mon, 26 Nov 2018 09:45:14 +0100 Boris Brezillon…

Follow the naming scheme introduced by the Cadence driver to keep things consistent.

---
  drivers/i3c/master/Makefile                             | 2 +-
  drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} | 0
  2 files changed, 1 insertion(+), 1 deletion(-)

rename drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} (100%)

Any opinion on this rename. If you disagree with this, then I'd like to know it.

Regards,

Boris

Quoted 12 lines

drivers/i3c/master/i3c-master-dw.c

Quoted 12 lines
drivers/i3c/master/Makefile +1 -1
index fc53939a0bb1..c5f52733aa10 100644
@@ -1,2 +1,2 @@
  obj-$(CONFIG_CDNS_I3C_MASTER)		+= i3c-master-cdns.o
-obj-$(CONFIG_DW_I3C_MASTER)		+= dw-i3c-master.o
+obj-$(CONFIG_DW_I3C_MASTER)		+= i3c-master-dw.o
drivers/i3c/master/i3c-master-dw.c renamed from drivers/i3c/master/dw-i3c-master.c +0 -0
similarity index 100%
rename from drivers/i3c/master/dw-i3c-master.c
rename to drivers/i3c/master/i3c-master-dw.c

I already reply on initial thread. Please check my answers.

Best regards,

Vitor Soares

#3 lore raw

Hi Boris,

Quoted 24 lines · vitor

Hi Boris,

Quoted 20 lines · Boris Brezillon

Hi Vitor,

Quoted 9 lines · On Mon, 26 Nov 2018 09:45:14 +0100 Boris Brezillon…

Follow the naming scheme introduced by the Cadence driver to keep things consistent.

---
  drivers/i3c/master/Makefile                             | 2 +- drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} | 0

  2 files changed, 1 insertion(+), 1 deletion(-)

  rename drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} (100%)

Any opinion on this rename. If you disagree with this, then I'd like to know it.

Regards,

Boris

I don't agree with the master folder name. The name is redundant.

If you want to change my driver name I don't mind.

Quoted 18 lines
Quoted 13 lines

drivers/i3c/master/i3c-master-dw.c

Quoted 13 lines
drivers/i3c/master/Makefile +0 -0
index fc53939a0bb1..c5f52733aa10 100644
@@ -1,2 +1,2 @@

  obj-$(CONFIG_CDNS_I3C_MASTER)        += i3c-master-cdns.o

drivers/i3c/master/Makefile +1 -1
-obj-$(CONFIG_DW_I3C_MASTER)        += dw-i3c-master.o
+obj-$(CONFIG_DW_I3C_MASTER)        += i3c-master-dw.o
drivers/i3c/master/i3c-master-dw.c renamed from drivers/i3c/master/dw-i3c-master.c +0 -0
similarity index 100%
rename from drivers/i3c/master/dw-i3c-master.c
rename to drivers/i3c/master/i3c-master-dw.c

I already reply on initial thread. Please check my answers.

Quoted 3 lines

Best regards,

Vitor Soares

Best regards,

Vitor Soares