Skip to contentSkip to conversation

f2fs: read page index before freeing

PATCH In review Pan Bian 3 participants 9 messages Nov 22, 2018 – Nov 27, 2018 F2FS file system

lore
Share & tools
lore

Pan Bian

author
#0 lore raw

PATCH 1/1 f2fs: read page index before freeing

The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page.

---
 fs/f2fs/node.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/f2fs/node.c +3 -1
index d338740..88be946 100644
@@ -826,6 +826,7 @@ static int truncate_node(struct dnode_of_data *dn)
 	struct f2fs_sb_info *sbi = F2FS_I_SB(dn->inode);
 	struct node_info ni;
 	int err;
+	pgoff_t index;
 
 	err = f2fs_get_node_info(sbi, dn->nid, &ni);
 	if (err)
@@ -845,10 +846,11 @@ static int truncate_node(struct dnode_of_data *dn)
 	clear_node_page_dirty(dn->node_page);
 	set_sbi_flag(sbi, SBI_IS_DIRTY);
 
+	index = dn->node_page->index;
 	f2fs_put_page(dn->node_page, 1);
 
 	invalidate_mapping_pages(NODE_MAPPING(sbi),
-			dn->node_page->index, dn->node_page->index);
+			index, index);
 
 	dn->node_page = NULL;
 	trace_f2fs_truncate_node(dn->inode, dn->nid, ni.blk_addr);
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw

Hi Pan,

Quoted 3 lines · Pan Bian

The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page.

Good catch!

It will be better to add:

Fixes bf39c00a9a7f ("f2fs: drop obsolete node page when it is truncated")
Quoted 2 lines

Thanks,

maintainer
#2 lore raw
Quoted 8 lines · Chao Yu

Hi Pan,

Quoted 3 lines · Pan Bian

The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page.

Good catch!

+1

Quoted 10 lines

It will be better to add:

Fixes bf39c00a9a7f ("f2fs: drop obsolete node page when it is truncated")
Quoted 2 lines

Done.

Quoted 2 lines

Thanks,

#3 lore raw
In reply to Pan Bian

Hi Pan,

Quoted 3 lines · Pan Bian

The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page.

I notice that you found another use-after-free bug in ext4, out of curiosity, I'd like to ask how do you find those bugs? by tool or code review?

Thanks,

author
#4 lore raw
Quoted 9 lines · Chao Yu

Hi Pan,

Quoted 3 lines · Pan Bian

The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page.

I notice that you found another use-after-free bug in ext4, out of curiosity, I'd like to ask how do you find those bugs? by tool or code review?

I found such bugs by the aid of a tool I wrote recently. I designed a method to automatically find paired alloc/free functions. With such functions, I wrote two checkers, one to check mismatched alloc/free bugs, the other to check use-after-free and double-free bugs.

Best regards,
Pan Bian

#5 lore raw
Quoted 8 lines · PanBian
Quoted 7 lines · Chao Yu

Hi Pan,

Quoted 3 lines · Pan Bian

The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page.

Quoted 7 lines
Quoted 2 lines

I notice that you found another use-after-free bug in ext4, out of curiosity, I'd like to ask how do you find those bugs? by tool or code review?

I found such bugs by the aid of a tool I wrote recently. I designed a method to automatically find paired alloc/free functions. With such functions, I wrote two checkers, one to check mismatched alloc/free bugs, the other to check use-after-free and double-free bugs.

Excellent! Do you have any plan to open its source or announce it w/ binary to linux kernel developers, I think w/ it we can help to improve kernel's code quality efficiently.

Thanks,

Quoted 7 lines

Best regards,
Pan Bian

.

author
#6 lore raw
Quoted 12 lines · Chao Yu
Quoted 11 lines · PanBian
Quoted 9 lines · Chao Yu

Hi Pan,

Quoted 3 lines · Pan Bian

The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page.

I notice that you found another use-after-free bug in ext4, out of curiosity, I'd like to ask how do you find those bugs? by tool or code review?

Quoted 8 lines
Quoted 4 lines

I found such bugs by the aid of a tool I wrote recently. I designed a method to automatically find paired alloc/free functions. With such functions, I wrote two checkers, one to check mismatched alloc/free bugs, the other to check use-after-free and double-free bugs.

Excellent! Do you have any plan to open its source or announce it w/ binary to linux kernel developers, I think w/ it we can help to improve kernel's code quality efficiently.

Yes. I am now writing a paper about the method. I will open the source code as soon as I complete the paper and some optimizations.

Best,
Pan

#7 lore raw
Quoted 18 lines · PanBian
Quoted 17 lines · Chao Yu
Quoted 15 lines · PanBian
Quoted 9 lines · Chao Yu

Hi Pan,

Quoted 3 lines · Pan Bian

The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page.

I notice that you found another use-after-free bug in ext4, out of curiosity, I'd like to ask how do you find those bugs? by tool or code review?

I found such bugs by the aid of a tool I wrote recently. I designed a method to automatically find paired alloc/free functions. With such functions, I wrote two checkers, one to check mismatched alloc/free bugs, the other to check use-after-free and double-free bugs.

Quoted 6 lines
Quoted 3 lines

Excellent! Do you have any plan to open its source or announce it w/ binary to linux kernel developers, I think w/ it we can help to improve kernel's code quality efficiently.

Yes. I am now writing a paper about the method. I will open the source code as soon as I complete the paper and some optimizations.

Cool, if there is any progress, please let f2fs guys know, thank you in advance. :)

Thanks,

Quoted 7 lines

Best,
Pan

.

author
#8 lore raw
Quoted 23 lines · Chao Yu
Quoted 22 lines · PanBian
Quoted 20 lines · Chao Yu
Quoted 8 lines · PanBian
Quoted 7 lines · Chao Yu

Hi Pan,

Quoted 3 lines · Pan Bian

The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page.

Quoted 7 lines
Quoted 2 lines

I notice that you found another use-after-free bug in ext4, out of curiosity, I'd like to ask how do you find those bugs? by tool or code review?

I found such bugs by the aid of a tool I wrote recently. I designed a method to automatically find paired alloc/free functions. With such functions, I wrote two checkers, one to check mismatched alloc/free bugs, the other to check use-after-free and double-free bugs.

Excellent! Do you have any plan to open its source or announce it w/ binary to linux kernel developers, I think w/ it we can help to improve kernel's code quality efficiently.

Quoted 5 lines
Quoted 2 lines

Yes. I am now writing a paper about the method. I will open the source code as soon as I complete the paper and some optimizations.

Cool, if there is any progress, please let f2fs guys know, thank you in advance. :)

No problem. It's my honor to apply my tool to the Linux kernel.

Quoted 3 lines

Thanks,