Skip to contentSkip to conversation

v4l: ioctl: Allow drivers to fill in the format description

PATCH New Sakari Ailus 1 participant 1 message Nov 26, 2018 Media (V4L/DVB)

lore
Share & tools
lore

Sakari Ailus

author
#0 lore raw

PATCH 1/1 v4l: ioctl: Allow drivers to fill in the format description

The v4l_fill_fmtdesc() function does a good job in filling in pixelformat description. While generally all drivers should depend on this function doing the job, staging drivers that use their own formats may not.

Allow staging drivers to fill in their own formats by checking whether the description begins with a non-nil character before issuing the warning.

Signed-off-by Sakari Ailus <[email protected]>
Suggested-by Hans Verkuil <[email protected]>
---
 drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/v4l2-core/v4l2-ioctl.c +1 -1
index 402b6505502a..7473883ab509 100644
@@ -1345,9 +1345,9 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
 		case V4L2_PIX_FMT_MT21C:	descr = "Mediatek Compressed Format"; break;
 		case V4L2_PIX_FMT_SUNXI_TILED_NV12: descr = "Sunxi Tiled NV12 Format"; break;
 		default:
-			WARN(1, "Unknown pixelformat 0x%08x\n", fmt->pixelformat);
 			if (fmt->description[0])
 				return;
+			WARN(1, "Unknown pixelformat 0x%08x\n", fmt->pixelformat);
 			flags = 0;
 			snprintf(fmt->description, sz, "%c%c%c%c%s",
 					(char)(fmt->pixelformat & 0x7f),
Signature · 1 line
2.11.0