Skip to contentSkip to conversation

Add use of logger so that syslog files show when each test starts

PATCH In review Theodore Ts'o 2 participants 7 messages Oct 30, 2018 – Nov 26, 2018 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add use of logger so that syslog files show when each test starts

---
 check | 3 +++
 1 file changed, 3 insertions(+)
check +3 -0
index f6c3537..ebd87c0 100755
@@ -319,6 +319,7 @@ _call_test() {
 		local dmesg_marker=""
 		CHECK_DMESG=0
 	fi
+	$LOGGER_PROG "run blktests $TEST_NAME"
 
 	trap _cleanup EXIT
 	if ! TMPDIR="$(mktemp --tmpdir -p "$OUTPUT" -d "tmpdir.${TEST_NAME//\//.}.XXX")"; then
@@ -578,6 +579,8 @@ fi
 eval set -- "$TEMP"
 unset TEMP
 
+LOGGER_PROG="$(type -P logger)" || LOGGER_PROG=true
+
 if [[ -r config ]]; then
 	# shellcheck disable=SC1091
 	. config
Signature · 1 line
2.18.0.rc0
#1 lore raw

Ping?

- Ted

Quoted 29 lines · Theodore Ts'o
---
 check | 3 +++
 1 file changed, 3 insertions(+)
check +3 -0
index f6c3537..ebd87c0 100755
@@ -319,6 +319,7 @@ _call_test() {
 		local dmesg_marker=""
 		CHECK_DMESG=0
 	fi
+	$LOGGER_PROG "run blktests $TEST_NAME"
 
 	trap _cleanup EXIT
 	if ! TMPDIR="$(mktemp --tmpdir -p "$OUTPUT" -d "tmpdir.${TEST_NAME//\//.}.XXX")"; then
@@ -578,6 +579,8 @@ fi
 eval set -- "$TEMP"
 unset TEMP
 
+LOGGER_PROG="$(type -P logger)" || LOGGER_PROG=true
+
 if [[ -r config ]]; then
 	# shellcheck disable=SC1091
 	. config
Signature · 1 line
2.18.0.rc0
#2 lore raw
Quoted 26 lines · Theodore Y. Ts'o

Ping?

- Ted

Quoted 21 lines · Theodore Ts'o
---
 check | 3 +++
 1 file changed, 3 insertions(+)
check +1 -0
index f6c3537..ebd87c0 100755
@@ -319,6 +319,7 @@ _call_test() {
 		local dmesg_marker=""
 		CHECK_DMESG=0
 	fi
+	$LOGGER_PROG "run blktests $TEST_NAME"
 
 	trap _cleanup EXIT
 	if ! TMPDIR="$(mktemp --tmpdir -p "$OUTPUT" -d "tmpdir.${TEST_NAME//\//.}.XXX")"; then
@@ -578,6 +579,8 @@ fi
 eval set -- "$TEMP"
 unset TEMP
 
Quoted 8 lines
Quoted 8 lines
check +2 -0
+LOGGER_PROG="$(type -P logger)" || LOGGER_PROG=true
+
 if [[ -r config ]]; then
 	# shellcheck disable=SC1091
 	. config
Signature · 1 line
2.18.0.rc0

Hey, Ted, sorry, I meant to ask you about this in person at LPC but forgot to. Forgive my ignorance about syslog, but does syslog not pick up the line we write to dmesg?

#3 lore raw
Quoted 4 lines · Omar Sandoval

Hey, Ted, sorry, I meant to ask you about this in person at LPC but forgot to. Forgive my ignorance about syslog, but does syslog not pick up the line we write to dmesg?

Unfortunately, it does not.

root@xfstests-ltm:~# echo foo testing >> /dev/kmsg 
root@xfstests-ltm:~# dmesg | tail
[    7.103899] random: crng init done
[    7.104759] random: 7 urandom warning(s) missed due to ratelimiting
[    7.154525] EDAC MC: Ver: 3.0.0
[    7.221973] EDAC sbridge: Seeking for: PCI ID 8086:2fa0
[    7.221977] EDAC sbridge:  Ver: 1.1.1 
[    7.259154] device-mapper: uevent: version 1.0.3
[    7.267252] device-mapper: ioctl: 4.35.0-ioctl (2016-06-23) initialised: [email protected]
[    7.762306] EXT4-fs (sda1): resizing filesystem from 2620928 to 13106683 blocks
[    8.541258] EXT4-fs (sda1): resized filesystem to 13106683
[840160.646340] foo testing
root@xfstests-ltm:~# tail /var/log/kern.log
root@xfstests-ltm:~# grep kern.log /etc/rsyslog.conf 
kern.*				-/var/log/kern.log

So as you can see nothing written to kern.log, even though we wrote to /dev/kmsg.

To prove that kern.log will get kernel messages:

root@xfstests-ltm:~# mke2fs -t ext4 -Fq /tmp/foo.img 8M
root@xfstests-ltm:~# mount -t ext4 /tmp/foo.img /mnt
root@xfstests-ltm:~# echo testing > /sys/fs/ext4/loop0/trigger_fs_error 
root@xfstests-ltm:~# tail /var/log/kern.log
Nov 26 13:30:22 xfstests-ltm kernel: [840286.728296] loop: module loaded
Nov 26 13:30:22 xfstests-ltm kernel: [840286.752181] EXT4-fs (loop0): mounted filesystem with ordered data mode. Opts: (null)
Nov 26 13:30:41 xfstests-ltm kernel: [840305.773418] EXT4-fs error (device loop0): trigger_test_error:123: comm bash: testing
root@xfstests-ltm:~# 

- Ted

#4 lore raw
Quoted 29 lines · Theodore Y. Ts'o
Quoted 4 lines · Omar Sandoval

Hey, Ted, sorry, I meant to ask you about this in person at LPC but forgot to. Forgive my ignorance about syslog, but does syslog not pick up the line we write to dmesg?

Unfortunately, it does not.

root@xfstests-ltm:~# echo foo testing >> /dev/kmsg 
root@xfstests-ltm:~# dmesg | tail
[    7.103899] random: crng init done
[    7.104759] random: 7 urandom warning(s) missed due to ratelimiting
[    7.154525] EDAC MC: Ver: 3.0.0
[    7.221973] EDAC sbridge: Seeking for: PCI ID 8086:2fa0
[    7.221977] EDAC sbridge:  Ver: 1.1.1 
[    7.259154] device-mapper: uevent: version 1.0.3
[    7.267252] device-mapper: ioctl: 4.35.0-ioctl (2016-06-23) initialised: [email protected]
[    7.762306] EXT4-fs (sda1): resizing filesystem from 2620928 to 13106683 blocks
[    8.541258] EXT4-fs (sda1): resized filesystem to 13106683
[840160.646340] foo testing
root@xfstests-ltm:~# tail /var/log/kern.log
root@xfstests-ltm:~# grep kern.log /etc/rsyslog.conf 
kern.*				-/var/log/kern.log

So as you can see nothing written to kern.log, even though we wrote to /dev/kmsg.

To prove that kern.log will get kernel messages:

Quoted 8 lines
root@xfstests-ltm:~# mke2fs -t ext4 -Fq /tmp/foo.img 8M
root@xfstests-ltm:~# mount -t ext4 /tmp/foo.img /mnt
root@xfstests-ltm:~# echo testing > /sys/fs/ext4/loop0/trigger_fs_error 
root@xfstests-ltm:~# tail /var/log/kern.log
Nov 26 13:30:22 xfstests-ltm kernel: [840286.728296] loop: module loaded
Nov 26 13:30:22 xfstests-ltm kernel: [840286.752181] EXT4-fs (loop0): mounted filesystem with ordered data mode. Opts: (null)
Nov 26 13:30:41 xfstests-ltm kernel: [840305.773418] EXT4-fs error (device loop0): trigger_test_error:123: comm bash: testing
root@xfstests-ltm:~# 

Hm, what if we output it as KERN_INFO?

check +1 -1
index f6c3537..9b4765f 100755
@@ -314,7 +314,7 @@ _call_test() {
 
 	if [[ -w /dev/kmsg ]]; then
 		local dmesg_marker="run blktests $TEST_NAME at ${TEST_RUN["date"]}"
-		echo "$dmesg_marker" >> /dev/kmsg
+		echo "<6>$dmesg_marker" >> /dev/kmsg
 	else
 		local dmesg_marker=""
 		CHECK_DMESG=0
#5 lore raw
Quoted 8 lines · Omar Sandoval

Hm, what if we output it as KERN_INFO?

check +0 -0
index f6c3537..9b4765f 100755

check _call_test() { · line 320

Quoted 8 lines
check +1 -1
@@ -314,7 +314,7 @@ _call_test() {
 
 	if [[ -w /dev/kmsg ]]; then
 		local dmesg_marker="run blktests $TEST_NAME at ${TEST_RUN["date"]}"
-		echo "$dmesg_marker" >> /dev/kmsg
+		echo "<6>$dmesg_marker" >> /dev/kmsg
 	else
 		local dmesg_marker=""
 		CHECK_DMESG=0

Still not working, alas. I tested it via:

root@xfstests-ltm:~# echo "<6>testing 123" >> /dev/kmsg 

It still didn't appear in /var/log/kern.log

- Ted

#6 lore raw
Quoted 20 lines · Theodore Y. Ts'o
Quoted 8 lines · Omar Sandoval

Hm, what if we output it as KERN_INFO?

check +0 -0
index f6c3537..9b4765f 100755

check _call_test() { · line 320

Quoted 8 lines
check +1 -1
@@ -314,7 +314,7 @@ _call_test() {
 
 	if [[ -w /dev/kmsg ]]; then
 		local dmesg_marker="run blktests $TEST_NAME at ${TEST_RUN["date"]}"
-		echo "$dmesg_marker" >> /dev/kmsg
+		echo "<6>$dmesg_marker" >> /dev/kmsg
 	else
 		local dmesg_marker=""
 		CHECK_DMESG=0

Still not working, alas. I tested it via:

Quoted 5 lines
root@xfstests-ltm:~# echo "<6>testing 123" >> /dev/kmsg 

It still didn't appear in /var/log/kern.log

- Ted

Ok, well that's my due diligence, so applied. Thanks!