Skip to contentSkip to conversation

strace: don't remove strace-graph unconditionally

PATCH New Baruch Siach 2 participants 3 messages Nov 27, 2018 – Nov 28, 2018

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 strace: don't remove strace-graph unconditionally

strace-graph is a perl script. This script is removed unconditionally since commit 720c0ca5ba7 ("strace: convert to makefile.autotools.in format") from 2008. Since then Buildroot added support for perl on target. Don't remove strace-graph when perl is built for target.

Signed-off-by Baruch Siach <[email protected]>
---
 package/strace/strace.mk | 2 ++
 1 file changed, 2 insertions(+)
package/strace/strace.mk +2 -0
index 471dbc2e1dd3..10869453d146 100644
@@ -38,6 +38,8 @@ define STRACE_REMOVE_STRACE_GRAPH
 	rm -f $(TARGET_DIR)/usr/bin/strace-graph
 endef
 
+ifeq ($(BR2_PACKAGE_PERL),)
 STRACE_POST_INSTALL_TARGET_HOOKS += STRACE_REMOVE_STRACE_GRAPH
+endif
 
 $(eval $(autotools-package))
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 strace: don't remove strace-graph unconditionally

Hello,

Quoted 6 lines · Baruch Siach

strace-graph is a perl script. This script is removed unconditionally since commit 720c0ca5ba7 ("strace: convert to makefile.autotools.in format") from 2008. Since then Buildroot added support for perl on target. Don't remove strace-graph when perl is built for target.

Signed-off-by Baruch Siach <[email protected]>

Would be nice to enclose the STRACE_REMOVE_STRACE_GRAPH function into the condition. No need to resend just for that, it can be fixed when applying.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Applied
#2 lore raw

PATCH 1/1 strace: don't remove strace-graph unconditionally

In reply to Baruch Siach

Hello,

Quoted 9 lines · Baruch Siach

strace-graph is a perl script. This script is removed unconditionally since commit 720c0ca5ba7 ("strace: convert to makefile.autotools.in format") from 2008. Since then Buildroot added support for perl on target. Don't remove strace-graph when perl is built for target.

Signed-off-by Baruch Siach <[email protected]>
---
 package/strace/strace.mk | 2 ++
 1 file changed, 2 insertions(+)

Applied to next after moving the hook definition inside the condition. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com