Skip to contentSkip to conversation

trace: simple style changes

PATCH Applied Larry Dewey 3 participants 3 messages Nov 27, 2018 – Nov 28, 2018

lore
Share & tools
lore

Larry Dewey

author
#0 lore raw

PATCH 1/1 trace: simple style changes

This changes two lines in simple.c that end with a comma, and replaces them with a semi-colon.

Signed-off-by Larry Dewey <[email protected]>
---
 trace/simple.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
trace/simple.c +2 -2
index 701dec639c..ac904eca91 100644
@@ -169,9 +169,9 @@ static gpointer writeout_thread(gpointer opaque)
         wait_for_trace_records_available();
 
         if (g_atomic_int_get(&dropped_events)) {
-            dropped.rec.event = DROPPED_EVENT_ID,
+            dropped.rec.event = DROPPED_EVENT_ID;
             dropped.rec.timestamp_ns = get_clock();
-            dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t),
+            dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t);
             dropped.rec.pid = trace_pid;
             do {
                 dropped_count = g_atomic_int_get(&dropped_events);
Signature · 1 line
2.19.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Larry Dewey

This changes two lines in simple.c that end with a comma, and replaces them with a semi-colon.

Signed-off-by Larry Dewey <[email protected]>
---
 trace/simple.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
trace/simple.c +0 -0
index 701dec639c..ac904eca91 100644
@@ -169,9 +169,9 @@ static gpointer writeout_thread(gpointer opaque)
         wait_for_trace_records_available();

trace/simple.c static gpointer writeout_thread(gpointer opaque) · line 177

Quoted 10 lines
trace/simple.c +2 -2
 
         if (g_atomic_int_get(&dropped_events)) {
-            dropped.rec.event = DROPPED_EVENT_ID,
+            dropped.rec.event = DROPPED_EVENT_ID;
             dropped.rec.timestamp_ns = get_clock();
-            dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t),
+            dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t);
             dropped.rec.pid = trace_pid;
             do {
                 dropped_count = g_atomic_int_get(&dropped_events);

I can't see any reason for why sequence points were used, other than in 62bab73213ba885426a781eb2741670b9f3cae36 getting mixed up between

if (cond) { ...; ... } and an earlier var = (type) { ..., ... }.

Reviewed-by John Snow <[email protected]>