tools/lib/traceevent: make libtraceevent thread safe
PATCH v3 1/1 tools/lib/traceevent: make libtraceevent thread safe
This patch is a PoC about transforming libtraceevent into a thread safe library. It implements per thread local storage and internal APIs to access it. It covers only tep->last_event cache, but easily can be extended with all library's thread sensitive data.
---
v2: Added local thread data per tep context
v3: Implemented APIs to access specific tread local data,
instead of the whole struct tep_thread_data.
--- tools/lib/traceevent/event-parse-local.h | 18 ++- tools/lib/traceevent/event-parse-thread.c | 131 ++++++++++++++++++++++ tools/lib/traceevent/event-parse.c | 21 ++-- 3 files changed, 158 insertions(+), 12 deletions(-) create mode 100644 tools/lib/traceevent/event-parse-thread.c
tools/lib/traceevent/event-parse-local.h +15 -3
@@ -14,6 +14,14 @@ struct func_list;struct event_handler ;struct func_resolver ; +/* cache */ +struct tep_thread_data { +struct tep_handle *tep; +struct tep_thread_data *next; + +struct tep_event *last_event; +}; +struct tep_handle {int ref_count;
@@ -83,9 +91,6 @@ struct tep_handle {struct event_handler *handlers;struct tep_function_handler *func_handlers; -/* cache */ -struct tep_event *last_event; -char *trace_clock; };
@@ -96,4 +101,11 @@ unsigned short tep_data2host2(struct tep_handle *pevent, unsigned short data);unsigned int tep_data2host4 (struct tep_handle *pevent,unsigned int data);unsigned long long tep_data2host8 (struct tep_handle *pevent,unsigned long long data); +/* tep cache per thread */ +struct tep_event *tep_find_event_by_id_cache (struct tep_handle *tep,int id); +struct tep_event * +tep_find_event_by_name_cache (struct tep_handle *tep,const char *name,const char *sys); +void tep_set_serach_event_cache (struct tep_handle *tep,struct tep_event *event); +void tep_destroy_thread_local (struct tep_handle *tep); +#endif /* _PARSE_EVENTS_INT_H */
tools/lib/traceevent/event-parse-thread.c new file +131 -0
131 lines not on this page · raw message
tools/lib/traceevent/event-parse.c +12 -9
@@ -3485,10 +3485,11 @@ struct tep_event *tep_find_event(struct tep_handle *pevent, int id)struct tep_event **eventptr;struct tep_event key;struct tep_event *pkey = &key; +struct tep_event *event_cache =tep_find_event_by_id_cache (pevent, id);/* Check cache first */ -if (pevent->last_event && pevent->last_event->id == id) -return pevent->last_event; +if (event_cache) +return event_cache; key.id = id;
@@ -3496,7 +3497,7 @@ struct tep_event *tep_find_event(struct tep_handle *pevent, int id) sizeof(*pevent->events), events_id_cmp);if (eventptr) { - pevent->last_event = *eventptr; +tep_set_serach_event_cache (pevent, *eventptr);return *eventptr; }
@@ -3516,13 +3517,13 @@ struct tep_event * tep_find_event_by_name(struct tep_handle *pevent, const char *sys, const char *name) { - struct tep_event *event = NULL; int i; +struct tep_event *event =NULL ; +struct tep_event *event_cache =tep_find_event_by_name_cache (pevent, name, sys); -if (pevent->last_event && -strcmp (pevent->last_event->name, name) ==0 && - (!sys ||strcmp (pevent->last_event->system, sys) ==0 )) -return pevent->last_event; +/* Check cache first */ +if (event_cache) +return event_cache;for (i =0 ; i < pevent->nr_events; i++) { event = pevent->events[i];
@@ -3533,10 +3534,12 @@ tep_find_event_by_name(struct tep_handle *pevent,break ; } } +if (i == pevent->nr_events) event =NULL ; +if (event) +tep_set_serach_event_cache (pevent, event); - pevent->last_event = event;return event; }
Signature · 1 line
2.19.1
Quoted 1 line · On Wed, 28 Nov 2018 13:31:31 +0000 Tzvetomir Stoyanov <[email protected]>…
This patch is a PoC about transforming libtraceevent
Hi Tzvetomir,
You may want to talk with Yordan about how to send patches with a subject like:
[POC][PATCH v3] tools/lib/traceevent: make libtraceevent thread safe
As the subject should state that this is a proof of concept patch.
Quoted 74 lines
into a thread safe library. It implements per thread local storage and internal APIs to access it. It covers only
tep->last_eventcache, but easily can be extended with all library's thread sensitive data.Signed-off-by Tzvetomir Stoyanov <[email protected]>---
v2: Added local thread data per tep context
v3: Implemented APIs to access specific tread local data,
instead of the whole structtep_thread_data.--- tools/lib/traceevent/event-parse-local.h | 18 ++- tools/lib/traceevent/event-parse-thread.c | 131 ++++++++++++++++++++++ tools/lib/traceevent/event-parse.c | 21 ++-- 3 files changed, 158 insertions(+), 12 deletions(-) create mode 100644 tools/lib/traceevent/event-parse-thread.ctools/lib/traceevent/event-parse-local.h +15
-3@@ -14,6 +14,14 @@ struct func_list;struct event_handler ;struct func_resolver ; +/* cache */ +struct tep_thread_data { +struct tep_handle *tep; +struct tep_thread_data *next; + +struct tep_event *last_event; +}; +struct tep_handle {int ref_count;@@ -83,9 +91,6 @@ struct tep_handle {struct event_handler *handlers;struct tep_function_handler *func_handlers; -/* cache */ -struct tep_event *last_event; -char *trace_clock; };@@ -96,4 +101,11 @@ unsigned short tep_data2host2(struct tep_handle *pevent, unsigned short data);unsigned int tep_data2host4 (struct tep_handle *pevent,unsigned int data);unsigned long long tep_data2host8 (struct tep_handle *pevent,unsigned long long data); +/* tep cache per thread */ +struct tep_event *tep_find_event_by_id_cache (struct tep_handle *tep,int id); +struct tep_event * +tep_find_event_by_name_cache (struct tep_handle *tep,const char *name,const char *sys); +void tep_set_serach_event_cache (struct tep_handle *tep,struct tep_event *event); +void tep_destroy_thread_local (struct tep_handle *tep); +#endif /* _PARSE_EVENTS_INT_H */ tools/lib/traceevent/event-parse-thread.c new file +10
-0@@ -0,0 +1,131 @@ +// SPDX-License-Identifier: LGPL-2.1 +/* +* Copyright (C) 2009, 2010 Red Hat Inc, Steven Rostedt <[email protected]> +* +*/ + +#include "event-parse.h" +#include "event-parse-local.h" +#include "event-utils.h" +
tools/lib/traceevent/event-parse-thread.c line 20
Quoted 10 lines
tools/lib/traceevent/event-parse-thread.c new file +10
-0+static __threadstruct tep_thread_data *tep_thread_local; + +static struct tep_thread_data *tep_alloc_thread_local (struct tep_handle *tep) +{ +struct tep_thread_data *local; + + local =calloc (1 ,sizeof (struct tep_thread_data )); +if (local) { + local->tep = tep; + local->next = tep_thread_local;
I really don't want a loop. We should have one thread cache. Heck, then we don't even need to allocate it.
-- Steve
Quoted 5 lines
tools/lib/traceevent/event-parse-thread.c new file +5
-0+ tep_thread_local = local; + } +return local; +} +
Hi Steven
Quoted 95 lines · Steven Rostedt
Quoted 1 line · On Wed, 28 Nov 2018 13:31:31 +0000 Tzvetomir Stoyanov <[email protected]>…
This patch is a PoC about transforming libtraceevent
Hi Tzvetomir,
You may want to talk with Yordan about how to send patches with a subject like:
[POC][PATCH v3]
tools/lib/traceevent: make libtraceevent thread safeAs the subject should state that this is a proof of concept patch.
Quoted 79 lines
into a thread safe library. It implements per thread local storage and internal APIs to access it. It covers only
tep->last_eventcache, but easily can be extended with all library's thread sensitive data.Signed-off-by Tzvetomir Stoyanov <[email protected]>---
v2: Added local thread data per tep context
v3: Implemented APIs to access specific tread local data,
instead of the whole structtep_thread_data.--- tools/lib/traceevent/event-parse-local.h | 18 ++- tools/lib/traceevent/event-parse-thread.c | 131 ++++++++++++++++++++++ tools/lib/traceevent/event-parse.c | 21 ++-- 3 files changed, 158 insertions(+), 12 deletions(-) create mode 100644 tools/lib/traceevent/event-parse-thread.ctools/lib/traceevent/event-parse-local.h +15
-3@@ -14,6 +14,14 @@ struct func_list;struct event_handler ;struct func_resolver ; +/* cache */ +struct tep_thread_data { +struct tep_handle *tep; +struct tep_thread_data *next; + +struct tep_event *last_event; +}; +struct tep_handle {int ref_count;@@ -83,9 +91,6 @@ struct tep_handle {struct event_handler *handlers;struct tep_function_handler *func_handlers; -/* cache */ -struct tep_event *last_event; -char *trace_clock; };@@ -96,4 +101,11 @@ unsigned short tep_data2host2(struct tep_handle *pevent, unsigned short data);unsigned int tep_data2host4 (struct tep_handle *pevent,unsigned int data);unsigned long long tep_data2host8 (struct tep_handle *pevent,unsigned long long data); +/* tep cache per thread */ +struct tep_event *tep_find_event_by_id_cache (struct tep_handle *tep,int id); +struct tep_event * +tep_find_event_by_name_cache (struct tep_handle *tep,const char *name,const char *sys); +void tep_set_serach_event_cache (struct tep_handle *tep,struct tep_event *event); +void tep_destroy_thread_local (struct tep_handle *tep); +#endif /* _PARSE_EVENTS_INT_H */ tools/lib/traceevent/event-parse-thread.c new file +15
-0@@ -0,0 +1,131 @@ +// SPDX-License-Identifier: LGPL-2.1 +/* +* Copyright (C) 2009, 2010 Red Hat Inc, Steven Rostedt <[email protected]> +* +*/ + +#include "event-parse.h" +#include "event-parse-local.h" +#include "event-utils.h" + +static __threadstruct tep_thread_data *tep_thread_local; + +static struct tep_thread_data *tep_alloc_thread_local (struct tep_handle *tep) +{ +struct tep_thread_data *local;
Quoted 9 lines
tools/lib/traceevent/event-parse-thread.c line 20
Quoted 5 lines
tools/lib/traceevent/event-parse-thread.c new file +5
-0+ + local =calloc (1 ,sizeof (struct tep_thread_data )); +if (local) { + local->tep = tep; + local->next = tep_thread_local;I really don't want a loop. We should have one thread cache. Heck, then we don't even need to allocate it.
The reason for dynamic allocation is that we should support the case where we have
multiple threads, working with multiple tep handlers. We need each thread to has local
data for each tep handler, so we should use list (or other dynamic structure) of all
tep handlers per thread. The global variable
static __thread struct tep_thread_data *tep_thread_local;
has to store locals for multiple tep handlers, in context of current thread.
Quoted 10 lines
-- Steve
Quoted 5 lines
tools/lib/traceevent/event-parse-thread.c new file +5
-0+ tep_thread_local = local; + } +return local; +} +
Signature · 2 lines
Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center