KVM: VMX: re-add ple_gap module parameter

PATCH In review Luiz Capitulino 5 participants 7 messages Nov 23, 2018 – Nov 28, 2018

Subsystems (4)

Stable branch x86 KVM KVM x86

lore

Share & tools

lore

Luiz Capitulino

author

2018-11-23 17:02 UTC #0 lore raw

PATCH 1/1 KVM: VMX: re-add ple_gap module parameter

Apparently, the ple_gap parameter was accidentally removed by commit c8e88717cfc6b36bedea22368d97667446318291. Add it back.

Signed-off-by Luiz Capitulino <[email protected]>

---
 arch/x86/kvm/vmx.c | 1 +
 1 file changed, 1 insertion(+)

arch/x86/kvm/vmx.c +1 -0

index 4555077d69ce..be6f13f1c25f 100644
@@ -174,6 +174,7 @@ module_param_named(preemption_timer, enable_preemption_timer, bool, S_IRUGO);
  * refer SDM volume 3b section 21.6.13 & 22.1.3.
  */
 static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
+module_param(ple_gap, uint, 0444);
 
 static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
 module_param(ple_window, uint, 0444);

Signature · 1 line

2.17.2

Liran Alon

Reviewed-by on v1 1/1

2018-11-23 17:42 UTC #1 lore raw

Quoted 10 lines · Luiz Capitulino

Apparently, the ple_gap parameter was accidentally removed by commit c8e88717cfc6b36bedea22368d97667446318291. Add it back.
Signed-off-by Luiz Capitulino <[email protected]>

Weird that nobody noticed this when patch was applied… Thanks.

Reviewed-by Liran Alon <[email protected]>

Quoted 19 lines

---
arch/x86/kvm/vmx.c | 1 +

1 file changed, 1 insertion(+)

arch/x86/kvm/vmx.c +1 -0

index 4555077d69ce..be6f13f1c25f 100644
@@ -174,6 +174,7 @@ module_param_named(preemption_timer, enable_preemption_timer, bool, S_IRUGO);
 * refer SDM volume 3b section 21.6.13 & 22.1.3.
 */
 static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
+module_param(ple_gap, uint, 0444);
 
 static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
 module_param(ple_window, uint, 0444);

Signature · 1 line

2.17.2

Luiz Capitulino

author

2018-11-23 18:26 UTC #2 lore raw

Quoted 11 lines · On Fri, 23 Nov 2018 19:42:53 +0200 Liran Alon <[email protected]> wrote:

Quoted 8 lines · Luiz Capitulino
Apparently, the ple_gap parameter was accidentally removed by commit c8e88717cfc6b36bedea22368d97667446318291. Add it back.
Signed-off-by Luiz Capitulino <[email protected]>
Weird that nobody noticed this when patch was applied… Thanks.
Reviewed-by Liran Alon <[email protected]>

I forgot to mention that I noticed this because I have systems disabling ple with ple_gap=0 in modprobe.conf. In those systems kvm_intel won't load anymore.

Quoted 21 lines

Quoted 20 lines

---
arch/x86/kvm/vmx.c | 1 +

1 file changed, 1 insertion(+)

arch/x86/kvm/vmx.c +1 -0

index 4555077d69ce..be6f13f1c25f 100644
@@ -174,6 +174,7 @@ module_param_named(preemption_timer, enable_preemption_timer, bool, S_IRUGO);
 * refer SDM volume 3b section 21.6.13 & 22.1.3.
 */
 static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
+module_param(ple_gap, uint, 0444);
 
 static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
 module_param(ple_window, uint, 0444);

Signature · 1 line

2.17.2

Moger, Babu

Reviewed-by

2018-11-28 15:57 UTC #3 lore raw

My bad.. Sorry about this. I think this should also go to [email protected]

Quoted 9 lines

-----Original Message-----
From: Luiz Capitulino <[email protected]>
Sent: Friday, November 23, 2018 12:27 PM
To: Liran Alon <[email protected]>
Cc: Paolo Bonzini <[email protected]>; Moger, Babu <[email protected]>; [email protected]; linux- [email protected]
Subject: Re: [PATCH] KVM: VMX: re-add ple_gap module parameter

Quoted 15 lines

Quoted 1 line · On Fri, 23 Nov 2018 19:42:53 +0200 Liran Alon <[email protected]> wrote:
Quoted 1 line
On 23 Nov 2018, at 19:02, Luiz Capitulino <[email protected]>
Quoted 10 lines · wrote:
Quoted 7 lines
Apparently, the ple_gap parameter was accidentally removed by commit c8e88717cfc6b36bedea22368d97667446318291. Add it back.
Signed-off-by Luiz Capitulino <[email protected]>
Weird that nobody noticed this when patch was applied… Thanks.
Reviewed-by Liran Alon <[email protected]>

Reviewed-by Babu Moger <[email protected]>

Quoted 27 lines

I forgot to mention that I noticed this because I have systems disabling ple with ple_gap=0 in modprobe.conf. In those systems kvm_intel won't load anymore.
Quoted 10 lines
arch/x86/kvm/vmx.c module_param_named(preemption_timer,
Quoted 10 lines
---
arch/x86/kvm/vmx.c | 1 +
1 file changed, 1 insertion(+)
arch/x86/kvm/vmx.c +0 -0
index 4555077d69ce..be6f13f1c25f 100644
@@ -174,6 +174,7 @@ module_param_named(preemption_timer,
enable_preemption_timer, bool, S_IRUGO);
Quoted 11 lines
Quoted 10 lines
arch/x86/kvm/vmx.c +1 -1
 * refer SDM volume 3b section 21.6.13 & 22.1.3.
 */
 static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
+module_param(ple_gap, uint, 0444);
 
 static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
 module_param(ple_window, uint, 0444);
--
2.17.2

Luiz Capitulino

author

2018-11-28 16:03 UTC #4 lore raw

Quoted 2 lines · Babu

My bad.. Sorry about this. I think this should also go to [email protected]

No problem man, this happens. Thanks for the review!

Quoted 55 lines

Quoted 10 lines
-----Original Message-----
From: Luiz Capitulino <[email protected]>
Sent: Friday, November 23, 2018 12:27 PM
To: Liran Alon <[email protected]>
Cc: Paolo Bonzini <[email protected]>; Moger, Babu <[email protected]>; [email protected]; linux- [email protected]
Subject: Re: [PATCH] KVM: VMX: re-add ple_gap module parameter
Quoted 15 lines
Quoted 1 line · On Fri, 23 Nov 2018 19:42:53 +0200 Liran Alon <[email protected]> wrote:
Quoted 1 line
On 23 Nov 2018, at 19:02, Luiz Capitulino <[email protected]>
Quoted 10 lines · wrote:
Quoted 7 lines
Apparently, the ple_gap parameter was accidentally removed by commit c8e88717cfc6b36bedea22368d97667446318291. Add it back.
Signed-off-by Luiz Capitulino <[email protected]>
Weird that nobody noticed this when patch was applied… Thanks.
Reviewed-by Liran Alon <[email protected]>
Reviewed-by Babu Moger <[email protected]>
Quoted 27 lines
I forgot to mention that I noticed this because I have systems disabling ple with ple_gap=0 in modprobe.conf. In those systems kvm_intel won't load anymore.
Quoted 10 lines
arch/x86/kvm/vmx.c module_param_named(preemption_timer,
Quoted 10 lines
---
arch/x86/kvm/vmx.c | 1 +
1 file changed, 1 insertion(+)
arch/x86/kvm/vmx.c +0 -0
index 4555077d69ce..be6f13f1c25f 100644
@@ -174,6 +174,7 @@ module_param_named(preemption_timer,  
enable_preemption_timer, bool, S_IRUGO);
Quoted 11 lines
Quoted 10 lines
arch/x86/kvm/vmx.c +1 -1
 * refer SDM volume 3b section 21.6.13 & 22.1.3.
 */
 static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
+module_param(ple_gap, uint, 0444);
 
 static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
 module_param(ple_window, uint, 0444);
--
2.17.2

Sasha Levin

maintainer

2018-11-28 16:11 UTC #5 lore raw

In reply to Moger, Babu

Quoted 2 lines · Babu

My bad.. Sorry about this. I think this should also go to [email protected]

Please actually add the stable tag in the commit message if you intend for this patch to go in stable.

Paolo Bonzini

maintainer

2018-11-28 16:40 UTC #6 lore raw

Quoted 6 lines · Sasha Levin

Quoted 2 lines · Babu
My bad.. Sorry about this. I think this should also go to [email protected]
Please actually add the stable tag in the commit message if you intend for this patch to go in stable.

No worries, the patch is already on its way to Linus with the stable tag.

Paolo