ath10k: Move non-fatal warn logs to dbg level
PATCH 1/1 ath10k: Move non-fatal warn logs to dbg level
During driver load below warn logs are printed in the console. Since driver may not implement all wmi events sent by fw and all of them are non-fatal, move this log to debug level to remove un-necessary warn message on console.
[ 361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393 [ 361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569
--- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/wmi-tlv.c +1 -1
@@ -621,7 +621,7 @@ static void ath10k_wmi_tlv_op_rx(struct ath10k *ar, struct sk_buff *skb)ath10k_wmi_event_mgmt_tx_compl (ar, skb);break ;default : -ath10k_warn (ar,"Unknown eventid: %d\n" , id); +ath10k_dbg (ar,ATH10K_DBG_WMI ,"Unknown eventid: %d\n" , id);break ; }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 10 lines · Govind Singh
During driver load below warn logs are printed in the console. Since driver may not implement all wmi events sent by fw and all of them are non-fatal, move this log to debug level to remove un-necessary warn message on console.
[ 361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393 [ 361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569Signed-off-by Govind Singh <[email protected]>
Alternatively, you could add these ignored commands to wmi-tlv.h, and just ignore them specifically. That's better documentation, in case new WMI events come along that *are* important to notice when we ignore them. There are other recent examples of that sort of patch being merged.
Brian
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 10 lines · Brian Norris
Quoted 9 lines · Govind Singh
During driver load below warn logs are printed in the console. Since driver may not implement all wmi events sent by fw and all of them are non-fatal, move this log to debug level to remove un-necessary warn message on console.
[ 361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393 [ 361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569
Quoted 7 lines
Quoted 1 line
Signed-off-by Govind Singh <[email protected]>Alternatively, you could add these ignored commands to
wmi-tlv.h, and just ignore them specifically. That's better documentation, in case new WMI events come along that *are* important to notice when we ignore them. There are other recent examples of that sort of patch being merged.
I have actually tried to do that (what Brian describes above) during the last years but the problem is that there are just so many different firmware branches that it's difficult to keep up in ath10k. So in the end these warnings just confused the users and they mistakenly thought this warning message is the cause of their problems. That's why I think it's best to remove this warning.
Signature · 1 line
Kalle Valo
Quoted 7 lines · Kalle Valo
Quoted 5 lines · Brian Norris
Alternatively, you could add these ignored commands to
wmi-tlv.h, and just ignore them specifically. That's better documentation, in case new WMI events come along that *are* important to notice when we ignore them. There are other recent examples of that sort of patch being merged.
Quoted 6 lines
I have actually tried to do that (what Brian describes above) during the last years but the problem is that there are just so many different firmware branches that it's difficult to keep up in ath10k. So in the end these warnings just confused the users and they mistakenly thought this warning message is the cause of their problems. That's why I think it's best to remove this warning.
Thanks for the background. To be clear, I'm perfectly fine with this patch too. I was mostly just volunteering an alternative, in case it *was* your intention as maintainer to keep it this way.
Regards,
Brian
Quoted 10 lines · Govind Singh
During driver load below warn logs are printed in the console. Since driver may not implement all wmi events sent by fw and all of them are non-fatal, move this log to debug level to remove un-necessary warn message on console.
[ 361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393 [ 361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569Signed-off-by Govind Singh <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
bd085be6ba95 ath10k: move non-fatal warn logs to dbg level
Signature · 3 lines
https://patchwork.kernel.org/patch/10703901/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 10 lines · Govind Singh
During driver load below warn logs are printed in the console. Since driver may not implement all wmi events sent by fw and all of them are non-fatal, move this log to debug level to remove un-necessary warn message on console.
[ 361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393 [ 361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569Signed-off-by Govind Singh <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
bd085be6ba95 ath10k: move non-fatal warn logs to dbg level
Signature · 9 lines
https://patchwork.kernel.org/patch/10703901/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k