c-ares: support host build

PATCH New Robert Rose 4 participants 6 messages Nov 29, 2018 – Dec 3, 2018

lore

Share & tools

lore

Robert Rose

author

2018-11-29 06:21 UTC #0 lore raw

PATCH v4 1/2 c-ares: support host build

Signed-off-by Robert Rose <[email protected]>

---
 package/c-ares/c-ares.mk | 1 +
 1 file changed, 1 insertion(+)

package/c-ares/c-ares.mk +1 -0

index 67254244a1..76e9687b37 100644
@@ -15,3 +15,4 @@ C_ARES_LICENSE = MIT
 C_ARES_LICENSE_FILES = ares_mkquery.c
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))

Signature · 1 line

2.20.0.rc0.387.gc7a69e6b6c-goog

Robert Rose

author

2018-11-29 06:21 UTC #1 lore raw

PATCH v4 2/2 grpc: new package

Signed-off-by Robert Rose <[email protected]>

---
 DEVELOPERS                                    |  3 ++
 package/Config.in                             |  1 +
 .../0001-target-build-using-host-plugin.patch | 44 +++++++++++++++++++
 package/grpc/Config.in                        | 11 +++++
 package/grpc/grpc.hash                        |  5 +++
 package/grpc/grpc.mk                          | 36 +++++++++++++++
 6 files changed, 100 insertions(+)
 create mode 100644 package/grpc/0001-target-build-using-host-plugin.patch
 create mode 100644 package/grpc/Config.in
 create mode 100644 package/grpc/grpc.hash
 create mode 100644 package/grpc/grpc.mk

DEVELOPERS +3 -0

index 53467da489..437614c190 100644
@@ -1772,6 +1772,9 @@ F:	package/subversion/
 N:	RJ Ascani <[email protected]>
 F:	package/azmq/
 
+N:	Robert Rose <[email protected]>
+F:	package/grpc
+
 N:	Rodrigo Rebello <[email protected]>
 F:	package/chocolate-doom/
 F:	package/irssi/

package/Config.in +1 -0

index b60e7700ad..2d0cc51797 100644
@@ -1495,6 +1495,7 @@ menu "Networking"
 	source "package/freeradius-client/Config.in"
 	source "package/geoip/Config.in"
 	source "package/glib-networking/Config.in"
+	source "package/grpc/Config.in"
 	source "package/gssdp/Config.in"
 	source "package/gupnp/Config.in"
 	source "package/gupnp-av/Config.in"

package/grpc/0001-target-build-using-host-plugin.patch new file +44 -0

44 lines not on this page · raw message

package/grpc/Config.in new file +11 -0

new file mode 100644
index 0000000000..e4364c2fe6
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_GRPC
+	bool "grpc"
+	select BR2_PACKAGE_C_ARES
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_PROTOBUF
+	select BR2_PACKAGE_ZLIB
+	help
+	  A language-neutral, platform-neutral, open source, remote
+	  procedure call (RPC) system initially developed at Google.
+
+	  http://github.com/grpc/grpc

package/grpc/grpc.hash new file +5 -0

new file mode 100644
index 0000000000..8a1df947fd
@@ -0,0 +1,5 @@
+# Locally computed
+sha256 a5342629fe1b689eceb3be4d4f167b04c70a84b9d61cf8b555e968bc500bdb5a grpc-v1.16.1.tar.gz
+sha256 cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 LICENSE
+
+

package/grpc/grpc.mk new file +36 -0

new file mode 100644
index 0000000000..1aa5447386
@@ -0,0 +1,36 @@
+################################################################################
+#
+# grpc
+#
+################################################################################
+
+GRPC_VERSION = v1.16.1
+GRPC_SOURCE = grpc-$(GRPC_VERSION).tar.gz
+GRPC_SITE = $(call github,grpc,grpc,$(GRPC_VERSION))
+GRPC_LICENSE = Apache-2.0
+GRPC_LICENSE_FILES = LICENSE
+
+GRPC_INSTALL_STAGING = YES
+
+# Need to use host grpc_cpp_plugin during cross compilation.
+GRPC_DEPENDENCIES = c-ares host-grpc openssl protobuf zlib
+HOST_GRPC_DEPENDENCIES = host-c-ares host-openssl host-protobuf host-zlib
+
+GRPC_CONF_OPTS = \
+         -D_gRPC_CARES_LIBRARIES=cares \
+         -DgRPC_CARES_PROVIDER=none \
+         -DgRPC_PROTOBUF_PROVIDER=package \
+         -DgRPC_SSL_PROVIDER=package \
+         -DgRPC_ZLIB_PROVIDER=package \
+         -DgRPC_NATIVE_CPP_PLUGIN=$(HOST_DIR)/bin/grpc_cpp_plugin
+
+HOST_GRPC_CONF_OPTS = \
+         -D_gRPC_CARES_LIBRARIES=cares \
+         -DgRPC_CARES_PROVIDER=none \
+         -DgRPC_CARES_PROVIDER=none \
+         -DgRPC_PROTOBUF_PROVIDER=package \
+         -DgRPC_SSL_PROVIDER=package \
+         -DgRPC_ZLIB_PROVIDER=package
+
+$(eval $(cmake-package))
+$(eval $(host-cmake-package))

Signature · 1 line

2.20.0.rc0.387.gc7a69e6b6c-goog

Thomas Petazzoni

2018-11-29 21:12 UTC #2 lore raw

PATCH v4 2/2 grpc: new package

Hello,

Quoted 13 lines · Robert Rose

Signed-off-by Robert Rose <[email protected]>

---
 DEVELOPERS                                    |  3 ++
 package/Config.in                             |  1 +
 .../0001-target-build-using-host-plugin.patch | 44 +++++++++++++++++++
 package/grpc/Config.in                        | 11 +++++
 package/grpc/grpc.hash                        |  5 +++
 package/grpc/grpc.mk                          | 36 +++++++++++++++
 6 files changed, 100 insertions(+)
 create mode 100644 package/grpc/0001-target-build-using-host-plugin.patch
 create mode 100644 package/grpc/Config.in
 create mode 100644 package/grpc/grpc.hash
 create mode 100644 package/grpc/grpc.mk

Thanks for this new iteration. However, it's a pity that you didn't reuse any of the improvements I had, and which I suggested you to re-use for your next iteration.

So, I redid the same changes, and also improved the description of 0001-target-build-using-host-plugin.patch which was really not sufficient.

Here is the list of changes I did:

[Thomas:
- add missing Config.in dependencies inherited from BR2_PACKAGE_PROTOBUF, as well as the corresponding Config.in comment
- replace spaces by tabs in grpc.mk indentation
- remove superfluous GRPC_SOURCE variable
- improved patch description.]

After those changes, I applied this patch to next. Thanks for your contribution!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Yann E. MORIN

2018-12-03 16:00 UTC #3 lore raw

PATCH v4 2/2 grpc: new package

Robert, Thomas, All,

On 2018-11-29 22:12 +0100, Thomas Petazzoni spake thusly:

Quoted 25 lines · Robert Rose

Quoted 13 lines
Signed-off-by Robert Rose <[email protected]>
---
 DEVELOPERS                                    |  3 ++
 package/Config.in                             |  1 +
 .../0001-target-build-using-host-plugin.patch | 44 +++++++++++++++++++
 package/grpc/Config.in                        | 11 +++++
 package/grpc/grpc.hash                        |  5 +++
 package/grpc/grpc.mk                          | 36 +++++++++++++++
 6 files changed, 100 insertions(+)
 create mode 100644 package/grpc/0001-target-build-using-host-plugin.patch
 create mode 100644 package/grpc/Config.in
 create mode 100644 package/grpc/grpc.hash
 create mode 100644 package/grpc/grpc.mk
Thanks for this new iteration. However, it's a pity that you didn't reuse any of the improvements I had, and which I suggested you to re-use for your next iteration.
So, I redid the same changes, and also improved the description of 0001-target-build-using-host-plugin.patch which was really not sufficient.
Here is the list of changes I did:

Quoted 7 lines

[Thomas:
- add missing Config.in dependencies inherited from BR2_PACKAGE_PROTOBUF, as well as the corresponding Config.in comment
- replace spaces by tabs in grpc.mk indentation
- remove superfluous GRPC_SOURCE variable
- improved patch description.]

Itr also seems that grpc would somehow need gflags:

CMake Warning at cmake/gflags.cmake:26 (message):
gRPC_GFLAGS_PROVIDER is "module" but GFLAGS_ROOT_DIR is wrong

That's because the built-in copy of gflags is missing (good!) as it is managed by a git submodule, and those are not retrieved when using the github macro (good!). So, maybe extend HOST_GRPC_CONF_OPTS with:

gRPC_GFLAGS_PROVIDER=none

Alternatively, you could make the existing gflags package a host package, and use that?

Additionally, there is a similar issue with the 'benchmark' package:

CMake Warning at cmake/benchmark.cmake:26 (message):
gRPC_BENCHMARK_PROVIDER is "module" but BENCHMARK_ROOT_DIR is wrong

We don't have a benchmark package in Buildroot, so maybe extend HOST_GRPC_CONF_OPTS with:

gRPC_BENCHMARK_PROVIDER=none

Note that thes two issues should probably be also checked for, and fixed for the target variant of grpc too.

Finally, we do have a bunch of autobuild failures:

    http://autobuild.buildroot.org/?reason=host-grpc-v1.16.1

Care to have a look, please?

Regards,
Yann E. MORIN.

Quoted 12 lines

After those changes, I applied this patch to next. Thanks for your contribution!
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Matthew Weber

2018-12-03 19:34 UTC #4 lore raw

PATCH v4 2/2 grpc: new package

Robert,

Quoted 59 lines · Yann E. MORIN

Robert, Thomas, All,
On 2018-11-29 22:12 +0100, Thomas Petazzoni spake thusly:
Quoted 25 lines · Robert Rose
Quoted 13 lines
Signed-off-by Robert Rose <[email protected]>
---
 DEVELOPERS                                    |  3 ++
 package/Config.in                             |  1 +
 .../0001-target-build-using-host-plugin.patch | 44 +++++++++++++++++++
 package/grpc/Config.in                        | 11 +++++
 package/grpc/grpc.hash                        |  5 +++
 package/grpc/grpc.mk                          | 36 +++++++++++++++
 6 files changed, 100 insertions(+)
 create mode 100644 package/grpc/0001-target-build-using-host-plugin.patch
 create mode 100644 package/grpc/Config.in
 create mode 100644 package/grpc/grpc.hash
 create mode 100644 package/grpc/grpc.mk
Thanks for this new iteration. However, it's a pity that you didn't reuse any of the improvements I had, and which I suggested you to re-use for your next iteration.
So, I redid the same changes, and also improved the description of 0001-target-build-using-host-plugin.patch which was really not sufficient.
Here is the list of changes I did:
Quoted 7 lines
[Thomas:
- add missing Config.in dependencies inherited from BR2_PACKAGE_PROTOBUF, as well as the corresponding Config.in comment
- replace spaces by tabs in grpc.mk indentation
- remove superfluous GRPC_SOURCE variable
- improved patch description.]
Itr also seems that grpc would somehow need gflags:
CMake Warning at cmake/gflags.cmake:26 (message):
gRPC_GFLAGS_PROVIDER is "module" but GFLAGS_ROOT_DIR is wrong
That's because the built-in copy of gflags is missing (good!) as it is managed by a git submodule, and those are not retrieved when using the github macro (good!). So, maybe extend HOST_GRPC_CONF_OPTS with:
gRPC_GFLAGS_PROVIDER=none
Alternatively, you could make the existing gflags package a host package, and use that?
Additionally, there is a similar issue with the 'benchmark' package:
CMake Warning at cmake/benchmark.cmake:26 (message):
gRPC_BENCHMARK_PROVIDER is "module" but BENCHMARK_ROOT_DIR is wrong
We don't have a benchmark package in Buildroot, so maybe extend HOST_GRPC_CONF_OPTS with:

Quoted 9 lines

gRPC_BENCHMARK_PROVIDER=none
Note that thes two issues should probably be also checked for, and fixed for the target variant of grpc too.
Finally, we do have a bunch of autobuild failures:
    http://autobuild.buildroot.org/?reason=host-grpc-v1.16.1

I was able to reproduce this in a non-sandboxed environment and it looks like the "grpc_cpp_plugin" app is outputting that error, not the 'protoc' part of the command.

Output
----------------------
terminate called after throwing an instance of 'std::system_error'
what(): Unknown error -1
Aborted (core dumped)

A quick strace and gdb run didn't get me much further. It looks like the libstdc++ is maybe having a memory allocation issue but I'll have to work on getting more debug symbols (sort of a messy point to debug when between host machine and buildroot host package builds).

Matt

Thomas Petazzoni

Applied

2018-11-29 21:10 UTC #5 lore raw

PATCH v4 1/2 c-ares: support host build

In reply to Robert Rose

Hello,

Quoted 4 lines · Robert Rose

Signed-off-by Robert Rose <[email protected]>
---
 package/c-ares/c-ares.mk | 1 +
 1 file changed, 1 insertion(+)

Applied to next after extending the commit log, and re-adding Arnout Acked-by.

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com