[PATCH 1/2] drm/i915/backlight: Restore backlight on resume

Maarten Lankhorst

author

2018-11-29 12:42 UTC #0 lore raw

PATCH 1/2 drm/i915/backlight: Restore backlight on resume

Restore our saved values for backlight. This way even with fastset on S4 resume we will correctly restore the backlight to the active values.

Signed-off-by Maarten Lankhorst <[email protected]>

Cc Tolga Cakir <[email protected]>

Cc Basil Eric Rabi <[email protected]>

Cc Hans de Goede <[email protected]>

Cc Ville Syrjälä <[email protected]>

Reported-by Ville Syrjälä <[email protected]>

---
 drivers/gpu/drm/i915/intel_display.c |  2 ++
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_panel.c   | 29 ++++++++++++++++++++++++++++
 3 files changed, 32 insertions(+)

drivers/gpu/drm/i915/intel_display.c +2 -0

index d07fa4456150..3faccfcd39a8 100644
@@ -15844,7 +15844,9 @@ void intel_display_resume(struct drm_device *dev)
 	if (!ret)
 		ret = __intel_display_resume(dev, state, &ctx);
 
+	intel_panel_restore_backlight(dev_priv);
 	intel_enable_ipc(dev_priv);
+
 	drm_modeset_drop_locks(&ctx);
 	drm_modeset_acquire_fini(&ctx);

drivers/gpu/drm/i915/intel_drv.h +1 -0

index 40edb21087a7..e2c10acd7bc8 100644
@@ -1983,6 +1983,7 @@ int intel_panel_init(struct intel_panel *panel,
 		     struct drm_display_mode *fixed_mode,
 		     struct drm_display_mode *downclock_mode);
 void intel_panel_fini(struct intel_panel *panel);
+void intel_panel_restore_backlight(struct drm_i915_private *dev_priv);
 void intel_fixed_panel_mode(const struct drm_display_mode *fixed_mode,
 			    struct drm_display_mode *adjusted_mode);
 void intel_pch_panel_fitting(struct intel_crtc *crtc,

drivers/gpu/drm/i915/intel_panel.c +29 -0

index e6cd7b55c018..39b9717ac36a 100644
@@ -1903,6 +1903,35 @@ intel_panel_init_backlight_funcs(struct intel_panel *panel)
 	}
 }
 
+void intel_panel_restore_backlight(struct drm_i915_private *dev_priv)
+{
+	struct intel_connector *connector;
+	struct drm_connector_list_iter conn_iter;
+
+	/* Kill all the work that may have been queued by hpd. */
+	drm_connector_list_iter_begin(&dev_priv->drm, &conn_iter);
+	for_each_intel_connector_iter(connector, &conn_iter) {
+		struct intel_panel *panel = &connector->panel;
+		const struct drm_connector_state *conn_state =
+			connector->base.state;
+
+		if (!panel->backlight.present)
+			continue;
+
+		if (panel->backlight.enabled && conn_state->crtc) {
+			const struct intel_crtc_state *crtc_state =
+				to_intel_crtc_state(conn_state->crtc->state);
+
+			intel_panel_enable_backlight(crtc_state, conn_state);
+		} else {
+			WARN(panel->backlight.enabled, "Backlight enabled without crtc\n");
+
+			intel_panel_disable_backlight(conn_state);
+		}
+	}
+	drm_connector_list_iter_end(&conn_iter);
+}
+
 int intel_panel_init(struct intel_panel *panel,
 		     struct drm_display_mode *fixed_mode,
 		     struct drm_display_mode *downclock_mode)

Signature · 6 lines

2.19.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Maarten Lankhorst

author

2018-11-29 12:42 UTC #1 lore raw

PATCH 2/2 drm/i915/backlight: Fix backlight takeover on LPT, v2.

On lynxpoint the bios sometimes sets up the backlight using the CPU display, but the driver expects using the PWM PCH override register.

Read the value from the CPU register, then convert it to the other units by converting from the old duty cycle, to freq, to the new units.

This value is then programmed in the override register, after which we set the override and disable the CPU display control. This allows us to switch the source without flickering, and make the backlight controls work in the driver.

Changes since v1:
- Read BLC_PWM_CPU_CTL2 to cpu_ctl2.
- Clean up cpu_mode if slightly.
- Always disable BLM_PWM_ENABLE in cpu_ctl2.

Signed-off-by Maarten Lankhorst <[email protected]>

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108225

Cc Basil Eric Rabi <[email protected]>

Cc Hans de Goede <[email protected]>

Cc Tolga Cakir <[email protected]>

Cc Ville Syrjälä <[email protected]>

Tested-by Tolga Cakir <[email protected]>

---
 drivers/gpu/drm/i915/intel_panel.c | 40 +++++++++++++++++++++++++++---
 1 file changed, 36 insertions(+), 4 deletions(-)

drivers/gpu/drm/i915/intel_panel.c +36 -4

index 39b9717ac36a..49c516e33df6 100644
@@ -1484,8 +1484,8 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	struct intel_panel *panel = &connector->panel;
-	u32 pch_ctl1, pch_ctl2, val;
-	bool alt;
+	u32 cpu_ctl2, pch_ctl1, pch_ctl2, val;
+	bool alt, cpu_mode;
 
 	if (HAS_PCH_LPT(dev_priv))
 		alt = I915_READ(SOUTH_CHICKEN2) & LPT_PWM_GRANULARITY;

@@ -1499,6 +1499,8 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
 	pch_ctl2 = I915_READ(BLC_PWM_PCH_CTL2);
 	panel->backlight.max = pch_ctl2 >> 16;
 
+	cpu_ctl2 = I915_READ(BLC_PWM_CPU_CTL2);
+
 	if (!panel->backlight.max)
 		panel->backlight.max = get_backlight_max_vbt(connector);

@@ -1507,12 +1509,42 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
 
 	panel->backlight.min = get_backlight_min_vbt(connector);
 
-	val = lpt_get_backlight(connector);
+	panel->backlight.enabled = pch_ctl1 & BLM_PCH_PWM_ENABLE;
+
+	cpu_mode = panel->backlight.enabled && HAS_PCH_LPT(dev_priv) &&
+		   !(pch_ctl1 & BLM_PCH_OVERRIDE_ENABLE) &&
+		   (cpu_ctl2 & BLM_PWM_ENABLE);
+	if (cpu_mode) {
+		u32 freq;
+
+		/*
+		 * We're in cpu mode, convert to PCH units.
+		 *
+		 * Convert CPU pwm tick back to hz, back to new PCH units again.
+		 * this is the same formula as pch_hz_to_pwm, but the other way
+		 * around..
+		 */
+		val = pch_get_backlight(connector);
+		freq = DIV_ROUND_CLOSEST(KHz(dev_priv->rawclk_freq), val * 128);
+
+		DRM_DEBUG_KMS("Backlight PCH value: %u, converted to freq %u, converted to lpt units %u, minmax: %u/%u\n",
+			      val, freq, lpt_hz_to_pwm(connector, freq), panel->backlight.min, panel->backlight.max);
+
+		val = lpt_hz_to_pwm(connector, freq);
+	} else
+		val = lpt_get_backlight(connector);
 	val = intel_panel_compute_brightness(connector, val);
 	panel->backlight.level = clamp(val, panel->backlight.min,
 				       panel->backlight.max);
 
-	panel->backlight.enabled = pch_ctl1 & BLM_PCH_PWM_ENABLE;
+	if (cpu_mode) {
+		/* Write converted CPU PWM value to PCH override register */
+		lpt_set_backlight(connector->base.state, panel->backlight.level);
+		I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
+	}
+
+	if (cpu_ctl2 & BLM_PWM_ENABLE)
+		I915_WRITE(BLC_PWM_CPU_CTL2, cpu_ctl2 & ~BLM_PWM_ENABLE);
 
 	return 0;
 }

Signature · 6 lines

2.19.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

CI

2018-11-29 12:51 UTC #2 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/backlight: Restore backlight on resume

In reply to Maarten Lankhorst

== Series Details ==

Series: series starting with [1/2] drm/i915/backlight: Restore backlight on resume
URL : https://patchwork.freedesktop.org/series/53239/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
39d3f7d1a54b drm/i915/backlight: Restore backlight on resume
776b5f4bda9e drm/i915/backlight: Fix backlight takeover on LPT, v2.
-:67: CHECK:BRACES: braces {} should be used on all arms of this statement
#67: FILE: drivers/gpu/drm/i915/intel_panel.c:1517:
+	if (cpu_mode) {
[...]
+	} else
[...]

-:81: WARNING:LONG_LINE: line over 100 characters #81: FILE: drivers/gpu/drm/i915/intel_panel.c:1531:
+ val, freq, lpt_hz_to_pwm(connector, freq), panel->backlight.min, panel->backlight.max);

-:84: CHECK:BRACES: Unbalanced braces around else statement #84: FILE: drivers/gpu/drm/i915/intel_panel.c:1534:
+ } else

total: 0 errors, 1 warnings, 2 checks, 62 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

CI

2018-11-29 12:53 UTC #3 lore raw

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/backlight: Restore backlight on resume

In reply to Maarten Lankhorst

== Series Details ==

Series: series starting with [1/2] drm/i915/backlight: Restore backlight on resume
URL : https://patchwork.freedesktop.org/series/53239/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/backlight: Restore backlight on resume
Okay!

Commit: drm/i915/backlight: Fix backlight takeover on LPT, v2. -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void)

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

CI

2018-11-29 13:08 UTC #4 lore raw

✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/backlight: Restore backlight on resume

In reply to Maarten Lankhorst

== Series Details ==

Series: series starting with [1/2] drm/i915/backlight: Restore backlight on resume
URL : https://patchwork.freedesktop.org/series/53239/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5221 -> Patchwork_10951
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_10951 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10951, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53239/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_10951:

### IGT changes ###

#### Possible regressions ####

* igt@gem_close_race@basic-threads:
- fi-bsw-kefka: PASS -> INCOMPLETE

Known issues
------------

Here are the changes found in Patchwork_10951 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

* {igt@runner@aborted}:
- {fi-icl-y}: NOTRUN -> FAIL [fdo#108070]
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108709]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-ivb-3520m: FAIL [fdo#108880] -> PASS

* igt@gem_mmap@basic-small-bo:
- fi-glk-dsi: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS

* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS

#### Warnings ####

* igt@i915_selftest@live_contexts:
- {fi-icl-u3}: INCOMPLETE [fdo#108315] -> DMESG-FAIL [fdo#108569]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (45 -> 44)
------------------------------

Additional (4): fi-icl-y fi-gdg-551 fi-kbl-8809g fi-pnv-d510
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600

Build changes
-------------

* Linux: CI_DRM_5221 -> Patchwork_10951

CI_DRM_5221: 4c3e98f6787fab0ce3c5d20d25ebd538dfe234af @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10951: 776b5f4bda9e64f0378ba336b64cb168ac360478 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

776b5f4bda9e drm/i915/backlight: Fix backlight takeover on LPT, v2. 39d3f7d1a54b drm/i915/backlight: Restore backlight on resume

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10951/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

CI

2018-11-29 13:51 UTC #5 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)

In reply to Maarten Lankhorst

== Series Details ==

Series: series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)
URL : https://patchwork.freedesktop.org/series/53239/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
65214d12d27f drm/i915/backlight: Restore backlight on resume
bbcaa34deb24 drm/i915/backlight: Fix backlight takeover on LPT, v2.
-:67: CHECK:BRACES: braces {} should be used on all arms of this statement
#67: FILE: drivers/gpu/drm/i915/intel_panel.c:1517:
+	if (cpu_mode) {
[...]
+	} else
[...]

-:81: WARNING:LONG_LINE: line over 100 characters #81: FILE: drivers/gpu/drm/i915/intel_panel.c:1531:
+ val, freq, lpt_hz_to_pwm(connector, freq), panel->backlight.min, panel->backlight.max);

-:84: CHECK:BRACES: Unbalanced braces around else statement #84: FILE: drivers/gpu/drm/i915/intel_panel.c:1534:
+ } else

total: 0 errors, 1 warnings, 2 checks, 62 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

CI

2018-11-29 13:53 UTC #6 lore raw

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)

In reply to Maarten Lankhorst

== Series Details ==

Series: series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)
URL : https://patchwork.freedesktop.org/series/53239/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/backlight: Restore backlight on resume
Okay!

Commit: drm/i915/backlight: Fix backlight takeover on LPT, v2. -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1512:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1537:34: warning: expression using sizeof(void)

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

CI

2018-11-29 14:08 UTC #7 lore raw

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)

In reply to Maarten Lankhorst

== Series Details ==

Series: series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)
URL : https://patchwork.freedesktop.org/series/53239/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5222 -> Patchwork_10953
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53239/revisions/2/mbox/

Known issues
------------

Here are the changes found in Patchwork_10953 that come from known issues:

### IGT changes ###

#### Issues hit ####

* {igt@runner@aborted}:
- {fi-icl-y}: NOTRUN -> FAIL [fdo#108070]

#### Possible fixes ####

* igt@gem_mmap_gtt@basic:
- fi-glk-dsi: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (49 -> 44)
------------------------------

Additional (1): fi-icl-y
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600

Build changes
-------------

* Linux: CI_DRM_5222 -> Patchwork_10953

CI_DRM_5222: a6f85043a0ca86eb0072e69bf92b77f7d9d6d5d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10953: bbcaa34deb2437826b94f61b7fa80d81df2137c0 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

bbcaa34deb24 drm/i915/backlight: Fix backlight takeover on LPT, v2. 65214d12d27f drm/i915/backlight: Restore backlight on resume

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10953/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

CI

2018-11-30 01:21 UTC #8 lore raw

✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)

In reply to Maarten Lankhorst

== Series Details ==

Series: series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)
URL : https://patchwork.freedesktop.org/series/53239/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5222_full -> Patchwork_10953_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_10953_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_schedule@pi-ringfull-blt:
- shard-skl: NOTRUN -> FAIL [fdo#103158]

* igt@gem_exec_whisper@normal:
- shard-skl: PASS -> TIMEOUT [fdo#108592]

* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +2

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-apl: PASS -> DMESG-WARN [fdo#107956]

* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-glk: PASS -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232] +2

* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107882]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- {shard-iclb}: PASS -> FAIL [fdo#103167] +1

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: PASS -> FAIL [fdo#103167]

* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-skl: PASS -> FAIL [fdo#105682] +2

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
- shard-skl: PASS -> FAIL [fdo#103167]

* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1

* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166]

* igt@kms_setmode@basic:
- shard-skl: NOTRUN -> FAIL [fdo#99912]

* igt@pm_backlight@fade_with_suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107847]

* igt@pm_rpm@basic-rte:
- shard-skl: PASS -> INCOMPLETE [fdo#107807] +1

* igt@pm_rpm@system-suspend-execbuf:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107807]

* igt@syncobj_wait@multi-wait-for-submit-unsubmitted-signaled:
- shard-snb: PASS -> INCOMPLETE [fdo#105411] / [fdo#107469]

#### Possible fixes ####

* igt@kms_color@pipe-b-degamma:
- shard-apl: FAIL [fdo#104782] -> PASS

* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: FAIL [fdo#103232] -> PASS +2

* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1

* igt@kms_cursor_crc@cursor-128x42-random:
- shard-glk: FAIL [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-256x256-offscreen:
- shard-skl: FAIL [fdo#103232] -> PASS

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-xtiled:
- shard-skl: FAIL [fdo#107791] -> PASS

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: FAIL [fdo#105363] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +1

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen:
- {shard-iclb}: FAIL [fdo#103167] -> PASS

* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS

* igt@kms_psr@suspend:
- {shard-iclb}: INCOMPLETE [fdo#107713] -> PASS

* igt@pm_rpm@legacy-planes:
- shard-skl: INCOMPLETE [fdo#105959] / [fdo#107807] -> PASS

#### Warnings ####

* igt@i915_suspend@shrink:
- shard-skl: INCOMPLETE [fdo#106886] -> DMESG-WARN [fdo#108784]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_5222 -> Patchwork_10953

CI_DRM_5222: a6f85043a0ca86eb0072e69bf92b77f7d9d6d5d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10953: bbcaa34deb2437826b94f61b7fa80d81df2137c0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10953/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx