Skip to contentSkip to conversation

sysctl: clean up nr_pdflush_threads leftover

PATCH Superseded Rafael Aquini 2 participants 3 messages Nov 28, 2018 – Nov 29, 2018 Memory management

lore
Share & tools
lore

Rafael Aquini

author
#0 lore raw

PATCH 1/1 sysctl: clean up nr_pdflush_threads leftover

nr_pdflush_threads has been long deprecated and removed, but a remnant of its glorious past is still around in CTL_VM names enum. This patch is a minor clean-up to that case.

Signed-off-by Rafael Aquini <[email protected]>
---
 include/uapi/linux/sysctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/sysctl.h +1 -1
index d71013fffaf6..dad5a8f93343 100644
@@ -174,7 +174,7 @@ enum
 	VM_DIRTY_RATIO=12,	/* dirty_ratio */
 	VM_DIRTY_WB_CS=13,	/* dirty_writeback_centisecs */
 	VM_DIRTY_EXPIRE_CS=14,	/* dirty_expire_centisecs */
-	VM_NR_PDFLUSH_THREADS=15, /* nr_pdflush_threads */
+	VM_UNUSED15=15,		/* was: int nr_pdflush_threads */
 	VM_OVERCOMMIT_RATIO=16, /* percent of RAM to allow overcommit in */
 	VM_PAGEBUF=17,		/* struct: Control pagebuf parameters */
 	VM_HUGETLB_PAGES=18,	/* int: Number of available Huge Pages */
Signature · 1 line
2.17.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 30 lines · Rafael Aquini

nr_pdflush_threads has been long deprecated and removed, but a remnant of its glorious past is still around in CTL_VM names enum. This patch is a minor clean-up to that case.

Signed-off-by Rafael Aquini <[email protected]>

---
include/uapi/linux/sysctl.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/sysctl.h +1 -1
index d71013fffaf6..dad5a8f93343 100644
@@ -174,7 +174,7 @@ enum
 	VM_DIRTY_RATIO=12,	/* dirty_ratio */
 	VM_DIRTY_WB_CS=13,	/* dirty_writeback_centisecs */
 	VM_DIRTY_EXPIRE_CS=14,	/* dirty_expire_centisecs */
-	VM_NR_PDFLUSH_THREADS=15, /* nr_pdflush_threads */
+	VM_UNUSED15=15,		/* was: int nr_pdflush_threads */
 	VM_OVERCOMMIT_RATIO=16, /* percent of RAM to allow overcommit in */
 	VM_PAGEBUF=17,		/* struct: Control pagebuf parameters */
 	VM_HUGETLB_PAGES=18,	/* int: Number of available Huge Pages */
Signature · 1 line
2.17.2

Please reword the comment to add a colon after the word "int" to match earlier comments in the enum:

+ VM_UNUSED15=15, /* was: int: nr_pdflush_threads */

Also, as long as you're changing this file, please fix the typo earlier in the same enum:

- VM_UNUSED2=2, /* was; int: Linear or sqrt() swapout for hogs */
+ VM_UNUSED2=2, /* was: int: Linear or sqrt() swapout for hogs */

Reviewed-by William Kucharski <[email protected]>
author
#2 lore raw

PATCH v2 1/1 sysctl: clean up nr_pdflush_threads leftover

In reply to Rafael Aquini

nr_pdflush_threads has been long deprecated and
removed, but a remnant of its glorious past is
still around in CTL_VM names enum. This patch
is a minor clean-up to that case.

Reviewed-by William Kucharski <[email protected]>
Signed-off-by Rafael Aquini <[email protected]>

---
v2:
- adjust typo "was;" for VM_UNUSED2 comment [wkucharski]
- add colon after "int" for VM_UNUSED15 comment [wkucharski]

 include/uapi/linux/sysctl.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/uapi/linux/sysctl.h +2 -2
index d71013fffaf6..9df59925ed55 100644
@@ -161,7 +161,7 @@ enum
 enum
 {
 	VM_UNUSED1=1,		/* was: struct: Set vm swapping control */
-	VM_UNUSED2=2,		/* was; int: Linear or sqrt() swapout for hogs */
+	VM_UNUSED2=2,		/* was: int: Linear or sqrt() swapout for hogs */
 	VM_UNUSED3=3,		/* was: struct: Set free page thresholds */
 	VM_UNUSED4=4,		/* Spare */
 	VM_OVERCOMMIT_MEMORY=5,	/* Turn off the virtual memory safety limit */

@@ -174,7 +174,7 @@ enum
 	VM_DIRTY_RATIO=12,	/* dirty_ratio */
 	VM_DIRTY_WB_CS=13,	/* dirty_writeback_centisecs */
 	VM_DIRTY_EXPIRE_CS=14,	/* dirty_expire_centisecs */
-	VM_NR_PDFLUSH_THREADS=15, /* nr_pdflush_threads */
+	VM_UNUSED15=15,		/* was: int: nr_pdflush_threads */
 	VM_OVERCOMMIT_RATIO=16, /* percent of RAM to allow overcommit in */
 	VM_PAGEBUF=17,		/* struct: Control pagebuf parameters */
 	VM_HUGETLB_PAGES=18,	/* int: Number of available Huge Pages */
Signature · 1 line
2.17.2