dts: am335x-pdu001: Fix polarity of card detection input
PATCH 1/1 dts: am335x-pdu001: Fix polarity of card detection input
When a micro SD card is inserted in the PDU001 card cage, the card detection switch is opened and the corresponding GPIO input is driven by a pull-up. Hence change the active level of the card detection input from low to high.
---
arch/arm/dts/am335x-pdu001.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/am335x-pdu001.dts +1 -1
@@ -576,7 +576,7 @@ bus-width = <4>; pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>; - cd-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; + cd-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; }; &sham {
Signature · 1 line
2.17.1
PATCH 1/1 dts: am335x-pdu001: Fix polarity of card detection input
Quoted 16 lines · Felix Brack
When a micro SD card is inserted in the PDU001 card cage, the card detection switch is opened and the corresponding GPIO input is driven by a pull-up. Hence change the active level of the card detection input from low to high.
Signed-off-by Felix Brack <[email protected]>---
arch/arm/dts/am335x-pdu001.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/am335x-pdu001.dts +0
-0
arch/arm/dts/am335x-pdu001.dts line 582
Quoted 8 lines
arch/arm/dts/am335x-pdu001.dts +1
-1@@ -576,7 +576,7 @@ bus-width = <4>; pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>; - cd-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; + cd-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; }; &sham {
Is this in upstream Linux as well? If so what tag/hash? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181129/221c2da6/attachment.sig>
PATCH 1/1 dts: am335x-pdu001: Fix polarity of card detection input
Quoted 25 lines · Tom Rini
Quoted 23 lines · Felix Brack
When a micro SD card is inserted in the PDU001 card cage, the card detection switch is opened and the corresponding GPIO input is driven by a pull-up. Hence change the active level of the card detection input from low to high.
Signed-off-by Felix Brack <[email protected]>---
arch/arm/dts/am335x-pdu001.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/am335x-pdu001.dts +1
-1@@ -576,7 +576,7 @@ bus-width = <4>; pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>; - cd-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; + cd-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; };
Quoted 4 lines
arch/arm/dts/am335x-pdu001.dts line 582
Quoted 1 line
arch/arm/dts/am335x-pdu001.dts +0
-0&sham {Is this in upstream Linux as well? If so what tag/hash? Thanks!
Not yet. I will send the Linux patch within a few days. The fix appears for U-Boot first as it is required for the upcoming patch that enables CONFIG_BLK and CONFIG_DM_MMC for this board.
regards, Felix
PATCH 1/1 dts: am335x-pdu001: Fix polarity of card detection input
Quoted 26 lines · Felix Brack
Quoted 25 lines · Tom Rini
Quoted 23 lines · Felix Brack
When a micro SD card is inserted in the PDU001 card cage, the card detection switch is opened and the corresponding GPIO input is driven by a pull-up. Hence change the active level of the card detection input from low to high.
Signed-off-by Felix Brack <[email protected]>---
arch/arm/dts/am335x-pdu001.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/am335x-pdu001.dts +1
-1@@ -576,7 +576,7 @@ bus-width = <4>; pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>; - cd-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; + cd-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; };
Quoted 7 lines
Quoted 4 lines
arch/arm/dts/am335x-pdu001.dts line 582
Quoted 1 line
arch/arm/dts/am335x-pdu001.dts +0
-0&sham {Is this in upstream Linux as well? If so what tag/hash? Thanks!
Not yet. I will send the Linux patch within a few days. The fix appears for U-Boot first as it is required for the upcoming patch that enables
CONFIG_BLKandCONFIG_DM_MMCfor this board.
Please reply to the thread with a ML link there so we can track and make sure it doesn't get out of sync, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181129/a5b54f79/attachment.sig>
PATCH 1/1 dts: am335x-pdu001: Fix polarity of card detection input
Quoted 31 lines · Tom Rini
Quoted 30 lines · Felix Brack
Quoted 29 lines · Tom Rini
Quoted 16 lines · Felix Brack
When a micro SD card is inserted in the PDU001 card cage, the card detection switch is opened and the corresponding GPIO input is driven by a pull-up. Hence change the active level of the card detection input from low to high.
Signed-off-by Felix Brack <[email protected]>---
arch/arm/dts/am335x-pdu001.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/am335x-pdu001.dts +0
-0arch/arm/dts/am335x-pdu001.dts line 582
Quoted 8 lines
arch/arm/dts/am335x-pdu001.dts +1
-1@@ -576,7 +576,7 @@ bus-width = <4>; pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>; - cd-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; + cd-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; }; &sham {Is this in upstream Linux as well? If so what tag/hash? Thanks!
Quoted 7 lines
Quoted 3 lines
Not yet. I will send the Linux patch within a few days. The fix appears for U-Boot first as it is required for the upcoming patch that enables
CONFIG_BLKandCONFIG_DM_MMCfor this board.Please reply to the thread with a ML link there so we can track and make sure it doesn't get out of sync, thanks!
I'm not sure if I got that correctly. What is an 'ML link'?
Was there something wrong with my last post or would you like me to post a message in this thread once the patch is in upstream Linux?
Felix
PATCH 1/1 dts: am335x-pdu001: Fix polarity of card detection input
Quoted 36 lines · Felix Brack
Quoted 35 lines · Tom Rini
Quoted 33 lines · Felix Brack
Quoted 25 lines · Tom Rini
Quoted 23 lines · Felix Brack
When a micro SD card is inserted in the PDU001 card cage, the card detection switch is opened and the corresponding GPIO input is driven by a pull-up. Hence change the active level of the card detection input from low to high.
Signed-off-by Felix Brack <[email protected]>---
arch/arm/dts/am335x-pdu001.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/am335x-pdu001.dts +1
-1@@ -576,7 +576,7 @@ bus-width = <4>; pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>; - cd-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; + cd-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; };Quoted 4 lines
arch/arm/dts/am335x-pdu001.dts line 582
Quoted 1 line
arch/arm/dts/am335x-pdu001.dts +0
-0&sham {Is this in upstream Linux as well? If so what tag/hash? Thanks!
Not yet. I will send the Linux patch within a few days. The fix appears for U-Boot first as it is required for the upcoming patch that enables
CONFIG_BLKandCONFIG_DM_MMCfor this board.
Quoted 5 lines
Quoted 3 lines
Please reply to the thread with a ML link there so we can track and make sure it doesn't get out of sync, thanks!
I'm not sure if I got that correctly. What is an 'ML link'?Was there something wrong with my last post or would you like me to post a message in this thread once the patch is in upstream Linux?
The general preference is that when we touch the dts files that aren't U-Boot centric the commit message references the Linux githash/tag it's taken from, for easier future re-syncs. Since you're in progress on fixing this in Linux too, you can just reply here so it's at least tracked on the ML and archives that the change _is_ going upstream so we aren't likely to overwrite it by accident later (and since you'd be the one pushing a future re-sync, you'd also notice, so it's really not likely to happen). Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181129/cf106c3f/attachment.sig>
PATCH 1/1 dts: am335x-pdu001: Fix polarity of card detection input
Hi Tom,
Quoted 43 lines · Tom Rini
Quoted 36 lines · Felix Brack
Quoted 35 lines · Tom Rini
Quoted 33 lines · Felix Brack
Quoted 25 lines · Tom Rini
Quoted 23 lines · Felix Brack
When a micro SD card is inserted in the PDU001 card cage, the card detection switch is opened and the corresponding GPIO input is driven by a pull-up. Hence change the active level of the card detection input from low to high.
Signed-off-by Felix Brack <[email protected]>---
arch/arm/dts/am335x-pdu001.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/am335x-pdu001.dts +1
-1@@ -576,7 +576,7 @@ bus-width = <4>; pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>; - cd-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; + cd-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; };Quoted 4 lines
arch/arm/dts/am335x-pdu001.dts line 582
Quoted 1 line
arch/arm/dts/am335x-pdu001.dts +0
-0&sham {Is this in upstream Linux as well? If so what tag/hash? Thanks!
Not yet. I will send the Linux patch within a few days. The fix appears for U-Boot first as it is required for the upcoming patch that enables
CONFIG_BLKandCONFIG_DM_MMCfor this board.Quoted 5 lines
Quoted 3 lines
Please reply to the thread with a ML link there so we can track and make sure it doesn't get out of sync, thanks!
I'm not sure if I got that correctly. What is an 'ML link'?Was there something wrong with my last post or would you like me to post a message in this thread once the patch is in upstream Linux?
Quoted 9 lines
The general preference is that when we touch the dts files that aren't U-Boot centric the commit message references the Linux githash/tag it's taken from, for easier future re-syncs. Since you're in progress on fixing this in Linux too, you can just reply here so it's at least tracked on the ML and archives that the change _is_ going upstream so we aren't likely to overwrite it by accident later (and since you'd be the one pushing a future re-sync, you'd also notice, so it's really not likely to happen). Thanks!
FYI: with patch https://patchwork.ozlabs.org/patch/1026522/ DTS for this board is now in identical in U-Boot and Linux.
regards Felix
PATCH 1/1 dts: am335x-pdu001: Fix polarity of card detection input
Quoted 56 lines · Felix Brack
Hi Tom,
Quoted 43 lines · Tom Rini
Quoted 36 lines · Felix Brack
Quoted 35 lines · Tom Rini
Quoted 33 lines · Felix Brack
Quoted 25 lines · Tom Rini
Quoted 23 lines · Felix Brack
When a micro SD card is inserted in the PDU001 card cage, the card detection switch is opened and the corresponding GPIO input is driven by a pull-up. Hence change the active level of the card detection input from low to high.
Signed-off-by Felix Brack <[email protected]>---
arch/arm/dts/am335x-pdu001.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/am335x-pdu001.dts +1
-1@@ -576,7 +576,7 @@ bus-width = <4>; pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>; - cd-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; + cd-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; };Quoted 4 lines
arch/arm/dts/am335x-pdu001.dts line 582
Quoted 1 line
arch/arm/dts/am335x-pdu001.dts +0
-0&sham {Is this in upstream Linux as well? If so what tag/hash? Thanks!
Not yet. I will send the Linux patch within a few days. The fix appears for U-Boot first as it is required for the upcoming patch that enables
CONFIG_BLKandCONFIG_DM_MMCfor this board.Quoted 5 lines
Quoted 3 lines
Please reply to the thread with a ML link there so we can track and make sure it doesn't get out of sync, thanks!
I'm not sure if I got that correctly. What is an 'ML link'?Was there something wrong with my last post or would you like me to post a message in this thread once the patch is in upstream Linux?
Quoted 9 lines
The general preference is that when we touch the dts files that aren't U-Boot centric the commit message references the Linux githash/tag it's taken from, for easier future re-syncs. Since you're in progress on fixing this in Linux too, you can just reply here so it's at least tracked on the ML and archives that the change _is_ going upstream so we aren't likely to overwrite it by accident later (and since you'd be the one pushing a future re-sync, you'd also notice, so it's really not likely to happen). Thanks!
Quoted 2 lines
FYI: with patch https://patchwork.ozlabs.org/patch/1026522/ DTS for this board is now in identical in U-Boot and Linux.
Thanks for the follow-up!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190117/44180077/attachment.sig>
Quoted 6 lines · Felix Brack
When a micro SD card is inserted in the PDU001 card cage, the card detection switch is opened and the corresponding GPIO input is driven by a pull-up. Hence change the active level of the card detection input from low to high.
Signed-off-by Felix Brack <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181207/f7b179ec/attachment.sig>