Skip to contentSkip to conversation

perl-time-hires: remove it

PATCH New Francois Perrad 3 participants 5 messages Nov 22, 2018 – Nov 29, 2018

lore
Share & tools
lore

Francois Perrad

author
#0 lore raw

PATCH 1/1 perl-time-hires: remove it

this is a core module (ie. included in the Perl distribution)

Signed-off-by Francois Perrad <[email protected]>
---
 DEVELOPERS                                   |  1 -
 package/Config.in                            |  1 -
 package/perl-time-hires/Config.in            | 10 ----------
 package/perl-time-hires/perl-time-hires.hash |  6 ------
 package/perl-time-hires/perl-time-hires.mk   | 14 --------------
 5 files changed, 32 deletions(-)
 delete mode 100644 package/perl-time-hires/Config.in
 delete mode 100644 package/perl-time-hires/perl-time-hires.hash
 delete mode 100644 package/perl-time-hires/perl-time-hires.mk
DEVELOPERS +0 -1
index 53467da48..6f687d748 100644
@@ -351,7 +351,6 @@ F:	package/perl-mime-base64/
 F:	package/perl-net-dns/
 F:	package/perl-net-http/
 F:	package/perl-netaddr-ip/
-F:	package/perl-time-hires/
 F:	package/perl-timedate/
 F:	package/perl-uri/
 F:	package/perl-www-robotrules/
package/Config.in +0 -1
index b60e7700a..038ddf6b2 100644
@@ -756,7 +756,6 @@ menu "Perl libraries/modules"
 	source "package/perl-sys-cpu/Config.in"
 	source "package/perl-sys-meminfo/Config.in"
 	source "package/perl-sys-mmap/Config.in"
-	source "package/perl-time-hires/Config.in"
 	source "package/perl-time-parsedate/Config.in"
 	source "package/perl-timedate/Config.in"
 	source "package/perl-try-tiny/Config.in"
package/perl-time-hires/Config.in deleted +0 -10
deleted file mode 100644
index db2ca039c..000000000
@@ -1,10 +0,0 @@
-config BR2_PACKAGE_PERL_TIME_HIRES
-	bool "perl-time-hires"
-	depends on !BR2_STATIC_LIBS
-	help
-	  High resolution alarm, sleep, gettimeofday, interval timers.
-
-	  https://metacpan.org/release/Time-HiRes
-
-comment "perl-time-hires needs a toolchain w/ dynamic library"
-	depends on BR2_STATIC_LIBS
package/perl-time-hires/perl-time-hires.hash deleted +0 -6
deleted file mode 100644
index 426076668..000000000
@@ -1,6 +0,0 @@
-# retrieved by scancpan from http://cpan.metacpan.org/
-md5    8f998cb60966c86e24c500016e4d1ce8 Time-HiRes-1.9758.tar.gz
-sha256 5bfa145bc11e70a8e337543b1084a293743a690691b568493455dedf58f34b1e Time-HiRes-1.9758.tar.gz
-
-# computed by scancpan
-sha256 ecc20782bd6c34d2d632356020f9ad0150c7ae1803ae9560258d76d4533030da README
package/perl-time-hires/perl-time-hires.mk deleted +0 -14
deleted file mode 100644
index 03322c3fb..000000000
@@ -1,14 +0,0 @@
-################################################################################
-#
-# perl-time-hires
-#
-################################################################################
-
-PERL_TIME_HIRES_VERSION = 1.9758
-PERL_TIME_HIRES_SOURCE = Time-HiRes-$(PERL_TIME_HIRES_VERSION).tar.gz
-PERL_TIME_HIRES_SITE = $(BR2_CPAN_MIRROR)/authors/id/J/JH/JHI
-PERL_TIME_HIRES_LICENSE = Artistic or GPL-1.0+
-PERL_TIME_HIRES_LICENSE_FILES = README
-PERL_TIME_HIRES_DISTNAME = Time-HiRes
-
-$(eval $(perl-package))
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 perl-time-hires: remove it

Hello,

Quoted 13 lines · Francois Perrad

this is a core module (ie. included in the Perl distribution)

Signed-off-by Francois Perrad <[email protected]>
---
 DEVELOPERS                                   |  1 -
 package/Config.in                            |  1 -
 package/perl-time-hires/Config.in            | 10 ----------
 package/perl-time-hires/perl-time-hires.hash |  6 ------
 package/perl-time-hires/perl-time-hires.mk   | 14 --------------
 5 files changed, 32 deletions(-)
 delete mode 100644 package/perl-time-hires/Config.in
 delete mode 100644 package/perl-time-hires/perl-time-hires.hash
 delete mode 100644 package/perl-time-hires/perl-time-hires.mk

We need Config.in.legacy handling when removing packages/options. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 perl-time-hires: remove it

Quoted 17 lines · Thomas Petazzoni

Hello,

Quoted 13 lines · Francois Perrad

this is a core module (ie. included in the Perl distribution)

Signed-off-by Francois Perrad <[email protected]>
---
 DEVELOPERS                                   |  1 -
 package/Config.in                            |  1 -
 package/perl-time-hires/Config.in            | 10 ----------
 package/perl-time-hires/perl-time-hires.hash |  6 ------
 package/perl-time-hires/perl-time-hires.mk   | 14 --------------
 5 files changed, 32 deletions(-)
 delete mode 100644 package/perl-time-hires/Config.in
 delete mode 100644 package/perl-time-hires/perl-time-hires.hash
 delete mode 100644 package/perl-time-hires/perl-time-hires.mk
Quoted 1 line

We need Config.in.legacy handling when removing packages/options.

No we don't. Config.in.legacy handling is there to make sure that the user
after upgrading Buildroot still has everything that she had enabled before. In this case, the Time::HiRes module *is* there because it is part of perl. So no legacy handling needed.

Regards,
Arnout

#3 lore raw

PATCH 1/1 perl-time-hires: remove it

Hello,

Quoted 4 lines · Arnout Vandecappelle

No we don't. Config.in.legacy handling is there to make sure that the user
after upgrading Buildroot still has everything that she had enabled before. In this case, the Time::HiRes module *is* there because it is part of perl. So no legacy handling needed.

Indeed, thanks for pointing this out. I've applied the patch as-is.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Applied
#4 lore raw

PATCH 1/1 perl-time-hires: remove it

In reply to Francois Perrad

Hello,

Quoted 13 lines · Francois Perrad

this is a core module (ie. included in the Perl distribution)

Signed-off-by Francois Perrad <[email protected]>
---
 DEVELOPERS                                   |  1 -
 package/Config.in                            |  1 -
 package/perl-time-hires/Config.in            | 10 ----------
 package/perl-time-hires/perl-time-hires.hash |  6 ------
 package/perl-time-hires/perl-time-hires.mk   | 14 --------------
 5 files changed, 32 deletions(-)
 delete mode 100644 package/perl-time-hires/Config.in
 delete mode 100644 package/perl-time-hires/perl-time-hires.hash
 delete mode 100644 package/perl-time-hires/perl-time-hires.mk

Applied to next, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com