drm/i915/icl: Remove Wa_1604302699

PATCH In review Tvrtko Ursulin 3 participants 5 messages Nov 29, 2018 – Nov 30, 2018

Subsystems (2)

DRM drivers Intel i915

lore

Share & tools

lore

Tvrtko Ursulin

author

2018-11-29 13:46 UTC #0 lore raw

PATCH 1/1 drm/i915/icl: Remove Wa_1604302699

From: Tvrtko Ursulin <[email protected]>

It seems that the documentation does not reference this any more, plus, bit 28 does not stick when written to the register.

Therefore I can only assume this is something which was documented in the past but got removed from the hardware in the meantime.

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Mika Kuoppala <[email protected]>

---
 drivers/gpu/drm/i915/intel_workarounds.c | 5 -----
 1 file changed, 5 deletions(-)

drivers/gpu/drm/i915/intel_workarounds.c +0 -5

index 39cd1f823ea9..e5cd6c6c66c3 100644
@@ -882,11 +882,6 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)
 		   I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE) |
 		   GWUNIT_CLKGATE_DIS);
 
-	/* Wa_1604302699:icl */
-	I915_WRITE(GEN10_L3_CHICKEN_MODE_REGISTER,
-		   I915_READ(GEN10_L3_CHICKEN_MODE_REGISTER) |
-		   GEN11_I2M_WRITE_DISABLE);
-
 	/* Wa_1406838659:icl (pre-prod) */
 	if (IS_ICL_REVID(dev_priv, ICL_REVID_A0, ICL_REVID_B0))
 		I915_WRITE(INF_UNIT_LEVEL_CLKGATE,

Signature · 6 lines

2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Mika Kuoppala

Reviewed-by on v1 1/1

2018-11-29 13:57 UTC #1 lore raw

Quoted 10 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>
It seems that the documentation does not reference this any more, plus, bit 28 does not stick when written to the register.
Therefore I can only assume this is something which was documented in the past but got removed from the hardware in the meantime.
Signed-off-by Tvrtko Ursulin <[email protected]>
Cc Mika Kuoppala <[email protected]>

Reviewed-by Mika Kuoppala <[email protected]>

Quoted 22 lines

---
 drivers/gpu/drm/i915/intel_workarounds.c | 5 -----
 1 file changed, 5 deletions(-)

drivers/gpu/drm/i915/intel_workarounds.c +0 -5

index 39cd1f823ea9..e5cd6c6c66c3 100644
@@ -882,11 +882,6 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)
 		   I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE) |
 		   GWUNIT_CLKGATE_DIS);
 
-	/* Wa_1604302699:icl */
-	I915_WRITE(GEN10_L3_CHICKEN_MODE_REGISTER,
-		   I915_READ(GEN10_L3_CHICKEN_MODE_REGISTER) |
-		   GEN11_I2M_WRITE_DISABLE);
-
 	/* Wa_1406838659:icl (pre-prod) */
 	if (IS_ICL_REVID(dev_priv, ICL_REVID_A0, ICL_REVID_B0))
 		I915_WRITE(INF_UNIT_LEVEL_CLKGATE,

Signature · 1 line

2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2018-11-29 14:47 UTC #2 lore raw

✓ Fi.CI.BAT: success for drm/i915/icl: Remove Wa_1604302699

In reply to Tvrtko Ursulin

== Series Details ==

Series: drm/i915/icl: Remove Wa_1604302699
URL : https://patchwork.freedesktop.org/series/53244/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5222 -> Patchwork_10955
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_10955 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10955, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53244/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_10955:

### IGT changes ###

#### Warnings ####

* igt@prime_vgem@basic-fence-flip:
- fi-ivb-3520m: SKIP -> PASS

Known issues
------------

Here are the changes found in Patchwork_10955 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-skl-guc: PASS -> FAIL [fdo#103191] / [fdo#107362]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

#### Possible fixes ####

* igt@gem_mmap_gtt@basic:
- fi-glk-dsi: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS

[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (49 -> 41)
------------------------------

Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510

Build changes
-------------

* Linux: CI_DRM_5222 -> Patchwork_10955

CI_DRM_5222: a6f85043a0ca86eb0072e69bf92b77f7d9d6d5d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10955: 11100b9f61c3f4c893fdd337b2fa733ee3cdce02 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

11100b9f61c3 drm/i915/icl: Remove Wa_1604302699

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10955/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Tvrtko Ursulin

author

2018-11-30 15:10 UTC #3 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915/icl: Remove Wa_1604302699

Quoted 77 lines · Patchwork

== Series Details ==
Series: drm/i915/icl: Remove Wa_1604302699
URL : https://patchwork.freedesktop.org/series/53244/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5222 -> Patchwork_10955
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_10955 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10955, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
   External URL: https://patchwork.freedesktop.org/api/1.0/series/53244/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_10955:
### IGT changes ###
#### Warnings ####
* igt@prime_vgem@basic-fence-flip:
- fi-ivb-3520m: SKIP -> PASS
Known issues
------------
Here are the changes found in Patchwork_10955 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-skl-guc: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
   * igt@gem_mmap_gtt@basic:
     - fi-glk-dsi:         INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS

   
   [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
   [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (49 -> 41)
------------------------------
   Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510
Build changes
-------------
* Linux: CI_DRM_5222 -> Patchwork_10955

Quoted 8 lines

   CI_DRM_5222: a6f85043a0ca86eb0072e69bf92b77f7d9d6d5d5 @ git://anongit.freedesktop.org/gfx-ci/linux
   IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
   Patchwork_10955: 11100b9f61c3f4c893fdd337b2fa733ee3cdce02 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

11100b9f61c3 drm/i915/icl: Remove Wa_1604302699

Pushed, thanks for review!

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2018-11-30 02:11 UTC #4 lore raw

✓ Fi.CI.IGT: success for drm/i915/icl: Remove Wa_1604302699

In reply to Tvrtko Ursulin

== Series Details ==

Series: drm/i915/icl: Remove Wa_1604302699
URL : https://patchwork.freedesktop.org/series/53244/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5222_full -> Patchwork_10955_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_10955_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10955_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_10955_full:

### IGT changes ###

#### Warnings ####

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-snb: PASS -> SKIP

Known issues
------------

Here are the changes found in Patchwork_10955_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_schedule@pi-ringfull-blt:
- shard-skl: NOTRUN -> FAIL [fdo#103158]

* igt@gem_workarounds@suspend-resume:
- shard-apl: PASS -> DMESG-WARN [fdo#108566]

* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +2

* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-skl: PASS -> DMESG-WARN [fdo#107956]

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-apl: PASS -> DMESG-WARN [fdo#107956]

* igt@kms_color@pipe-a-degamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]

* igt@kms_cursor_crc@cursor-256x85-random:
- shard-glk: PASS -> FAIL [fdo#103232] +2

* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-apl: PASS -> FAIL [fdo#103232]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107882]

* igt@kms_flip@blocking-absolute-wf_vblank-interruptible:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363]

* igt@kms_flip_tiling@flip-to-y-tiled:
- shard-skl: PASS -> FAIL [fdo#107931]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167] +2

* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-glk: PASS -> FAIL [fdo#103167] / [fdo#105682]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +1

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
- {shard-iclb}: PASS -> FAIL [fdo#103167] +2

* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: PASS -> FAIL [fdo#108145]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1

* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +6

* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +1

* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +1

* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- {shard-iclb}: PASS -> FAIL [fdo#103166] +2

* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-skl: NOTRUN -> FAIL [fdo#103166] / [fdo#107815]

* igt@kms_setmode@basic:
- shard-skl: NOTRUN -> FAIL [fdo#99912]
- shard-kbl: PASS -> FAIL [fdo#99912]

* igt@pm_backlight@fade_with_suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107847]

* igt@pm_rpm@debugfs-read:
- shard-skl: PASS -> INCOMPLETE [fdo#107807] +1

* igt@syncobj_wait@multi-wait-for-submit-unsubmitted-signaled:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]

#### Possible fixes ####

* igt@gem_ctx_isolation@vecs0-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS

* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- {shard-iclb}: DMESG-WARN [fdo#107724] -> PASS +8

* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- {shard-iclb}: DMESG-WARN [fdo#107956] -> PASS

* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: FAIL [fdo#103232] -> PASS +2

* igt@kms_cursor_crc@cursor-128x42-random:
- shard-glk: FAIL [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-256x256-offscreen:
- shard-skl: FAIL [fdo#103232] -> PASS

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-xtiled:
- shard-skl: FAIL [fdo#107791] -> PASS

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt:
- {shard-iclb}: DMESG-FAIL [fdo#107724] -> PASS +2

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-apl: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- {shard-iclb}: FAIL [fdo#103167] -> PASS +1

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +3

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render:
- {shard-iclb}: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +2

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- {shard-iclb}: DMESG-FAIL [fdo#103166] / [fdo#107724] -> PASS

* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- {shard-iclb}: FAIL [fdo#103166] -> PASS +2

* igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS

* igt@kms_psr@suspend:
- {shard-iclb}: INCOMPLETE [fdo#107713] -> PASS

* igt@pm_rpm@legacy-planes:
- shard-skl: INCOMPLETE [fdo#105959] / [fdo#107807] -> PASS

#### Warnings ####

* igt@i915_selftest@live_contexts:
- {shard-iclb}: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108315]

* igt@i915_suspend@shrink:
- shard-skl: INCOMPLETE [fdo#106886] -> DMESG-WARN [fdo#108784]
- shard-glk: DMESG-WARN [fdo#108784] -> INCOMPLETE [fdo#103359] / [fdo#106886] / [k.org#198133]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_5222 -> Patchwork_10955

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10955/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx