Skip to contentSkip to conversation

drm/i915/selftests: Extract spinner code

PATCH In review Tvrtko Ursulin 3 participants 15 messages Nov 30, 2018 – Dec 1, 2018

Subsystems (2)
DRM drivers Intel i915
lore
Share & tools
lore

Tvrtko Ursulin

author
#0 lore raw

PATCH 1/2 drm/i915/selftests: Extract spinner code

From: Tvrtko Ursulin <[email protected]>

Pull out spinner code to a standalone file to enable it to be shortly used by other and new test cases.

Plain code movement - no functional changes.

Signed-off-by Tvrtko Ursulin <[email protected]>
---
 drivers/gpu/drm/i915/Makefile                |   3 +-
 drivers/gpu/drm/i915/selftests/igt_spinner.c | 199 ++++++++++++
 drivers/gpu/drm/i915/selftests/igt_spinner.h |  37 +++
 drivers/gpu/drm/i915/selftests/intel_lrc.c   | 301 ++++---------------
 4 files changed, 290 insertions(+), 250 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/selftests/igt_spinner.c
 create mode 100644 drivers/gpu/drm/i915/selftests/igt_spinner.h
drivers/gpu/drm/i915/Makefile +2 -1
index 0ff878c994e2..e56370b046b4 100644
@@ -164,7 +164,8 @@ i915-$(CONFIG_DRM_I915_CAPTURE_ERROR) += i915_gpu_error.o
 i915-$(CONFIG_DRM_I915_SELFTEST) += \
 	selftests/i915_random.o \
 	selftests/i915_selftest.o \
-	selftests/igt_flush_test.o
+	selftests/igt_flush_test.o \
+	selftests/igt_spinner.o
 
 # virtual gpu code
 i915-y += i915_vgpu.o
drivers/gpu/drm/i915/selftests/igt_spinner.c new file +199 -0

199 lines not on this page · raw message

drivers/gpu/drm/i915/selftests/igt_spinner.h new file +37 -0
new file mode 100644
index 000000000000..391777c76dc7
@@ -0,0 +1,37 @@
+/*
+ * SPDX-License-Identifier: MIT
+ *
+ * Copyright © 2018 Intel Corporation
+ */
+
+#ifndef __I915_SELFTESTS_IGT_SPINNER_H__
+#define __I915_SELFTESTS_IGT_SPINNER_H__
+
+#include "../i915_selftest.h"
+
+#include "../i915_drv.h"
+#include "../i915_request.h"
+#include "../intel_ringbuffer.h"
+#include "../i915_gem_context.h"
+
+struct igt_spinner {
+	struct drm_i915_private *i915;
+	struct drm_i915_gem_object *hws;
+	struct drm_i915_gem_object *obj;
+	u32 *batch;
+	void *seqno;
+};
+
+int igt_spinner_init(struct igt_spinner *spin, struct drm_i915_private *i915);
+void igt_spinner_fini(struct igt_spinner *spin);
+
+struct i915_request *
+igt_spinner_create_request(struct igt_spinner *spin,
+			   struct i915_gem_context *ctx,
+			   struct intel_engine_cs *engine,
+			   u32 arbitration_command);
+void igt_spinner_end(struct igt_spinner *spin);
+
+bool igt_wait_for_spinner(struct igt_spinner *spin, struct i915_request *rq);
+
+#endif
drivers/gpu/drm/i915/selftests/intel_lrc.c +52 -249

510 lines not on this page · raw message

Signature · 6 lines
2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#1 lore raw

PATCH 2/2 drm/i915/selftests: Fix live_workarounds to actually do resets

From: Tvrtko Ursulin <[email protected]>

The test was missing some magic ingredients to actually trigger the resets.

In case of the full reset we need the I915_RESET_HANDOFF flag set, and in case of engine reset we need a busy request.

Thanks to Chris for helping with reset magic.

Signed-off-by Tvrtko Ursulin <[email protected]>
Cc Chris Wilson <[email protected]>
---
 .../drm/i915/selftests/intel_workarounds.c    | 58 +++++++++++++++----
 1 file changed, 48 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/selftests/intel_workarounds.c +48 -10
index d1a0923d2f38..8e49c005d4db 100644
@@ -6,6 +6,7 @@
 
 #include "../i915_selftest.h"
 
+#include "igt_spinner.h"
 #include "igt_wedge_me.h"
 #include "mock_context.h"
 

@@ -159,35 +160,57 @@ static int check_whitelist(const struct whitelist *w,
 
 static int do_device_reset(struct intel_engine_cs *engine)
 {
-	i915_reset(engine->i915, ENGINE_MASK(engine->id), NULL);
+	set_bit(I915_RESET_HANDOFF, &engine->i915->gpu_error.flags);
+	i915_reset(engine->i915, ENGINE_MASK(engine->id), "live_workarounds");
 	return 0;
 }
 
 static int do_engine_reset(struct intel_engine_cs *engine)
 {
-	return i915_reset_engine(engine, NULL);
+	return i915_reset_engine(engine, "live_workarounds");
 }
 
-static int switch_to_scratch_context(struct intel_engine_cs *engine)
+static int
+switch_to_scratch_context(struct intel_engine_cs *engine,
+			  struct igt_spinner *spin)
 {
 	struct i915_gem_context *ctx;
 	struct i915_request *rq;
+	int err = 0;
 
 	ctx = kernel_context(engine->i915);
 	if (IS_ERR(ctx))
 		return PTR_ERR(ctx);
 
 	intel_runtime_pm_get(engine->i915);
-	rq = i915_request_alloc(engine, ctx);
+
+	if (spin)
+		rq = igt_spinner_create_request(spin, ctx, engine, MI_NOOP);
+	else
+		rq = i915_request_alloc(engine, ctx);
+
 	intel_runtime_pm_put(engine->i915);
 
 	kernel_context_close(ctx);
-	if (IS_ERR(rq))
-		return PTR_ERR(rq);
+
+	if (IS_ERR(rq)) {
+		spin = NULL;
+		err = PTR_ERR(rq);
+		goto err;
+	}
 
 	i915_request_add(rq);
 
-	return 0;
+	if (spin && !igt_wait_for_spinner(spin, rq)) {
+		pr_err("Spinner failed to start\n");
+		err = -ETIMEDOUT;
+	}
+
+err:
+	if (err && spin)
+		igt_spinner_end(spin);
+
+	return err;
 }
 
 static int check_whitelist_across_reset(struct intel_engine_cs *engine,

@@ -195,9 +218,20 @@ static int check_whitelist_across_reset(struct intel_engine_cs *engine,
 					const struct whitelist *w,
 					const char *name)
 {
+	bool want_spin = reset == do_engine_reset;
 	struct i915_gem_context *ctx;
+	struct igt_spinner spin;
 	int err;
 
+	pr_info("Checking %d whitelisted registers (RING_NONPRIV) [%s]\n",
+		w->count, name);
+
+	if (want_spin) {
+		err = igt_spinner_init(&spin, engine->i915);
+		if (err)
+			return err;
+	}
+
 	ctx = kernel_context(engine->i915);
 	if (IS_ERR(ctx))
 		return PTR_ERR(ctx);

@@ -208,11 +242,17 @@ static int check_whitelist_across_reset(struct intel_engine_cs *engine,
 		goto out;
 	}
 
-	err = switch_to_scratch_context(engine);
+	err = switch_to_scratch_context(engine, want_spin ? &spin : NULL);
 	if (err)
 		goto out;
 
 	err = reset(engine);
+
+	if (want_spin) {
+		igt_spinner_end(&spin);
+		igt_spinner_fini(&spin);
+	}
+
 	if (err) {
 		pr_err("%s reset failed\n", name);
 		goto out;

@@ -259,8 +299,6 @@ static int live_reset_whitelist(void *arg)
 	if (!whitelist_build(engine, &w))
 		return 0;
 
-	pr_info("Checking %d whitelisted registers (RING_NONPRIV)\n", w.count);
-
 	set_bit(I915_RESET_BACKOFF, &error->flags);
 	set_bit(I915_RESET_ENGINE + engine->id, &error->flags);
Signature · 6 lines
2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#2 lore raw

PATCH v2 2/2 drm/i915/selftests: Fix live_workarounds to actually do resets

From: Tvrtko Ursulin <[email protected]>

The test was missing some magic ingredients to actually trigger the resets.

In case of the full reset we need the I915_RESET_HANDOFF flag set, and in case of engine reset we need a busy request.

Thanks to Chris for helping with reset magic.

v2:
* Grab RPM ref over reset.

Signed-off-by Tvrtko Ursulin <[email protected]>
Cc Chris Wilson <[email protected]>
---
 .../drm/i915/selftests/intel_workarounds.c    | 65 +++++++++++++++----
 1 file changed, 53 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/selftests/intel_workarounds.c +53 -12
index d1a0923d2f38..80396b3592f5 100644
@@ -6,6 +6,7 @@
 
 #include "../i915_selftest.h"
 
+#include "igt_spinner.h"
 #include "igt_wedge_me.h"
 #include "mock_context.h"
 

@@ -159,35 +160,57 @@ static int check_whitelist(const struct whitelist *w,
 
 static int do_device_reset(struct intel_engine_cs *engine)
 {
-	i915_reset(engine->i915, ENGINE_MASK(engine->id), NULL);
+	set_bit(I915_RESET_HANDOFF, &engine->i915->gpu_error.flags);
+	i915_reset(engine->i915, ENGINE_MASK(engine->id), "live_workarounds");
 	return 0;
 }
 
 static int do_engine_reset(struct intel_engine_cs *engine)
 {
-	return i915_reset_engine(engine, NULL);
+	return i915_reset_engine(engine, "live_workarounds");
 }
 
-static int switch_to_scratch_context(struct intel_engine_cs *engine)
+static int
+switch_to_scratch_context(struct intel_engine_cs *engine,
+			  struct igt_spinner *spin)
 {
 	struct i915_gem_context *ctx;
 	struct i915_request *rq;
+	int err = 0;
 
 	ctx = kernel_context(engine->i915);
 	if (IS_ERR(ctx))
 		return PTR_ERR(ctx);
 
 	intel_runtime_pm_get(engine->i915);
-	rq = i915_request_alloc(engine, ctx);
+
+	if (spin)
+		rq = igt_spinner_create_request(spin, ctx, engine, MI_NOOP);
+	else
+		rq = i915_request_alloc(engine, ctx);
+
 	intel_runtime_pm_put(engine->i915);
 
 	kernel_context_close(ctx);
-	if (IS_ERR(rq))
-		return PTR_ERR(rq);
+
+	if (IS_ERR(rq)) {
+		spin = NULL;
+		err = PTR_ERR(rq);
+		goto err;
+	}
 
 	i915_request_add(rq);
 
-	return 0;
+	if (spin && !igt_wait_for_spinner(spin, rq)) {
+		pr_err("Spinner failed to start\n");
+		err = -ETIMEDOUT;
+	}
+
+err:
+	if (err && spin)
+		igt_spinner_end(spin);
+
+	return err;
 }
 
 static int check_whitelist_across_reset(struct intel_engine_cs *engine,

@@ -195,10 +218,22 @@ static int check_whitelist_across_reset(struct intel_engine_cs *engine,
 					const struct whitelist *w,
 					const char *name)
 {
+	struct drm_i915_private *i915 = engine->i915;
+	bool want_spin = reset == do_engine_reset;
 	struct i915_gem_context *ctx;
+	struct igt_spinner spin;
 	int err;
 
-	ctx = kernel_context(engine->i915);
+	pr_info("Checking %d whitelisted registers (RING_NONPRIV) [%s]\n",
+		w->count, name);
+
+	if (want_spin) {
+		err = igt_spinner_init(&spin, i915);
+		if (err)
+			return err;
+	}
+
+	ctx = kernel_context(i915);
 	if (IS_ERR(ctx))
 		return PTR_ERR(ctx);
 

@@ -208,11 +243,19 @@ static int check_whitelist_across_reset(struct intel_engine_cs *engine,
 		goto out;
 	}
 
-	err = switch_to_scratch_context(engine);
+	err = switch_to_scratch_context(engine, want_spin ? &spin : NULL);
 	if (err)
 		goto out;
 
+	intel_runtime_pm_get(i915);
 	err = reset(engine);
+	intel_runtime_pm_put(i915);
+
+	if (want_spin) {
+		igt_spinner_end(&spin);
+		igt_spinner_fini(&spin);
+	}
+
 	if (err) {
 		pr_err("%s reset failed\n", name);
 		goto out;

@@ -227,7 +270,7 @@ static int check_whitelist_across_reset(struct intel_engine_cs *engine,
 
 	kernel_context_close(ctx);
 
-	ctx = kernel_context(engine->i915);
+	ctx = kernel_context(i915);
 	if (IS_ERR(ctx))
 		return PTR_ERR(ctx);
 

@@ -259,8 +302,6 @@ static int live_reset_whitelist(void *arg)
 	if (!whitelist_build(engine, &w))
 		return 0;
 
-	pr_info("Checking %d whitelisted registers (RING_NONPRIV)\n", w.count);
-
 	set_bit(I915_RESET_BACKOFF, &error->flags);
 	set_bit(I915_RESET_ENGINE + engine->id, &error->flags);
Signature · 6 lines
2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] drm/i915/selftests: Fix live_workarounds to actually do resets

In reply to Tvrtko Ursulin

Quoting Tvrtko Ursulin (2018-11-30 08:02:54)

Quoted 5 lines

From: Tvrtko Ursulin <[email protected]>

The test was missing some magic ingredients to actually trigger the resets.

Quoted 7 lines

In case of the full reset we need the I915_RESET_HANDOFF flag set, and in case of engine reset we need a busy request.

Thanks to Chris for helping with reset magic.

Signed-off-by Tvrtko Ursulin <[email protected]>
Cc Chris Wilson <[email protected]>

Thanks for fixing up my fail,

Reviewed-by Chris Wilson <[email protected]>

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#4 lore raw

Re: [PATCH 2/2] drm/i915/selftests: Fix live_workarounds to actually do resets

Quoted 9 lines · Chris Wilson

Quoting Tvrtko Ursulin (2018-11-30 08:02:54)

Quoted 8 lines

From: Tvrtko Ursulin <[email protected]>

The test was missing some magic ingredients to actually trigger the resets.

In case of the full reset we need the I915_RESET_HANDOFF flag set, and in case of engine reset we need a busy request.

Quoted 7 lines
Quoted 4 lines

Thanks to Chris for helping with reset magic.

Signed-off-by Tvrtko Ursulin <[email protected]>
Cc Chris Wilson <[email protected]>

Thanks for fixing up my fail,

Reviewed-by Chris Wilson <[email protected]>

Thanks, happy with v2 as well? (adds rpm over reset)

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Re: [PATCH 2/2] drm/i915/selftests: Fix live_workarounds to actually do resets

Quoting Tvrtko Ursulin (2018-11-30 12:17:13)

Quoted 13 lines · Chris Wilson
Quoted 11 lines

Quoting Tvrtko Ursulin (2018-11-30 08:02:54)

Quoted 10 lines

From: Tvrtko Ursulin <[email protected]>

The test was missing some magic ingredients to actually trigger the resets.

In case of the full reset we need the I915_RESET_HANDOFF flag set, and in case of engine reset we need a busy request.

Thanks to Chris for helping with reset magic.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Tvrtko Ursulin <[email protected]>
Cc Chris Wilson <[email protected]>

Thanks for fixing up my fail,

Reviewed-by Chris Wilson <[email protected]>

Thanks, happy with v2 as well? (adds rpm over reset)

Yup, was trying to save electrons :)
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#6 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: Extract spinner code

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/selftests: Extract spinner code
URL : https://patchwork.freedesktop.org/series/53298/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
afa57c2cbca8 drm/i915/selftests: Extract spinner code
-:28: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

-:33: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #33: FILE: drivers/gpu/drm/i915/selftests/igt_spinner.c:1:
+/*

-:238: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #238: FILE: drivers/gpu/drm/i915/selftests/igt_spinner.h:1:
+/*

total: 0 errors, 3 warnings, 0 checks, 755 lines checked fb93a854e613 drm/i915/selftests: Fix live_workarounds to actually do resets

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#7 lore raw

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/selftests: Extract spinner code

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/selftests: Extract spinner code
URL : https://patchwork.freedesktop.org/series/53298/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/selftests: Extract spinner code
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)

Commit: drm/i915/selftests: Fix live_workarounds to actually do resets Okay!

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#8 lore raw

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: Extract spinner code

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/selftests: Extract spinner code
URL : https://patchwork.freedesktop.org/series/53298/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5227 -> Patchwork_10974
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53298/revisions/1/mbox/

Known issues
------------

Here are the changes found in Patchwork_10974 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]

#### Possible fixes ####

* igt@gem_ctx_create@basic-files:
- fi-bsw-kefka: FAIL [fdo#108656] -> PASS

* igt@gem_exec_suspend@basic-s4-devices:
- fi-ivb-3520m: FAIL [fdo#108880] -> PASS

* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS

#### Warnings ####

* igt@i915_selftest@live_contexts:
- {fi-icl-u3}: INCOMPLETE [fdo#108315] -> DMESG-FAIL [fdo#108569]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108315]: https://bugs.freedesktop.org/show_bug.cgi?id=108315
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108656]: https://bugs.freedesktop.org/show_bug.cgi?id=108656
[fdo#108880]: https://bugs.freedesktop.org/show_bug.cgi?id=108880

Participating hosts (50 -> 44)
------------------------------

Additional (1): fi-glk-j4005
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_5227 -> Patchwork_10974

CI_DRM_5227: 95052693524067ba66e1a6733355739fbcc8d5b6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10974: fb93a854e61368ca0d8457ac01cc0de7f663c0e6 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

fb93a854e613 drm/i915/selftests: Fix live_workarounds to actually do resets afa57c2cbca8 drm/i915/selftests: Extract spinner code

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10974/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/2
#9 lore raw
In reply to Tvrtko Ursulin

Quoting Tvrtko Ursulin (2018-11-30 08:02:53)

Quoted 8 lines

From: Tvrtko Ursulin <[email protected]>

Pull out spinner code to a standalone file to enable it to be shortly used by other and new test cases.

Plain code movement - no functional changes.

Signed-off-by Tvrtko Ursulin <[email protected]>

Shiver me conflicts.

Reviewed-by Chris Wilson <[email protected]>

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#10 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2)
URL : https://patchwork.freedesktop.org/series/53298/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
bcfddfda17f5 drm/i915/selftests: Extract spinner code
-:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

-:34: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #34: FILE: drivers/gpu/drm/i915/selftests/igt_spinner.c:1:
+/*

-:239: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #239: FILE: drivers/gpu/drm/i915/selftests/igt_spinner.h:1:
+/*

total: 0 errors, 3 warnings, 0 checks, 755 lines checked dc4e63c0e82f drm/i915/selftests: Fix live_workarounds to actually do resets

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#11 lore raw

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2)
URL : https://patchwork.freedesktop.org/series/53298/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/selftests: Extract spinner code
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)

Commit: drm/i915/selftests: Fix live_workarounds to actually do resets Okay!

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#12 lore raw

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2)
URL : https://patchwork.freedesktop.org/series/53298/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5230 -> Patchwork_10975
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53298/revisions/2/mbox/

Known issues
------------

Here are the changes found in Patchwork_10975 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-ivb-3520m: PASS -> FAIL [fdo#108880]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]

* {igt@runner@aborted}:
- {fi-icl-y}: NOTRUN -> FAIL [fdo#108070]

#### Possible fixes ####

* igt@gem_ctx_create@basic-files:
- fi-kbl-7560u: INCOMPLETE [fdo#103665] -> PASS

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-apl-guc: DMESG-WARN [fdo#108566] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108880]: https://bugs.freedesktop.org/show_bug.cgi?id=108880

Participating hosts (50 -> 43)
------------------------------

Additional (1): fi-icl-y
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u3 fi-pnv-d510

Build changes
-------------

* Linux: CI_DRM_5230 -> Patchwork_10975

CI_DRM_5230: b0a2de64f8969163f6e01071d5e05748f18a8bab @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10975: dc4e63c0e82fe413f33149832a5581f4a7a64887 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

dc4e63c0e82f drm/i915/selftests: Fix live_workarounds to actually do resets bcfddfda17f5 drm/i915/selftests: Extract spinner code

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10975/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#13 lore raw

Re: ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2)

Quoted 79 lines · Patchwork

== Series Details ==

Series: series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2)
URL : https://patchwork.freedesktop.org/series/53298/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5230 -> Patchwork_10975
====================================================

Summary
-------

   **SUCCESS**

   No regressions found.

   External URL: https://patchwork.freedesktop.org/api/1.0/series/53298/revisions/2/mbox/

Known issues
------------

Here are the changes found in Patchwork_10975 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-ivb-3520m: PASS -> FAIL [fdo#108880]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]

* {igt@runner@aborted}:
- {fi-icl-y}: NOTRUN -> FAIL [fdo#108070]

#### Possible fixes ####

* igt@gem_ctx_create@basic-files:
- fi-kbl-7560u: INCOMPLETE [fdo#103665] -> PASS

   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
     - fi-apl-guc:         DMESG-WARN [fdo#108566] -> PASS

   
   {name}: This element is suppressed. This means it is ignored when computing
           the status of the difference (SUCCESS, WARNING, or FAILURE).

   [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
   [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
   [fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070
   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
   [fdo#108880]: https://bugs.freedesktop.org/show_bug.cgi?id=108880

Participating hosts (50 -> 43)
------------------------------

Additional (1): fi-icl-y
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u3 fi-pnv-d510

Build changes
-------------

* Linux: CI_DRM_5230 -> Patchwork_10975

   CI_DRM_5230: b0a2de64f8969163f6e01071d5e05748f18a8bab @ git://anongit.freedesktop.org/gfx-ci/linux
   IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
   Patchwork_10975: dc4e63c0e82fe413f33149832a5581f4a7a64887 @ git://anongit.freedesktop.org/gfx-ci/linux
Quoted 4 lines

== Linux commits ==

dc4e63c0e82f drm/i915/selftests: Fix live_workarounds to actually do resets bcfddfda17f5 drm/i915/selftests: Extract spinner code

Pushed, thanks for the reviews and help with reset magic!

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#14 lore raw

✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/selftests: Extract spinner code (rev2)
URL : https://patchwork.freedesktop.org/series/53298/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5230_full -> Patchwork_10975_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_10975_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10975_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_10975_full:

### IGT changes ###

#### Warnings ####

* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP

Known issues
------------

Here are the changes found in Patchwork_10975_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- {shard-iclb}: NOTRUN -> DMESG-WARN [fdo#107956]

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#107956]

* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-skl: NOTRUN -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-64x64-suspend:
- {shard-iclb}: NOTRUN -> FAIL [fdo#103232] +2
- shard-skl: PASS -> INCOMPLETE [fdo#104108]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: PASS -> FAIL [fdo#102670] / [fdo#106081]

* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled:
- shard-skl: PASS -> FAIL [fdo#103184]

* igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
- {shard-iclb}: PASS -> WARN [fdo#108336]

* igt@kms_flip@dpms-off-confusion:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] +6

* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- {shard-iclb}: PASS -> FAIL [fdo#100368]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-apl: PASS -> FAIL [fdo#103167]

* igt@kms_frontbuffer_tracking@fbc-badstride:
- {shard-iclb}: PASS -> DMESG-FAIL [fdo#107724] +5

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
- {shard-iclb}: PASS -> FAIL [fdo#103167] +5

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
- {shard-iclb}: NOTRUN -> FAIL [fdo#103167]

* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-apl: PASS -> FAIL [fdo#103166]

* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-glk: PASS -> FAIL [fdo#103166]

* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]

* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- {shard-iclb}: PASS -> FAIL [fdo#103166]

* igt@kms_rmfb@rmfb-ioctl:
- {shard-iclb}: NOTRUN -> DMESG-WARN [fdo#107724]

* igt@kms_rotation_crc@primary-y-tiled-reflect-x-270:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +1

* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
- {shard-iclb}: NOTRUN -> FAIL [fdo#99912]

* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +7

* igt@perf@polling:
- shard-hsw: PASS -> FAIL [fdo#102252]

* igt@pm_backlight@fade_with_suspend:
- {shard-iclb}: NOTRUN -> FAIL [fdo#107847]

* igt@pm_rpm@dpms-lpsp:
- shard-skl: PASS -> INCOMPLETE [fdo#107807] +1

* igt@pm_rpm@sysfs-read:
- shard-skl: NOTRUN -> INCOMPLETE [fdo#107807]

* {igt@runner@aborted}:
- shard-kbl: NOTRUN -> FAIL [fdo#108903] / [fdo#108904] / [fdo#108905]

#### Possible fixes ####

* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-skl: TIMEOUT [fdo#108039] -> PASS

* igt@gem_userptr_blits@readonly-unsync:
- shard-skl: TIMEOUT [fdo#108887] -> PASS

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-snb: DMESG-WARN [fdo#107956] -> PASS

* igt@kms_chv_cursor_fail@pipe-a-128x128-bottom-edge:
- shard-skl: FAIL [fdo#104671] -> PASS

* igt@kms_cursor_crc@cursor-256x85-offscreen:
- shard-skl: FAIL [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +1

* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: FAIL [fdo#100368] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: FAIL [fdo#103167] -> PASS +1

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@fbcpsr-tilingchange:
- shard-skl: FAIL [fdo#105682] -> PASS +1

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen:
- {shard-iclb}: FAIL [fdo#103167] -> PASS +7

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-skl: FAIL [fdo#103167] -> PASS +1

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- {shard-iclb}: INCOMPLETE [fdo#107713] -> PASS

* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS

* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- {shard-iclb}: FAIL [fdo#103166] -> PASS +4

* igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
- {shard-iclb}: DMESG-WARN [fdo#107724] -> PASS

* igt@kms_rotation_crc@primary-rotation-180:
- shard-skl: FAIL [fdo#103925] / [fdo#107815] -> PASS

* igt@pm_rpm@legacy-planes:
- {shard-iclb}: DMESG-WARN [fdo#108654] -> PASS

* igt@pm_rpm@legacy-planes-dpms:
- shard-skl: INCOMPLETE [fdo#105959] / [fdo#107807] -> PASS

* igt@pm_rpm@modeset-non-lpsp-stress:
- shard-skl: INCOMPLETE [fdo#107807] -> SKIP

* igt@pm_rpm@system-suspend-devices:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS +1

* igt@pm_rpm@system-suspend-execbuf:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107807] -> PASS

* igt@sw_sync@sync_busy_fork_unixsocket:
- {shard-iclb}: INCOMPLETE [fdo#108889] -> PASS

#### Warnings ####

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-apl: FAIL [fdo#108145] -> DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#108145] +1

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102252]: https://bugs.freedesktop.org/show_bug.cgi?id=102252
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103925]: https://bugs.freedesktop.org/show_bug.cgi?id=103925
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104671]: https://bugs.freedesktop.org/show_bug.cgi?id=104671
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105959]: https://bugs.freedesktop.org/show_bug.cgi?id=105959
[fdo#106081]: https://bugs.freedesktop.org/show_bug.cgi?id=106081
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107847]: https://bugs.freedesktop.org/show_bug.cgi?id=107847
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108039]: https://bugs.freedesktop.org/show_bug.cgi?id=108039
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#108887]: https://bugs.freedesktop.org/show_bug.cgi?id=108887
[fdo#108889]: https://bugs.freedesktop.org/show_bug.cgi?id=108889
[fdo#108903]: https://bugs.freedesktop.org/show_bug.cgi?id=108903
[fdo#108904]: https://bugs.freedesktop.org/show_bug.cgi?id=108904
[fdo#108905]: https://bugs.freedesktop.org/show_bug.cgi?id=108905
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_5230 -> Patchwork_10975

CI_DRM_5230: b0a2de64f8969163f6e01071d5e05748f18a8bab @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10975: dc4e63c0e82fe413f33149832a5581f4a7a64887 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10975/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx