Skip to contentSkip to conversation

net/i40e: fixed return value check for hash

PATCH Applied Qiming Yang 2 participants 2 messages Nov 30, 2018 Network drivers

lore
Share & tools
lore

Qiming Yang

author
#0 lore raw

PATCH 1/1 net/i40e: fixed return value check for hash

RSS hash configure get API didn't check the return value. Will return sucess even get RSS hash key failed. This patch fixed teh issue.

Fixes d0a349409bd7 ("i40e: support AQ based RSS config")
Cc [email protected]
Signed-off-by Qiming Yang <[email protected]>
---
 drivers/net/i40e/i40e_ethdev.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +4 -1
index 7030eb1..552a7a5 100644
@@ -7459,9 +7459,12 @@ i40e_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
 	struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
 	struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 	uint64_t hena;
+	int ret;
 
-	i40e_get_rss_key(pf->main_vsi, rss_conf->rss_key,
+	ret = i40e_get_rss_key(pf->main_vsi, rss_conf->rss_key,
 			 &rss_conf->rss_key_len);
+	if (ret)
+		return ret;
 
 	hena = (uint64_t)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(0));
 	hena |= ((uint64_t)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(1))) << 32;
Signature · 1 line
2.9.5