Skip to contentSkip to conversation

quagga: bump to version 1.2.3

PATCH New Fabrice Fontaine 2 participants 3 messages Dec 1, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 quagga: bump to version 1.2.3

- Remove all patches except the first one as they are already in this version
- Remove AUTORECONF = YES as we're not patching any *.ac files anymore
- Disable new nhrpd option
- Add hash for license file

---
 ...ure-fix-static-linking-with-readline.patch |  41 -------
 ...y-fix-indirect-static-link-with-zlib.patch | 108 -----------------
 ...PATH-size-calculation-for-long-paths.patch |  33 -----
 ...valid-attr-length-sends-NOTIFY-with-.patch |  69 -----------
 ...Fix-double-free-of-unknown-attribute.patch | 112 -----------------
 ...bug-print-of-received-NOTIFY-data-ca.patch | 114 ------------------
 ...x-infinite-loop-on-certain-invalid-O.patch |  43 -------
 package/quagga/quagga.hash                    |   5 +-
 package/quagga/quagga.mk                      |   8 +-
 9 files changed, 7 insertions(+), 526 deletions(-)
 delete mode 100644 package/quagga/0002-configure-fix-static-linking-with-readline.patch
 delete mode 100644 package/quagga/0003-lib-memory-fix-indirect-static-link-with-zlib.patch
 delete mode 100644 package/quagga/0004-bgpd-Fix-AS_PATH-size-calculation-for-long-paths.patch
 delete mode 100644 package/quagga/0005-bgpd-security-invalid-attr-length-sends-NOTIFY-with-.patch
 delete mode 100644 package/quagga/0006-bgpd-security-Fix-double-free-of-unknown-attribute.patch
 delete mode 100644 package/quagga/0007-bgpd-security-debug-print-of-received-NOTIFY-data-ca.patch
 delete mode 100644 package/quagga/0008-bgpd-security-fix-infinite-loop-on-certain-invalid-O.patch
package/quagga/0002-configure-fix-static-linking-with-readline.patch deleted +0 -41
deleted file mode 100644
index 243dfaf75d..0000000000
@@ -1,41 +0,0 @@
-From 62ede7482da15d276b880f6d8540dce400dc50a7 Mon Sep 17 00:00:00 2001
-From: Thomas Petazzoni <[email protected]>
-Date: Thu, 26 Nov 2015 15:59:07 +0100
-Subject: [PATCH] configure: fix static linking with readline
-
-When static linking is used, the order of the libraries is important,
-and the libraries using a symbol from another library should be listed
-*before* the library providing that symbol (see
-http://eli.thegreenplace.net/2013/07/09/library-order-in-static-linking)
-for details.
-
-When vtysh is linked statically, the command line contains "-lcurses
--lreadline", which causes a build failure due to unresolved
-symbols. This is because readline is using symbols from the curses
-library: the order should be the opposite.
-
-This patch fixes that problem by putting the -lreadline at the
-beginning of the LIBREADLINE variable calcualted by the configure
-script.
-
-Signed-off-by: Thomas Petazzoni <[email protected]>
----
- configure.ac | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/configure.ac b/configure.ac
-index 3003e62..290953d 100755
---- a/configure.ac
-+++ b/configure.ac
-@@ -652,7 +652,7 @@ dnl	 [TODO] on Linux, and in [TODO] on Solaris.
- 	      )]
- 	    )]
- 	  )
--         AC_CHECK_LIB(readline, main, LIBREADLINE="$LIBREADLINE -lreadline",,
-+         AC_CHECK_LIB(readline, main, LIBREADLINE="-lreadline $LIBREADLINE",,
-                       "$LIBREADLINE")
-          if test $ac_cv_lib_readline_main = no; then
-            AC_MSG_ERROR([vtysh needs libreadline but was not found and usable on your system.])
--- 
-2.6.3
-
package/quagga/0003-lib-memory-fix-indirect-static-link-with-zlib.patch deleted +0 -108

108 lines not on this page · raw message

package/quagga/0004-bgpd-Fix-AS_PATH-size-calculation-for-long-paths.patch deleted +0 -33
deleted file mode 100644
index 1425cf0426..0000000000
@@ -1,33 +0,0 @@
-From 7a42b78be9a4108d98833069a88e6fddb9285008 Mon Sep 17 00:00:00 2001
-From: Andreas Jaggi <[email protected]>
-Date: Mon, 2 Oct 2017 19:38:43 +0530
-Subject: [PATCH] bgpd: Fix AS_PATH size calculation for long paths
-
-If you have an AS_PATH with more entries than
-what can be written into a single AS_SEGMENT_MAX
-it needs to be broken up.  The code that noticed
-that the AS_PATH needs to be broken up was not
-correctly calculating the size of the resulting
-message.  This patch addresses this issue.
-
-Signed-off-by: Peter Korsgaard <[email protected]>
----
- bgpd/bgp_aspath.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/bgpd/bgp_aspath.c b/bgpd/bgp_aspath.c
-index b7af5e88..d813bfba 100644
---- a/bgpd/bgp_aspath.c
-+++ b/bgpd/bgp_aspath.c
-@@ -903,7 +903,7 @@ aspath_put (struct stream *s, struct aspath *as, int use32bit )
-               assegment_header_put (s, seg->type, AS_SEGMENT_MAX);
-               assegment_data_put (s, seg->as, AS_SEGMENT_MAX, use32bit);
-               written += AS_SEGMENT_MAX;
--              bytes += ASSEGMENT_SIZE (written, use32bit);
-+              bytes += ASSEGMENT_SIZE (AS_SEGMENT_MAX, use32bit);
-             }
-           
-           /* write the final segment, probably is also the first */
--- 
-2.11.0
-
package/quagga/0005-bgpd-security-invalid-attr-length-sends-NOTIFY-with-.patch deleted +0 -69

69 lines not on this page · raw message

package/quagga/0006-bgpd-security-Fix-double-free-of-unknown-attribute.patch deleted +0 -112

112 lines not on this page · raw message

package/quagga/0007-bgpd-security-debug-print-of-received-NOTIFY-data-ca.patch deleted +0 -114

114 lines not on this page · raw message

package/quagga/0008-bgpd-security-fix-infinite-loop-on-certain-invalid-O.patch deleted +0 -43

43 lines not on this page · raw message

package/quagga/quagga.hash +4 -1
index 6da37cf806..93fc42c8fc 100644
@@ -1,2 +1,5 @@
 # Locally calculated after checking pgp signature
-sha256	b5a94e5bdad3062e04595a5692b8cc435f0a85102f75dfdca0a06d093b4ef63f	quagga-1.1.1.tar.gz
+sha256	ee2c0907a106902abbdcaf63b4f28c67241c4f3396989ed54da7b4976eecad31	quagga-1.2.3.tar.gz
+
+# Hash for license file
+sha256	b39c1bad4e51e2a3389cd25fc4addebe41a3ae7c11100795683f9330de1536e5	COPYING
package/quagga/quagga.mk +3 -5
index 8c2b80631b..23ab004050 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-QUAGGA_VERSION = 1.1.1
+QUAGGA_VERSION = 1.2.3
 QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
 QUAGGA_DEPENDENCIES = host-gawk host-pkgconf
 QUAGGA_LICENSE = GPL-2.0+
@@ -16,10 +16,8 @@ QUAGGA_LICENSE_FILES = COPYING
 QUAGGA_CONF_OPTS = \
 	--program-transform-name='' \
 	--sysconfdir=/etc/quagga \
-	--localstatedir=/var/run/quagga
-
-# 0002-configure-fix-static-linking-with-readline.patch
-QUAGGA_AUTORECONF = YES
+	--localstatedir=/var/run/quagga \
+	--disable-nhrpd
 
 ifeq ($(BR2_PACKAGE_LIBCAP),y)
 QUAGGA_CONF_OPTS += --enable-capabilities
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 quagga: add nhrpd option

---
 package/quagga/Config.in |  6 ++++++
 package/quagga/quagga.mk | 10 ++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)
package/quagga/Config.in +6 -0
index 6c51394db3..1a86586ba3 100644
@@ -42,6 +42,12 @@ config BR2_PACKAGE_QUAGGA_ISISD
 	help
 	  Enable isisd support in quagga.
 
+config BR2_PACKAGE_QUAGGA_NHRPD
+	bool "NHRPD protocol"
+	select BR2_PACKAGE_C_ARES
+	help
+	  Build Next Hop Routing Protocol daemon.
+
 config BR2_PACKAGE_QUAGGA_OSPFD
 	bool "OSPFv2 protocol"
 	help
package/quagga/quagga.mk +8 -2
index 23ab004050..420d72c79d 100644
@@ -16,8 +16,7 @@ QUAGGA_LICENSE_FILES = COPYING
 QUAGGA_CONF_OPTS = \
 	--program-transform-name='' \
 	--sysconfdir=/etc/quagga \
-	--localstatedir=/var/run/quagga \
-	--disable-nhrpd
+	--localstatedir=/var/run/quagga
 
 ifeq ($(BR2_PACKAGE_LIBCAP),y)
 QUAGGA_CONF_OPTS += --enable-capabilities
@@ -59,6 +58,13 @@ define QUAGGA_PERMISSIONS
 	/etc/quagga d 755 quagga quagga - - - - -
 endef
 
+ifeq ($(BR2_PACKAGE_QUAGGA_NHRPD),y)
+QUAGGA_CONF_OPTS += --enable-nhrpd
+QUAGGA_DEPENDENCIES += c-ares
+else
+QUAGGA_CONF_OPTS += --disable-nhrpd
+endif
+
 ifeq ($(BR2_PACKAGE_QUAGGA_SNMP),y)
 QUAGGA_CONF_ENV += ac_cv_path_NETSNMP_CONFIG=$(STAGING_DIR)/usr/bin/net-snmp-config
 QUAGGA_CONF_OPTS += --enable-snmp=agentx
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/2 quagga: bump to version 1.2.3

In reply to Fabrice Fontaine

Hello,

Quoted 17 lines · Fabrice Fontaine

- Remove all patches except the first one as they are already in this version
- Remove AUTORECONF = YES as we're not patching any *.ac files anymore
- Disable new nhrpd option
- Add hash for license file

---
 ...ure-fix-static-linking-with-readline.patch |  41 -------
 ...y-fix-indirect-static-link-with-zlib.patch | 108 -----------------
 ...PATH-size-calculation-for-long-paths.patch |  33 -----
 ...valid-attr-length-sends-NOTIFY-with-.patch |  69 -----------
 ...Fix-double-free-of-unknown-attribute.patch | 112 -----------------
 ...bug-print-of-received-NOTIFY-data-ca.patch | 114 ------------------
 ...x-infinite-loop-on-certain-invalid-O.patch |  43 -------
 package/quagga/quagga.hash                    |   5 +-
 package/quagga/quagga.mk                      |   8 +-
Quoted 8 lines
 9 files changed, 7 insertions(+), 526 deletions(-)
 delete mode 100644 package/quagga/0002-configure-fix-static-linking-with-readline.patch
 delete mode 100644 package/quagga/0003-lib-memory-fix-indirect-static-link-with-zlib.patch
 delete mode 100644 package/quagga/0004-bgpd-Fix-AS_PATH-size-calculation-for-long-paths.patch
 delete mode 100644 package/quagga/0005-bgpd-security-invalid-attr-length-sends-NOTIFY-with-.patch
 delete mode 100644 package/quagga/0006-bgpd-security-Fix-double-free-of-unknown-attribute.patch
 delete mode 100644 package/quagga/0007-bgpd-security-debug-print-of-received-NOTIFY-data-ca.patch
 delete mode 100644 package/quagga/0008-bgpd-security-fix-infinite-loop-on-certain-invalid-O.patch

Both applied to next. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com