Skip to contentSkip to conversation

ARC: change defconfig defaults to ARCv2

PATCH Applied Alexey Brodkin 4 participants 5 messages Nov 30, 2018 – Dec 3, 2018

Subsystems (2)
Stable branch Synopsys ARC architecture
lore
Share & tools
lore

Alexey Brodkin

author
#0 lore raw

PATCH v2 1/1 ARC: change defconfig defaults to ARCv2

From: Kevin Hilman <[email protected]>

Change the default defconfig (used with 'make defconfig') to the ARCv2 nsim_hs_defconfig, and also switch the default Kconfig ISA selection to ARCv2.

This allows several default defconfigs (e.g. make defconfig, make allnoconfig, make tinyconfig) to all work with ARCv2 by default.

Note since we change default architecture from ARCompact to ARCv2 it's required to explicitly mention architecture type in ARCompact defconfigs otherwise ARCv2 will be implied and binaries will be generated for ARCv2.

Signed-off-by Kevin Hilman <khilman at baylibre.com>
Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
Cc <stable at vger.kernel.org> # 4.4.x

---

Changes v1 -> v2:
* Added CONFIG_ISA_ARCOMPACT to ARCompact defconfigs

 arch/arc/Kconfig                    | 2 +-
 arch/arc/Makefile                   | 2 +-
 arch/arc/configs/axs101_defconfig   | 1 +
 arch/arc/configs/nps_defconfig      | 1 +
 arch/arc/configs/nsim_700_defconfig | 1 +
 arch/arc/configs/nsimosci_defconfig | 1 +
 arch/arc/configs/tb10x_defconfig    | 1 +
 7 files changed, 7 insertions(+), 2 deletions(-)
arch/arc/Kconfig +1 -1
index 5fcbda6b37cc..6dd783557330 100644
@@ -109,7 +109,7 @@ endmenu
 
 choice
 	prompt "ARC Instruction Set"
-	default ISA_ARCOMPACT
+	default ISA_ARCV2
 
 config ISA_ARCOMPACT
 	bool "ARCompact ISA"
arch/arc/Makefile +1 -1
index c64c505d966c..df00578c279d 100644
@@ -6,7 +6,7 @@
 # published by the Free Software Foundation.
 #
 
-KBUILD_DEFCONFIG := nsim_700_defconfig
+KBUILD_DEFCONFIG := nsim_hs_defconfig
 
 cflags-y	+= -fno-common -pipe -fno-builtin -mmedium-calls -D__linux__
 cflags-$(CONFIG_ISA_ARCOMPACT)	+= -mA7
arch/arc/configs/axs101_defconfig +1 -0
index 8c23bd086cd0..020d4493edfd 100644
@@ -14,6 +14,7 @@ CONFIG_PERF_EVENTS=y
 # CONFIG_VM_EVENT_COUNTERS is not set
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_MODULES=y
 CONFIG_MODULE_FORCE_LOAD=y
 CONFIG_MODULE_UNLOAD=y
arch/arc/configs/nps_defconfig +1 -0
index ae7a0d8be98d..6e84060e7c90 100644
@@ -15,6 +15,7 @@ CONFIG_SYSCTL_SYSCALL=y
 CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_KPROBES=y
 CONFIG_MODULES=y
 CONFIG_MODULE_FORCE_LOAD=y
arch/arc/configs/nsim_700_defconfig +1 -0
index 8e0b8b134cd9..219c2a65294b 100644
@@ -15,6 +15,7 @@ CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_KPROBES=y
 CONFIG_MODULES=y
 # CONFIG_LBDAF is not set
arch/arc/configs/nsimosci_defconfig +1 -0
index ad77f20e5aa6..35dfc6491a09 100644
@@ -15,6 +15,7 @@ CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_KPROBES=y
 CONFIG_MODULES=y
 # CONFIG_LBDAF is not set
arch/arc/configs/tb10x_defconfig +1 -0
index a7f65313f84a..e71ade3cf9c8 100644
@@ -19,6 +19,7 @@ CONFIG_KALLSYMS_ALL=y
 # CONFIG_AIO is not set
 CONFIG_EMBEDDED=y
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_SLAB=y
 CONFIG_MODULES=y
 CONFIG_MODULE_FORCE_LOAD=y
Signature · 1 line
2.16.2
Applied
#1 lore raw
Quoted 9 lines · Alexey Brodkin

From: Kevin Hilman <khilman at baylibre.com>

Change the default defconfig (used with 'make defconfig') to the ARCv2 nsim_hs_defconfig, and also switch the default Kconfig ISA selection to ARCv2.

This allows several default defconfigs (e.g. make defconfig, make allnoconfig, make tinyconfig) to all work with ARCv2 by default.

Quoted 8 lines

Note since we change default architecture from ARCompact to ARCv2 it's required to explicitly mention architecture type in ARCompact defconfigs otherwise ARCv2 will be implied and binaries will be generated for ARCv2.

Signed-off-by Kevin Hilman <khilman at baylibre.com>
Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
Cc <stable at vger.kernel.org> # 4.4.x

Applied.

Thx,
-Vineet

Tested-by on v2 1/1
#2 lore raw
In reply to Alexey Brodkin
Quoted 9 lines · Alexey Brodkin

From: Kevin Hilman <khilman at baylibre.com>

Change the default defconfig (used with 'make defconfig') to the ARCv2 nsim_hs_defconfig, and also switch the default Kconfig ISA selection to ARCv2.

This allows several default defconfigs (e.g. make defconfig, make allnoconfig, make tinyconfig) to all work with ARCv2 by default.

Quoted 8 lines

Note since we change default architecture from ARCompact to ARCv2 it's required to explicitly mention architecture type in ARCompact defconfigs otherwise ARCv2 will be implied and binaries will be generated for ARCv2.

Signed-off-by Kevin Hilman <khilman at baylibre.com>
Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
Cc <stable at vger.kernel.org> # 4.4.x
Tested-by Kevin Hilman <khilman at baylibre.com>

Nice, thanks for cleaning this up. I tested it again for the kernelCI use cases, and it's still working.

Thanks,

Kevin

maintainer
#3 lore raw

PATCH v2 1/1 ARC: change defconfig defaults to ARCv2

In reply to Alexey Brodkin

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: 4.4.+

The bot has tested the following trees: v4.19.5, v4.14.84, v4.9.141, v4.4.165,

v4.19.5: Build OK!
v4.14.84: Build OK!
v4.9.141: Failed to apply! Possible dependencies:
Unable to calculate

v4.4.165: Failed to apply! Possible dependencies:

    845033be0041 ("ARC: [plat-eznps] Add eznps board defconfig and dts")

How should we proceed with this patch?

--
Thanks,
Sasha

author
#4 lore raw

Hi Sasha,

Quoted 7 lines · Sasha Levin

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: 4.4.+

Quoted 6 lines

The bot has tested the following trees: v4.19.5, v4.14.84, v4.9.141, v4.4.165,

v4.19.5: Build OK!
v4.14.84: Build OK!
v4.9.141: Failed to apply! Possible dependencies:
Unable to calculate

That's a fixed hunk for 4.9:
---------------------->8----------------------

arch/arc/Makefile +1 -1
@@ -8,7 +8,7 @@
 
 UTS_MACHINE := arc
 
-KBUILD_DEFCONFIG := nsim_700_defconfig
+KBUILD_DEFCONFIG := nsim_hs_defconfig
 
 cflags-y       += -fno-common -pipe -fno-builtin -mmedium-calls -D__linux__
 cflags-$(CONFIG_ISA_ARCOMPACT) += -mA7

---------------------->8----------------------

Quoted 2 lines

v4.4.165: Failed to apply! Possible dependencies:

    845033be0041 ("ARC: [plat-eznps] Add eznps board defconfig and dts")

Indeed EzChip's nps400 platform was added later but we don't need it in 4.4.y as IIRC there were quite some other dependencies, so just drop hunk related to it.

And once nps_defconfig hunk is dropped there's a fixd hunk for arch/arc/Makefile similarly to 4.9:
---------------------->8----------------------

arch/arc/Makefile +1 -1
@@ -12,7 +12,7 @@ ifeq ($(CROSS_COMPILE),)
 CROSS_COMPILE := arc-linux-
 endif
 
-KBUILD_DEFCONFIG := nsim_700_defconfig
+KBUILD_DEFCONFIG := nsim_hs_defconfig
 
 cflags-y       += -fno-common -pipe -fno-builtin -mmedium-calls -D__linux__
 cflags-$(CONFIG_ISA_ARCOMPACT) += -mA7

---------------------->8----------------------

Quoted 1 line

How should we proceed with this patch?

Hope above helps. Otherwise I may send complete patches for both 4.4 and 4.9.

Let me know what is your preference.

-Alexey