drop silly "static inline asmlinkage" from dump_stack()
PATCH 1/1 drop silly "static inline asmlinkage" from dump_stack()
Signed-off-by Alexey Dobriyan <[email protected]>
---
include/linux/printk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/printk.h +1 -1
@@ -269,7 +269,7 @@ static inline void show_regs_print_info(const char *log_lvl) { } -static inline asmlinkage void dump_stack(void) +static inline void dump_stack (void ) { }
include/linux/printk.h static inline void show_regs_print_info(const char *log_lvl) · line 272
Quoted 2 lines · Alexey Dobriyan
include/linux/printk.h +1
-1-static inline asmlinkage void dump_stack(void) +static inline void dump_stack (void )
Why is it "silly"? An explanation in the commit message would be useful.
Quoted 17 lines
Signed-off-by Alexey Dobriyan <[email protected]>---
include/linux/printk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/printk.h +1
-1@@ -269,7 +269,7 @@ static inline void show_regs_print_info(const char *log_lvl) { } -static inline asmlinkage void dump_stack(void) +static inline void dump_stack (void ) { }
Signature · 2 lines
Cheers, Joey Pabalinas
Quoted 5 lines · Joey Pabalinas
include/linux/printk.h static inline void show_regs_print_info(const char *log_lvl) · line 272
Quoted 2 lines · Alexey Dobriyan
include/linux/printk.h +1
-1-static inline asmlinkage void dump_stack(void) +static inline void dump_stack (void )Why is it "silly"? An explanation in the commit message would be useful.
Empty function will be inlined so asmlinkage doesn't do anything.
Joey Pabalinas
Acked-byQuoted 1 line · Alexey Dobriyan
Empty function will be inlined so asmlinkage doesn't do anything.
Yes, that is an example of a perfect explanation to have in the commit message :) Ack from me after that addition.
Acked-by Joey Pabalinas <[email protected]>
Signature · 2 lines
Cheers, Joey Pabalinas